[PATCH v2] app/testpmd: fix secondary process not forwarding

Under multi-process scenario, the secondary process gets queue state from the wrong location (the global variable 'ports'). Therefore, the secondary process can not forward since "stream_init" is not called. This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get' to get queue state f

dev@dpdk.org

https://bugs.dpdk.org/show_bug.cgi?id=1163 Bug ID: 1163 Summary: [dpdk-23.03-rc1] app/test-pmd/cmdline_flow meson build failed with cflag param optimization=1 on Ubuntu22.04 &&RHEL8.6 with gcc11.3.0&&8.5.0 Product: DPDK

RE: [PATCH v2 2/3] doc: update outdated information for the nfp PMD

> On 2/20/2023 8:41 AM, Chaoyong He wrote: > > From: Walter Heymans > > > > Update nfp documentation with new information and remove outdated > > information. The most significant changes that are updated include: > > - Previously the NFP PMD did not support functionality to control VFs, > > it

[PATCH] event/cnxk: add WQE stashing support

From: Pavan Nikhilesh CN10K supports stashing the scheduled WQE carried by `rte_event` to the cores L2 Dcache.The number of cache lines to be stashed and the offset is configurable per HWGRP i.e. event queue. By default, stashing is enabled on queues which have been connected to Rx adapter. Stas

Re: [PATCH v2 2/3] doc: update outdated information for the nfp PMD

On 2/21/2023 9:04 AM, Chaoyong He wrote: >> On 2/20/2023 8:41 AM, Chaoyong He wrote: >>> From: Walter Heymans >>> >>> Update nfp documentation with new information and remove outdated >>> information. The most significant changes that are updated include: >>> - Previously the NFP PMD did not suppo

[PATCH v1] app/testpmd: fix flex item compilation error

When configuring meson with option "--optimization=1", gcc complains "maybe-uninitialized" warning and it was treated as error since Werror is enabled. Assign fp to NULL at declaration can avoid this. Fixes: c8e25fbf1440 ("ethdev: add flow flex modify") Cc: sta...@dpdk.org Signed-off-by: Rongwei

[PATCH v2] app/testpmd: fix flex item compilation error

When configuring meson with option "--optimization=1", gcc complains "maybe-uninitialized" warning and it was treated as error since Werror is enabled. Assign fp to NULL at declaration can avoid this. Bugzilla ID: 1163 Fixes: c8e25fbf1440 ("ethdev: add flow flex modify") Cc: sta...@dpdk.org Repo

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

Not only this if, there can be many places to add such branch prediction helpers On the gve pmd code. I preferred to patch only the bug here and not used unlikely to minimize noise. Imho, adding likely/unlikely to all gve pmd code can be topic of another patch maybe. Levend > On 21 Feb 2023,

RE: [PATCH v2 2/3] doc: update outdated information for the nfp PMD

> On 2/21/2023 9:04 AM, Chaoyong He wrote: > >> On 2/20/2023 8:41 AM, Chaoyong He wrote: > >>> From: Walter Heymans > >>> > >>> Update nfp documentation with new information and remove outdated > >>> information. The most significant changes that are updated include: > >>> - Previously the NFP PMD

Re: [dpdk-dev] [RFC] testpmd: support user-id attribute

This feature assigns custom IDs to flow rules so a complete sequence of commands can prepared in a script. As a test application, I think it is really valuable to be able to script a sequence. Any other opinions? If you want to see this feature please speak to encourage its development. 30/01/20

Re: [PATCH v1] config: make max memzones definition configurable

13/02/2023 18:04, Ophir Munk: > Since the new rte API was "discussed in recent years" and it is also > dependent on different driver vendors acceptance - I suggest that the > compilation option will be applied now. I think there is a misunderstanding here. > The new rte API effort will start in

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

On 2/21/2023 10:07 AM, Levend Sayar wrote: > Not only this if, there can be many places to add such branch prediction > helpers > On the gve pmd code. > > I preferred to patch only the bug here and not used unlikely to minimize > noise. > > Imho, adding likely/unlikely to all gve pmd code can

[PATCH v2 0/6] fix the set flow actions

The former logic of set flow actions don't consider the mask filed of control message passed to the firmware, and this caused the firmware skip the set action logic wrongly. This patch series aims to fix this problem. -- v2: * fix the compile warning. -- Chaoyong He (6): net/nfp: fix the set MA

[PATCH v2 1/6] net/nfp: fix the set MAC flow action

The former logic of set MAC source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right MAC address as expected. Fixes: 4f6983154570 ("net/nfp: sup

[PATCH v2 2/6] net/nfp: fix the set IPv4 flow action

The former logic of set IPv4 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4 address as expected. Fixes: ab80975b0a14 ("net/nfp: s

[PATCH v2 3/6] net/nfp: fix the set IPv6 flow action

The former logic of set IPv6 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: s

[PATCH v2 4/6] net/nfp: fix the set TP flow action

The former logic of set TP source/destination flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TP as expected. Fixes: fc185097bbe6 ("net/nfp: support TP source flo

[PATCH v2 6/6] net/nfp: fix the set IPv4/v6 DSCP flow action

The former logic of set IPv4/v6 DSCP flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4/v6 DSCP as expected. Fixes: 9c665d70f7a7 ("net/nfp: support IPv4 DSCP fl

[PATCH v2 5/6] net/nfp: fix the set TTL flow action

The former logic of set TTL flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TTL as expected. Fixes: ac12e126c482 ("net/nfp: support TTL flow action") Cc: sta...@d

Re: [PATCH v6 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger wrote: > > Fix instances of USER1 logtype in fdset and crypto > sections. > > Acked-by: Chenbo Xia > Reviewed-by: Maxime Coquelin > Signed-off-by: Stephen Hemminger > --- > lib/vhost/fd_man.c | 4 ++-- > lib/vhost/vhost_crypto.c | 4

Re: [PATCH v6 1/5] ip_frag: use a dynamic logtype

On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger wrote: > > DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in > lieu of doing proper logtype registration. > > Acked-by: Konstantin Ananyev > Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper > library") > Signed-off-by

Re: [PATCH v2 2/3] doc: update outdated information for the nfp PMD

On 2/21/2023 10:11 AM, Chaoyong He wrote: >> On 2/21/2023 9:04 AM, Chaoyong He wrote: On 2/20/2023 8:41 AM, Chaoyong He wrote: > From: Walter Heymans > > Update nfp documentation with new information and remove outdated > information. The most significant changes that are upda

Re: [PATCH v6 0/5] Replace use of RTE_LOGTYPE_USER1 in libraries

On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger wrote: > > The DPDK libraries and drivers should not be using the USER1 logtype. > > v6 - fix checkpatch warnings > > Stephen Hemminger (5): > ip_frag: use a dynamic logtype > reorder: use a dynamic logtype > latencystats: use dynamic logtype

Re: [PATCH v3 2/2] net/gve: add Rx/Tx queue stats as extended stats

Thanks Ferruh for the review. My comments are inlined. > On 21 Feb 2023, at 01:57, Ferruh Yigit wrote: > > On 2/20/2023 9:11 PM, Levend Sayar wrote: >> Google Virtual NIC rx/tx queue stats are added as extended stats. >> >> Signed-off-by: Levend Sayar > > Thank you for the update, mainly look

[PATCH] net/af_xdp: fix integer handling issues

Fix integer handling issues (NEGATIVE_RETURNS) reported in coverity scan. Add a check to sock variable if the value is negative return -1. Coverity issue: 383245 Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") Signed-off-by: Shibin Koikkara Reeny --- drivers/net/af_xdp/rte_eth_af_xd

Re: Testpmd/l3fwd port shutdown failure on Arm Altra systems

Hi Qiming, Just a friendly reminder, would you please take a look? Thanks, Juraj On Tue, Feb 7, 2023 at 3:10 AM Xing, Beilei wrote: > > Hi Qiming, > > Could you please help on this? Thanks. > > BR, > Beilei > > > -Original Message- > > From: Juraj Linkeš > > Sent: Monday, February 6,

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

> >> diff --git a/lib/pmu/rte_pmu.c b/lib/pmu/rte_pmu.c new file mode > >> 100644 index 00..950f999cb7 > >> --- /dev/null > >> +++ b/lib/pmu/rte_pmu.c > >> @@ -0,0 +1,460 @@ > >> +/* SPDX-License-Identifier: BSD-3-Clause > >> + * Copyright(C) 2023 Marvell International Ltd. > >> + */ > >>

RE: [PATCH 1/3] examples/ipsec-secgw: fix auth IV length

Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...@amd.com; > rnagadhee...

RE: [PATCH 2/3] examples/ipsec-secgw: check capabilities before session create

Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...@amd.com; > rnagadhee...

RE: [PATCH 3/3] examples/ipsec-secgw: refactor inline capability check

Acked-by: Kai Ji > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 16, 2023 2:25 PM > To: dev@dpdk.org > Cc: Nicolau, Radu ; ano...@marvell.com; > g.si...@nxp.com; hemant.agra...@nxp.com; Ji, Kai ; > ruifeng.w...@arm.com; sunilprakashrao.uttar...@amd.com; > rnagadhee...

Re: [PATCH] net/af_xdp: fix integer handling issues

On 2/21/2023 11:14 AM, Shibin Koikkara Reeny wrote: > Fix integer handling issues (NEGATIVE_RETURNS) reported > in coverity scan. Add a check to sock variable if the > value is negative return -1. > > Coverity issue: 383245 > Fixes: 7fc6ae50369d ("net/af_xdp: support CNI Integration") > > Signed-

[PATCH v4] net/gve: add Rx/Tx queue stats as extended stats

Google Virtual NIC rx/tx queue stats are added as extended stats. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 137 +++ drivers/net/gve/gve_ethdev.h | 28 +-- drivers/net/gve/gve_rx.c | 12 +-- drivers/net/gve/gve_tx.c | 11 +-- 4

[PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

Google Virtual NIC rx/tx queue stats are added as extended stats. Signed-off-by: Levend Sayar --- drivers/net/gve/gve_ethdev.c | 137 +++ drivers/net/gve/gve_ethdev.h | 28 +-- drivers/net/gve/gve_rx.c | 12 +-- drivers/net/gve/gve_tx.c | 11 +-- 4

[PATCH v1 0/2] net/octeon_ep: support device close and port kind

This patch set adds device close functionality and 2nd patch adds port kind functionality. Sathesh Edara (2): net/octeon_ep: support device close net/octeon_ep: support port kind drivers/net/octeon_ep/otx_ep_common.h | 1 + drivers/net/octeon_ep/otx_ep_ethdev.c | 65 +---

[PATCH v1 2/2] net/octeon_ep: support port kind

Added port kind functionality. Signed-off-by: Sathesh Edara --- drivers/net/octeon_ep/otx_ep_common.h | 1 + drivers/net/octeon_ep/otx_ep_ethdev.c | 2 +- drivers/net/octeon_ep/otx_ep_rxtx.c | 16 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/net/oc

Re: unable to bind to vfio-pci

On Tue, Feb 21, 2023 at 08:05:20PM +0530, Nagendra Prabhu A T wrote: >Hi All, >I am trying to bind vfio-pci using dpdk-devbind.py, But i am seeing teh >following error : >root@nat-kvm:/usr/src/dpdk-22.11/usertools# dpdk-devbind.py >--bind=vfio-pci :51:00.0 Error: bind failed

Re: [PATCH v8 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

On Tue, Feb 21, 2023 at 12:36 AM Stephen Hemminger wrote: > > Replace all uses of the global logtype with a dynamic log type. > > Signed-off-by: Stephen Hemminger > --- > lib/eal/common/eal_common_log.c | 1 - > lib/eal/include/rte_log.h | 2 +- > lib/efd/rte_efd.c | 4 >

[PATCH v1 1/2] net/octeon_ep: support device close

Added dev close functionality in the ethdev ops and moves input and output queue deletion functionality into it from otx_epdev_exit() routine. Signed-off-by: Sathesh Edara --- drivers/net/octeon_ep/otx_ep_ethdev.c | 63 --- 1 file changed, 29 insertions(+), 34 deletions(-

Re: [PATCH v8 21/22] hash: move rte_hash_set_alg out header

On Tue, Feb 21, 2023 at 12:38 AM Stephen Hemminger wrote: > > The code for setting algorithm for hash is not at all perf sensitive, > and doing it inline has a couple of problems. First, it means that if > multiple files include the header, then the initialization gets done > multiple times. But a

Re: [PATCH 1/2] net/bonding: add independent LACP sending function

On Thu, Feb 16, 2023 at 11:47:27AM -0800, Stephen Hemminger wrote: > On Thu, 16 Feb 2023 15:15:13 +0800 > Chaoyong He wrote: > > > +void > > +rte_eth_bond_8023ad_lacp_send_one(void *queue) > > +{ > > + uint32_t i; > > + uint16_t slave_tx_count; > > + uint16_t active_slave_count; > > +

unable to bind to vfio-pci

Hi All, I am trying to bind vfio-pci using dpdk-devbind.py, But i am seeing teh following error : root@nat-kvm:/usr/src/dpdk-22.11/usertools# dpdk-devbind.py --bind=vfio-pci :51:00.0 Error: bind failed for :51:00.0 - Cannot bind to driver vfio-pci: [Errno 22] Invalid argument root@nat-kvm

Re: [PATCH v8 21/22] hash: move rte_hash_set_alg out header

On Tue, Feb 21, 2023 at 12:38 AM Stephen Hemminger wrote: > diff --git a/lib/hash/rte_hash_crc.c b/lib/hash/rte_hash_crc.c > new file mode 100644 > index ..c59eebccb1eb > --- /dev/null > +++ b/lib/hash/rte_hash_crc.c > @@ -0,0 +1,63 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + *

Re: [dpdk-dev] [RFC] testpmd: support user-id attribute

As per RFC, I guess possible testpmd implementation will have a mapping between user-id(new) <=> rule-id (old/testpmd) And this mapping will be maintained in testpmd code. Please check, if that is how it is planned? Another option I feel that this mapping done outside, by intermediate script OVS_

Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

On 2/21/2023 2:18 PM, Levend Sayar wrote: > Google Virtual NIC rx/tx queue stats are added as extended stats. > > Signed-off-by: Levend Sayar Reviewed-by: Ferruh Yigit <...> > @@ -20,6 +20,7 @@ gve_rx_refill(struct gve_rx_queue *rxq) > if (nb_alloc <= rxq->nb_avail) { > di

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

On 2/20/2023 9:11 PM, Levend Sayar wrote: > rx no_mbufs stats counter update is added for another error case. > > Fixes: 4f6b1dd8240c ("net/gve: support basic statistics") > Cc: junfeng@intel.com > > Signed-off-by: Levend Sayar Reviewed-by: Ferruh Yigit (No problem for this time, but for

Re: unable to bind to vfio-pci

On Tue, Feb 21, 2023 at 09:30:15PM +0530, Nagendra Prabhu A T wrote: >HI Bruce, >Thanks for your reply. >I have removed the binding of all other ports. So , i can confirm that >#2 is taken care of. >I tried using a different driver "uio_pci_generic". I still see the >same is

Re: [PATCH v3] vhost: exclude VM hugepages from coredumps

Hi Mike, On 2/10/23 22:12, Mike Pattrick wrote: On Fri, Feb 10, 2023 at 10:53 AM David Marchand wrote: Hello Mike, On Wed, Dec 7, 2022 at 5:54 PM Mike Pattrick wrote: Currently if an application wants to include shared hugepages in coredumps in conjunction with the vhost library, the core

Re: unable to bind to vfio-pci

On Tue, Feb 21, 2023 at 09:46:30PM +0530, Nagendra Prabhu A T wrote: >These are the messages i am seeing dmesg >[16588.298660] vfio-pci: probe of :8a:00.2 failed with error -22 >[16591.574630] i40e :8a:00.3: i40e_ptp_stop: removed PHC on >enp138s0f3 >[16593.138613] vfio-

[PATCH v4] net/ark: support for single function with multiple port

Support the creation of multiple ports from one ark device via the use of ark pmd extension, though the assignment of queues to port. Add unique dev_private data for each port. This patch repairs a latent issue uncovered during testing. Signed-off-by: Ed Czeck --- v3: * Backport to LTS version

RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: set AES-CTR IV length to 16

Hi Radu, Shall I change AES-128-CTR iv_len field in cipher_algos struct of sa.c from 8 to 16 and revert below change? Thanks Tejasree > -Original Message- > From: Nicolau, Radu > Sent: Wednesday, February 1, 2023 8:08 PM > To: Akhil Goyal > Cc: Anoob Joseph ; dev@dpdk.org; Tejasree Ko

Re: [PATCH v3 1/2] net/gve: fix Rx no mbufs stats counter update

Thanks Ferruh for the heads up. It was a little confusion for me to decide what to do either. I will do as expected for future. I did not want to overwrite any commit that is already acked. So pushed new versions only for the ones needs recommits. Levend > On 21 Feb 2023, at 18:58, Ferruh Yig

Re: [PATCH v5] net/gve: add Rx/Tx queue stats as extended stats

Thanks Ferruh for the review. > On 21 Feb 2023, at 18:58, Ferruh Yigit wrote: > > On 2/21/2023 2:18 PM, Levend Sayar wrote: >> Google Virtual NIC rx/tx queue stats are added as extended stats. >> >> Signed-off-by: Levend Sayar > > Reviewed-by: Ferruh Yigit > > <...> > >> @@ -20,6 +20,7 @@

[PATCH v4] hash: add XOR32 hash function

An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its use case in P4. We implement it in this patch so it could be easily registered in the pipeline later. Signed-off-by: Bili Dong --- .mailmap | 1 + app/test/test_hash_functions.c | 33 +-- lib

Re: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

On Tue, 21 Feb 2023 07:24:19 + Ruifeng Wang wrote: > > -Original Message- > > From: fengchengwen > > Sent: Monday, February 20, 2023 2:58 PM > > To: Ashok Kaladi ; jer...@marvell.com; > > tho...@monjalon.net > > Cc: dev@dpdk.org; s.v.naga.haris...@intel.com; erik.g.carri...@intel.co

Re: unable to bind to vfio-pci

On Tue, 21 Feb 2023 16:27:31 + Bruce Richardson wrote: > On Tue, Feb 21, 2023 at 09:46:30PM +0530, Nagendra Prabhu A T wrote: > >These are the messages i am seeing dmesg > >[16588.298660] vfio-pci: probe of :8a:00.2 failed with error -22 > >[16591.574630] i40e :8a:00.3: i4

Re: [PATCH v8 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

On Tue, 21 Feb 2023 15:55:29 +0100 David Marchand wrote: > On Tue, Feb 21, 2023 at 12:36 AM Stephen Hemminger > wrote: > > > > Replace all uses of the global logtype with a dynamic log type. > > > > Signed-off-by: Stephen Hemminger > > --- > > lib/eal/common/eal_common_log.c | 1 - > > lib/eal

RE: [PATCH 1/2] net/mana: add version information for dependencies

> Subject: Re: [PATCH 1/2] net/mana: add version information for dependencies > > On 1/20/2023 2:19 AM, lon...@linuxonhyperv.com wrote: > > > From: Long Li > > > > The required dependencies for mana from rdma-core and Linux kernel > > have been released. Add those information to the doc. > > > >

[PATCH] config: added support for NVIDIA ARM implementer ID

From: Cliff Burdick NVIDIA's Jetson Xavier is an ARM chip with NVIDIA as the implementer ID and a new part number. This patch adds support for this implementer ID and the part number. Signed-off-by: Cliff Burdick --- .mailmap | 1 + config/arm/meson.build | 21 ++

[PATCH] config: added support for NVIDIA ARM implementer ID

From: Cliff Burdick NVIDIA's Jetson Xavier is an ARM chip with NVIDIA as the implementer ID and a new part number. This patch adds support for this implementer ID and the part number. Signed-off-by: Cliff Burdick --- .mailmap | 1 + config/arm/meson.build | 21 ++

[PATCH v5] hash: add XOR32 hash function

An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its use case in P4. We implement it in this patch so it could be easily registered in the pipeline later. Signed-off-by: Bili Dong --- .mailmap | 1 + app/test/test_hash_functions.c | 33 +-- lib

Re: [PATCH v6 0/5] Replace use of RTE_LOGTYPE_USER1 in libraries

On Tue, 21 Feb 2023 11:42:45 +0100 David Marchand wrote: > On Mon, Feb 20, 2023 at 7:50 PM Stephen Hemminger > wrote: > > > > The DPDK libraries and drivers should not be using the USER1 logtype. > > > > v6 - fix checkpatch warnings > > > > Stephen Hemminger (5): > > ip_frag: use a dynamic log

[PATCH v7 0/5] Convert us of RTE_LOGTYPE_USER1 in libraries

The DPDK libraries and drivers should not be using the USER1 logtype. v7 - fix review comments. Replace USER1 in ip_frag and vhost crypto. Stephen Hemminger (5): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logtype vhost: use logtype instead of R

[PATCH v7 1/5] ip_frag: use a dynamic logtype

DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 5 - lib/

[PATCH v7 2/5] reorder: use a dynamic logtype

Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

[PATCH v7 3/5] latencystats: use dynamic logtype

Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 3 ++- 1 file c

[PATCH v7 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Reviewed-by: Maxime Coquelin Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 4 ++-- lib/vhost/vhost_crypto.c | 22 +++--- 2 files changed, 13 insertions(+), 13 deletions(-) diff

[PATCH v7 5/5] ipsec: fix usage of RTE_LOGTYPE_USER1

There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v9 00/22] Convert static logtypes in libraries

This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. There are several options on how to treat the old static types: leave them there, mark as deprecated, or remove them. This version removes them since there i

[PATCH v9 02/22] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v9 01/22] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Reviewed-by: Jiayu Hu Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- lib/gs

[PATCH v9 03/22] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v9 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 4 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/eal/com

[PATCH v9 05/22] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v9 06/22] acl: replace LOGTYPE_ACL with dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v9 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 100644 --- a/examples/di

[PATCH v9 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f57c54d2b57c..76b890b76c88

[PATCH v9 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c | 3 ++- lib/power/power_common.c| 2 ++

[PATCH v9 10/22] ring: replace RTE_LOGTYPE_RING with dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v9 11/22] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 2 ++ lib/mempool/rte_mempool.h | 8 lib/mempool/version.map | 3 +++

[PATCH v9 12/22] lpm: replace RTE_LOGTYPE_LPM with dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v9 13/22] kni: replace RTE_LOGTYPE_KNI with dynamic type

Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v9 14/22] sched: replace RTE_LOGTYPE_SCHED with dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v9 15/22] examples/ipsecgw: replace RTE_LOGTYPE_PORT

Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++-

[PATCH v9 16/22] port: replace RTE_LOGTYPE_PORT with dynamic type

Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v9 17/22] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v9 18/22] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v9 19/22] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

Use a dynamically allocated logtype. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/e

[PATCH v9 20/22] hash: move rte_thash_gfni stubs out of header file

Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 ++- lib/hash/rte_thash_gfni.c | 47 +++ lib/hash/rte_thash_gfni.h | 28 +--

[PATCH v9 21/22] hash: move rte_hash_set_alg out header

The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v9 22/22] hash: convert RTE_LOGTYPE_HASH to dynamic type

Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 5 + lib/hash/rte_thash.c|

[PATCH v6] hash: add XOR32 hash function

An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its use case in P4. We implement it in this patch so it could be easily registered in the pipeline later. Signed-off-by: Bili Dong --- .mailmap | 1 + app/test/test_hash_functions.c | 33 +++-- lib/h

Re: [PATCH v2] app/testpmd: fix flex item compilation error

21/02/2023 11:02, Rongwei Liu: > When configuring meson with option "--optimization=1", gcc > complains "maybe-uninitialized" warning and it was treated as > error since Werror is enabled. > > Assign fp to NULL at declaration can avoid this. That's probably a false positive, but I'm OK to workaro

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

Hi Thomas, Do you want me to squash the unit tests in the mempool lib patch or do I have to wait for the reviews from mempool maintainers Thanks, Kamalakshitha > -Original Message- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 5:53 AM > To: olivier.m...@6wind.com; andrew.r

Updated invitation with note: DTS Working Group - DPDK @ Every 2 weeks from 9am to 10am on Wednesday from Wed Oct 19, 2022 to Tue Feb 21 (EDT) (dev@dpdk.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/Detroit X-LIC-LOCATION:America/Detroit BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY

Updated invitation with note: DTS Working Group - DPDK @ Every 2 weeks from 9am to 10am on Wednesday from Wed Feb 8 to Tue Feb 21 (EST) (dev@dpdk.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/Detroit X-LIC-LOCATION:America/Detroit BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY

DTS Working Group Cancellation

Dear DPDK Community, For the time being the DPDK DTS Working Group, starting tomorrow, has been officially cancelled per internal request. Any questions, let me know. Thank you! Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux Foundation 248.835.4812 (mobil

[PATCH] net/mana: use RTE_LOG_DP for logs on datapath

From: Long Li Change all the logging statements on the datapath to use RTE_LOG_DP() to reduce CPU overhead when logging is not enabled for datapath. Fixes: 517ed6e2d5 ("net/mana: add basic driver with build environment") Cc: sta...@dpdk.org Signed-off-by: Long Li --- drivers/net/mana/gdma.c |

Re: [PATCH v6] hash: add XOR32 hash function

The reported performance issue is a mystery to me. Does anyone have an idea what's going on? Thanks, Bili On Tue, Feb 21, 2023 at 11:37 AM Bili Dong wrote: > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for

Reminder - DPDK Techboard Meeting - Tomorrow Wed. 2/22/23 @ 7am PT/10am ET/1600h CET

Good evening, Tomorrow, Wednesday Feb. 22, 2023, the DPDK tech board will meet at 7am PT/10am ET/1600h CET. An agenda will be placed here by the tech board members: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db Link to sign into the meeting https://meet.jit.si/dpdk Thanks,

Re: [PATCH 1/2] net/mana: add version information for dependencies

On 1/20/2023 2:19 AM, lon...@linuxonhyperv.com wrote: > From: Long Li > > The required dependencies for mana from rdma-core and Linux kernel have > been released. Add those information to the doc. > > Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") > Signed-off-by: Long

  1   2   >