RE: [PATCH v2] net/ice: add devargs for disabling mac filter

> -Original Message- > From: Zhang, Qi Z > Sent: Monday, December 26, 2022 2:15 PM > To: Zhang, Ke1X ; Zhang, Yuying > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ice: add devargs for disabling mac filter > > > > > -Original Message- > > From: Zhang, Ke1X > > Sent: Wednesda

[PATCH v3 1/2] eal: add nonnull and access function attributes

Add "nonnull" function attribute to help the compiler detect a NULL pointer being passed to a function not accepting NULL pointers as an argument at build time. Add "access" function attribute to tell the compiler how a function accesses its pointer arguments. Add these attributes to the rte_memc

[PATCH v3 2/2] net/bnx2x: fix warnings about rte_memcopy lengths

Bugfix: The vlan in the bulletin does not contain a VLAN header, only the VLAN ID, so only copy 2 byte, not 4. The target structure has padding after the field, so copying 2 byte too many is effectively harmless. There is no need to backport this patch. Added type casts where copying arrays to the

[PATCH v4 1/2] eal: add nonnull and access function attributes

Add "nonnull" function attribute to help the compiler detect a NULL pointer being passed to a function not accepting NULL pointers as an argument at build time. Add "access" function attribute to tell the compiler how a function accesses its pointer arguments. Add these attributes to the rte_memc

[PATCH v4 2/2] net/bnx2x: fix warnings about rte_memcpy lengths

Bugfix: The vlan in the bulletin does not contain a VLAN header, only the VLAN ID, so only copy 2 byte, not 4. The target structure has padding after the field, so copying 2 byte too many is effectively harmless. There is no need to backport this patch. Added type casts where copying arrays to the

dlb2 weird rte_memcpy

Timothy, What is the purpose of [1]? Is it superfluous, or should ".hw_rsrc_max" be removed from the source pointer, or is the size wrong? [1]: https://elixir.bootlin.com/dpdk/latest/source/drivers/event/dlb2/dlb2.c#L280 Building with access attributes to rte_memcpy() [2] causes this error: .

Re: dumpcap, interfaces, and promiscuous mode

I would like to respectfully ask that you please re-read my initial email. Unfortunately the interface selection issue I describe is not resolved in 22.11 (currently running). It is also easily observed by reviewing the current code (once one knows to look for it). I'll be the first to admit I d

RE: Mysterious CI/IOL failures in Patchwork

Hi Owen, Thanks for fixing the dashboard. It looks like the email test result sender needs to have some environments added too, please refer to the email below – testing fail, but all say PASS. Test-Label: iol-testing Test-Status: FAILURE http://dpdk.org/patch/121449 _Testing iss

[PATCH v5 1/4] eal: add nonnull and access function attributes

Add "nonnull" function attribute to help the compiler detect a NULL pointer being passed to a function not accepting NULL pointers as an argument at build time. Add "access" function attribute to tell the compiler how a function accesses its pointer arguments. Add these attributes to the rte_memc

[PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

Bugfix: The vlan in the bulletin does not contain a VLAN header, only the VLAN ID, so only copy 2 byte, not 4. The target structure has padding after the field, so copying 2 byte too many is effectively harmless. There is no need to backport this patch. Use RTE_PTR_ADD where copying arrays to the

[PATCH v5 3/4] event/dlb2: remove superfluous rte_memcpy

Copying with the same src and dst address has no effect; removed to avoid compiler warning. Signed-off-by: Morten Brørup v5: * First patch in series. --- drivers/event/dlb2/dlb2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 6

[PATCH v5 4/4] net/mlx5: fix warning about rte_memcpy length

Use RTE_PTR_ADD where copying to the offset of a field in a structure holding multiple fields, to avoid compiler warnings. Signed-off-by: Morten Brørup v5: * First patch in series. --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

Re: [PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

On Wed, Dec 28, 2022, 16:10 Morten Brørup wrote: > Bugfix: The vlan in the bulletin does not contain a VLAN header, only the > VLAN ID, so only copy 2 byte, not 4. The target structure has padding > after the field, so copying 2 byte too many is effectively harmless. > It is a small nitpick but w

RE: [PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

From: Stanisław Kardach [mailto:k...@semihalf.com] Sent: Wednesday, 28 December 2022 17.14 > On Wed, Dec 28, 2022, 16:10 Morten Brørup wrote: > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only the > > VLAN ID, so only copy 2 byte, not 4. The target structure has padding > >

[RFC] ethdev: sharing indirect actions between ports

The RTE Flow API implements the concept of shared objects, known as indirect actions (RTE_FLOW_ACTION_TYPE_INDIRECT). An application can create the indirect action of desired type and configuration with rte_flow_action_handle_create call and then specify the obtained action handle in multiple flows

Re: [PATCH v5 3/4] event/dlb2: remove superfluous rte_memcpy

On Wed, 28 Dec 2022 16:10:18 +0100 Morten Brørup wrote: > Copying with the same src and dst address has no effect; removed to > avoid compiler warning. > > Signed-off-by: Morten Brørup > > v5: > * First patch in series. > --- > drivers/event/dlb2/dlb2.c | 3 --- > 1 file changed, 3 deletions(

Re: [PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

On Wed, 28 Dec 2022 17:38:56 +0100 Morten Brørup wrote: > From: Stanisław Kardach [mailto:k...@semihalf.com] > Sent: Wednesday, 28 December 2022 17.14 > > On Wed, Dec 28, 2022, 16:10 Morten Brørup > > wrote: > > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only the > >

Re: dumpcap, interfaces, and promiscuous mode

On Wed, 28 Dec 2022 09:12:12 -0500 Ben Magistro wrote: > I would like to respectfully ask that you please re-read my initial email. > > Unfortunately the interface selection issue I describe is not resolved in > 22.11 (currently running). It is also easily observed by reviewing the > current co

RE: [PATCH v5 2/4] net/bnx2x: fix warnings about rte_memcpy lengths

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 28 December 2022 18.03 > > On Wed, 28 Dec 2022 17:38:56 +0100 > Morten Brørup wrote: > > > From: Stanisław Kardach [mailto:k...@semihalf.com] > > Sent: Wednesday, 28 December 2022 17.14 > > > On Wed, Dec 28, 2022, 1

[PATCH v2] net/mlx5: add stub functions to null drv ops

There are several functions implementation that queries the drv type to understand which fops function to use. In case the type is DV, the function gets the concrete DV function and calls it. In case it’s not, the function returns an error. The current implementation is not flexible enough and wil

[PATCH v3] net/iavf: add lock for vf commands

iavf admin queue commands aren't thread-safe. Bugs surrounding this issue can manifest in a variety of ways but frequently pend_cmd is over written. Simultaneously executing commands can result in a misconfigured device or DPDK sleeping in a thread for 2 second. Despite this limitation, vf command

Get started contributing to the DPDK

Dear DPDK team, My name is Raul and I recently discovered the DPDK project and I am very interested in contributing and becoming more involved. Can you please provide some guidance on how to get started with my first contribution? I am particularly interested in tackling bugs that are suitable

[PATCH v4] net/iavf: add lock for vf commands

iavf admin queue commands aren't thread-safe. Bugs surrounding this issue can manifest in a variety of ways but frequently pend_cmd is over written. Simultaneously executing commands can result in a misconfigured device or DPDK sleeping in a thread for 2 second. Despite this limitation, vf command