[PATCH 1/4] examples/ipsec-secgw: update error prints to data path log

2022-02-06 Thread Nithin Dabilpuram
Update error prints in data path to RTE_LOG_DP(). Error prints in fast path are not good for performance as they slow down the application when few bad packets are received. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec_worker.c | 6 -- 1 file changed, 4 insertions(+), 2 de

[PATCH 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-06 Thread Nithin Dabilpuram
Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. In other cases such as Tx Inline protocol offload, checksum computation is implicitly taken care by HW. The advantage of having only necessary offloads enabled is that Tx burst function can be as light as possible. Signed-off-by

[PATCH 3/4] examples/ipsec-secgw: fix buffer free logic in vector mode

2022-02-06 Thread Nithin Dabilpuram
Fix packet processing to skip after mbuf is freed instead of touching and Tx'ing it. Also free vector event buffer in event worker when after processing there is no pkt to be enqueued to Tx adapter. Fixes: 86738ebe1e3d ("examples/ipsec-secgw: support event vector") Cc: scha...@marvell.com Cc: sta

[PATCH 4/4] examples/ipsec-secgw: add per port pool and vector pool size

2022-02-06 Thread Nithin Dabilpuram
Add support to enable per port packet pool and also override vector pool size from command line args. This is useful on some HW to tune performance based on usecase. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/event_helper.c | 17 ++-- examples/ipsec-secgw/event_helper.h | 2 +

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-06 Thread Ananyev, Konstantin
> > This patchset introduces config file support for l3fwd > > and its lookup methods LPM, FIB, and EM, similar to > > that of l3fwd-acl. This allows for route rules to be > > defined in configuration files and edited there instead > > of in each of the lookup methods hardcoded route tables. > >

Re: [PATCH 5/6] eal/windows: fix the curly braces mismatch problem

2022-02-06 Thread Dmitry Kozlyuk
2022-02-06 08:44 (UTC+0800), Weiguo Li: > Supplement the first half of braces for the extern "C" block > > Fixes: 99a2dd955fba6 ("lib: remove librte_ prefix from directory names") > Cc: bruce.richard...@intel.com > > Signed-off-by: Weiguo Li > --- > lib/eal/windows/include/dirent.h | 4 >

Re: [PATCH 13/16] eal: add define guards to avoid multi-inclusion

2022-02-06 Thread Dmitry Kozlyuk
2022-02-06 11:58 (UTC+0800), Weiguo Li: > Supplement define guards to prevent multiple inclusion. > > Signed-off-by: Weiguo Li > --- > lib/eal/include/rte_eal_paging.h| 5 + > lib/eal/windows/include/rte_virt2phys.h | 5 + > 2 files changed, 10 insertions(+) > > diff --git a/lib

[Bug 934] crypto_aesni_mb PMD found crash in access mb_mgr on primary process after secondary process launch scan/probe

2022-02-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=934 Bug ID: 934 Summary: crypto_aesni_mb PMD found crash in access mb_mgr on primary process after secondary process launch scan/probe Product: DPDK Version: 20.11 H

[Bug 935] aesni_mb_pmd does not trigger parallel processing for multiple jobs

2022-02-06 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=935 Bug ID: 935 Summary: aesni_mb_pmd does not trigger parallel processing for multiple jobs Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNC

RE: [PATCH v2 1/1] vhost: integrate dmadev in asynchronous datapath

2022-02-06 Thread Hu, Jiayu
Hi Maxime, Thanks for your comments. Please see replies inline. > -Original Message- > From: Maxime Coquelin > Sent: Thursday, February 3, 2022 9:04 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: i.maxim...@ovn.org; Xia, Chenbo ; Richardson, > Bruce ; Van Haaren, Harry > ; Pai G, Sunil ; > Mcna

Re: [PATCH] net/virtio: include ipv4 cksum to support cksum offload capability

2022-02-06 Thread Harold Huang
Hi, Maxime, Maxime Coquelin 于2022年1月31日周一 18:04写道: > > Hi Harold, > > On 1/7/22 12:53, Harold Huang wrote: > > Device cksum offload capability usually include ipv4 cksum, tcp and udp > > cksum offload capability. The application such as OVS usually negotiate > > with the drive like this to enable

[PATCH] common/cnxk: validate length argument

2022-02-06 Thread Ankur Dwivedi
The x->len is passed as argument to npc_prep_mcam_ldata(). In the function the len is used to reference elements of int_info and int_info_mask array. The arrays are of length NPC_MAX_EXTRACT_DATA_LEN. Validating the x->len value so that it is not greater than NPC_MAX_EXTRACT_DATA_LEN. This patch

[PATCH v2 1/4] examples/ipsec-secgw: update error prints to data path log

2022-02-06 Thread Nithin Dabilpuram
Update error prints in data path to RTE_LOG_DP(). Error prints in fast path are not good for performance as they slow down the application when few bad packets are received. Signed-off-by: Nithin Dabilpuram --- v2: - Fixed issue with warning in patch 4/4 by checking for session pool initializa

[PATCH v2 3/4] examples/ipsec-secgw: fix buffer free logic in vector mode

2022-02-06 Thread Nithin Dabilpuram
Fix packet processing to skip after mbuf is freed instead of touching and Tx'ing it. Also free vector event buffer in event worker when after processing there is no pkt to be enqueued to Tx adapter. Fixes: 86738ebe1e3d ("examples/ipsec-secgw: support event vector") Cc: scha...@marvell.com Cc: sta

[PATCH v2 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-06 Thread Nithin Dabilpuram
Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. In other cases such as Tx Inline protocol offload, checksum computation is implicitly taken care by HW. The advantage of having only necessary offloads enabled is that Tx burst function can be as light as possible. Signed-off-by

[PATCH v2 4/4] examples/ipsec-secgw: add per port pool and vector pool size

2022-02-06 Thread Nithin Dabilpuram
Add support to enable per port packet pool and also override vector pool size from command line args. This is useful on some HW to tune performance based on usecase. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/event_helper.c | 17 ++-- examples/ipsec-secgw/event_helper.h | 2 +

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: support queue-based priority flow control

2022-02-06 Thread Jerin Jacob
) On Thu, Feb 3, 2022 at 9:31 PM Ferruh Yigit wrote: > > On 1/31/2022 6:08 PM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Based on device support and use-case need, there are two different ways > > to enable PFC. The first case is the port level PFC configuration, in > > this case,

[PATCH 01/20] common/cnxk: increase resource count for bitmap alloc

2022-02-06 Thread Nithin Dabilpuram
From: Satha Rao CN10K supports up to 832 resources at SMQ level, so increase bitmap count to 1024. Signed-off-by: Satha Rao --- Depends-on: Series-20935 ("common/cnxk: use XAQ create API for inline device") Depends-on: Series-20934 ("common/cnxk: add workaround for vWQE flush") drivers/common

[PATCH 03/20] common/cnxk: adjust shaper rates to lower boundaries

2022-02-06 Thread Nithin Dabilpuram
From: Satha Rao New api to get floor values for a requested shaper rate, which can assure packets should never be transmitted at a rate higher than configured. Keep the old api to get HW suggested values. And introduce new parameter to select appropriate api. Signed-off-by: Satha Rao --- driv

[PATCH 02/20] common/cnxk: realloc inline device XAQ AURA

2022-02-06 Thread Nithin Dabilpuram
Add support to realloc inline device XAQ AURA with more buffers of new packet pool AURA. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_inl.h | 1 + drivers/common/cnxk/roc_nix_inl_dev.c | 110 +- drivers/common/cnxk/roc_nix_inl_dev_irq

[PATCH 06/20] common/cnxk: enable l3hdr write back in SA

2022-02-06 Thread Nithin Dabilpuram
From: Vidya Sagar Velumuri Enable the field in SA to write back l2, l3 hdrs in case of errors during inline processing. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot.c | 1 + drivers/common/cnxk/roc_ie_ot.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 08/20] common/cnxk: use SSO time counter threshold for IRQ

2022-02-06 Thread Nithin Dabilpuram
Enable time counter based threshold for raising SSO EXE_INT instead of IAQ threshold. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_inl_dev_irq.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_inl_dev_irq.c b/dri

[PATCH 04/20] common/cnxk: support inline device API without ROC NIX

2022-02-06 Thread Nithin Dabilpuram
From: Vidya Sagar Velumuri Update the inline device functions to work when roc_nix is NULL. This is required, as IPsec driver have to use these APIs to work with inline IPsec device, but the IPsec driver might not have roc_nix information. Signed-off-by: Vidya Sagar Velumuri --- drivers/common

[PATCH 09/20] common/cnxk: allow force use of SSO pffunc for outb inline

2022-02-06 Thread Nithin Dabilpuram
Allow force use of SSO pffunc even when inline dev is available so that in case driver needs events directly delivered to event device. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h | 1 + drivers/common/cnxk/roc_nix_inl.c | 7 ++- 2 files changed, 7 insertions(+), 1

[PATCH 05/20] common/cnxk: use common SA init API for default options

2022-02-06 Thread Nithin Dabilpuram
From: Vidya Sagar Velumuri Use common SA init API before doing initialization based on params. This is better so that all HW specific default values are at single place for lookaside and inline. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_

[PATCH 07/20] common/cnxk: support to enable aura tail drop for RQ

2022-02-06 Thread Nithin Dabilpuram
Add support to enable aura tail drop via RQ specifically for inline device RQ's pkt pool. This is better than RQ red drop as it can be applied to all RQ's that are not having security enabled but using same packet pool. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix.h

[PATCH 10/20] net/cnxk: added Rx metadata negotiate operation

2022-02-06 Thread Nithin Dabilpuram
From: Satha Rao Added rx_metadata_negotiate api to enable mark update RX offload. Removed software logic to enable/disable mark update inside flow create/destroy apis. Signed-off-by: Satha Rao --- drivers/net/cnxk/cn10k_ethdev.c | 26 ++ drivers/net/cnxk/cn10k_rte_flo

[PATCH 12/20] net/cnxk: fix inline device RQ tag mask

2022-02-06 Thread Nithin Dabilpuram
Fix inline device rq tagmask to get packets with receive errors as type ETHDEV packets to callback handler so that packet buffers can get freed. Currently only ipsec denied packets get the right tag mask. Fixes: ee48f711f3b0 ("common/cnxk: support NIX inline inbound and outbound setup") Cc: sta..

[PATCH 11/20] common/cnxk: removed tracking of mark actions

2022-02-06 Thread Nithin Dabilpuram
From: Satha Rao Removed roc npc apis which tracks addition and deletion of mark actions. Signed-off-by: Satha Rao --- drivers/common/cnxk/roc_npc.c | 21 - drivers/common/cnxk/roc_npc.h | 3 --- drivers/common/cnxk/roc_npc_priv.h | 1 - drivers/common/cnxk/versi

[PATCH 13/20] net/cnxk: register callback early to handle initial packets

2022-02-06 Thread Nithin Dabilpuram
Register callback early to handle initial error packets from inline device. Fixes: 69daa9e5022b ("net/cnxk: support inline security setup for cn10k") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev.c | 6 ++ drivers/net/cnxk/cn10k_ethdev.h | 3

[PATCH 14/20] net/cnxk: realloc inline dev XAQ for security

2022-02-06 Thread Nithin Dabilpuram
Realloc inline dev XAQ when Rx/Tx security ie enabled with new packet pool as XAQ should be large enough to hold all mbufs if inline outbound reports error or all mbufs. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/d

[PATCH 15/20] net/cnxk: use raw mbuf free on inline sec err

2022-02-06 Thread Nithin Dabilpuram
Use raw mbuf free on inline sec error to simulate HW NPA free instead of doing rte_pktmbuf_free(). This is needed as the callback will not be called from DPDK lcore. Fixes: 69daa9e5022b ("net/cnxk: support inline security setup for cn10k") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram ---

[PATCH 16/20] net/cnxk: use NPA batch burst free for meta buffers

2022-02-06 Thread Nithin Dabilpuram
Currently meta buffers are freed in bursts of one LMT line i.e 15 pointers. Instead free them in bursts of 16 LMTlines which is 240 ptrs for better perf. Also mark mempool objects as get and put in missing places. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_worker.h | 13

[PATCH 17/20] net/cnxk: enable packet pool tail drop

2022-02-06 Thread Nithin Dabilpuram
Enable packet pool tail drop on RQ when inbound security is not enabled. This is only part of the config. It is a NOP if tail drop is not enabled on NPA_AURA_CTX_S. And tail drop on packet pool AURA is enabled only when that packet pool aura is used by inline device RQ. Signed-off-by: Nithin Dabil

[PATCH 18/20] net/cnxk: enable flow control by default on device configure

2022-02-06 Thread Nithin Dabilpuram
Enable flow control by default on device configuration instead of basing it on Kernel behaviour. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_ethdev.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/driv

[PATCH 20/20] net/cnxk: add option to override outbound inline sa iv

2022-02-06 Thread Nithin Dabilpuram
Add option to override outbound inline sa iv for debug purposes via environment variable. User can set env variable as: export CN10K_ETH_SEC_IV_OVR="0x0, 0x0,..." Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c | 62 + 1 file changed,

[PATCH 19/20] net/cnxk: add dev args for min-max spi

2022-02-06 Thread Nithin Dabilpuram
Add support for inline inbound SPI range via devargs instead of just max SPI value and range being 0..max. Signed-off-by: Nithin Dabilpuram --- doc/guides/nics/cnxk.rst | 28 +- drivers/common/cnxk/roc_nix.h | 5 ++- drivers/common/cnxk/roc_nix_inl.c | 68

RE: [EXT] [PATCH 1/4] crypto: add dsa random number k

2022-02-06 Thread Akhil Goyal
Hi Arek, > This commit adds random number 'k' to dsa > op param struct. > > Signed-off-by: Arek Kusztal > --- Could you please update the description of the patches, To describe the need of the patch and what has been done in the patch. Most of the commits in this set does not describe the need

RE: [PATCH v2] net/af_xdp: re-enable secondary process support

2022-02-06 Thread Loftus, Ciara
> > On 2/4/2022 12:54 PM, Ciara Loftus wrote: > > Secondary process support had been disabled for the AF_XDP PMD > > because there was no logic in place to share the AF_XDP socket > > file descriptors between the processes. This commit introduces > > this logic using the IPC APIs. > > > > Since AF