Re: [dpdk-dev] [PATCH v2] net/iavf: fix Rx total stats

2019-12-13 Thread Ye Xiaolong
On 12/13, Wu, Jingjing wrote: > > >> -Original Message- >> From: Min, JiaqiX >> Sent: Friday, December 13, 2019 9:23 AM >> To: dev@dpdk.org >> Cc: Wu, Jingjing ; Yang, Qiming >> ; Min, JiaqiX >> ; sta...@dpdk.org >> Subject: [PATCH v2] net/iavf: fix Rx total stats >> >> Rx total stats is

Re: [dpdk-dev] [PATCH] Don't combine '-r' and '--export-dynamic' linker options

2019-12-13 Thread Ray Kinsella
On 12/12/2019 16:05, Thomas Monjalon wrote: > 25/10/2019 03:20, Rafael Ávila de Espíndola: >> Running ld with '-r' switches the linker to a very special mode where >> some other linker options don't make sense. >> >> In particular, '--export-dynamic' normally requires that all global >> symbols

Re: [dpdk-dev] [EXT] Re: [PATCH 00/15] add OCTEONTX2 inline IPsec support

2019-12-13 Thread Thomas Monjalon
13/12/2019 08:41, Anoob Joseph: > Hi Thomas, Jerin, > > Please see inline. > > Thanks, > Anoob > > From: Thomas Monjalon > > 09/12/2019 09:06, Jerin Jacob: > > > On Sun, Dec 8, 2019 at 5:25 PM Anoob Joseph > > wrote: > > > > > > > > This series adds inline IPsec support in OCTEONTX2 PMD. > > >

Re: [dpdk-dev] [PATCH v3 03/17] net/ionic: add log

2019-12-13 Thread Hemant Agrawal
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, December 11, 2019 12:19 AM > To: Alfredo Cardigliano > Cc: dev@dpdk.org; Stephen Hemminger ; > Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v3 03/17] net/ionic: add log > Importance: High > > On 12/9/2019 9:46 P

Re: [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures definitions

2019-12-13 Thread Hemant Agrawal
Hi Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Wednesday, December 11, 2019 12:19 AM > To: Alfredo Cardigliano > Cc: dev@dpdk.org; Hemant Agrawal ; Stephen > Hemminger > Subject: Re: [dpdk-dev] [PATCH v3 02/17] net/ionic: add hardware structures > definitions > Importance:

[dpdk-dev] [PATCH] update Intel roadmap for 20.02

2019-12-13 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- Roadmap provided by: Cc: Tim O'Driscoll Cc: John Mcnamara --- content/roadmap/_index.md | 8 1 file changed, 8 insertions(+) diff --git a/content/roadmap/_index.md b/content/roadmap/_index.md index ed727f0..ae43c16 100644 --- a/content/roadmap/_index.md

Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-13 Thread Sexton, Rory
Hi Beilei, See comments below. Regards, Rory > > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > It's not only add new customized pctype, but mainly enable FDIR for l2ipv3, > so how about " net/i40e: support FDIR for L2TPv3"? > > Detailed commit log is also needed. Of course

Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity

2019-12-13 Thread Neil Horman
On Thu, Dec 12, 2019 at 11:58:26AM +, Bruce Richardson wrote: > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: return on encountering algo as NULL

2019-12-13 Thread Savinay Dharmappa
if algo is NULL set the status to error and return. This change prevent crashing of ipsec-secgw application when a specific cipher/auth/aead algo are not supported by application. Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") Signed-off-by: Savinay Dharmappa Acked-by:

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2019-12-13 Thread Ananyev, Konstantin
> > > > > The rte_security API which enables inline protocol/crypto feature > > > > > mandates that for every security session an rte_flow is created. > > > > > This would internally translate to a rule in the hardware which > > > > > would do packet classification. > > > > > > > > > > In rte_secur

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: return on encountering algo as NULL

2019-12-13 Thread Ananyev, Konstantin
Hi, > if algo is NULL set the status to error and return. This change > prevent crashing of ipsec-secgw application when a specific > cipher/auth/aead algo are not supported by application. It seems you forgot 'fix' in the header 😊 examples/ipsec-secgw: fix ... > > Fixes: 0d547ed03717 ("exa

[dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

2019-12-13 Thread Michal Krawczyk
This version of the HAL allows to use the latest HW features, like rx offsets. Driver was adjusted to the new version to fix the build. Signed-off-by: Michal Krawczyk Signed-off-by: Maciej Bielski --- drivers/net/ena/base/ena_com.c| 154 +++--- drivers/net/ena/base/

[dpdk-dev] [PATCH 2/2] net/ena: add support for RX_OFFSET feature

2019-12-13 Thread Michal Krawczyk
From: Maciej Bielski Allow the data in the first buffer to be shifted by `pkt_offset` after the header room. The offset value is provided by `ena_rx_ctx`. As part of this update, the version of the ENA was upgraded to v2.0.3. Signed-off-by: Maciej Bielski Acked-by: Michal Krawczyk --- driver

[dpdk-dev] [PATCH 0/2] net/ena: add support for Rx offsets

2019-12-13 Thread Michal Krawczyk
Hi, Those 2 patches are adding support for the device to set "Rx offsets". It is supported on the newest generation and driver should support it as well. Maciej Bielski (1): net/ena: add support for RX_OFFSET feature Michal Krawczyk (1): net/ena: upgrade HAL for new HW features drivers/net

[dpdk-dev] DPDK techboard minutes of Dec 4

2019-12-13 Thread Kevin Traynor
Minutes of Technical Board Meeting, 2019-12-04 Members Attending - -Bruce -Ferruh -Hemant -Honnappa -Jerin -Kevin (Chair) -Konstantin -Maxime -Olivier -Stephen -Thomas NOTE: The technical board meetings every second Wednesday on IRC channel #dpdk-board, at 3pm UTC. Meetings are

[dpdk-dev] [PATCH v5 0/3] Add ABI compatibility checks to the meson build

2019-12-13 Thread Kevin Laatz
With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly important to check patches for ABI compatibility. We propose adding the ABI compatibility checking to be done as part of the build. The advantages to adding the ABI compatibility checking to the build are

[dpdk-dev] [PATCH v5 3/3] build: clean up experimental syms check

2019-12-13 Thread Kevin Laatz
This patch cleans up the meson build files in lib and drivers by moving the custom target for checking the experimental syms next to the abi compat checks. This also removes the dependency on the check for the shared build, which was not required by anything, but was only added to force the experim

[dpdk-dev] [PATCH v5 2/3] build: add abi checks to meson

2019-12-13 Thread Kevin Laatz
This patch adds a script to generate ABI dump files. These files will be required to perform ABI compatibility checks during the build later in the patchset. This script should be run on a DPDK version with a stable ABI. Since this is a tool designed for human use, we simplify it to just work off

Re: [dpdk-dev] [PATCH] Don't combine '-r' and '--export-dynamic' linker options

2019-12-13 Thread Rafael Avila de Espindola
Thomas Monjalon writes: > 25/10/2019 03:20, Rafael Ávila de Espíndola: >> Running ld with '-r' switches the linker to a very special mode where >> some other linker options don't make sense. >> >> In particular, '--export-dynamic' normally requires that all global >> symbols be included in the d

[dpdk-dev] [PATCH v2] Don't combine -r and -export-dynamic linker options

2019-12-13 Thread Rafael Ávila de Espíndola
Running ld with -r switches the linker to a very special mode where some other linker options don't make sense. In particular, -export-dynamic normally requires that all global symbols be included in the dynamic symbol table, but a .o file doesn't even have a dynamic symbol table. When given both

[dpdk-dev] [PATCH 0/4] Add external contiguous memory support to Virtio-user

2019-12-13 Thread Maxime Coquelin
Somme applications/frameworks using DPDK allocate their own memory for its buffers. This is the case of Seastar, and also VPP. It is currently not possible to use Virtio-user PMD with these applications because Virtio-user requires file descriptor for this memory to be shared with the vhost-user b

[dpdk-dev] [PATCH 3/4] bus/vdev: add DMA mapping supprt

2019-12-13 Thread Maxime Coquelin
This patch enables VDEVs to implement their own DMA map and unmap callbacks. It will be used by Virtio-user PMD to support external memory registered by applications like Seastar or VPP. Signed-off-by: Maxime Coquelin --- drivers/bus/vdev/rte_bus_vdev.h | 24 drivers/bus/vdev/v

[dpdk-dev] [PATCH 1/4] eal: add new API to register contiguous external memory

2019-12-13 Thread Maxime Coquelin
This new API allows to pass a file descriptor while registering external and contiguous memory in the IOVA space. This is required for using Virtio-user PMD with application using external memory for the mbuf's buffers, like Seastar or VPP. FD is only attached to the segments if single_file_segme

[dpdk-dev] [PATCH 4/4] net/virtio: add DMA mapping callback to virtio-user

2019-12-13 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- .../net/virtio/virtio_user/virtio_user_dev.c | 10 +--- .../net/virtio/virtio_user/virtio_user_dev.h | 3 + drivers/net/virtio/virtio_user_ethdev.c | 58 +++ 3 files changed, 63 insertions(+), 8 deletions(-) diff --git a/drivers/net/vir

[dpdk-dev] [PATCH 2/4] eal: allow getting memory segment FD with external memory

2019-12-13 Thread Maxime Coquelin
Now that it is possible to associate a file descriptor when registering external and contiguous memory, let's allow it. If no FD is available for the memory segment, ENOENT error is returned. Signed-off-by: Maxime Coquelin --- lib/librte_eal/common/eal_common_memory.c | 12 1 file

[dpdk-dev] [PATCH] net/mlx5: avoid crash when meter action conf is NULL

2019-12-13 Thread xiangxia . m . yue
From: Tonghao Zhang When offloading the meter, should check the action conf and make sure it is valid. Fixes: f46bf7488705 ("net/mlx5: support meter flow action") Cc: Suanming Mou Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_flow_dv.c | 9 - 1 file changed, 8 insertions(+),

[dpdk-dev] [PATCH v2] net/mlx5: avoid crash when meter action conf is NULL

2019-12-13 Thread xiangxia . m . yue
From: Tonghao Zhang When offloading the meter, should check the action conf and make sure it is valid. Fixes: f46bf7488705 ("net/mlx5: support meter flow action") Cc: Suanming Mou Signed-off-by: Tonghao Zhang --- v2: coding style issues: http://patches.dpdk.org/patch/63849/ --- drivers/net/m

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fixed port can not link up in FreeBSD

2019-12-13 Thread Ananyev, Konstantin
Few small nits below. s/fixed/fix/ > In FreeBSD environment, nic_uio drivers do not support interrupts, > rte_intr_callback_register() will fail to register interrupts. > We can not make link status to change from down to up by interrupt > callback. So we need to wait for the controller to acquir

[dpdk-dev] [FDIO] dpdk: add devargs support

2019-12-13 Thread chenmin . sun
From: Chenmin Sun Type: feature This patch adds the devargs support for dpdk device The devargs are used as hardware-specific init args for dpdk devices please refer to the nic guides under $(DPDK_DIR)/doc/guides/nics/$(NIC_DRIVER).rst Signed-off-by: Chenmin Sun Change-Id: Id380d04720090bb66af

Re: [dpdk-dev] [PATCH] net/mlx5: fix eagain on admin down

2019-12-13 Thread Slava Ovsiienko
Hi, Mike In the mlx5_link_update_unlocked_gs() the dev_link.link_speed is set like this: dev_link.link_speed = (ecmd->speed == UINT32_MAX) ? ETH_SPEED_NUM_NONE : ecmd->speed; So, dev_link.link_speed can't be assigned with -1. Do I misunderstand you commit message? With best regards, Sl

[dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-13 Thread Ivan Dyukov
Some applications like pktgen use link_speed to calculate transmit rate. It limits outcome traffic to hardcoded 10G. This patch makes link_speed configurable at compile time. Signed-off-by: Ivan Dyukov --- config/common_base | 1 + config/meson.build | 1 + dri

Re: [dpdk-dev] [FDIO] dpdk: add devargs support

2019-12-13 Thread Ananyev, Konstantin
> From: Chenmin Sun > > Type: feature > > This patch adds the devargs support for dpdk device > The devargs are used as hardware-specific init args for dpdk devices > please refer to the nic guides under > $(DPDK_DIR)/doc/guides/nics/$(NIC_DRIVER).rst > > Signed-off-by: Chenmin Sun > Change-

Re: [dpdk-dev] [FDIO] dpdk: add devargs support

2019-12-13 Thread Sun, Chenmin
O I'm sorry... Best Regards, Sun, Chenmin -Original Message- From: Ananyev, Konstantin Sent: Friday, December 13, 2019 10:51 PM To: Sun, Chenmin ; dev@dpdk.org Subject: RE: [dpdk-dev] [FDIO] dpdk: add devargs support > From: Chenmin Sun > > Type: feature > > This patch adds the

Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-13 Thread Maxime Coquelin
Hi Ivan, On 12/13/19 3:44 PM, Ivan Dyukov wrote: > Some applications like pktgen use link_speed to calculate transmit > rate. It limits outcome traffic to hardcoded 10G. > > This patch makes link_speed configurable at compile time. > > Signed-off-by: Ivan Dyukov > --- > config/common_base

Re: [dpdk-dev] [PATCH] net/mlx5: fix eagain on admin down

2019-12-13 Thread Mike Manning
Hi Slava, Thanks, you are right - I retract my patch, as this was fixed in v19.08 by 6fd05da9efbd ("net/mlx5: fix link speed info when link is down") as per the line you indicate. I should explain that we are using Debian 10 which uses v18.11, here we had a painful issue with the combination of th

[dpdk-dev] [PATCH v3 0/4] Refactor crypto unit tests.

2019-12-13 Thread Adam Dybkowski
This patch set is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. In

[dpdk-dev] [PATCH v3 1/4] test/crypto: refactor unit tests

2019-12-13 Thread Adam Dybkowski
This patch gets rid of individual functions that all call test_blockcipher_all_tests separately for every PMD and instead provides just one set universal for all PMDs that's basing on the driver id from the global variable gbl_driver_id. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.

[dpdk-dev] [PATCH v3 2/4] test/crypto: refactor unit tests - continuation

2019-12-13 Thread Adam Dybkowski
Remove the functions that are not used any more but were left after the previous commit. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 323 -- 1 file changed, 323 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c

[dpdk-dev] [PATCH v3 4/4] test/crypto: refactor unit tests into one combined array

2019-12-13 Thread Adam Dybkowski
This patch refactors most of unit tests to be contained in one combined array, and run depending on the PMD capabilities instead of providing multiple array with tests for individual PMDs. Only a subset of unit tests was merged into one array - it combines all tests originally meant to be run on th

[dpdk-dev] [PATCH v3 3/4] test/crypto: add capability checks

2019-12-13 Thread Adam Dybkowski
This patch adds capability checks to many tests meant to be run in the future on various PMDs. This way the code is prepared for more thorough refactoring in order to create one big central unit tests array. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 616 ++

Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2019 15:59:23 +0100 Maxime Coquelin wrote: > Hi Ivan, > > On 12/13/19 3:44 PM, Ivan Dyukov wrote: > > Some applications like pktgen use link_speed to calculate transmit > > rate. It limits outcome traffic to hardcoded 10G. > > > > This patch makes link_speed configurable at compi

Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-13 Thread Maxime Coquelin
On 12/13/19 5:26 PM, Stephen Hemminger wrote: > On Fri, 13 Dec 2019 15:59:23 +0100 > Maxime Coquelin wrote: > >> Hi Ivan, >> >> On 12/13/19 3:44 PM, Ivan Dyukov wrote: >>> Some applications like pktgen use link_speed to calculate transmit >>> rate. It limits outcome traffic to hardcoded 10G. >

Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

2019-12-13 Thread Stephen Hemminger
On Fri, 13 Dec 2019 14:32:15 +0100 Michal Krawczyk wrote: > This version of the HAL allows to use the latest HW features, like > rx offsets. > > Driver was adjusted to the new version to fix the build. > > Signed-off-by: Michal Krawczyk > Signed-off-by: Maciej Bielski You are mixing multiple

[dpdk-dev] [PATCH v6 00/11] Add ABI compatibility checks to the meson build

2019-12-13 Thread Kevin Laatz
With the recent changes made to stabilize ABI versioning in DPDK, it will become increasingly important to check patches for ABI compatibility. We propose adding the ABI compatibility checking to be done as part of the build. The advantages to adding the ABI compatibility checking to the build are

[dpdk-dev] [PATCH v6 03/11] drivers/mempool: add dump files for v20.0 ABI

2019-12-13 Thread Kevin Laatz
This patch adds the drivers/mempool .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump files (the baseline, ie. current stable ABI version) and the code being c

[dpdk-dev] [PATCH v6 04/11] drivers/common: add dump files for v20.0 ABI

2019-12-13 Thread Kevin Laatz
This patch adds the drivers/common .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump files (the baseline, ie. current stable ABI version) and the code being co

[dpdk-dev] [PATCH v6 05/11] drivers/raw: add dump files for v20.0 ABI

2019-12-13 Thread Kevin Laatz
This patch adds the drivers/raw .dump files generated for the v20.0 ABI. These files will be used to compare the ABI during the meson build when the compat_checks meson is enabled. If there is a mismatch between the .dump files (the baseline, ie. current stable ABI version) and the code being compi

[dpdk-dev] [PATCH v6 11/11] build: clean up experimental syms check

2019-12-13 Thread Kevin Laatz
This patch cleans up the meson build files in lib and drivers by moving the custom target for checking the experimental syms next to the abi compat checks. This also removes the dependency on the check for the shared build, which was not required by anything, but was only added to force the experim

[dpdk-dev] [PATCH v6 10/11] build: add abi checks to meson

2019-12-13 Thread Kevin Laatz
This patch adds a script to generate ABI dump files. These files will be required to perform ABI compatibility checks during the build later in the patchset. This script should be run on a DPDK version with a stable ABI. Since this is a tool designed for human use, we simplify it to just work off

Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-13 Thread Xing, Beilei
> -Original Message- > From: Sexton, Rory > Sent: Friday, December 13, 2019 3:18 AM > To: Xing, Beilei ; dev@dpdk.org > Cc: Zhang, Qi Z ; adrien.mazarg...@6wind.com; > Jagus, DariuszX > Subject: RE: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > > Hi Beilei, > > See comments b

Re: [dpdk-dev] [PATCH v2] net/virtio: add link speed tuning

2019-12-13 Thread Ivan Dyukov
Hi Maxime, Thank you for comments. 13.12.2019 17:59, Maxime Coquelin пишет: > Hi Ivan, > > On 12/13/19 3:44 PM, Ivan Dyukov wrote: >> Some applications like pktgen use link_speed to calculate transmit >> rate. It limits outcome traffic to hardcoded 10G. >> >> This patch makes link_speed configura

[dpdk-dev] [PATCH] net/ice: correct VSI context

2019-12-13 Thread Beilei Xing
There'll always be a MDD event triggered when adding a FDIR rule. The root cause is 'LAN enable' is not configured during control VSI setup. Besides, correct FDIR fields for both main VSI and control VSI. Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine") Cc: sta...@dpdk.org Signed-off-

Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

2019-12-13 Thread Michał Krawczyk
pt., 13 gru 2019 o 17:34 Stephen Hemminger napisał(a): > > On Fri, 13 Dec 2019 14:32:15 +0100 > Michal Krawczyk wrote: > > > This version of the HAL allows to use the latest HW features, like > > rx offsets. > > > > Driver was adjusted to the new version to fix the build. > > > > Signed-off-by: M

[dpdk-dev] 82599 TX flush on carrier loss

2019-12-13 Thread Dave Burton
Howdy! I would like to know how to get the TX queue drained when the link is down (rte_eth_link_get_nowait return rte_eth_link.link_status = 0). Background: our appliance has multi-port 82599 multimode-fiber NICs, and acts as a bump-on-a-wire, taking packets off port N, perhaps processing them,

Re: [dpdk-dev] [PATCH 0/6] bnxt patchset

2019-12-13 Thread Ajit Khaparde
On Tue, Dec 10, 2019 at 6:48 AM Kalesh A P < kalesh-anakkur.pura...@broadcom.com> wrote: > From: Kalesh AP > > bnxt patchset with bug fixes and enhancements. > > Please apply. > Patchset applied to dpdk-next-net-brcm. Thanks > > Kalesh AP (6): > net/bnxt: restore mac filters during reset reco

[dpdk-dev] [PATCH] net/bnxt: add support for flow mark action

2019-12-13 Thread Ajit Khaparde
Add support for RTE_FLOW_ACTION_TYPE_MARK Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_ethdev.c | 8 ++ drivers/net/bnxt/bnxt_filter.h | 3 ++ drivers/net/bnxt/bnxt_flow.c | 35 ++-- drivers/net/b