Re: [dpdk-dev] running dpdk application on the same machine with other none dpdk application

2019-01-30 Thread Rami Rosen
Hi Shirley, > Do you know if the PF_NO_SETAFFINITY flag can help in any way? AFAIK, this will not work for kernel thread. For example, with 4.8.13-1 kernel: Display all kernel threads with ps aux | grep "\["n (as kernel threads are enclosed in square brackets, [ ]) And pick one of them and try:

[dpdk-dev] [PATCH] net/ice: fix segment fault

2019-01-30 Thread Qi Zhang
Fix segment fault when detach a device due to some redundant function call in ice_dev_uninit. Fixes: f9cf4f864150 ("net/ice: support device initialization") Signed-off-by: Qi Zhang --- drivers/net/ice/ice_ethdev.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/dr

Re: [dpdk-dev] running dpdk application on the same machine with other none dpdk application

2019-01-30 Thread Shirley Avishour
Hi Rami, This is correct but that is because the default value of the PF_NO_SETAFFINITY flags does not allow to set affinity to kernel threads from user space. I was looking for a way to change the kernel and recompile it to be able to block kernel threads from running on the cpu isolated cores. (s

Re: [dpdk-dev] running dpdk application on the same machine with other none dpdk application

2019-01-30 Thread Shirley Avishour
Perhaps by modifying the function set_cpus_allowed() which sets the kernel threads flag with PF_NO_SETAFFINITY. To remark it in the kernel code and to recompile the code. On Wed, Jan 30, 2019 at 10:27 AM Shirley Avishour wrote: > Hi Rami, > This is correct but that is because the default value

Re: [dpdk-dev] running dpdk application on the same machine with other none dpdk application

2019-01-30 Thread Rami Rosen
Hi Shirley, Hi, It could be that this will work, but as I assume you know - This requires providing a patched kernel to end customers, some will not like it, some will maybe not accept it - It could be that a kernel patch to the Kernel Mailing list for enabling such functionality (globally or pe

Re: [dpdk-dev] running dpdk application on the same machine with other none dpdk application

2019-01-30 Thread Shirley Avishour
Hi, I will consider that. Thanks again for your help. Shirley. On Wed, Jan 30, 2019 at 10:40 AM Rami Rosen wrote: > Hi Shirley, > > Hi, > It could be that this will work, but as I assume you know - > > This requires providing a patched kernel to end customers, some will not > like it, some > wil

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread David Marchand
On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > On 1/29/2019 5:34 PM, David Marchand wrote: > > On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit > wrote: > > > >> Fixes line commit id length defined as 12 in fixline alias: > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Ferruh Yigit
On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > 29/01/2019 16:30, Ferruh Yigit: >> Fixes line commit id length defined as 12 in fixline alias: >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' >> >> Check if the Fixes line commit id length matches the defined value. > > This ch

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Ferruh Yigit
On 1/30/2019 9:58 AM, David Marchand wrote: > On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > >> On 1/29/2019 5:34 PM, David Marchand wrote: >>> On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit >> wrote: >>> Fixes line commit id length defined as 12 in fixline alias: fixline = log -1

[dpdk-dev] [PATCH 0/3] more doc about isolated mode and bifurcated model

2019-01-30 Thread Thomas Monjalon
The flow isolated mode lacks some advertisement in the docs, especially in association with flow bifurcation. There was also a miss in flow bifurcation howto for Mellanox case. Thomas Monjalon (3): doc: remove useless anchor for flow API guide doc: add references to flow isolated mode in NICs

[dpdk-dev] [PATCH 3/3] doc: improve Mellanox bifurcated model description

2019-01-30 Thread Thomas Monjalon
In the howto guide about flow bifurcation, the Mellanox case (which does not require specific details) was missing in the landscape. In the Linux drivers guide, it was not clear that the flow bifurcation is performed in the NIC hardware. References to flow isolated mode are also inserted in those

[dpdk-dev] [PATCH 1/3] doc: remove useless anchor for flow API guide

2019-01-30 Thread Thomas Monjalon
A doc page (.rst file) can be referenced with :doc: syntax instead of :ref: to .. anchor. Signed-off-by: Thomas Monjalon --- doc/guides/howto/rte_flow.rst | 2 +- doc/guides/nics/mvpp2.rst | 2 +- doc/guides/prog_guide/rte_flow.rst | 2 -- doc/guides/rel_notes/release_1

[dpdk-dev] [PATCH 2/3] doc: add references to flow isolated mode in NICs guide

2019-01-30 Thread Thomas Monjalon
Some drivers (mlx, mvpp2, sfc) support the flow isolated mode, but the feature was not advertised. A reference to the feature description is added for each driver. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx4.rst | 2 ++ doc/guides/nics/mlx5.rst | 2 +- doc/guides/

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 11:17:00AM +, Ferruh Yigit wrote: > On 1/30/2019 9:58 AM, David Marchand wrote: > > On Tue, Jan 29, 2019 at 7:07 PM Ferruh Yigit wrote: > > > >> On 1/29/2019 5:34 PM, David Marchand wrote: > >>> On Tue, Jan 29, 2019 at 4:31 PM Ferruh Yigit > >> wrote: > >>> > Fix

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:17, Ferruh Yigit: > On 1/30/2019 9:58 AM, David Marchand wrote: > > The contributing guide does indicate you are supposed to run both > > checkpatches.sh and check-git-log.sh. > > I am pretty sure I missed this second step in the past.. > > > > How about calling check-git-log.sh from

Re: [dpdk-dev] [PATCH] net/pcap: fix memory leak

2019-01-30 Thread Ferruh Yigit
On 1/30/2019 1:08 AM, Qi Zhang wrote: > Fix potential memory leak due to kvlist not be freed. > > Fixes: 0d0dd2d9d8ff ("net/pcap: enable data path for secondary process") > Cc: sta...@dpdk.org > > Reported-by: Gage Eads > Signed-off-by: Qi Zhang Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > 29/01/2019 16:30, Ferruh Yigit: > >> Fixes line commit id length defined as 12 in fixline alias: > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > >> > >> Check

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:29, Bruce Richardson: > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > 29/01/2019 16:30, Ferruh Yigit: > > >> Fixes line commit id length defined as 12 in fixline alias: > > >> fixline = log -1 --abbrev=12 --format=

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:17, Ferruh Yigit: > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > The contributing guide does indicate you are supposed to run both > > > checkpatches.sh and check-git-log.sh. > > > I am pretty sure I missed this

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Bruce Richardson
On Wed, Jan 30, 2019 at 12:31:21PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:29, Bruce Richardson: > > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > > 29/01/2019 16:30, Ferruh Yigit: > > > >> Fixes line commit id length de

Re: [dpdk-dev] [RFC] lfring: lock-free ring buffer

2019-01-30 Thread Ola Liljedahl
On Wed, 2019-01-30 at 05:17 +, Eads, Gage wrote: >  > > > 2. On the plus side, the enqueue function design that allows it to use > > > 1/2 the atomics of mine appears to be independent of reserving ring > > > slots, and should transfer over fairly cleanly. I'm a little concerned > > > about th

Re: [dpdk-dev] [PATCH] qat/compress: fix qat comp setup inter_buffers

2019-01-30 Thread Trahe, Fiona
> -Original Message- > From: Kovacevic, Marko > Sent: Thursday, January 24, 2019 3:03 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yigit, Ferruh ; > ktray...@redhat.com; Kovacevic, Marko > ; Trahe, Fiona > Subject: [PATCH] qat/compress: fix qat comp setup inter_buffers > > This patch

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:35, Bruce Richardson: > On Wed, Jan 30, 2019 at 12:31:21PM +0100, Thomas Monjalon wrote: > > 30/01/2019 12:29, Bruce Richardson: > > > On Wed, Jan 30, 2019 at 11:15:44AM +, Ferruh Yigit wrote: > > > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > > > 29/01/2019 16:30, Ferruh

Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax

2019-01-30 Thread Thomas Monjalon
30/01/2019 12:31, Bruce Richardson: > On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > > 30/01/2019 12:17, Ferruh Yigit: > > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > > The contributing guide does indicate you are supposed to run both > > > > checkpatches.sh and check-gi

Re: [dpdk-dev] Compiler for Windows

2019-01-30 Thread Thomas Monjalon
08/01/2019 11:24, Burakov, Anatoly: > On 07-Jan-19 5:08 PM, Thomas Monjalon wrote: > > 07/01/2019 18:00, Bruce Richardson: > >> I think for windows we probably want to start with the MS compiler first, > >> since from my understanding it's probably the default go-to compiler for > >> developers on

[dpdk-dev] [PATCH] net/virtio: set offload flag for jumbo frames

2019-01-30 Thread Jens Freimann
Port configuration fails when offload flags don't match the expected value, e.g. when max-pkt-len is set to a value that should enable receive port offloading but doesn't. This can be triggered by running testpmd e.g. with --max-pkt-len=2000. It will fail with "Ethdev port_id=0 requested Rx offloa

Re: [dpdk-dev] [PATCH] net/virtio: set offload flag for jumbo frames

2019-01-30 Thread Maxime Coquelin
On 1/30/19 4:26 PM, Jens Freimann wrote: Port configuration fails when offload flags don't match the expected value, e.g. when max-pkt-len is set to a value that should enable receive port offloading but doesn't. This can be triggered by running testpmd e.g. with --max-pkt-len=2000. It will f

Re: [dpdk-dev] [PATCH] net/virtio: set offload flag for jumbo frames

2019-01-30 Thread Jens Freimann
On Wed, Jan 30, 2019 at 04:41:55PM +0100, Maxime Coquelin wrote: On 1/30/19 4:26 PM, Jens Freimann wrote: Port configuration fails when offload flags don't match the expected value, e.g. when max-pkt-len is set to a value that should enable receive port offloading but doesn't. This can be tri

[dpdk-dev] 18.08.1 patches review and test

2019-01-30 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for stable release 18.08.1. Please help review and test. The tentative date for the final release is 28, February. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression

Re: [dpdk-dev] Compiler for Windows

2019-01-30 Thread Menon, Ranjit
Thank you for the direction, Thomas and Tech Board members. If clang-win64 has support for GCC extensions (__attribute(constructor/align/etc...)), then the changes to common DPDK code should be minimal. Also, Jeff got meson to output VS project files to compile with MSVC - we'll just need to ma

[dpdk-dev] [RFC,v2] lfring: lock-free ring buffer

2019-01-30 Thread Ola Liljedahl
Lock-free MP/MC ring buffer with SP/SC options. The ring buffer metadata only maintains one set of head and tail indexes. Tail is updated on enqueue, head is updated on dequeue. The ring slots between head and tail always contains valid (unconsumed) slots. Each ring slot consists of a struct of dat

[dpdk-dev] [PATCH] doc: remove note about meson being experimental

2019-01-30 Thread Bruce Richardson
At this stage, meson builds are widely supported for DPDK, and so the build system should be no longer called out as experimental. NOTE: this does not imply it's the primary build system, just that it's safe to use for day-to-day work and for packaging if so desired. Signed-off-by: Bruce Richardso

[dpdk-dev] [PATCH v2] net/virtio: set offload flag for jumbo frames

2019-01-30 Thread Jens Freimann
Port configuration fails because offload flags don't match the expected value when max-pkt-len is set to a value that should enable receive port offloading but doesn't. There are two cases to consider: 1. VIRTIO_NET_F_MTU is set. Then we need to check if the requested max-pkt-len fits into the

[dpdk-dev] [PATCH v2 1/2] examples/vhost_scsi: Don't build without virtio_scsi.h

2019-01-30 Thread Michael Santana
From: Aaron Conole The vhost_scsi example code is set to build, even if the requisite header file virtio_scsi.h isn't available. This happens on some Ubuntu systems when some versions of the libc-dev package aren't available. Check whether the virtio_scsi.h file exists, and if not, set the buil

[dpdk-dev] [PATCH v2 0/2] Introduce travis support

2019-01-30 Thread Michael Santana
This series introduces the ability for any github mirrors of the DPDK project, including developer mirrors, to kick off builds under the travis CI infrastructure. For now, this just means compilation - no other kinds of automated run exists yet. In the future, this can be expanded to execute and

[dpdk-dev] [PATCH v2 2/2] ci: Introduce travis builds for github repositories

2019-01-30 Thread Michael Santana
GitHub is a service used by developers to store repositories. GitHub provides service integrations that allow 3rd party services to access developer repositories and perform actions. One of these services is Travis-CI, a simple continuous integration platform. This is a simple initial implementa

[dpdk-dev] [PATCH] build: add option to override max ethports

2019-01-30 Thread Chas Williams
Allow users and packagers to override the default RTE_MAX_ETHPORTS. This adds a new meson option, max_ethports which defaults to the current value. Signed-off-by: Chas Williams <3ch...@gmail.com> --- config/meson.build | 1 + config/rte_config.h | 1 - meson_options.txt | 2 ++ 3 files changed

Re: [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only)

2019-01-30 Thread Honnappa Nagarahalli
> > This operation can be used for non-blocking algorithms, such as a non- > blocking stack or ring. > > Signed-off-by: Gage Eads > --- > .../common/include/arch/x86/rte_atomic_64.h| 31 +++ > lib/librte_eal/common/include/generic/rte_atomic.h | 65 > ++ > 2

Re: [dpdk-dev] [PATCH 0/3] more doc about isolated mode and bifurcated model

2019-01-30 Thread Shahaf Shuler
Wednesday, January 30, 2019 1:20 PM, Thomas Monjalon: > Subject: [dpdk-dev] [PATCH 0/3] more doc about isolated mode and > bifurcated model > > The flow isolated mode lacks some advertisement in the docs, especially in > association with flow bifurcation. > There was also a miss in flow bifurcatio

Re: [dpdk-dev] [PATCH 1/3] doc: add mlx5 note for Bluefield build configuration

2019-01-30 Thread Shahaf Shuler
Wednesday, January 30, 2019 9:53 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH 1/3] doc: add mlx5 note for Bluefield build > configuration > > Fixes: d14e4e976f65 ("config: add Mellanox BlueField armv8 SoC") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh For the series - Acked-by: Shaha