[dpdk-dev] [PATCH] net/mlx5: fix invalid count in xstats

2018-05-20 Thread David Marchand
With the commit af4f09f28294 ("net/mlx5: prefix all functions with mlx5"), mlx5_xstats_get() is not compliant any longer with the api. It always returns the caller max entries count while it should return how many entries it wrote/wanted to write. Fixes: af4f09f28294 ("net/mlx5: prefix all functio

Re: [dpdk-dev] [RFC v2] vhost: new rte_vhost API proposal

2018-05-20 Thread Yuanhan Liu
On Fri, May 18, 2018 at 03:50:45PM +0200, Maxime Coquelin wrote: > Hi Dariusz, > > On 05/18/2018 03:01 PM, Dariusz Stojaczyk wrote: > > rte_vhost is not vhost-user spec compliant. Some Vhost drivers have > > been already confirmed not to work with rte_vhost. virtio-user-scsi-pci > > in QEMU 2.12 d

Re: [dpdk-dev] release date for 17.11.3?

2018-05-20 Thread Yuanhan Liu
On Thu, May 17, 2018 at 10:11:40PM +0200, Thomas Monjalon wrote: > 17/05/2018 18:16, Montorsi, Francesco: > > Hi all, > > I'd like to build DPDK on Centos 7.5... I found a commit > > (http://dpdk.org/browse/dpdk-stable/commit/?h=17.11&id=3ee847054cc9ab62fa2c9c6dc6ba68899d620e3a) > > that allows t

[dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type

2018-05-20 Thread Jerin Jacob
The initial thought was to create a separate event type for each adapter, in order to make consistency with new event adapters, remove RTE_EVENT_TYPE_ETH_RX_ADAPTER event type and use RTE_EVENT_TYPE_ETHDEV event type instead like other event adapters. Cc: Nikhil Rao Signed-off-by: Jerin Jacob --

Re: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type

2018-05-20 Thread Jerin Jacob
-Original Message- > Date: Sun, 20 May 2018 22:18:43 +0530 > From: Jerin Jacob > To: dev@dpdk.org > Cc: Jerin Jacob , Nikhil Rao > > Subject: [dpdk-dev] [PATCH] eventdev: remove ethdev Rx adapter event type > X-Mailer: git-send-email 2.17.0 > > The initial thought was to create a separa

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-20 Thread Parthasarathy, JananeeX M
Hello Thomas, -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Friday, May 18, 2018 7:18 PM To: Parthasarathy, JananeeX M Cc: dev@dpdk.org; Burakov, Anatoly ; Pattan, Reshma Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script 18/05/2018 15:

Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script

2018-05-20 Thread Thomas Monjalon
20/05/2018 19:41, Parthasarathy, JananeeX M: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 18/05/2018 15:32, Parthasarathy, JananeeX M: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 15/05/2018 18:14, Parthasarathy, JananeeX M: > > > > > From: Thomas Monjalon [mailto:th

Re: [dpdk-dev] mellanox connectx-2 support

2018-05-20 Thread Vasiliy Tolstov
чт, 17 мая 2018 г. в 9:02, Olga Shern : > Vasily, > > ConnectX-2 is very, very old card. > We don't support it. > You can run DPDK on ConnectX-3 Pro, ConnectX-4 /LX and ConnectX-5 NICs. > The best performance and better feature set you will get with ConnectX-5 > > Best Regards, > Thanks for info,

Re: [dpdk-dev] [PATCH] pci: remove unused function

2018-05-20 Thread Rosen, Rami
Hi, Looks good to me. I noticed that the same is also with the rte_pci_detach() function, and I will send a patch to remove it as well. Regards, Rami Rosen -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, May 18, 2018 02:45 To: dev@

[dpdk-dev] [PATCH] pci: remove unused function

2018-05-20 Thread Rami Rosen
The function rte_pci_detach() is private to PCI and is not used anywhere in current code base. Remove dead code. Signed-off-by: Rami Rosen --- drivers/bus/pci/pci_common.c | 36 drivers/bus/pci/private.h| 14 -- 2 files changed, 50 deletions(-

Re: [dpdk-dev] [PATCH] net/cxgbevf: fix inter-vm traffic when physical link down

2018-05-20 Thread Ferruh Yigit
On 5/18/2018 7:59 PM, Rahul Lakkireddy wrote: > From: Shagun Agrawal > > Add force_link_up devargs to always force link as up for VFs. > This enables VFs on the same NIC to send traffic to each other > even when physical link is down. > > Fixes: 011ebc236ddc ("net/cxgbe: add skeleton VF driver")

Re: [dpdk-dev] [PATCH 1/4] net/qede: fix multicast filtering

2018-05-20 Thread Ferruh Yigit
On 5/20/2018 1:15 AM, Rasesh Mody wrote: > From: Harish Patil > > This patch is to fix multicast filtering using set_mc_addr_list(). > > Fixes: 77fac1b54fc9 ("net/qede: fix filtering code") > Cc: sta...@dpdk.org > > Signed-off-by: Harish Patil > Signed-off-by: Shahed Shaikh > Signed-off-by: R

Re: [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus

2018-05-20 Thread Thomas Monjalon
> Andy Green (21): > lib/librte_ethdev: change eth-dev-ops API to return int > rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy > lib/librte_eal: explicit tmp cast > /lib/librte_eal: stage cast from uint64 to long > rte_ring_generic.h: stack declarations befor

Re: [dpdk-dev] [PATCH v3 3/3] raw/ifpga_rawdev: fix the clang compiling issue

2018-05-20 Thread Thomas Monjalon
17/05/2018 03:47, Gavin Hu: > If the subject changes to raw/ifpga, it will get a Wrong headline prefix(can > be ignored?) warning when running git-log-fixes.h Yes, this warning can be ignored.

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: fix the clang compiling issue

2018-05-20 Thread Thomas Monjalon
17/05/2018 04:46, Gavin Hu: > From: gavin hu > > This patch adds a pair of "()" to embrace the argument > input to the function-like macro invocation. > > drivers/net/mlx5/mlx5_rxtx_vec.c:37: > drivers/net/mlx5/mlx5_rxtx_vec_neon.h:170:24: error: too many arguments > provided to function-like ma

Re: [dpdk-dev] [PATCH] eal: fix directory permissions

2018-05-20 Thread Thomas Monjalon
18/05/2018 15:55, Adrien Mazarguil: > Executable bit must be set on directories for normal users to enter them. > > This patch addresses the inability to start DPDK applications as non-root > due to errors such as: > > EAL: failed to bind /tmp/dpdk/rte/mp_socket: Permission denied > > Fixes: 56

Re: [dpdk-dev] [PATCH v2] test/eventdev: update the port id to 16 bit

2018-05-20 Thread Thomas Monjalon
15/05/2018 20:06, Vipin Varghese: > port id in test case is update to unsigned int 16 bit, to > prevent compilation failure when RTE_MAX_ETHPORTS port is > set more than 255. > > Signed-off-by: Vipin Varghese > Acked-by: Nikhil Rao Fixes: fc8030eb8fe9 ("test/eventdev: add tests for eth Rx adapt

Re: [dpdk-dev] [PATCH] bus/vdev: don't double space log messages

2018-05-20 Thread Thomas Monjalon
17/05/2018 11:33, Ferruh Yigit: > On 5/16/2018 10:51 PM, Stephen Hemminger wrote: > > The VDEV_LOG() macro already adds a newline, don't duplicate. > > > > Signed-off-by: Stephen Hemminger > > Fixes: d22fcb225c24 ("bus/vdev: change log type") > > Reviewed-by: Ferruh Yigit Applied, thanks

[dpdk-dev] [PATCH] net liquidio fix Unable to update lio_dev->linfo.link var

2018-05-20 Thread yaochuhong
Signed-off-by: yaochuhong --- drivers/net/liquidio/lio_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c old mode 100644 new mode 100755 index 0e

[dpdk-dev] [PATCH 2/2] fix Coding Style

2018-05-20 Thread yaochuhong
--- drivers/net/liquidio/lio_ethdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) mode change 100755 => 100644 drivers/net/liquidio/lio_ethdev.c diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c old mode 100755 new mode 100644 index bd47911..0a6eb5

Re: [dpdk-dev] [PATCH v5] net/ixgbe: fix to config VLAN strip on the fly

2018-05-20 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > Sent: Saturday, May 19, 2018 6:11 PM > To: Zhang, Qi Z; Yigit, Ferruh; Lu, Wenzhuo; Ananyev, Konstantin; Wu, > Yanglong > Cc: dev@dpdk.org; Dai, Wei; sta...@dpdk.org; Wei Dai > Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2] i40e: fix corruption of VF stats via port representor

2018-05-20 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Saturday, May 19, 2018 10:18 AM > To: Horton, Remy; dev@dpdk.org > Cc: Yigit, Ferruh; Xing, Beilei; Zhang, Helin; Wu, Jingjing > Subject: RE: [PATCH v2] i40e: fix corruption of VF stats via port representor > > > > > -Original Messag

[dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var

2018-05-20 Thread yaochuhong
Signed-off-by: yaochuhong --- drivers/net/liquidio/lio_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c old mode 100644 new mode 100755 index 0e

[dpdk-dev] [PATCH 3/3] add signoff

2018-05-20 Thread yaochuhong
Signed-off-by: yaochuhong --- drivers/net/liquidio/lio_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c index 0a6eb55..a6a37c8 100644 --- a/drivers/net/liquidio/lio_ethdev.c +++ b/drivers/net/liquid

[dpdk-dev] [PATCH 2/3] fix Coding Style

2018-05-20 Thread yaochuhong
--- drivers/net/liquidio/lio_ethdev.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) mode change 100755 => 100644 drivers/net/liquidio/lio_ethdev.c diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c old mode 100755 new mode 100644 index bd47911..0a6eb5

[dpdk-dev] [PATCH v6 3/8] rte_ip.h: cast type decided by sizeof to uint32

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ip.h: In function 'rte_ipv4_udptcp_cksum': /projects/lagopus/src/dpdk/build/include/rte_byteorder.h: 51:24: warning: conversion from 'long unsigned int' to 'uint32_t' {aka 'unsigned int'} may change value [-Wconversion] #define rte_bswap16(x) ((uint16_t

[dpdk-dev] [PATCH v6 2/8] rte_rwlock.h: gcc8 sign conversion warnings

2018-05-20 Thread Andy Green
In file included from /projects/lagopus/src/dpdk/ build/include/rte_rwlock.h:12, from ./mgr/lock.h:24, from ./mgr/sock_io.c:54: /projects/lagopus/src/dpdk/build/include/generic/ rte_rwlock.h: In function 'rte_rwlock_read_lock': /projects/lagopus/src/dpdk/build/incl

[dpdk-dev] [PATCH v6 0/8] Fixes for GCC8 against lagopus

2018-05-20 Thread Andy Green
The following series fixes build problems in dpdk master headers, found when using it as the dpdk subproject in lagopus. These errors are coming when you try to use the dpdk headers, not when you build dpdk itself. These are the remaining 5 patches not yet applied, with one split into three for c

[dpdk-dev] [PATCH v6 1/8] lib/librte_eal: explicit tmp cast

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_memcpy.h: 793:2: note: in expansion of macro 'MOVEUNALIGNED_LEFT47' MOVEUNALIGNED_LEFT47(dst, src, n, srcofs); ^~~~ /projects/lagopus/src/dpdk/build/include/rte_memcpy.h: 649:51: warning: conversion from 'size_t' {aka 'long unsigned i

[dpdk-dev] [PATCH v6 4/8] rte_mbuf.h: reduce temp to match uint16 types

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h: In function 'rte_pktmbuf_detach': /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: 1583:17: warning: conversion from 'uint32_t' {aka 'unsigned int'} to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversi

[dpdk-dev] [PATCH v6 8/8] rte_ethdev.h: align sign and scope of temp var

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_ethdev.h: In function 'rte_eth_rx_burst': /projects/lagopus/src/dpdk/build/include/rte_ethdev.h: 3836:18: warning: conversion to 'int16_t' {aka 'short int'} from 'uint16_t' {aka 'short unsigned int'} may change the sign of the result [-Wsign-conversion]

[dpdk-dev] [PATCH v6 5/8] rte_mbuf.h: avoid implicit demotion in 64-bit arith

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h: In function 'rte_validate_tx_offload': /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: 2112:19: warning: conversion to 'uint64_t' {aka 'long unsigned int'} from 'int' may change the sign of the result [-Wsign-conversion] inner_l3_offset +=

[dpdk-dev] [PATCH v6 7/8] rte_mbuf.h: add and subtract explicitly to avoid promotion

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h: In function 'rte_pktmbuf_prepend': /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: 1908:17: warning: conversion from 'int' to 'uint16_t' {aka 'short unsigned int'} may change value [-Wconversion] m->data_off -= len;

[dpdk-dev] [PATCH v6 6/8] rte_mbuf.h: choose correct type for temp

2018-05-20 Thread Andy Green
/projects/lagopus/src/dpdk/build/include/rte_mbuf.h: In function 'rte_pktmbuf_linearize': /projects/lagopus/src/dpdk/build/include/rte_mbuf.h: 1873:32: warning: conversion to 'int' from 'uint32_t' {aka 'unsigned int'} may change the sign of the result [-Wsign-conversion] #define rte_pktmbuf_pkt_len

Re: [dpdk-dev] [PATCH v5 00/21] Fixes for GCC8 against lagopus

2018-05-20 Thread Andy Green
On 05/21/2018 06:18 AM, Thomas Monjalon wrote: Andy Green (21): lib/librte_ethdev: change eth-dev-ops API to return int rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy lib/librte_eal: explicit tmp cast /lib/librte_eal: stage cast from uint64 to long

Re: [dpdk-dev] [PATCH] net/i40e: add a specific API to control the LLDP agent

2018-05-20 Thread Zijie Pan
> > Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e. > > It supports the following i40e debug lldp commands: > > - start/stop of the LLDP agent. > > - get local/remote of the LLDP MIB (Management Information Base). > > > > Signed-off-by: Laurent Hardy > > Signed-off-

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid count in xstats

2018-05-20 Thread Nélio Laranjeiro
On Sun, May 20, 2018 at 10:13:58AM +0200, David Marchand wrote: > With the commit af4f09f28294 ("net/mlx5: prefix all functions with mlx5"), > mlx5_xstats_get() is not compliant any longer with the api. > It always returns the caller max entries count while it should return how > many entries it wr

Re: [dpdk-dev] [PATCH v5 01/21] lib/librte_ethdev: change eth-dev-ops API to return int

2018-05-20 Thread Stephen Hemminger
On Sun, 20 May 2018 02:43:58 + Shreyansh Jain wrote: > > > This doesn't feel correct. A counter, especially the number of > > descriptors in a queue, doesn't have a negative value. So, 1) this is > > an unnatural return and 2) we litter the code with unnecessary > > typecast. > > > > > >

Re: [dpdk-dev] [PATCH 1/3] net liquidio fix Unable to update lio_dev->linfo.link var

2018-05-20 Thread Stephen Hemminger
On Mon, 21 May 2018 09:20:53 +0800 yaochuhong wrote: > Signed-off-by: yaochuhong > --- > drivers/net/liquidio/lio_ethdev.c | 6 ++ > 1 file changed, 6 insertions(+) > mode change 100644 => 100755 drivers/net/liquidio/lio_ethdev.c > > diff --git a/drivers/net/liquidio/lio_ethdev.c > b/dri