[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/649 Cloudstack 8656: do away with silently ignoring exceptions You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOU

LGTMs or review critic please

I have some trivial changes that deal with ignored exceptions and resource leaks and such, Can I have some feedback on https://github.com/apache/cloudstack/pull/649 https://github.com/apache/cloudstack/pull/604 https://github.com/apache/cloudstack/pull/603 -- Daan

[DISCUSS][PROPOSAL] cleanup repo

As we are changing our review process I want to clean up the repository at apache getting rid of stale branches. Of course the release branches of old releases should stay, but a lot of old branches have been merged at unknown places in the master or old release branches. I want to propose to delet

Re: [DISCUSS][PROPOSAL] cleanup repo

On 08/02/2015 03:46 PM, Daan Hoogland wrote: > As we are changing our review process I want to clean up the > repository at apache getting rid of stale branches. Of course the > release branches of old releases should stay, but a lot of old > branches have been merged at unknown places in the mas

Re: [DISCUSS][PROPOSAL] cleanup repo

+1 On Sunday, August 2, 2015, Daan Hoogland wrote: > As we are changing our review process I want to clean up the > repository at apache getting rid of stale branches. Of course the > release branches of old releases should stay, but a lot of old > branches have been merged at unknown places in

unit tests in eclipse

H, Since shortly I can not run unit tests in eclipse anymore. has anybody seen this: java.lang.NoClassDefFoundError: org/junit/runner/notification/StoppedByUserException at org.eclipse.jdt.internal.junit4.runner.JUnit4TestLoader.createTest(JUnit4TestLoader.java:48) at org.eclipse.jdt.in

Re: unit tests in eclipse

Guess I had a mixed workspace luna/mars. forget everything but the brocade build failure. On Sun, Aug 2, 2015 at 10:15 PM, Daan Hoogland wrote: > I have removed ~/.m2/repository and rebuild to no avail. The brocade > vcs doesn't build either. > > any hints? > > thanks > -- > Daan -- Daan

Re: [DISCUSS][PROPOSAL] cleanup repo

+1 Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On August 2, 2015 at 5:17 PM Wido den Hollander wrote: > > > > > On 08/02/2015 03:46 PM, Daan Hoogland wrote: > > As we are changing our review process I want to clean up the > > repository at

[GitHub] cloudstack pull request: Cloudstack 8656: do away with silently ig...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/649#issuecomment-127112655 Aside from a few comments on 04e9083c3199effa295e47bc617b9b406adb6109, LGTM. --- If your project is set up for it, you can reply to this email and have your r

Re: [DISCUSS][PROPOSAL] cleanup repo

+1 Agree. We have more than 200 branches. ~Rajani On Mon, Aug 3, 2015 at 4:39 AM, Boris Schrijver wrote: > +1 > > > Best regards, > > Boris Schrijver > > TEL: +31633784542 > MAIL: bo...@pcextreme.nl > > > > > On August 2, 2015 at 5:17 PM Wido den Hollander > wrote: > > > > > > > > > >

[GitHub] cloudstack pull request: CLOUDSTACK-8640: Revert to AWS SDK 1.3.22

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/647#issuecomment-127128369 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request: CLOUDSTACK-8686:Verify data disk attachme...

Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/631#discussion_r36058447 --- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py --- @@ -0,0 +1,209 @@ +# Licensed to the Apache Software Foundation (ASF) under