[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

2023-04-28 Thread Simon Butcher via Phabricator via cfe-commits
simonbutcher added a comment. I can't see anything wrong with this patch and it looks pretty straightforward to me, but is it necessary? '-Wtypedef-redefinition' is documented as not applying to system headers

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

2023-05-02 Thread Simon Butcher via Phabricator via cfe-commits
simonbutcher accepted this revision. simonbutcher added a comment. > we definitely use -Wsystem-headers. Fair enough, that hadn't occurred to me. The change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148822/new/ https://reviews.llvm.org/D