[PATCH] D68410: [AttrDocs] document always_inline

2019-10-03 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added a comment. Note that the latest GCC docs (rather than 4.1.2) are at: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html For reference, this was triggered from: https://lore.kernel.org/lkml/cakwvodm_gouedjayxtqctuvdl+9vwvfeofhv06mlmyva75c...@mail.gmail.com/ Reposito

[PATCH] D68410: [AttrDocs] document always_inline

2020-12-06 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5498 + +See also `the MSDN Inline docs`_, `the GCC Common Function Attribute docs`_, +and `the GCC Inline docs`_. MSDN is gone now, Microsoft Docs is the new one. Repository: rG LL

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

2021-05-26 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) melver wrote: > aaron.ballman

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

2021-05-26 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added inline comments. Comment at: clang/include/clang/Basic/Features.def:52 LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(coverage_sanitizer, LangOpts.SanitizeCoverage) FEATURE(assume_nonnull, true) melver wrote: > ojeda wrote: >

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

2022-09-29 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added a comment. Thanks Nick for the ping. Indeed, `rustc` allows to use a "target specification file" to create new targets that are not built-in, as a JSON file. They are unstable though, since they are fairly tied to LLVM, and I think the Rust compiler team prefers to stabilize flags i

[PATCH] D139395: Add support for integer types normalization

2022-12-06 Thread Miguel Ojeda via Phabricator via cfe-commits
ojeda added subscribers: nathanchance, nickdesaulniers. ojeda added a comment. Cc @nickdesaulniers @nathanchance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 ___