Hi, I filed the bug (https://llvm.org/bugs/show_bug.cgi?id=26283) some
time ago and nobody picked it up, so here is a trivial patch exposing
the missing macros, that to the best of my ability were already
present as the internal underscored versions.
Perhaps a more general bug about C11 floating p
s a __LDBL_DECIMAL_DIG__ predefined macro. __DECIMAL_DIG__ will not
> always be the same as __LDBL_DECIMAL_DIG__.
>
> -- HT
>
> On Mon, Feb 8, 2016 at 11:26 PM, Jorge Teixeira via cfe-commits
> wrote:
>>
>> Hi, I filed the bug (https://llvm.org/bugs/show_bug.cgi?id=26283) some
>> ti
gt; JT
>>>
>>> On Tue, Feb 9, 2016 at 1:41 PM, Hubert Tong
>>> wrote:
>>> > There is a __LDBL_DECIMAL_DIG__ predefined macro. __DECIMAL_DIG__ will
>>> > not
>>> > always be the same as __LDBL_DECIMAL_DIG__.
>>> >
>>> >
not noticed it when I was testing because on my arch
>>>>> DECIMAL_DIG is defined to be the LDBL version...
>>>>>
>>>>> Updated patch is attached.
>>>>>
>>>>> JT
>>>>>
>>>>> On Tue, Feb 9, 2016 at 1:41 P
e usual
>>>>>> reviewers for this part of the code base.
>>>>>>
>>>>>> -- HT
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 9, 2016 at 2:56 PM, Jorge Teixeira
>>>>>>
>>>>>>
at __LDBL_DECIMAL_DIG__ is
>>>>> the right value, so you could test the values are correct by checking
>>>>> that LDBL_DECIMAL_DIG == __LDBL_DECIMAL_DIG__.
>>>>>
>>>>>> JT
>>>>>>
>>>>>&g
;>> are
>> >>>>>> guaranteed to be correct, etc. This is probably not possible / does
>> >>>>>> not make sense.
>> >>>>>
>> >>>>> That looks like a decent basic test for this. The test should be
>> >>>>> n
>> >>>> wrote:
>>> >> >>>>> On Tue, Feb 9, 2016 at 2:43 PM, Jorge Teixeira
>>> >> >>>>> wrote:
>>> >> >>>>>> Richard,
>>> >> >>>>>>
>>&
; >> >>>> and exposed versions of the macros.
>> >>> >> >>>> No attempt was made to support C99 or C89.
>> >>> >> >>>>
>> >>> >> >>>> I am not very clear on the proper use of the wh
>>> >> >>>> instead
>> >> >>> >> >>>> of float.c because I am only checking a subset of what the
>> >> >>> >> >>>> standard
>> >> >>> >> >>>> mandates
should 1) use soft float
>>> >> >> >>> >> >> (bad
>>> >> >> >>> >> >> idea),
>>> >> >> >>> >> >> 2)
>>> >> >> >>> >> >> issue a diagnostic saying that that arch cann
11 matches
Mail list logo
