[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/112887 This patch should not introduce much overhead as it only does one more constraint map lookup, which is really quick. Depends on #112583 >From e380dd4572c8914fbd87a812e74addba1f24304d Mon Sep 17 00:00:00 2001

[clang] [Clang] [PGO] Provide default value for -fprofile-sample-use (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog updated https://github.com/llvm/llvm-project/pull/112750 From 642f7ac9b1e999d8adb690b67c6303139794379d Mon Sep 17 00:00:00 2001 From: "Pirog, Mikolaj Maciej" Date: Thu, 17 Oct 2024 10:17:09 -0700 Subject: [PATCH 1/2] Provide default value for -fprofile-sample-us

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog edited https://github.com/llvm/llvm-project/pull/112750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-18 Thread Richard Smith via cfe-commits
zygoloid wrote: > How about: > [...] Yeah, I think that fixes it. For me that looks a lot less simple than using a union, but it is nice to have only a single implementation. I'd be fine with going in that direction. For CHERI, can we assume that the least-significant byte of the pointer rep

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog updated https://github.com/llvm/llvm-project/pull/112750 From 642f7ac9b1e999d8adb690b67c6303139794379d Mon Sep 17 00:00:00 2001 From: "Pirog, Mikolaj Maciej" Date: Thu, 17 Oct 2024 10:17:09 -0700 Subject: [PATCH 1/3] Provide default value for -fprofile-sample-us

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-18 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/112747 >From c2f223d84c18498f3cbe1582b006b0d4c52999aa Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Thu, 17 Oct 2024 14:04:05 +0100 Subject: [PATCH 1/3] [Clang][AArch64] Fix Pure Scalables Types argument

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-18 Thread Momchil Velikov via cfe-commits
@@ -533,11 +638,158 @@ bool AArch64ABIInfo::isZeroLengthBitfieldPermittedInHomogeneousAggregate() return true; } +// Check if a type is a Pure Scalable Type as defined by AAPCS64. Return the +// number of data vectors and the number of predicate vectors in the types, into

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112424 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH 1/2] [Clang] prevent setting default lexical access specifier f

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112612 >From 6112d12f757cce0214132e9201dc2a434e40e0c7 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 16 Oct 2024 23:42:05 +0300 Subject: [PATCH 1/2] [Clang] prevent assertion failure in value-dependent initi

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/111561 >From dd1095566251508aae4009a626774413eb8dc7a1 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 8 Oct 2024 12:54:26 -0400 Subject: [PATCH 1/3] [Clang][Sema] Fix exception specification comparison

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-18 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > > How about: > > [...] > > Yeah, I think that fixes it. For me that looks a lot less simple than using a > union, but it is nice to have only a single implementation. I'd be fine with > going in that direction. > > For CHERI, can we assume that the least-significant byte of th

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: This seems to have broken precommit CI on Windows: https://buildkite.com/llvm-project/github-pull-requests/builds/65#0192a01b-d3ac-44ad-abff-e53ac4a206ab all of the failures look related to line endings, and I noticed that I got a ton of command line messages of the for

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-18 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 3c8255f30f7548cfb86858d980cc3e1524b3607f Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [NFC] clang add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112820 >From 53683a8543bb6a558a778dc1cc15adb3180df7e4 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:23:19 +0200 Subject: [PATCH 1/4] [NFC] clang add DiagnosticsTestHelper decl MIME-Version: 1.0 Conten

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 reopened https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] clang add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
@@ -1024,6 +1024,9 @@ class DiagnosticsEngine : public RefCountedBase { /// @} }; +/// Declare the friend function for testing to avoid GCC warning. jsji wrote: Sure. https://github.com/llvm/llvm-project/pull/112820 ___

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: Yes, I think that would be a better solution, I will try to get to that when I have time,

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/112820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Extract device archives if symbol is used on the host (PR #111921)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Accidentally deleted this branch and forgot to reopen this. Tests will fail until https://github.com/llvm/llvm-project/pull/111890 lands. https://github.com/llvm/llvm-project/pull/111921 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/112820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix an assertion in expression recovery (PR #112888)

2024-10-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/7768 Here is the relevant piece of the build log for

[clang] [analyzer] Improve solver (PR #112583)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/112583 >From dfb86a3ddad88a9a97fff054af1bf86d746ee49d Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 16 Oct 2024 15:52:31 +0200 Subject: [PATCH] [analyzer][Solver] Improve getSymVal and friends (1/2) Instead

[clang] [analyzer] Improve solver (PR #112583)

2024-10-18 Thread Balazs Benics via cfe-commits
@@ -50,31 +50,10 @@ void test2() { b = d; a -= d; - if (a != 0) -return; - - clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}} + clang_analyzer_warnIfReached(); // expected-warning {{REACHABLE}} - /* The BASELINE passes these checks ('wrning' is us

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Nested lambdas could refer to outer packs that would be expanded by a larger CXXFoldExpr, in which case that reference could happen to be a full expression containing intermediate types/expressions, e.g. Su

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/112896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix an assertion in expression recovery (PR #112888)

2024-10-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/112888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/112896 Nested lambdas could refer to outer packs that would be expanded by a larger CXXFoldExpr, in which case that reference could happen to be a full expression containing intermediate types/expressions, e.g. Subst

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, thanks! I blame my editor's dictionary 😂 https://github.com/llvm/llvm-project/pull/112899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog ready_for_review https://github.com/llvm/llvm-project/pull/112750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6a623e8 - [NFC] add DiagnosticsTestHelper decl (#112820)

2024-10-18 Thread via cfe-commits
Author: Jinsong Ji Date: 2024-10-18T12:53:59-04:00 New Revision: 6a623e8484fe713d7074acb7ceab520458bfa89c URL: https://github.com/llvm/llvm-project/commit/6a623e8484fe713d7074acb7ceab520458bfa89c DIFF: https://github.com/llvm/llvm-project/commit/6a623e8484fe713d7074acb7ceab520458bfa89c.diff LO

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-18 Thread Eli Friedman via cfe-commits
@@ -353,6 +427,17 @@ AArch64ABIInfo::classifyArgumentType(QualType Ty, bool IsVariadic, nullptr, true, Align); } + // In AAPCS named arguments of a Pure Scalable Type are passed expanded in + // registers, or indirectly if there are not enough registers. + if (Ki

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-10-18 Thread Aaron Ballman via cfe-commits
@@ -13,246 +13,40 @@ #include "IncrementalParser.h" #include "clang/AST/DeclContextInternals.h" -#include "clang/CodeGen/BackendUtil.h" -#include "clang/CodeGen/CodeGenAction.h" -#include "clang/CodeGen/ModuleBuilder.h" #include "clang/Frontend/CompilerInstance.h" -#include "

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-10-18 Thread Vassil Vassilev via cfe-commits
@@ -13,246 +13,40 @@ #include "IncrementalParser.h" #include "clang/AST/DeclContextInternals.h" -#include "clang/CodeGen/BackendUtil.h" -#include "clang/CodeGen/CodeGenAction.h" -#include "clang/CodeGen/ModuleBuilder.h" #include "clang/Frontend/CompilerInstance.h" -#include "

[clang] Remove type-punning in LazyOffsetPtr. (PR #112806)

2024-10-18 Thread Richard Smith via cfe-commits
https://github.com/zygoloid closed https://github.com/llvm/llvm-project/pull/112806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove type-punning in LazyOffsetPtr. (PR #112806)

2024-10-18 Thread Richard Smith via cfe-commits
zygoloid wrote: Closing in favour of #112927. https://github.com/llvm/llvm-project/pull/112806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/111561 >From 8fe948147c63311600994a0d846a3ad0bce95f2a Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 8 Oct 2024 12:54:26 -0400 Subject: [PATCH 1/4] [Clang][Sema] Fix exception specification comparison

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-18 Thread Momchil Velikov via cfe-commits
@@ -533,11 +638,158 @@ bool AArch64ABIInfo::isZeroLengthBitfieldPermittedInHomogeneousAggregate() return true; } +// Check if a type is a Pure Scalable Type as defined by AAPCS64. Return the +// number of data vectors and the number of predicate vectors in the types, into

[clang] [llvm] [RISCV][ISel] Ensure 'in X' Constraints prevent X0 (PR #112563)

2024-10-18 Thread Sam Elliott via cfe-commits
lenary wrote: Yeah, I went back and looked at that issue, it's helpful to know that it was more than just the register allocator, that it was also copy propagation, which wasn't obvious from the comments. The failing tests are not related, but presumably caused by the rebase, but I'll still

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread via cfe-commits
ernsteiswuerfel wrote: I can confirm it fixes issue [#86460](https://github.com/llvm/llvm-project/issues/86460) for me just as awilfox original PR. https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[libunwind] [libunwind][AIX] Call dlclose only when dlsym() fails (PR #112768)

2024-10-18 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast approved this pull request. LGTM; thanks! https://github.com/llvm/llvm-project/pull/112768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] CXXRecords in anony namespace from diff TUs shouldn't be equivalent (PR #112534)

2024-10-18 Thread Ding Fei via cfe-commits
danix800 wrote: > The fix looks acceptable, but a test is needed. The test code in the bug > report can be used somehow in at the AST merge LIT tests or in the > `ASTImporterTest`. Thanks for reviewing. There's one more other similar crash (with this fix) and I'm still reducing the testcase.

[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/112887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 67e8421 - [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (#112887)

2024-10-18 Thread via cfe-commits
Author: Balazs Benics Date: 2024-10-18T16:15:33+02:00 New Revision: 67e84213f59e1f9485d15421bdb7243d25cee07e URL: https://github.com/llvm/llvm-project/commit/67e84213f59e1f9485d15421bdb7243d25cee07e DIFF: https://github.com/llvm/llvm-project/commit/67e84213f59e1f9485d15421bdb7243d25cee07e.diff

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread via cfe-commits
ldrumm wrote: There are a couple of things to unpack here > a number of test input files need to be in LF form to work Which ones? Either there's a bug in a parser somewhere, or I missed some test files. In either case I'd like to fix the issue. I watched the buildbots quite closely last nigh

[clang] [analyzer][Solver][NFC] Cleanup const-correctness inside range-based solver (PR #112891)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/112891 >From 6b1702b1ea58e5fa4566069345d277e081cd1165 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 18 Oct 2024 14:12:46 +0200 Subject: [PATCH] [analyzer][Solver][NFC] Cleanup const-correctness inside range

[clang] [analyzer][Solver][NFC] Cleanup const-correctness inside range-based solver (PR #112891)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/112891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1b49ee7 - [analyzer][Solver][NFC] Cleanup const-correctness inside range-based solver (#112891)

2024-10-18 Thread via cfe-commits
Author: Balazs Benics Date: 2024-10-18T16:16:29+02:00 New Revision: 1b49ee73fc3512551066cd3c6b969fad589c9d5e URL: https://github.com/llvm/llvm-project/commit/1b49ee73fc3512551066cd3c6b969fad589c9d5e DIFF: https://github.com/llvm/llvm-project/commit/1b49ee73fc3512551066cd3c6b969fad589c9d5e.diff

[clang] [clang][AST] CXXRecords in anony namespace from diff TUs shouldn't be equivalent (PR #112534)

2024-10-18 Thread Ding Fei via cfe-commits
https://github.com/danix800 converted_to_draft https://github.com/llvm/llvm-project/pull/112534 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Index][USR][NFC] Allow customizing langopts for USR generation (PR #109574)

2024-10-18 Thread Balazs Benics via cfe-commits
steakhal wrote: Ping @AaronBallman https://github.com/llvm/llvm-project/pull/109574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Solver][NFC] Cleanup const-correctness inside range-based solver (PR #112891)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112891.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp (+45-31) - (modified) clang/test/Analysis/un

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-18 Thread Oleksandr T. via cfe-commits
@@ -517,6 +517,7 @@ Bug Fixes to C++ Support certain situations. (#GH47400), (#GH90896) - Fix erroneous templated array size calculation leading to crashes in generated code. (#GH41441) - During the lookup for a base class name, non-type names are ignored. (#GH16855) +- Fix

[clang] [llvm] [RISCV][ISel] Ensure 'in X' Constraints prevent X0 (PR #112563)

2024-10-18 Thread Sam Elliott via cfe-commits
https://github.com/lenary updated https://github.com/llvm/llvm-project/pull/112563 >From bbf0b885dc5912d4dc29abcec5fe7cee7cfd1758 Mon Sep 17 00:00:00 2001 From: Sam Elliott Date: Wed, 16 Oct 2024 05:04:45 -0700 Subject: [PATCH 1/2] [RISCV] Inline Assembly: RVC constraint and N modifier This ch

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: We need this header because we are using the function enablezOSAutoConversion below in thi

[clang] [clang][AVR] Fix basic type size/alignment values to match avr-gcc. (PR #111290)

2024-10-18 Thread Patryk Wychowaniec via cfe-commits
https://github.com/Patryk27 approved this pull request. Looks good to me as well! https://github.com/llvm/llvm-project/pull/111290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. Can't believe this many Lol https://github.com/llvm/llvm-project/pull/112899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Jinsong Ji via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" jsji wrote: This is a c++ header, if we really need it, then we need to update it to c. @abhina-sree Can you

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/112899 None >From 3a3b67f30cde766adaede4cc53bec340fbe5d99f Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Fri, 18 Oct 2024 13:53:51 +0100 Subject: [PATCH] Fix typo "instrinsic" --- clang/utils/TableGen/RISCVVEmitter.

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-systemz Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/112899.diff 19 Files Affected: - (modified) clang/utils/TableGen/RISCVVEmitter.cpp (+2-2) - (modified) flang/docs/OptionComparison.md (+1-1)

[clang] Remove type-punning in LazyOffsetPtr. (PR #112806)

2024-10-18 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 edited https://github.com/llvm/llvm-project/pull/112806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-18 Thread via cfe-commits
@@ -3150,8 +3150,8 @@ Parser::DeclGroupPtrTy Parser::ParseCXXClassMemberDeclaration( if (Tok.is(tok::kw_concept)) { Diag(Tok.getLocation(), DS.isFriendSpecified() || NextToken().is(tok::kw_friend) - ? diag::err_friend_concept - : diag:: +

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/112896 >From 6caf16d6ce8eb939c91ed87493c2ccab82d38411 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 18 Oct 2024 20:22:08 +0800 Subject: [PATCH 1/2] [Clang] Don't assert on substituted-but-yet-expanded packs f

[clang] [Clang] Fix handling of immediate escalation for inherited constructors (PR #112860)

2024-10-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/112860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes This patch should not introduce much overhead as it only does one more constraint map lookup, which is really quick. Depends on #112583 --- Full diff: https://github.com/llvm/llvm-project/pull/112887.diff

[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes This patch should not introduce much overhead as it only does one more constraint map lookup, which is really quick. Depends on #112583 --- Full diff: https://github.com/llvm/llvm-projec

[clang] [llvm] [Clang] Put offloading globals in the `.llvm.rodata.offloading` section (PR #111890)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Would there be any reason to put entries for different offloading languages > into distinctly named “sub entries”? Not really, this is just a list of all the device-side symbols the host might want, that would make it more difficult to later extract. Also ping. https://githu

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello updated https://github.com/llvm/llvm-project/pull/112767 >From 20f602b8c28d966a7cc957a3ca4c6ed43e71258e Mon Sep 17 00:00:00 2001 From: "Daniel Paoliello (HE/HIM)" Date: Thu, 17 Oct 2024 12:21:25 -0700 Subject: [PATCH 1/3] Fix build break in SemaHLSL.cpp on MSVC 202

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) Changes This is one of the many PRs to fix errors with LLVM_ENABLE_WERROR=on. Built by GCC 11. Fix warning In destructor ‘llvm::APInt::~APInt()’, inlined from ‘llvm::APInt::~APInt()’ at llvm-project/llvm/include/ll

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -489,6 +542,9 @@ class OpLowerer { case Intrinsic::dx_typedBufferStore: HasErrors |= lowerTypedBufferStore(F); break; + case Intrinsic::dx_splitdouble: farzonl wrote: `replaceFunctionWithNamedStructOp` seems like the right way to

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/112025 >From a02a27171801ad3f5618099b5035ef8185c2f835 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 11 Oct 2024 12:21:49 -0500 Subject: [PATCH 1/3] [Clang] Add a flag to include GPU startup files Summary: The

[clang] [llvm] [NVPTX] Remove nvvm.ldg.global.* intrinsics (PR #112834)

2024-10-18 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM. Please add a note about the intrinsic removal/deprecation to the release notes. https://github.com/llvm/llvm-project/pull/112834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (c8ef) Changes According to [P0533R9](https://wg21.link/P0533R9), the C++ standard library functions `fma` are now `constexpr`: ```c++ constexpr floating-point-type fma(floating-point-type x, floating-point-type y,

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-18 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-18 Thread via cfe-commits
https://github.com/c8ef ready_for_review https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-18 Thread via cfe-commits
c8ef wrote: I'm not sure why there are noises in the Windows CI, as they seem unrelated. The Linux CI is working as expected. https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-18 Thread Shafik Yaghmour via cfe-commits
@@ -11536,6 +11536,9 @@ bool ArrayExprEvaluator::VisitCXXParenListOrInitListExpr( LValue Subobject = This; Subobject.addArray(Info, ExprToVisit, CAT); auto Eval = [&](const Expr *Init, unsigned ArrayIndex) { +if (Init->isValueDependent()) shafik wrot

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2024-10-18 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann updated https://github.com/llvm/llvm-project/pull/105738 >From b775b7288035d83281434e27341b98a76623802f Mon Sep 17 00:00:00 2001 From: Tom Honermann Date: Thu, 22 Aug 2024 09:44:56 -0700 Subject: [PATCH 1/3] [Clang] Match MSVC handling of duplicate header search

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-18 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik requested changes to this pull request. https://github.com/llvm/llvm-project/pull/112612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-18 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/113020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp commented: LGTM. Would be good to get review from someone more familiar with ASTs and external sema source. https://github.com/llvm/llvm-project/pull/112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-18 Thread Jonathan Thackray via cfe-commits
@@ -1331,7 +1331,10 @@ TEST(TargetParserTest, AArch64ExtensionFeatures) { AArch64::AEK_SVE_F16F32MM, AArch64::AEK_SVE_AES2, AArch64::AEK_SSVE_AES, AArch64::AEK_F8F32MM, AArch64::AEK_F8F16MM, AArch64::AEK_LSFE, - AArch64::AEK_FPRCVT, AArch64

[clang] f7b6dc8 - [Clang] Fix missing `-` in argument to nvlinker

2024-10-18 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-10-18T19:16:42-05:00 New Revision: f7b6dc821ad2aa02e027db76f193b85a87443e0b URL: https://github.com/llvm/llvm-project/commit/f7b6dc821ad2aa02e027db76f193b85a87443e0b DIFF: https://github.com/llvm/llvm-project/commit/f7b6dc821ad2aa02e027db76f193b85a87443e0b.diff

[clang] [llvm] [RISCV] Inline Assembly Support for GPR Pairs ('Pr') (PR #112983)

2024-10-18 Thread Sam Elliott via cfe-commits
lenary wrote: > I'm concerned that if we make i128 legal, we will have to write custom > splitting code for every operation. Using v2i64 probably has other problems > conflicting with the V extension fixed vector support. I sort-of expected that making `i128` legal would be problematic, I did

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -18952,6 +18955,142 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { tex3d wrote: This is quite a

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -18952,6 +18955,142 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -4871,6 +4871,12 @@ def HLSLRadians : LangBuiltin<"HLSL_LANG"> { let Prototype = "void(...)"; } +def HLSLSplitDouble: LangBuiltin<"HLSL_LANG"> { + let Spellings = ["__builtin_hlsl_splitdouble"]; tex3d wrote: Are we inconsistent on the use of "elementwis

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -4681,6 +4601,87 @@ void CallArg::copyInto(CodeGenFunction &CGF, Address Addr) const { IsUsed = true; } +/// Emit the actual writing-back of a writeback. +void CodeGenFunction::EmitWriteback(CodeGenFunction &CGF, tex3d wrote: Moving this function makes

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -5149,6 +5152,12 @@ class CodeGenFunction : public CodeGenTypeCache { SourceLocation ArgLoc, AbstractCallee AC, unsigned ParmNum); + /// EmitWriteback - Emit callbacks for function. + void EmitWritebacks(CodeGenFunctio

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -2074,6 +2083,35 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_splitdouble: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +Expr *Op0 = TheCall

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -18952,6 +18955,142 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -438,6 +438,24 @@ template constexpr uint asuint(T F) { return __detail::bit_cast(F); } +//===--===// +// asuint splitdouble builtins +//===---

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Joshua Batista via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/2] [Clang] fix range calculation for conditionals with throw

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 reopened https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112424 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH 1/2] [Clang] prevent setting default lexical access specifier f

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveMax` intrinsic (PR #112991)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6d13cc9411b998aabf1a55e0813236ba7a278929 b18e40978cae2c0d9ba9aeb61cf7294809b75012 --e

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/112600 >From 0739f6da81d7c1edd9578ae4ff9dd699e5c828c6 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Thu, 10 Oct 2024 14:31:25 -0700 Subject: [PATCH 01/14] ConceptSpecializationExpr shows up in AST!!! --- .../c

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Finn Plummer (inbelic) Changes ``` - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBui

[clang] [llvm] [RISCV] Inline Assembly Support for GPR Pairs ('Pr') (PR #112983)

2024-10-18 Thread Craig Topper via cfe-commits
topperc wrote: Is the plan to make i128 a legal type for RV64? https://github.com/llvm/llvm-project/pull/112983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/2] [Clang] fix range calculation for conditionals with throw

  1   2   3   4   5   >