[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -3,12 +3,18 @@ /// 4.7 enables cfg_checksum. /// 4.8 (default, compatible with gcov 7) emits the exit block the second. // RUN: rm -rf %t && mkdir %t && cd %t -// RUN: %clang_cc1 -emit-llvm -disable-red-zone -coverage-data-file=/dev/null -coverage-version='304*' %s -o - | \

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/110487 >From 375a71d114fffb94c16455f476364a7de9e08191 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Mon, 30 Sep 2024 03:41:15 -0700 Subject: [PATCH 1/3] [Clang][CodeGen] Emit load of value We were missing a loa

[clang] [clang-shlib] Add symbol versioning to all symbols (PR #110758)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes We do the same thing for libLLVM.so. This should help avoid issues when an applications loads two different versions of the library at the same time. --- Full diff: https://github.com/llvm/llvm-project/pul

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
francisvm wrote: I totally agree with you @tex3d, I wish we could add these constraints somewhere in `Builtins.td` in a more structured way. The diagnostic change was not unintentional, I just assumed we'd fix the one argument builtins in a separate commit from this one (aimed at two args). h

[clang] 1202c24 - [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (#110780)

2024-10-01 Thread via cfe-commits
Author: Volodymyr Sapsai Date: 2024-10-01T21:47:52-07:00 New Revision: 1202c24b0d128c4838252daeeb1268707da69507 URL: https://github.com/llvm/llvm-project/commit/1202c24b0d128c4838252daeeb1268707da69507 DIFF: https://github.com/llvm/llvm-project/commit/1202c24b0d128c4838252daeeb1268707da69507.di

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai closed https://github.com/llvm/llvm-project/pull/110780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] Mark CFProtectionOptions.def as a textual header because it is used for x-macro purposes. (PR #110780)

2024-10-01 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: CI error ``` Traceback (most recent call last): File "/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-r8xzr-1/llvm-project/github-pull-requests/libcxx/utils/generate_iwyu_mapping.py", line 92, in main(sys.argv[1:]) File "/var/lib/buildkite-agent/builds/linux-56-59b8f

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-01 Thread Florian Albrechtskirchinger via cfe-commits
https://github.com/falbrechtskirchinger updated https://github.com/llvm/llvm-project/pull/110496 >From 220d76a2b2327318a6b5261896736ddd3f05988a Mon Sep 17 00:00:00 2001 From: Florian Albrechtskirchinger Date: Mon, 30 Sep 2024 12:58:15 +0200 Subject: [PATCH] [Serialization] Handle uninitialized

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/109837 >From 07a2cab3fa5df2965f9f7da9ee2d3603581a47f1 Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 22 Sep 2024 20:23:20 -0700 Subject: [PATCH 1/2] [InstrPGO] Instrument sampling profile based cold function --- c

[clang] bb8b9ac - [Utils] Add new --update-tests flag to llvm-lit (#108425)

2024-10-01 Thread via cfe-commits
Author: Henrik G. Olsson Date: 2024-10-01T15:57:10-07:00 New Revision: bb8b9ac0ba5382bcf02f614b5b3a84c3699cf52c URL: https://github.com/llvm/llvm-project/commit/bb8b9ac0ba5382bcf02f614b5b3a84c3699cf52c DIFF: https://github.com/llvm/llvm-project/commit/bb8b9ac0ba5382bcf02f614b5b3a84c3699cf52c.di

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
@@ -0,0 +1,24 @@ +; RUN: opt < %s --passes=pgo-instr-gen -instrument-cold-function-coverage -S | FileCheck --check-prefixes=COLD %s +; RUN: opt < %s --passes=pgo-instr-gen -instrument-cold-function-coverage -cold-function-coverage-max-entry-count=1 -S | FileCheck --check-pr

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/110772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn created https://github.com/llvm/llvm-project/pull/110772 Reverts llvm/llvm-project#108425 >From 133d368b16d11e44bc3fca92a042cf5ad0ce8dd1 Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Tue, 1 Oct 2024 17:14:31 -0700 Subject: [PATCH] Revert "[Utils] Add new -

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-10-01 Thread via cfe-commits
zeroomega wrote: > Thanks for the analysis. Per-target runtime dir strikes again! That setting > keeps on creating issues (by no fault of its own) because it's not the > default. > > Can we do something like this instead, then? > > ``` > config.substitutions.append(('%{lib}', > '@LIBUNWIND_T

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: Thank you so much for your quick review! However, it seems the current CI is blocked by the issues mentioned in #110783 :( https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/5] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Thank you so much for your quick review! However, it seems the current CI is > blocked by the issues mentioned in #110783 :( I wouldn't be worried about that for a simple change like this, you can go ahead and merge. https://github.com/llvm/llvm-project/pull/110773 _

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: Thanks! 🥰 https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
@@ -9519,15 +9519,28 @@ Sema::ActOnStartRequiresExpr(SourceLocation RequiresKWLoc, } else if (Param->getType().hasQualifiers()) { Diag(Param->getBeginLoc(), diag::err_void_param_qualified); } -} - -if (Param->hasDefaultArg()) +} else if (Param->

[clang] 679be52 - [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (#110773)

2024-10-01 Thread via cfe-commits
Author: c8ef Date: 2024-10-02T12:01:31+08:00 New Revision: 679be527095ea60d5933b883ca276d8e593920ee URL: https://github.com/llvm/llvm-project/commit/679be527095ea60d5933b883ca276d8e593920ee DIFF: https://github.com/llvm/llvm-project/commit/679be527095ea60d5933b883ca276d8e593920ee.diff LOG: [Cl

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-01 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: This example from the failing test should warn I think: ```c++ class Foo { public: void foo1(); void foo2(); void foo3(Foo

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
@@ -9519,15 +9519,28 @@ Sema::ActOnStartRequiresExpr(SourceLocation RequiresKWLoc, } else if (Param->getType().hasQualifiers()) { Diag(Param->getBeginLoc(), diag::err_void_param_qualified); } -} - -if (Param->hasDefaultArg()) +} else if (Param->

[clang] [llvm] [Utils] Add new --update-tests flag to llvm-lit (PR #108425)

2024-10-01 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn closed https://github.com/llvm/llvm-project/pull/108425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: Interesting. You compiled with `-O2`, I compiled without optimization. When I compile it with `-O2`, I now get `0`. I've uploaded a gist with the disassembly generated with ``` clang -mllvm --x86-asm-syntax=intel -S test.c -o ./test-no-optimize.S ``` and ``` clang -O2 -mllvm --x86-

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Mircea Trofin via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, mtrofin wrote: I meant, why not jus

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Mircea Trofin via cfe-commits
https://github.com/mtrofin edited https://github.com/llvm/llvm-project/pull/109837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e495231 - Revert "[Utils] Add new --update-tests flag to llvm-lit" (#110772)

2024-10-01 Thread via cfe-commits
Author: Henrik G. Olsson Date: 2024-10-01T17:14:50-07:00 New Revision: e495231238b86ae2a3c7bb5f94634c19ca2af19a URL: https://github.com/llvm/llvm-project/commit/e495231238b86ae2a3c7bb5f94634c19ca2af19a DIFF: https://github.com/llvm/llvm-project/commit/e495231238b86ae2a3c7bb5f94634c19ca2af19a.di

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM overall; I just have some minor comments https://github.com/llvm/llvm-project/pull/109994 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: @bwendling I think you accidentally compiled the wrong branch. Looks like that is in `builtin_get_counted_by`, but this PR is in `bdos-member-expr-error` https://github.com/llvm/llvm-project/pull/110487 ___ cfe-commits mailing list cfe-co

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-testing-tools Author: Henrik G. Olsson (hnrklssn) Changes Reverts llvm/llvm-project#108425 --- Full diff: https://github.com/llvm/llvm-project/pull/110772.diff 9 Files Affected: - (modified) clang/test/lit.cfg.py (-10) - (modified) llvm/docs/Command

[clang] Allow tag-based API notes on anonymous tag decls with typedef names (PR #110768)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Gregor (DougGregor) Changes It is common practice in C to declare anonymous tags that are immediately given a typedef name, e.g., typedef enum { ... } MyType; At present, one can only express API notes on the typedef. However, t

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
bwendling wrote: > @bwendling I think you accidentally compiled the wrong branch. Looks like > that is in `builtin_get_counted_by`, but this PR is in > `bdos-member-expr-error` Yeah, sorry about that. https://github.com/llvm/llvm-project/pull/110487 ___

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
zeroomega wrote: Looks like https://github.com/llvm/llvm-project/pull/108999 broke the check bots. https://github.com/llvm/llvm-project/pull/110777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread via cfe-commits
zeroomega wrote: But IIUC, the diagnostic message change from this PR might be unintentional. The expected error message in 793ded7d0b7f1407636a98007f83074b8dd5f765 doesn't align to the error message from other tests in the same file. Should that be addressed? https://github.com/llvm/llvm-pro

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Test fix has re-landed: fea18afeed39fe4435d67eee1834f0f34b23013d. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fea18af - Fix failing test caused by b70d327

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:26:05-07:00 New Revision: fea18afeed39fe4435d67eee1834f0f34b23013d URL: https://github.com/llvm/llvm-project/commit/fea18afeed39fe4435d67eee1834f0f34b23013d DIFF: https://github.com/llvm/llvm-project/commit/fea18afeed39fe4435d67eee1834f0f34b23013d.diff L

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Unfortunately, I didn't see your revert, and my pull didn't show any changes from main before I quickly committed the test change. So my test change would also break the build with your revert. So I reverted the test change just now! Revert: 5d308af894ccc3f7a288d6abd6f9097b4cbc8

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Brian Cain via cfe-commits
@@ -0,0 +1,25 @@ + androm3da wrote: Absolutely. That's been the status quo and this PR on its own can't change that. The intent of this pull req is to allow anyone to build a toolchain for targeting hexagon (of which libc++, libc++abi, libunwind are a part).

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (c8ef) Changes This patch is a follow-up to #109831. In the discussion, we agreed that having parameter checks scattered across different areas isn't ideal. Therefore, I suggest merging the check from #88974 into the void parameter

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef ready_for_review https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread via cfe-commits
c8ef wrote: CC @zyn0217 @mizvekov @cor3ntin https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: > But IIUC, the diagnostic message change from this PR might be unintentional. > The expected error message in > [793ded7](https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765) > doesn't align to the error message from other tests in the same file.

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/4] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -781,6 +798,9 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure, #define INSTR_PROF_COVNAME_COFF ".lcovn" #define INSTR_PROF_ORDERFILE_COFF ".lorderfile$M" +// TODO: Placeholder for Windows. We need to revise when we upstream this. hubert-reinte

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,9 +1,15 @@ ;; Ensure __llvm_gcov_(writeout|reset|init) have the correct !kcfi_type ;; with integer normalization. ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtr

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate the parameter check for the `requires` expression parameter. (PR #110773)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/110773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,7 +1,13 @@ ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtriple=x86_64-unknown-linux-gnu | FileCheck \ +; RUN: --check-prefixes=CHECK,CHECK-ELF %s

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -2962,13 +2964,34 @@ void PPCAIXAsmPrinter::emitPGORefs(Module &M) { } } +void PPCAIXAsmPrinter::emitGCOVRefs() { + if (!OutContext.hasXCOFFSection( + "__llvm_gcov_ctr_section", + XCOFF::CsectProperties(XCOFF::XMC_RW, XCOFF::XTY_SD))) +return; + +

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -914,6 +918,7 @@ bool GCOVProfiler::emitProfileNotes( GlobalVariable *Counters = new GlobalVariable( *M, CounterTy, false, GlobalValue::InternalLinkage, Constant::getNullValue(CounterTy), "__llvm_gcov_ctr"); +Counters->setSection("__ll

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -1,8 +1,14 @@ ;; Ensure __llvm_gcov_(writeout|reset|init) have !kcfi_type with KCFI. ; RUN: mkdir -p %t && cd %t -; RUN: opt < %s -S -passes=insert-gcov-profiling | FileCheck %s +; RUN: opt < %s -S -passes=insert-gcov-profiling \ +; RUN: -mtriple=x86_64-unknown-linux-gnu | F

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -2962,13 +2964,34 @@ void PPCAIXAsmPrinter::emitPGORefs(Module &M) { } } +void PPCAIXAsmPrinter::emitGCOVRefs() { + if (!OutContext.hasXCOFFSection( + "__llvm_gcov_ctr_section", + XCOFF::CsectProperties(XCOFF::XMC_RW, XCOFF::XTY_SD))) +return; + +

[clang] [compiler-rt] [llvm] [PGO] Initialize GOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
@@ -781,6 +798,9 @@ serializeValueProfDataFrom(ValueProfRecordClosure *Closure, #define INSTR_PROF_COVNAME_COFF ".lcovn" #define INSTR_PROF_ORDERFILE_COFF ".lorderfile$M" +// TODO: Placeholder for Windows. We need to revise when we upstream this. hubert-reinte

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-01 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/108570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/6] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/7] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/110487 >From 375a71d114fffb94c16455f476364a7de9e08191 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Mon, 30 Sep 2024 03:41:15 -0700 Subject: [PATCH 1/2] [Clang][CodeGen] Emit load of value We were missing a loa

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Lei Wang via cfe-commits
wlei-llvm wrote: Thanks for the context! > Why not use the existing `-pgo-function-entry-coverage` > (https://discourse.llvm.org/t/instrprofiling-lightweight-instrumentation/59113/14?u=ellishg) > LLVM flag? It takes advantage of the `llvm.instrprof.cover` intrinsic which > has less size and r

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
bwendling wrote: I reverted my last commit. This leaves the original patch, which seems to work. @efriedma-quic, would you be okay with this patch while I work to improve the code in follow-up? https://github.com/llvm/llvm-project/pull/110487 ___ cfe

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
@@ -649,6 +649,24 @@ static void addPGOAndCoverageFlags(const ToolChain &TC, Compilation &C, } } + if (auto *ColdFuncCoverageArg = Args.getLastArg( + options::OPT_fprofile_generate_cold_function_coverage, + options::OPT_fprofile_generate_cold_function

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
@@ -1119,6 +1125,18 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level, // removed. MPM.addPass( PGOIndirectCallPromotion(true /* IsInLTO */, true /* SamplePGO */)); + +if (InstrumentSampleColdFuncPath.getNumOccurrences() && +

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-10-01 Thread via cfe-commits
zeroomega wrote: We are seeing `Clang :: Sema/aarch64-sve-vector-trig-ops.c` test failure after this change got landed. ``` Exit Code: 1 Command Output (stderr): -- RUN: at line 1: /b/s/w/ir/x/w/llvm_build/bin/clang -cc1 -internal-isystem /b/s/w/ir/x/w/llvm_build/lib/clang/20/include -nostdsy

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Lei Wang via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, wlei-llvm wrote: Sorry if my PR des

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Lei Wang via cfe-commits
wlei-llvm wrote: > For your use case, can you use > [ProfileSymbolList](https://github.com/llvm/llvm-project/blob/32ffc9fdc2cd422c88c926b862adb3de726e3888/llvm/include/llvm/ProfileData/SampleProf.h#L1509-L1512) > to identify very cold functions (executed but unsampled) or are you indeed > look

[clang] [clang-shlib] Add symbol versioning to all symbols (PR #110758)

2024-10-01 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/110758 We do the same thing for libLLVM.so. This should help avoid issues when an applications loads two different versions of the library at the same time. >From 59673ed97d92df34d6f662da5a51f6e28806b5af Mon Sep 17

[clang] [llvm] Revert "[Utils] Add new --update-tests flag to llvm-lit" (PR #110772)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Henrik G. Olsson (hnrklssn) Changes Reverts llvm/llvm-project#108425 --- Full diff: https://github.com/llvm/llvm-project/pull/110772.diff 9 Files Affected: - (modified) clang/test/lit.cfg.py (-10) - (modified) llvm/docs/CommandGuide/li

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Bill Wendling via cfe-commits
bwendling wrote: > > I reverted my last commit. This leaves the original patch, which seems to > > work. @efriedma-quic, would you be okay with this patch while I work to > > improve the code in follow-up? > > The original (and current) patch in this PR still introduces a regression. So > it

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/110767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: No worries https://github.com/llvm/llvm-project/pull/110487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Nico Weber via cfe-commits
nico wrote: Looks like this breaks check-clang: http://45.33.8.238/linux/149333/step_6.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: @francisvm This changed diagnostics, but didn't update all the affected tests. See: https://github.com/llvm/llvm-project/pull/110187#issuecomment-2387260975 https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cf

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
@@ -108,6 +108,7 @@ namespace MultilevelSpecialization { template<> template void B::f(int i, int (&arr1)[a], int (&arr2)[b]) {} // since-cxx11-error@-1 {{out-of-line definition of 'f' does not match any declaration in 'cwg2233::MultilevelSpecialization::B'}} +//

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-01 Thread via cfe-commits
c8ef wrote: > Please also add a note in the `clang/docs/ReleaseNotes.rst` Done. https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Michal Paszkowski via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics michalpaszkowski wrote: @AlexVlx I am not sure I follow the reasoning here. The idea behind those various tests in `/SPIRV/optimizations/` (including this one)

[clang] [Clang][TableGen] Change NeonEmitter to use const Record * (PR #110597)

2024-10-01 Thread Kazu Hirata via cfe-commits
@@ -1161,11 +1161,9 @@ void SVEEmitter::createIntrinsic( uint64_t Merge = R->getValueAsInt("Merge"); StringRef MergeSuffix = R->getValueAsString("MergeSuffix"); uint64_t MemEltType = R->getValueAsInt("MemEltType"); - std::vector FlagsList = R->getValueAsListOfDefs("Flags

[clang] 5831eed - [Clang][TableGen] Change Opcodes Emitter to use const Record * (#110588)

2024-10-01 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-10-01T06:52:48-07:00 New Revision: 5831eed8d038951eee0f9379de001a55ce352eb0 URL: https://github.com/llvm/llvm-project/commit/5831eed8d038951eee0f9379de001a55ce352eb0 DIFF: https://github.com/llvm/llvm-project/commit/5831eed8d038951eee0f9379de001a55ce352eb0.diff L

[clang-tools-extra] 7b8f7be - [clang-tidy] Add new check bugprone-tagged-union-member-count (#89925)

2024-10-01 Thread via cfe-commits
Author: tigbr Date: 2024-10-01T13:24:32+02:00 New Revision: 7b8f7beadcf1814b1f1aa985d344ca17747531a7 URL: https://github.com/llvm/llvm-project/commit/7b8f7beadcf1814b1f1aa985d344ca17747531a7 DIFF: https://github.com/llvm/llvm-project/commit/7b8f7beadcf1814b1f1aa985d344ca17747531a7.diff LOG: [c

[clang] b8b036a - [HLSL] Treat `main` as any other function (#110546)

2024-10-01 Thread via cfe-commits
Author: Chris B Date: 2024-10-01T07:36:36-05:00 New Revision: b8b036a7fe5b6e7ec306e3b80367e22d157a492b URL: https://github.com/llvm/llvm-project/commit/b8b036a7fe5b6e7ec306e3b80367e22d157a492b DIFF: https://github.com/llvm/llvm-project/commit/b8b036a7fe5b6e7ec306e3b80367e22d157a492b.diff LOG:

[clang] e96f778 - [clang][x86] Fix bad merge in #110581

2024-10-01 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2024-10-01T11:21:22+01:00 New Revision: e96f7788f5176dcf39c4eb53e4146f1e791adf83 URL: https://github.com/llvm/llvm-project/commit/e96f7788f5176dcf39c4eb53e4146f1e791adf83 DIFF: https://github.com/llvm/llvm-project/commit/e96f7788f5176dcf39c4eb53e4146f1e791adf83.diff

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-01 Thread David Sherwood via cfe-commits
@@ -4072,6 +4078,30 @@ static Value *upgradeX86IntrinsicCall(StringRef Name, CallBase *CI, Function *F, return Rep; } +static Value *upgradeAArch64IntrinsicCall(StringRef Name, CallBase *CI, + Function *F, IRBuilder<> &Builder) { +

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-01 Thread David Sherwood via cfe-commits
@@ -5553,6 +5553,14 @@ static SDValue getSVEPredicateBitCast(EVT VT, SDValue Op, SelectionDAG &DAG) { if (InVT == VT) return Op; + // Look through casts to when their input has more lanes than + // VT. This will increase the chances of removing casts that introduce n

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-01 Thread David Sherwood via cfe-commits
@@ -1003,6 +998,13 @@ defm SVFCVT_F32_F64 : SInstCvtMXZ<"svcvt_f32[_f64]", "MMPd", "MPd", "d", "aarc defm SVFCVT_F64_F16 : SInstCvtMXZ<"svcvt_f64[_f16]", "ddPO", "dPO", "d", "aarch64_sve_fcvt_f64f16">; defm SVFCVT_F64_F32 : SInstCvtMXZ<"svcvt_f64[_f32]", "ddPM", "dPM", "

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-01 Thread David Sherwood via cfe-commits
@@ -5553,6 +5553,14 @@ static SDValue getSVEPredicateBitCast(EVT VT, SDValue Op, SelectionDAG &DAG) { if (InVT == VT) return Op; + // Look through casts to when their input has more lanes than david-arm wrote: Perhaps better written as `casts to ` in

[clang] [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (PR #110699)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes These are also called for vectors. --- Full diff: https://github.com/llvm/llvm-project/pull/110699.diff 1 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+8) ``diff diff -

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Alex Voicu via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics AlexVlx wrote: This relies on `CodeGenPrepare::combineToUSubWithOverflow` firing, however when encoding the int sizes we can do loop strength reduction before,

[clang] [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (PR #110699)

2024-10-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110699 These are also called for vectors. >From 4c7c6d3707e533d8300a622be6e02bf21b07e46c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 1 Oct 2024 18:39:33 +0200 Subject: [PATCH] [clang][byte

[clang] [clang-tools-extra] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

2024-10-01 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/110366 From 4fb69942effb3cf34d07f33a14a95757b6ca5ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Sat, 28 Sep 2024 17:05:42 +0200 Subjec

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics arsenm wrote: This one is testing codegenprepare as part of the normal codegen pipeline, so this one is fine. The other case was a full optimization pipeline +

[clang] [Clang][TableGen] Change NeonEmitter to use const Record * (PR #110597)

2024-10-01 Thread Rahul Joshi via cfe-commits
@@ -1161,11 +1161,9 @@ void SVEEmitter::createIntrinsic( uint64_t Merge = R->getValueAsInt("Merge"); StringRef MergeSuffix = R->getValueAsString("MergeSuffix"); uint64_t MemEltType = R->getValueAsInt("MemEltType"); - std::vector FlagsList = R->getValueAsListOfDefs("Flags

[clang] [Clang][TableGen] Change NeonEmitter to use const Record * (PR #110597)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/110597 >From 7d9e44f13483c4a801ec7895aa231e4b7e11e223 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Mon, 30 Sep 2024 15:55:03 -0700 Subject: [PATCH] [Clang][TableGen] Change NeonEmitter to use const Record * --- c

  1   2   3   4   5   >