[clang] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-31 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Superseded by https://github.com/llvm/llvm-project/pull/106585. https://github.com/llvm/llvm-project/pull/102922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFCI] Slightly refactor getTemplateInstantiationArgs() (PR #102922)

2024-08-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/102922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Julian Schmidt (5chmidti) Changes Since #87832, unnamed identifiers are excluded from being diagnosed. As a result, the tests that were supposed to test that deleted functions are correctly ignored are ignored because of the unn

[clang] [clang][ASTImporter] New fix for default template parameter values. (PR #101836)

2024-08-31 Thread Matheus Izvekov via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -5968,11 +5962,21 @@ ASTNodeImporter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { } if (D->hasDefaultArgument()) { +// Default argument can be "inherited" when it has a reference

[clang] [llvm] [HLSL] AST support for WaveSize attribute. (PR #101240)

2024-08-31 Thread Xiang Li via cfe-commits
https://github.com/python3kgae closed https://github.com/llvm/llvm-project/pull/101240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Docs] Update function calls docs (PR #106860)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) Changes Update the function calls documentation to match the newly landed implementation. --- Full diff: https://github.com/llvm/llvm-project/pull/106860.diff 1 Files Affected: - (modified

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-08-31 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-08-31 Thread Younan Zhang via cfe-commits
@@ -33,11 +33,12 @@ class D{}; // expected-note{{previous definition is here}} template class D{}; // expected-error{{class template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list}} expected-e

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-08-31 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thanks for the review :) https://github.com/llvm/llvm-project/pull/101020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4f4bd41 - [NFC] Fix typos (#106817)

2024-08-31 Thread via cfe-commits
Author: c8ef Date: 2024-08-31T19:12:57-07:00 New Revision: 4f4bd41f7098af51c3ba2e62cc635e3c45c294d4 URL: https://github.com/llvm/llvm-project/commit/4f4bd41f7098af51c3ba2e62cc635e3c45c294d4 DIFF: https://github.com/llvm/llvm-project/commit/4f4bd41f7098af51c3ba2e62cc635e3c45c294d4.diff LOG: [NF

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: Looks really good. I only had some notes w.r.t. note tags. https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread via cfe-commits
@@ -5635,123 +5627,95 @@ static bool isAtLeastAsSpecializedAs(Sema &S, SourceLocation Loc, assert(Proto1 && Proto2 && "Function templates must have prototypes"); TemplateParameterList *TemplateParams = FT2->getTemplateParameters(); - SmallVector Deduced; - Deduced.resiz

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2f4232db0b72635b89c2356c8a2c0504b075a0ab...3945829650ac41f587c161cd6fb505225efba379 clang

[clang] [llvm] [Chore] Fix `formating` typos. NFC. (PR #106817)

2024-08-31 Thread via cfe-commits
c8ef wrote: Hi, could you please take a look? @owenca https://github.com/llvm/llvm-project/pull/106817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] [MallocChecker] suspect all release functions as candite for supression (PR #104599)

2024-08-31 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag edited https://github.com/llvm/llvm-project/pull/104599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/106862 >From 46704590d3a90518c7b58ce03ac29c3e65c26676 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 31 Aug 2024 18:44:37 +0200 Subject: [PATCH 1/3] [NFC][clang-tidy] reword diagnostic note in definitions-i

[clang] [analyzer] [MallocChecker] suspect all release functions as candite for supression (PR #104599)

2024-08-31 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/104599 >From 913036ab795d6b91d6bb74d82aa2d329fe689535 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 16 Aug 2024 17:45:57 +0300 Subject: [PATCH 1/3] clang/csa: suspect all functions as those that may do refc

[clang] [clang][ASTImporter] New fix for default template parameter values. (PR #101836)

2024-08-31 Thread Matheus Izvekov via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/mizvekov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101836 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/106861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/106862 >From 46704590d3a90518c7b58ce03ac29c3e65c26676 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 31 Aug 2024 18:44:37 +0200 Subject: [PATCH 1/2] [NFC][clang-tidy] reword diagnostic note in definitions-i

[clang] [llvm] [Chore] Fix `formating` typos. NFC. (PR #106817)

2024-08-31 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/106817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Thanks for review! Addressed comments. I have no commit access, if/when this looks good to go you can go ahead and click merge. https://github.com/llvm/llvm-project/pull/106801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [Clang][Concepts] Fix a constraint comparison regression for out-of-line ClassTemplateDecls (PR #102587)

2024-08-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/102587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Docs] Update function calls docs (PR #106860)

2024-08-31 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/106860 Update the function calls documentation to match the newly landed implementation. >From f3ee9f197eced0f7496c611f09dd684d84325f26 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Sat, 31 Aug 2024 11:16:28

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/106801 >From 3945829650ac41f587c161cd6fb505225efba379 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 31 Aug 2024 13:40:14 -0400 Subject: [PATCH] [clang-tidy] Add type annotations to add_new_check.py, fix

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/106849 >From 6ce4604725d36afaea17cf533d422a978c4389ff Mon Sep 17 00:00:00 2001 From: c8ef Date: Fri, 30 Aug 2024 15:34:34 + Subject: [PATCH 1/3] fix cast --- clang/lib/AST/ExprConstant.cpp | 2 +- clang/test/AST/ato

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread via cfe-commits
@@ -5635,123 +5627,95 @@ static bool isAtLeastAsSpecializedAs(Sema &S, SourceLocation Loc, assert(Proto1 && Proto2 && "Function templates must have prototypes"); TemplateParameterList *TemplateParams = FT2->getTemplateParameters(); - SmallVector Deduced; - Deduced.resiz

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/106849 Fixes #106713. >From 6ce4604725d36afaea17cf533d422a978c4389ff Mon Sep 17 00:00:00 2001 From: c8ef Date: Fri, 30 Aug 2024 15:34:34 + Subject: [PATCH 1/2] fix cast --- clang/lib/AST/ExprConstant.cpp | 2 +- cl

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-08-31 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/106495 >From e8f472674e0d1e70adcd1d29b8c902f4cd80f188 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Wed, 28 Aug 2024 21:15:57 -0700 Subject: [PATCH 1/3] [Clang][RISCV] Recognize unsupport feature by supporting isValidFe

[clang] [HLSL] Implement output parameter (PR #101083)

2024-08-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-02` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/1833 Here is the relevant piece of the bui

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux` running on `ppc64le-sanitizer` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/2832 Here is the relevant piece of the bu

[clang] [llvm] [HLSL] AST support for WaveSize attribute. (PR #101240)

2024-08-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,llvm` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/5200 Here is the re

[clang-tools-extra] [clang-tidy] fix nullptr dereference in bugprone-forwarding-reference (PR #106856)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Julian Schmidt (5chmidti) Changes Previously, when checking if a `TemplateSpecializationType` is either `enable_if` or `enable_if_t`, the AST matcher would call `getTemplateName`, `getASTemplateDecl` and `getTemplatedDecl` in su

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/106862 `make as inline` made little sense here, so I changed the `make` to `mark` and added `the definition` as well. >From 46704590d3a90518c7b58ce03ac29c3e65c26676 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date

[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/106861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-08-31 Thread Piyou Chen via cfe-commits
https://github.com/BeMg edited https://github.com/llvm/llvm-project/pull/106495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 89fb849 - [HLSL] Implement output parameter (#101083)

2024-08-31 Thread via cfe-commits
Author: Chris B Date: 2024-08-31T10:59:08-05:00 New Revision: 89fb8490a99e612f7a574e8678b21a90f689f5b4 URL: https://github.com/llvm/llvm-project/commit/89fb8490a99e612f7a574e8678b21a90f689f5b4 DIFF: https://github.com/llvm/llvm-project/commit/89fb8490a99e612f7a574e8678b21a90f689f5b4.diff LOG:

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-08-31 Thread Piyou Chen via cfe-commits
BeMg wrote: Rebase with https://github.com/llvm/llvm-project/pull/106680 and drop the `__RISCV_TargetAttrNeedOverride` relate code section. https://github.com/llvm/llvm-project/pull/106495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

2024-08-31 Thread Shoaib Meenai via cfe-commits
@@ -2900,7 +2900,7 @@ defm clangir : BoolFOption<"clangir", PosFlag, NegFlag LLVM pipeline to compile">, BothFlags<[], [ClangOption, CC1Option], "">>; -def emit_cir : Flag<["-"], "emit-cir">, Visibility<[CC1Option]>, +def emit_cir : Flag<["-"], "emit-cir">, Visibility<[C

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/106829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/106801 >From 17f4b4a4320ded64b4d6ea673508e3d2f470d0aa Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 31 Aug 2024 13:46:52 -0400 Subject: [PATCH] [clang-tidy] Add type annotations to add_new_check.py, fix

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
keinflue wrote: I just realized too late that this would be for the most part a revert of aea82d4551139. So I am not sure how to proceed. https://github.com/llvm/llvm-project/pull/106841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] b0276ec - [RISCV][NFC] Reimplementation of target attribute override mechanism (#106680)

2024-08-31 Thread via cfe-commits
Author: Piyou Chen Date: 2024-08-31T20:02:46+08:00 New Revision: b0276ec6b74cd65b765234f42b8e0e32597d3642 URL: https://github.com/llvm/llvm-project/commit/b0276ec6b74cd65b765234f42b8e0e32597d3642 DIFF: https://github.com/llvm/llvm-project/commit/b0276ec6b74cd65b765234f42b8e0e32597d3642.diff LO

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
@@ -177,5 +177,21 @@ static void __builtin_cpu_init(); // expected-error {{static declaration of '__b #endif #ifdef _MSC_VER -constexpr int x = []{ __noop; return 0; }(); // expected-no-diagnostics +constexpr int x = [] { + __noop; + return 0; +}(); // expected-no-diagnosti

[clang] [analyzer] [MallocChecker] suspect all release functions as candite for supression (PR #104599)

2024-08-31 Thread Pavel Skripkin via cfe-commits
@@ -3648,35 +3648,38 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, return nullptr; } - // See if we're releasing memory while inlining a destructor - // (or one of its callees). This turns on various common - //

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-08-31 Thread Piyou Chen via cfe-commits
https://github.com/BeMg edited https://github.com/llvm/llvm-project/pull/106495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-08-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/101020 >From 420705203a72c82446bd491b5766dde5fef116ff Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 29 Jul 2024 22:10:19 +0800 Subject: [PATCH 1/3] [Clang][Parser] Fix name lookup of template parameters for o

[clang] [Clang][RISCV] Recognize unsupport target feature by supporting isValidFeatureName (PR #106495)

2024-08-31 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/106495 >From e8f472674e0d1e70adcd1d29b8c902f4cd80f188 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Wed, 28 Aug 2024 21:15:57 -0700 Subject: [PATCH 1/4] [Clang][RISCV] Recognize unsupport feature by supporting isValidFe

[clang] 5b0bcec - [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (#101020)

2024-08-31 Thread via cfe-commits
Author: Younan Zhang Date: 2024-08-31T17:35:51+08:00 New Revision: 5b0bcec93dbc2e5bec049c452b157548334c5e28 URL: https://github.com/llvm/llvm-project/commit/5b0bcec93dbc2e5bec049c452b157548334c5e28 DIFF: https://github.com/llvm/llvm-project/commit/5b0bcec93dbc2e5bec049c452b157548334c5e28.diff

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3327 Here is the relevant piece of the b

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/106801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Julian Schmidt (5chmidti) Changes `make as inline` made little sense here, so I changed the `make` to `mark` and added `the definition` as well. --- Full diff: https://github.com/llvm/llvm-project/pull/106862.diff 1 Files Affected:

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-08-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/101020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

2024-08-31 Thread via cfe-commits
https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/3] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang] Fix crash in code with StmtExpr and atomic char load in Expr::EvaluateAsRValue. (PR #106751)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/106751 >From 6ce4604725d36afaea17cf533d422a978c4389ff Mon Sep 17 00:00:00 2001 From: c8ef Date: Fri, 30 Aug 2024 15:34:34 + Subject: [PATCH] fix cast --- clang/lib/AST/ExprConstant.cpp | 2 +- clang/test/AST/atomic-

[clang] [clang] NFCI: don't check deduced constraints when partial ordering (PR #106882)

2024-08-31 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. LGTM, but please wait for others' opinions before merging. https://github.com/llvm/llvm-project/pull/106882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang-tools-extra] [clang-tidy] Suggest using reinterpret_cast in bugprone-casting-thro… (PR #106784)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/106784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [docs] Clarify the issue with compiler-rt on Windows/MSVC (PR #106875)

2024-08-31 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/106875 Compiler-rt does support Windows just fine, even if outdated docs pages didn't list it as one of the supported OSes, this is being rectified in https://github.com/llvm/llvm-project/pull/106874. MinGW is anoth

[clang] [clang][bytecode] Fix diagnosting reads from temporaries (PR #106868)

2024-08-31 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/106868 Fix the DeclID not being set in global temporaries and use the same strategy for deciding if a temporary is readable as the current interpreter. >From 21f0a354dad22ac9fa540413cd859a5d6bd0904c Mon Sep 17 00:00:

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Julian Schmidt via cfe-commits
@@ -754,7 +765,7 @@ def main(): language_restrict = ( f"%(lang)s.{cpp_language_to_requirements.get(args.standard, 'CPlusPlus')}" ) -elif language in ["objc", "objc++"]: +else: # "objc" or "objc++" language_restrict = "%(lang)s.ObjC

[clang] cfe331b - [clang] function template non-call partial ordering fixes (#106829)

2024-08-31 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-08-31T16:07:42-03:00 New Revision: cfe331b853003cea868b84295552cecea63ab153 URL: https://github.com/llvm/llvm-project/commit/cfe331b853003cea868b84295552cecea63ab153 DIFF: https://github.com/llvm/llvm-project/commit/cfe331b853003cea868b84295552cecea63ab153.dif

[clang] [RISCV][NFC] Reimplementation of target attribute override mechanism (PR #106680)

2024-08-31 Thread Piyou Chen via cfe-commits
https://github.com/BeMg closed https://github.com/llvm/llvm-project/pull/106680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
https://github.com/keinflue updated https://github.com/llvm/llvm-project/pull/106841 >From 69ea0e56fcf84ca5951e73f89e3a1e02e303af91 Mon Sep 17 00:00:00 2001 From: keinflue <80230456+keinf...@users.noreply.github.com> Date: Sat, 31 Aug 2024 11:27:57 +0200 Subject: [PATCH] [clang] fix range of emp

[clang-tools-extra] [clang-tidy] fix nullptr dereference in bugprone-forwarding-reference (PR #106856)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/106856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-31 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: gentle ping https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/106849 >From 6ce4604725d36afaea17cf533d422a978c4389ff Mon Sep 17 00:00:00 2001 From: c8ef Date: Fri, 30 Aug 2024 15:34:34 + Subject: [PATCH 1/4] fix cast --- clang/lib/AST/ExprConstant.cpp | 2 +- clang/test/AST/ato

[clang] [HLSL] Implement output parameter (PR #101083)

2024-08-31 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/101083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-31 Thread Balazs Benics via cfe-commits
@@ -50,6 +118,75 @@ class BuiltinFunctionChecker : public Checker { } // namespace +std::pair +BuiltinFunctionChecker::checkOverflow(CheckerContext &C, SVal RetVal, + QualType Res) const { + ProgramStateRef State = C.getState(); + SValBu

[clang] [clang] NFCI: don't check deduced constraints when partial ordering (PR #106882)

2024-08-31 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/106882 We were incorrectly applying [temp.deduct]p5 to partial ordering. Marked as NFCI as I don't think the difference is actually observable in practice. During partial ordering, the deduced arguments will mostly b

[clang] [clang] [docs] Clarify the issue with compiler-rt on Windows/MSVC (PR #106875)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Martin Storsjö (mstorsjo) Changes Compiler-rt does support Windows just fine, even if outdated docs pages didn't list it as one of the supported OSes, this is being rectified in https://github.com/llvm/llvm-project/pull/106874. MinGW is

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-08-31 Thread via cfe-commits
https://github.com/dmasloff updated https://github.com/llvm/llvm-project/pull/106145 >From 568c99faf02964e278161bf1d8a469229e228758 Mon Sep 17 00:00:00 2001 From: dmasloff Date: Mon, 26 Aug 2024 22:11:05 +0300 Subject: [PATCH] [clang-format] Add new option: WrapNamespaceBodyWithNewlines --- c

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-08-31 Thread Owen Pan via cfe-commits
owenca wrote: Please run `git clang-format HEAD~` and `ninja clang-format-check-format` before pushing. https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang-tools-extra] [clang-tidy] fix nullptr dereference in bugprone-forwarding-reference (PR #106856)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/106856 Previously, when checking if a `TemplateSpecializationType` is either `enable_if` or `enable_if_t`, the AST matcher would call `getTemplateName`, `getASTemplateDecl` and `getTemplatedDecl` in succession to check

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef converted_to_draft https://github.com/llvm/llvm-project/pull/106849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/106829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-31 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,157 @@ +// RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \ +// RUN: -analyzer-checker=core,debug.ExprInspection + +#define __UINT_MAX__ (__INT_MAX__ * 2U + 1U) +#define __INT_MIN__ (-__INT_MAX__ - 1) + +void clang_analyzer_dump_int(int); +void cla

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-08-31 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
https://github.com/keinflue created https://github.com/llvm/llvm-project/pull/106841 In C++ enumerations without fixed underlying type which have either no enumerator or only enumerators with value 0 have a value set containing only 0, instead of 0 and 1. See [decl.enum]/8. This PR affects ca

[clang] [analyzer] [MallocChecker] suspect all release functions as candite for supression (PR #104599)

2024-08-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f0df4fbd0c7b6bb369ceaa1fd6f9e0c88d781ae5 0ab7a5a7ee72a60b3a478a7c508779458348f993 --e

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
@@ -754,7 +765,7 @@ def main(): language_restrict = ( f"%(lang)s.{cpp_language_to_requirements.get(args.standard, 'CPlusPlus')}" ) -elif language in ["objc", "objc++"]: +else: # "objc" or "objc++" language_restrict = "%(lang)s.ObjC

[clang] [llvm] [Chore] Fix `formating` typos. NFC. (PR #106817)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/106817 >From dc9e84136e33c6ab35b1263382b740ff9a9dcd68 Mon Sep 17 00:00:00 2001 From: c8ef Date: Sat, 31 Aug 2024 09:30:49 +0800 Subject: [PATCH] fix formating typo --- clang/lib/Tooling/Refactoring/AtomicChange.cpp

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
https://github.com/keinflue updated https://github.com/llvm/llvm-project/pull/106841 >From 533f32f7be161bfec45ee93cef3fbd78fc55e721 Mon Sep 17 00:00:00 2001 From: keinflue <80230456+keinf...@users.noreply.github.com> Date: Sat, 31 Aug 2024 11:27:57 +0200 Subject: [PATCH] [clang] fix range of emp

[clang] [clang] function template non-call partial ordering fixes (PR #106829)

2024-08-31 Thread via cfe-commits
@@ -5635,123 +5627,95 @@ static bool isAtLeastAsSpecializedAs(Sema &S, SourceLocation Loc, assert(Proto1 && Proto2 && "Function templates must have prototypes"); TemplateParameterList *TemplateParams = FT2->getTemplateParameters(); - SmallVector Deduced; - Deduced.resiz

[clang] [clang] The ms-extension __noop should return zero in a constexpr context. (PR #106849)

2024-08-31 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/106849 >From 6ce4604725d36afaea17cf533d422a978c4389ff Mon Sep 17 00:00:00 2001 From: c8ef Date: Fri, 30 Aug 2024 15:34:34 + Subject: [PATCH 1/5] fix cast --- clang/lib/AST/ExprConstant.cpp | 2 +- clang/test/AST/ato

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Julian Schmidt via cfe-commits
@@ -8,21 +8,19 @@ # # ===---===# -from __future__ import print_function -from __future__ import unicode_literals - import argparse import io import itertools import os import re import sys import textw

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
cor3ntin wrote: @shafik https://github.com/llvm/llvm-project/pull/106841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-08-31 Thread James Y Knight via cfe-commits
jyknight wrote: I think we can just switch it to be a textual header; it no longer has any decls. https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2024-08-31 Thread Oleksandr T. via cfe-commits
@@ -177,6 +177,26 @@ static bool isLanguageDefinedBuiltin(const SourceManager &SourceMgr, return false; } +static bool isReservedAttrName(Preprocessor &PP, IdentifierInfo *II) { a-tarasyuk wrote: @AaronBallman Thanks. Just to confirm, are future attribute

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/106801 >From 17f4b4a4320ded64b4d6ea673508e3d2f470d0aa Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 31 Aug 2024 13:46:52 -0400 Subject: [PATCH] [clang-tidy] Add type annotations to add_new_check.py, fix

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: I suppose it doesn't hurt to mention it. Don't tests need to be updated too? https://github.com/llvm/llvm-project/pull/106862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/106801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] NFCI: don't check deduced constraints when partial ordering (PR #106882)

2024-08-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes We were incorrectly applying [temp.deduct]p5 to partial ordering. Marked as NFCI as I don't think the difference is actually observable in practice. During partial ordering, the deduced arguments will mo

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-08-31 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov edited https://github.com/llvm/llvm-project/pull/106810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix nullptr dereference in bugprone-forwarding-reference (PR #106856)

2024-08-31 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/106856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix range of empty enumeration without fixed underlying type (PR #106841)

2024-08-31 Thread via cfe-commits
https://github.com/keinflue edited https://github.com/llvm/llvm-project/pull/106841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Add function check for windows platform (PR #106581)

2024-08-31 Thread via cfe-commits
https://github.com/fawdlstty updated https://github.com/llvm/llvm-project/pull/106581 >From f169f3c57a0a55c1a0dbb8f965bc17a87ceb98d7 Mon Sep 17 00:00:00 2001 From: fawdlstty Date: Fri, 30 Aug 2024 00:23:39 +0800 Subject: [PATCH 1/5] add check for windows platforms api --- .../bugprone/NotNull

[clang] [clang][bytecode] Fix diagnosing reads from temporaries (PR #106868)

2024-08-31 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3334 Here is the relevant piece of the b

[clang-tools-extra] [NFC][clang-tidy] reword diagnostic note in definitions-in-headers (PR #106862)

2024-08-31 Thread Julian Schmidt via cfe-commits
5chmidti wrote: I don't think this would need a release note, but it is user-facing. WDYT? https://github.com/llvm/llvm-project/pull/106862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] [clang-tidy] Add type annotations to add_new_check.py, fix minor bug (PR #106801)

2024-08-31 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/106801 >From 3945829650ac41f587c161cd6fb505225efba379 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sat, 31 Aug 2024 13:40:14 -0400 Subject: [PATCH] [clang-tidy] Add type annotations to add_new_check.py, fix

  1   2   >