Author: NAKAMURA Takumi
Date: 2024-05-10T16:00:16+09:00
New Revision: 7e52ad3b5b9509d0873965e8492ab01141342822
URL:
https://github.com/llvm/llvm-project/commit/7e52ad3b5b9509d0873965e8492ab01141342822
DIFF:
https://github.com/llvm/llvm-project/commit/7e52ad3b5b9509d0873965e8492ab01141342822.dif
Author: NAKAMURA Takumi
Date: 2024-05-10T16:00:16+09:00
New Revision: 2a61eebc66c0903cf3834a520b1f975ac3cdf92b
URL:
https://github.com/llvm/llvm-project/commit/2a61eebc66c0903cf3834a520b1f975ac3cdf92b
DIFF:
https://github.com/llvm/llvm-project/commit/2a61eebc66c0903cf3834a520b1f975ac3cdf92b.dif
Author: Owen Pan
Date: 2024-05-10T00:05:16-07:00
New Revision: 6ce4c4ca2bb846c2b8d64dc2b3d3496785c9edff
URL:
https://github.com/llvm/llvm-project/commit/6ce4c4ca2bb846c2b8d64dc2b3d3496785c9edff
DIFF:
https://github.com/llvm/llvm-project/commit/6ce4c4ca2bb846c2b8d64dc2b3d3496785c9edff.diff
LOG:
Author: Jack Styles
Date: 2024-05-10T08:09:02+01:00
New Revision: 6aac30fa43f094ac25269bda163dc89a88cb8da7
URL:
https://github.com/llvm/llvm-project/commit/6aac30fa43f094ac25269bda163dc89a88cb8da7
DIFF:
https://github.com/llvm/llvm-project/commit/6aac30fa43f094ac25269bda163dc89a88cb8da7.diff
L
https://github.com/Stylie777 closed
https://github.com/llvm/llvm-project/pull/90614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
banach-space wrote:
Thank you for this contribution Paul!
> Many autotools-utilizing projects (mpich among them) fail to complete the
> configure step since it tries to invoke the (unknown to them) Fortran
> compiler always with the -fallow-argument-mismatch flag.
It sounds like an issue with
https://github.com/banach-space approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/91660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/91567
>From ca2b9d52d31866a657e2eb19585cdcd11bcad7d3 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Thu, 9 May 2024 00:28:33 -0700
Subject: [PATCH 1/2] [Clang] Pass -fseparate-named-sections from the driver
This is
Author: Petr Hosek
Date: 2024-05-10T00:38:52-07:00
New Revision: 5d24217c2c1c06358168cae65d3ff8632b28cd7d
URL:
https://github.com/llvm/llvm-project/commit/5d24217c2c1c06358168cae65d3ff8632b28cd7d
DIFF:
https://github.com/llvm/llvm-project/commit/5d24217c2c1c06358168cae65d3ff8632b28cd7d.diff
LO
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/91567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
LGTM, but someone else should take a look as well.
https://github.com/llvm/llvm-project/pull/91692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/85564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/91712
Remove FormatToken::isSimpleTypeSpecifier() and call
Token::isSimpleTypeSpecifier(LangOpts) instead.
>From 3e0b10020d15c102e050ad3785622bef01d1c075 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 10 May 2024
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Remove FormatToken::isSimpleTypeSpecifier() and call
Token::isSimpleTypeSpecifier(LangOpts) instead.
---
Patch is 29.50 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-proje
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/87208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/87208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -135,6 +135,21 @@ TEST(IncludeCleaner, GetUnusedHeaders) {
Pointee(writtenInclusion("\"dir/unused.h\"";
}
+TEST(IncludeCleaner, SystemUnusedHeaders) {
+ auto TU = TestTU::withCode(R"cpp(
+#include
+#include
+SystemClass x;
+ )c
@@ -254,6 +254,10 @@ struct Fragment {
/// unused or missing. These can match any suffix of the header file in
/// question.
std::vector> IgnoreHeader;
+
+ /// If false (default), unused system headers will be ignored.
+ /// Standard library headers
@@ -572,32 +572,43 @@ struct FragmentCompiler {
#else
static llvm::Regex::RegexFlags Flags = llvm::Regex::NoFlags;
#endif
-auto Filters = std::make_shared>();
-for (auto &HeaderPattern : F.IgnoreHeader) {
- // Anchor on the right.
- std::string AnchoredPat
@@ -114,6 +114,7 @@ struct Config {
/// these regexes.
struct {
std::vector> IgnoreHeader;
+ bool AnalyzeSystemHeaders = false;
kadircet wrote:
can you move the comment about regexes near `IgnoreHeader`.
Also I think `AnalyzeAngledIncludes
@@ -62,15 +64,6 @@ issueIncludeCleanerDiagnostics(ParsedAST &AST,
llvm::StringRef Code,
const ThreadsafeFS &TFS,
HeaderFilter IgnoreHeader = {});
-/// Affects whether standard library includes should be considered
@@ -572,32 +572,43 @@ struct FragmentCompiler {
#else
static llvm::Regex::RegexFlags Flags = llvm::Regex::NoFlags;
#endif
-auto Filters = std::make_shared>();
-for (auto &HeaderPattern : F.IgnoreHeader) {
- // Anchor on the right.
- std::string AnchoredPat
@@ -135,6 +135,21 @@ TEST(IncludeCleaner, GetUnusedHeaders) {
Pointee(writtenInclusion("\"dir/unused.h\"";
}
+TEST(IncludeCleaner, SystemUnusedHeaders) {
+ auto TU = TestTU::withCode(R"cpp(
+#include
+#include
+SystemClass x;
+ )c
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/91713
None
>From 035363d336a9b115d5584efe01733cb1b76792c4 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 10 May 2024 16:28:06 +0800
Subject: [PATCH] [clang-tidy] use llvm::any_of refactor
getAnalyzerCheck
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91713.diff
1 Files Affected:
- (modified) clang-tools-extra/clang-tidy/ClangTidy.cpp (+5-5)
cor3ntin wrote:
This breaks the build, I'll push a fix shortly.
https://github.com/llvm/llvm-project/pull/91199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -954,9 +954,18 @@ void readGnuProperty(const InputSection &sec,
ObjFile &f) {
continue;
}
-uint32_t featureAndType = config->emachine == EM_AARCH64
- ? GNU_PROPERTY_AARCH64_FEATURE_1_AND
- : GN
@@ -7884,10 +7902,11 @@ template void
LLVMELFDumper::printNotes() {
W.printString("Type",
"Unknown (" + to_string(format_hex(Type, 10)) + ")");
+uint16_t Target = this->Obj.getHeader().e_machine;
yetingk wrote:
Is it better to
@@ -7884,10 +7902,11 @@ template void
LLVMELFDumper::printNotes() {
W.printString("Type",
"Unknown (" + to_string(format_hex(Type, 10)) + ")");
+uint16_t Target = this->Obj.getHeader().e_machine;
yetingk wrote:
Move this defini
kadircet wrote:
thanks for the patch! this definitely LGTM at high level.
as you folks also pointed out we don't want to surface analysis for angled
includes in general, as include-cleaner doesn't have support for system headers
yet (we wanted to have something similar to Stdlib includes, whic
SLTozer wrote:
It looks like this is causing crashes when including precompiled headers that
contain optnone functions; this can be reproduced with a very short header file
and any source file, even a completely empty one. Reproducer follows:
```
$ cat header.h
__attribute__((optnone)) void foo
https://github.com/hokein commented:
The fix looks good to me, and thanks for the comprehensive explanation in the
description.
https://github.com/llvm/llvm-project/pull/91628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/91628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -84,3 +84,17 @@ nested_init_list::concept_fail nil_invalid{1, ""};
// expected-note@#INIT_LIST_INNER_INVALID {{candidate template ignored:
substitution failure [with F = const char *]: constraints not satisfied for
class template 'concept_fail' [with F = const char *]}}
//
@@ -2583,11 +2580,27 @@ struct ConvertConstructorToDeductionGuideTransform {
//-- The types of the function parameters are those of the constructor.
for (auto *OldParam : TL.getParams()) {
- ParmVarDecl *NewParam =
- transformFunctionTypeParam(OldPara
https://github.com/ivanmurashko edited
https://github.com/llvm/llvm-project/pull/91645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -188,6 +188,8 @@ struct Config {
StringRef zBtiReport = "none";
StringRef zCetReport = "none";
StringRef zPauthReport = "none";
+ llvm::StringRef zZicfilpReport = "none";
yetingk wrote:
Use `StringRef` instead of `llvm::StringRef`.
https://github.co
yetingk wrote:
I am sorry that I missed the commit for a long time. Very sorry about it.
https://github.com/llvm/llvm-project/pull/77414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Tomas Matheson
Date: 2024-05-10T09:57:06+01:00
New Revision: e6d29be566d19a6558597ed1ede4783e85485749
URL:
https://github.com/llvm/llvm-project/commit/e6d29be566d19a6558597ed1ede4783e85485749
DIFF:
https://github.com/llvm/llvm-project/commit/e6d29be566d19a6558597ed1ede4783e85485749.diff
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/91718
We stacked allocated an OpaqueExpr that woukd be used after it was destroyed.
>From fe25f0455d84ea3fd0d8dd988be6ae907f6661c2 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 10 May 2024 10:55:20 +0200
S
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
We stack allocated an OpaqueExpr that woukd be used after it was destroyed.
---
Full diff: https://github.com/llvm/llvm-project/pull/91718.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaExprCXX.cpp (+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5d24217c2c1c06358168cae65d3ff8632b28cd7d
fe25f0455d84ea3fd0d8dd988be6ae907f6661c2 --
https://github.com/Endilll approved this pull request.
LGTM
You should leave a link in the description to the buildbot failure you're
addressing.
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91718
>From fe25f0455d84ea3fd0d8dd988be6ae907f6661c2 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 10 May 2024 10:55:20 +0200
Subject: [PATCH 1/2] [Clang] Fix Undefined Behavior introduced by #91199
We sta
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/91445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/91445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Merging that now to fix CI (hopefully)
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2024-05-10T11:15:26+02:00
New Revision: fc57f88f007497a4ead0ec8607ac66e1847b02d6
URL:
https://github.com/llvm/llvm-project/commit/fc57f88f007497a4ead0ec8607ac66e1847b02d6
DIFF:
https://github.com/llvm/llvm-project/commit/fc57f88f007497a4ead0ec8607ac66e1847b02d6.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/91718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/91445
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,196 @@
+//===-- SetgidSetuidOrderChecker.cpp - check privilege revocation calls
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/NagyDonat commented:
You forgot to add `CDM::CLibrary` in the definition of `SetuidDesc` and
`SetgidDesc` (see the new inline comment).
There are also several inline comments from my previous review where I'm
expecting an answer (not necessarily a code change -- in each case
@@ -0,0 +1,197 @@
+//===-- SetgidSetuidOrderChecker.cpp - check privilege revocation calls
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/91531
From 07dc4dd5c60c8a04637cce686b379e195deb5b67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 8 May 2024 20:01:57 +0200
Subject: [PATCH 1/2] [analyzer] Refactor recognition of the errno
https://github.com/momchil-velikov commented:
LGTM, cheers!
https://github.com/llvm/llvm-project/pull/90105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,10 +39,15 @@ namespace {
// Name of the "errno" variable.
// FIXME: Is there a system where it is not called "errno" but is a variable?
const char *ErrnoVarName = "errno";
+
// Names of functions that return a location of the "errno" value.
// FIXME: Are there other si
@@ -54,16 +59,10 @@ class ErrnoModeling
void checkLiveSymbols(ProgramStateRef State, SymbolReaper &SR) const;
bool evalCall(const CallEvent &Call, CheckerContext &C) const;
- // The declaration of an "errno" variable or "errno location" function.
- mutable const Decl *Er
NagyDonat wrote:
Thanks for the review, I updated my commit!
https://github.com/llvm/llvm-project/pull/91531
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -71,12 +71,9 @@ ProgramStateRef setErrnoState(ProgramStateRef State,
ErrnoCheckState EState);
/// Clear state of errno (make it irrelevant).
ProgramStateRef clearErrnoState(ProgramStateRef State);
-/// Determine if a `Decl` node related to 'errno'.
-/// This is true if the
https://github.com/simonzgx created
https://github.com/llvm/llvm-project/pull/91720
None
>From d0cde98f5e933c6f88703a55986f6cc508721fdc Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Xu Zhang (simonzgx)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91720.diff
3 Files Affected:
- (modified) clang/include/clang/Basic/Attr.td (+4-1)
- (added) clang/test/CodeGen/attr-ms-noinline.cpp (+53)
- (added)
https://github.com/simonzgx converted_to_draft
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From d0cde98f5e933c6f88703a55986f6cc508721fdc Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/momchil-velikov closed
https://github.com/llvm/llvm-project/pull/88553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mydeveloperday approved this pull request.
I think this will stop people introducing extra arguments to function
...isCpp,isThis,isThat)
LGTM
https://github.com/llvm/llvm-project/pull/91712
___
cfe-commits mailing list
cfe-commits@
llvmbot wrote:
@llvm/pr-subscribers-debuginfo
Author: Stephen Tozer (SLTozer)
Changes
This patch makes the final major change of the RemoveDIs project, changing the
default IR output from debug intrinsics to debug records.
This is expected to break a large number of tests: every single o
Author: Momchil Velikov
Date: 2024-05-10T11:57:08+01:00
New Revision: 2371a6410dd83e82862e1c4dce1f7411efbe6b1c
URL:
https://github.com/llvm/llvm-project/commit/2371a6410dd83e82862e1c4dce1f7411efbe6b1c
DIFF:
https://github.com/llvm/llvm-project/commit/2371a6410dd83e82862e1c4dce1f7411efbe6b1c.dif
https://github.com/momchil-velikov closed
https://github.com/llvm/llvm-project/pull/88105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -74,9 +73,13 @@ REGISTER_TRAIT_WITH_PROGRAMSTATE(ErrnoRegion, const
MemRegion *)
REGISTER_TRAIT_WITH_PROGRAMSTATE(ErrnoState, errno_modeling::ErrnoCheckState)
-/// Search for a variable called "errno" in the AST.
-/// Return nullptr if not found.
-static const VarDecl *ge
@@ -226,6 +236,10 @@ def run_clang_tidy(self):
print("--")
return clang_tidy_output
+def check_no_diagnosis(self, clang_tidy_output):
+if clang_tidy_output != "":
+sys.exit
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/91531
From 07dc4dd5c60c8a04637cce686b379e195deb5b67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 8 May 2024 20:01:57 +0200
Subject: [PATCH 1/3] [analyzer] Refactor recognition of the errno
https://github.com/5chmidti approved this pull request.
https://github.com/llvm/llvm-project/pull/91713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -136,53 +100,48 @@ void ErrnoModeling::checkBeginFunction(CheckerContext &C)
const {
ASTContext &ACtx = C.getASTContext();
ProgramStateRef State = C.getState();
- if (const auto *ErrnoVar = dyn_cast_or_null(ErrnoDecl)) {
-// There is an external 'errno' variable.
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/91531
From 07dc4dd5c60c8a04637cce686b379e195deb5b67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Wed, 8 May 2024 20:01:57 +0200
Subject: [PATCH 1/4] [analyzer] Refactor recognition of the errno
@@ -136,53 +100,48 @@ void ErrnoModeling::checkBeginFunction(CheckerContext &C)
const {
ASTContext &ACtx = C.getASTContext();
ProgramStateRef State = C.getState();
- if (const auto *ErrnoVar = dyn_cast_or_null(ErrnoDecl)) {
-// There is an external 'errno' variable.
@@ -520,6 +524,18 @@ class alignas(IdentifierInfoAlignment) IdentifierInfo {
RecomputeNeedsHandleIdentifier();
}
+ /// Determine whether this is the contextual keyword \c module.
+ bool isModulesDecl() const { return IsModulesDecl; }
yronglin wrote:
@@ -1329,6 +1341,100 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name p
sam-mccall wrote:
This commit did three things: A) changed the implementation, B) changed the
flag default, and C) deprecated the flag.
Since clang now crashes on widely-used, real-world code, can we at least revert
C, and ideally B until the crashes are fixed?
(It would also have been helpfu
@@ -1329,6 +1341,100 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name p
@@ -932,6 +932,12 @@ def warn_module_conflict : Warning<
InGroup;
// C++20 modules
+def err_module_decl_cannot_be_macros : Error<
+ "the module name in a module%select{| partition}0 declaration cannot contain
"
+ "an object-like macro %1, it's consists of one or more iden
@@ -520,6 +524,18 @@ class alignas(IdentifierInfoAlignment) IdentifierInfo {
RecomputeNeedsHandleIdentifier();
}
+ /// Determine whether this is the contextual keyword \c module.
+ bool isModulesDecl() const { return IsModulesDecl; }
+
+ /// Set whether this identif
Author: Qizhi Hu
Date: 2024-05-10T20:14:08+08:00
New Revision: 200f3bd39562f4d605f13567398025d30fa27d61
URL:
https://github.com/llvm/llvm-project/commit/200f3bd39562f4d605f13567398025d30fa27d61
DIFF:
https://github.com/llvm/llvm-project/commit/200f3bd39562f4d605f13567398025d30fa27d61.diff
LOG:
https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/91430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I don't think there is motivation to revert anything at this point (we should
avoid churn), however I do agree this is a regression that we should fix
quickly @mizvekov.
(Even if it's not a new bug, it is a newly exposed bug, the pain for users is
the same)
If the fix takes a
erichkeane wrote:
This patch doesn't really make sense to me. Why would we want
`__builtin_launder` to work on incomplete types?
https://github.com/llvm/llvm-project/pull/91070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/momchil-velikov updated
https://github.com/llvm/llvm-project/pull/91606
>From d3e381ac645d08b6f3b01283d47344556a163605 Mon Sep 17 00:00:00 2001
From: Momchil Velikov
Date: Thu, 9 May 2024 15:56:31 +0100
Subject: [PATCH] [AArch64] Add intrinsics for multi-vector to ZA array ve
Endilll wrote:
It'd also be nice if someone can share a reproducer that crashes on trunk but
not on 18.1.0 without names reduced to 1-2 letters. Definitely would speed up
the work towards the fix.
https://github.com/llvm/llvm-project/pull/89807
___
c
cor3ntin wrote:
Having a clean reduction to decide whether the code is supposed to compile or
not is indeed a good first step.
Clang 18 was not conforming and people might have relied on it.
There is a -fno-relaxed-template-template-args that can be used as a
workaround for now
https://gith
erichkeane wrote:
I agree with @sam-mccall : I think "crashes on some widely-used real-world
code" means we should revert `B` until we can make that case work. Yes, it is
a pre-existing issue, however it means that we aren't "ready" to change the
flag default.
However, we DEFINITELY need a u
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/91628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> If you're using `creduce`, this set of arguments disables all renaming
> passes: `--remove-pass pass_clang rename-fun --remove-pass pass_clang
> rename-param --remove-pass pass_clang rename-var --remove-pass pass_clang
> rename-class --remove-pass pass_clang rename-cxx-meth
cor3ntin wrote:
The committee says so
Because launder is just adding a fence on a pointer to T, we need not know what
T is.
I don't know whether there are scenarios where calling launder on an incomplete
type would be useful (as presumably you would new an object right before which
would req
@@ -0,0 +1,55 @@
+/*=== __clang_hip_device_macro_guards.h - guards for HIP device macros -===
+ *
+ * Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+ * See https://llvm.org/LICENSE.txt for license information.
+ * SPDX-License-Identifier: Apach
erichkeane wrote:
> The committee says so
>
> Because launder is just adding a fence on a pointer to T, we need not know
> what T is.
>
> I don't know whether there are scenarios where calling launder on an
> incomplete type would be useful (as presumably you would new an object right
> befo
erichkeane wrote:
> Should we try to force an instantiation in codegen for
> complete-but-not-yet-instantiated classes?
I think we have to here. I believe we can do this by changing the
`RequireCompleteType` to pass a null `diagnoser`.
See this overload:
https://clang.llvm.org/doxygen/cla
@@ -2583,11 +2580,27 @@ struct ConvertConstructorToDeductionGuideTransform {
//-- The types of the function parameters are those of the constructor.
for (auto *OldParam : TL.getParams()) {
- ParmVarDecl *NewParam =
- transformFunctionTypeParam(OldPara
1 - 100 of 337 matches
Mail list logo
