[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

2023-11-23 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @capfredf, can you rebase the PR to trigger a rebuild - the test failure seems unrelated to our changes but maybe it was fixed meanwhile. https://github.com/llvm/llvm-project/pull/67349 ___ cfe-commits mailing list cfe-commits@lists.

[libcxx] [libcxxabi] [lld] [compiler-rt] [clang] [llvm] [clang-tools-extra] [libc] [libunwind] [flang] [PowerPC] Combine sub within setcc back to sext (PR #66978)

2023-11-23 Thread Kai Luo via cfe-commits
@@ -14428,15 +14431,53 @@ SDValue PPCTargetLowering::combineSetCC(SDNode *N, // x != 0-y --> x+y != 0 if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) && RHS.hasOneUse()) { - SDLoc DL(N); - SelectionDAG &DAG = DCI.DAG; - EVT VT

[libcxx] [libcxxabi] [lld] [compiler-rt] [clang] [llvm] [clang-tools-extra] [libc] [libunwind] [flang] [PowerPC] Combine sub within setcc back to sext (PR #66978)

2023-11-23 Thread Kai Luo via cfe-commits
https://github.com/bzEq edited https://github.com/llvm/llvm-project/pull/66978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] ms inline asm: Fix {call,jmp} fptr (PR #73207)

2023-11-23 Thread Shengchen Kan via cfe-commits
KanRobert wrote: Investigating, I almost forgot the mechanism of MS inline asm support... https://github.com/llvm/llvm-project/pull/73207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[libcxx] [libcxxabi] [lld] [compiler-rt] [clang] [llvm] [clang-tools-extra] [libc] [libunwind] [flang] [PowerPC] Combine sub within setcc back to sext (PR #66978)

2023-11-23 Thread Kai Luo via cfe-commits
@@ -14428,15 +14431,53 @@ SDValue PPCTargetLowering::combineSetCC(SDNode *N, // x != 0-y --> x+y != 0 if (RHS.getOpcode() == ISD::SUB && isNullConstant(RHS.getOperand(0)) && RHS.hasOneUse()) { - SDLoc DL(N); - SelectionDAG &DAG = DCI.DAG; - EVT VT

[clang] [clang] Add partial-inlining options (PR #73210)

2023-11-23 Thread via cfe-commits
https://github.com/Jolyon0202 updated https://github.com/llvm/llvm-project/pull/73210 >From d5679e5dba708e8a54c63d63f3da6c92a6cf0aeb Mon Sep 17 00:00:00 2001 From: Jian Yang Date: Thu, 23 Nov 2023 12:54:52 +0800 Subject: [PATCH] [clang] Add partial-inlining options Adaptation of adding -fparti

[clang] [clang][AST][ASTMerge] prevent AST nodes from being deallocated early (PR #73096)

2023-11-23 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > > Debug the #72783 can prove it. Address interval (local from 0x3a9a00 to > > 0x3aaa00) allocated by allocator contains a IdentifierInfo variable (local > > address:0x3aa190) whose address is freed early. > > In this case, it looks better to extract the use-after-free variable

[clang] [clang-format] Fix a bug in formating `#define A x:` (PR #73220)

2023-11-23 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/73220 Fixed #70789. >From 0a8459053be654313efff8002ff3e171d8cd9d18 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 23 Nov 2023 00:41:41 -0800 Subject: [PATCH] [clang-format] Fix a bug in formating `#define A x:` Fi

[clang] [clang-format] Fix a bug in formating `#define A x:` (PR #73220)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixed #70789. --- Full diff: https://github.com/llvm/llvm-project/pull/73220.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+7) - (modified) clang/unittests/Format/FormatT

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Björn Svensson via cfe-commits
https://github.com/bjosv updated https://github.com/llvm/llvm-project/pull/73119 From 91cf412abcfd231ab399c3e44c6a9bc14109537c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Svensson?= Date: Tue, 21 Nov 2023 23:30:07 +0100 Subject: [PATCH 1/2] [clang-tidy] Add check hicpp-ignored-remove-r

[clang] [clang] Add missing LinkageSpec case to getCursorKindForDecl (PR #72401)

2023-11-23 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: It should, yes. https://github.com/llvm/llvm-project/pull/72401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: C++ empty record with align lead to va_list out of sync (PR #72197)

2023-11-23 Thread via cfe-commits
https://github.com/hstk30-hw edited https://github.com/llvm/llvm-project/pull/72197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix: C++ empty record with align lead to va_list out of sync (PR #72197)

2023-11-23 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/72197 >From 18c2151e870b757fe3238cc4031597352ecc440e Mon Sep 17 00:00:00 2001 From: hstk30-hw Date: Sat, 18 Nov 2023 11:00:29 + Subject: [PATCH] fix: empty record size > 64 with align let va_list get out of sync

[clang] [clang][analyzer] Move `security.cert.env.InvalidPtr` out of `alpha` (PR #71912)

2023-11-23 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/71912 From 977e421008c1247d54f4cb67967ed2a353935c03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Fri, 10 Nov 2023 10:08:58 +0100 Subject: [PATCH 1/3] [analyzer] Move security.cert.env.Inva

[clang] [Driver][MachineOutliner] Support -moutline option for aarch64_be (PR #73223)

2023-11-23 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 created https://github.com/llvm/llvm-project/pull/73223 This patch propagates the -moutline flag when target is aarch64_be, fix warning: 'aarch64_be' does not support '-moutline'; flag ignored [-Woption-ignored] >From 1492725fb3bb60f400264f718972ce249ec3eda8

[clang] [Driver][MachineOutliner] Support -moutline option for aarch64_be (PR #73223)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: dong jianqiang (dongjianqiang2) Changes This patch propagates the -moutline flag when target is aarch64_be, fix warning: 'aarch64_be' does not support '-moutline'; flag ignored [-Woption-ignored] --- Full diff: https://github.com/

[clang] [clang][analyzer] Move `security.cert.env.InvalidPtr` out of `alpha` (PR #71912)

2023-11-23 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/71912 From 80c1f88244b22aaa4badb26384a971d19759b660 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Fri, 10 Nov 2023 10:08:58 +0100 Subject: [PATCH 1/3] [analyzer] Move security.cert.env.Inva

[clang] [clang][analyzer] Move `security.cert.env.InvalidPtr` out of `alpha` (PR #71912)

2023-11-23 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: cleaned up the commiter email, as it was pointing to an old address https://github.com/llvm/llvm-project/pull/71912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/72627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -101,6 +101,30 @@ void error_fwrite(void) { Ret = fwrite(0, 1, 10, F); // expected-warning {{Stream might be already closed}} } +void error_fgetc(void) { + FILE *F = tmpfile(); + if (!F) +return; + int Ret = fgetc(F); + if (0 <= Ret && Ret <= 255) { +clang_an

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -259,14 +283,33 @@ void error_indeterminate_clearerr(void) { fclose(F); } +void error_indeterminate_fgetc(void) { + FILE *F = fopen("file", "r+"); + if (!F) +return; + int rc = fseek(F, 0, SEEK_SET); + if (rc) { +if (feof(F)) { balazske wrote:

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -303,3 +346,29 @@ void error_indeterminate_feof2(void) { } fclose(F); } + +void error_indeterminate_feof3(void) { + FILE *F = fopen("file", "r+"); + if (!F) +return; + if (fgetc(F) == EOF) { +if (feof(F)) { + // error is feof, should be non-indeterminate

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
https://github.com/balazske requested changes to this pull request. https://github.com/llvm/llvm-project/pull/72627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -303,3 +346,29 @@ void error_indeterminate_feof2(void) { } fclose(F); } + +void error_indeterminate_feof3(void) { balazske wrote: This test seems to be not necessary (previous tests cover these conditions), otherwise a more meaningful name should be ch

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -259,14 +283,33 @@ void error_indeterminate_clearerr(void) { fclose(F); } +void error_indeterminate_fgetc(void) { + FILE *F = fopen("file", "r+"); + if (!F) +return; + int rc = fseek(F, 0, SEEK_SET); + if (rc) { +if (feof(F)) { + clang_analyzer_warnIfReac

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -101,6 +101,30 @@ void error_fwrite(void) { Ret = fwrite(0, 1, 10, F); // expected-warning {{Stream might be already closed}} } +void error_fgetc(void) { + FILE *F = tmpfile(); + if (!F) +return; + int Ret = fgetc(F); + if (0 <= Ret && Ret <= 255) { +clang_an

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
@@ -768,26 +772,65 @@ void StreamChecker::evalFputc(const FnDescription *Desc, const CallEvent &Call, assertStreamStateOpened(OldSS); + // `fgetc` returns the read character on success, otherwise returns EOF. // `fputc` returns the written character on success, otherwi

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Bj=C3=B6rn?= Svensson Message-ID: In-Reply-To: @@ -41,6 +42,15 @@ #include "NoAssemblerCheck.h" #include "SignedBitwiseCheck.h" +namespace { + +// Checked functions for hicpp-ignored-remove-result. +const llvm::StringRef CheckedFunctions = "::std::remove;" ---

[llvm] [flang] [compiler-rt] [libcxx] [mlir] [clang] [libc] [AMDGPU] Define new targets gfx1200 and gfx1201 (PR #73133)

2023-11-23 Thread Jay Foad via cfe-commits
https://github.com/jayfoad updated https://github.com/llvm/llvm-project/pull/73133 >From 1011b8e7da174146dfb4c9a4bf54468ea021 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Tue, 21 Nov 2023 15:46:04 + Subject: [PATCH 1/2] [AMDGPU] Define new targets gfx1200 and gfx1201 Define target nam

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Björn?= Svensson Message-ID: In-Reply-To: @@ -107,6 +119,14 @@ class HICPPModule : public ClangTidyModule { CheckFactories.registerCheck( "hicpp-vararg"); } + + ClangTidyOptions getModuleOptions() override { +ClangTidyOptions Options; +ClangT

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Björn?= Svensson Message-ID: In-Reply-To: @@ -226,6 +226,7 @@ Clang-Tidy Checks :doc:`google-runtime-operator `, :doc:`google-upgrade-googletest-case `, "Yes" :doc:`hicpp-exception-baseclass `, + :doc:`hicpp-ignored-remove-result `, Pio

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Björn?= Svensson Message-ID: In-Reply-To: https://github.com/PiotrZSL commented: Looks fine, as we got already such checks that are and are not aliases. But consider doing this as an actually separate check instead of using an alias functionality. Simply change original check, add o

[clang] [clang][Interp] Add inline descriptor to global variables (PR #72892)

2023-11-23 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72892 >From b5360dd44bd5d8f10287e0a3641b0846e051a5c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 20 Nov 2023 11:5

[clang] 272812c - Revert "[clang] Avoid memcopy for small structure with padding under -ftrivial-auto-var-init (#71677)"

2023-11-23 Thread Muhammad Omair Javaid via cfe-commits
Author: Muhammad Omair Javaid Date: 2023-11-23T15:45:00+05:00 New Revision: 272812c7e43d8a45f19ea7b4a3b2667e7fb9e67a URL: https://github.com/llvm/llvm-project/commit/272812c7e43d8a45f19ea7b4a3b2667e7fb9e67a DIFF: https://github.com/llvm/llvm-project/commit/272812c7e43d8a45f19ea7b4a3b2667e7fb9e6

[clang] [clang][AST][ASTMerge] prevent AST nodes from being deallocated early (PR #73096)

2023-11-23 Thread Balázs Kéri via cfe-commits
balazske wrote: You have found that reason for the crash is that references to `IdentifierInfo` are remaining in `OnDiskChainedHashTableGenerator` and previously deallocated by `ASTUnit` destruction? In this case why is the `ASTUnit` (or something in it, probably `ASTContext`) the owner of the

[clang] [clang][ASTImporter] Fix import of variable template redeclarations. (PR #72841)

2023-11-23 Thread Balázs Kéri via cfe-commits
balazske wrote: I plan to fix import of `VarTemplateSpecializationDecl` in a different PR. The indicated assertion "Missing call to MapImported?" is likely to related to this part. https://github.com/llvm/llvm-project/pull/72841 ___ cfe-commits maili

[flang] [clang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space commented: Makes sense, but the summary should document when exactly the alias analysis is enabled/disabled. And the relationship between `-f{no}-alias-analysis` and the optimisation flags. Could you also add a note whether the implemented behaviour is consiste

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
@@ -242,10 +242,24 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts, clang::driver::options::OPT_fno_loop_versioning, false)) opts.LoopVersioning = 1; - opts.AliasAnalysis = - args.hasFlag(clang::driver::options::OPT_falias_

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis, + options::OP

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Tom Eccles via cfe-commits
@@ -242,10 +242,24 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts, clang::driver::options::OPT_fno_loop_versioning, false)) opts.LoopVersioning = 1; - opts.AliasAnalysis = - args.hasFlag(clang::driver::options::OPT_falias_

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
@@ -242,10 +242,24 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts, clang::driver::options::OPT_fno_loop_versioning, false)) opts.LoopVersioning = 1; - opts.AliasAnalysis = - args.hasFlag(clang::driver::options::OPT_falias_

[llvm] [clang] [flang] [Flang] Add code-object-version option (PR #72638)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/72638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [llvm] [clang] [Flang] Add code-object-version option (PR #72638)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
@@ -85,6 +85,19 @@ class CodeGenOptions : public CodeGenOptionsBase { RK_WithPattern, // Remark pattern specified via '-Rgroup=regexp'. }; + /// \brief Enumeration value for AMDGPU code object version, which is the + /// code object version times 100. + enum class Cod

[flang] [clang] [llvm] [Flang] Add code-object-version option (PR #72638)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
@@ -121,6 +121,16 @@ namespace llvm { Never, }; + /// \brief Enumeration value for AMDGPU code object version, which is the + /// code object version times 100. banach-space wrote: [nit] ```suggestion /// \brief Enumeration value for AMDGPU code ob

[clang] [llvm] [flang] [Flang] Add code-object-version option (PR #72638)

2023-11-23 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. Thanks for addressing my comments, the driver changes LGTM! Please wait for other reviewers to approve before landing this. In particular, I am not qualified to tell whether the bits specific to AMD GPUs are correct :) https://gith

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Tom Eccles via cfe-commits
@@ -242,10 +242,24 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts, clang::driver::options::OPT_fno_loop_versioning, false)) opts.LoopVersioning = 1; - opts.AliasAnalysis = - args.hasFlag(clang::driver::options::OPT_falias_

[clang] [clang-format] Fix a bug in formating `#define A x:` (PR #73220)

2023-11-23 Thread Björn Schäpers via cfe-commits
@@ -1171,6 +1171,13 @@ void UnwrappedLineParser::parsePPDefine() { assert((int)Line->PPLevel >= 0); Line->InMacroBody = true; + if (FormatTok->is(tok::identifier) && + Tokens->peekNextToken()->is(tok::colon)) { +nextToken(); +nextToken(); +addUnwrappedLin

[clang] [SystemZ] Move new test into existing CodeGen test. (PR #73230)

2023-11-23 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 created https://github.com/llvm/llvm-project/pull/73230 The test for emitted alignments is better placed in CodeGen. >From 72e252610893f919d25916b800d2afd1f8b0b9a4 Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Thu, 23 Nov 2023 12:33:11 +0100 Subject: [PATCH]

[clang] [SystemZ] Move new test into existing CodeGen test. (PR #73230)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Jonas Paulsson (JonPsson1) Changes The test for emitted alignments is better placed in CodeGen. --- Full diff: https://github.com/llvm/llvm-project/pull/73230.diff 2 Files Affected: - (modified) clang/

[clang] [clang] Ensure minimal alignment of global vars of incomplete type. (PR #72886)

2023-11-23 Thread Jonas Paulsson via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: %clang --target=s390x-linux -S -emit-llvm -o - %s | FileCheck %s JonPsson1 wrote: Sorry, my bad. There is a SystemZ test for this already, so I moved these tests into it instead. I created a new PR: https://github.com/llvm/llvm-project

[clang] [SystemZ] Move new test into existing CodeGen test. (PR #73230)

2023-11-23 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Moving recently added tests from Driver to CodeGen, per discussion for original PR (https://github.com/llvm/llvm-project/pull/72886). https://github.com/llvm/llvm-project/pull/73230 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Tom Eccles via cfe-commits
@@ -142,6 +142,26 @@ void Flang::addCodegenOptions(const ArgList &Args, if (shouldLoopVersion(Args)) CmdArgs.push_back("-fversion-loops-for-stride"); + Arg *aliasAnalysis = Args.getLastArg(options::OPT_falias_analysis, + options::OP

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Björn Svensson via cfe-commits
bjosv wrote: Great, I'll have a go at it to move it into a separate check. I used `cert-err33-c` as a blueprint and maybe that check can be updated later as well if we find a good model. https://github.com/llvm/llvm-project/pull/73119 ___ cfe-commits

[clang] [Driver] Add support for -export-dynamic which can match GCC behavior. (PR #72781)

2023-11-23 Thread dong jianqiang via cfe-commits
dongjianqiang2 wrote: > export-dynamic In that case, we have got to change `-exxx` to `-e xxx`, and `-export-dynamic` to `-rdynamic`. LGTM, and it follows GCC's official documented spec : ) https://github.com/llvm/llvm-project/pull/72781 ___ cfe-comm

[clang] [Clang] Improve support for expression messages in `static_assert` (PR #73234)

2023-11-23 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/73234 - Support non-member functions and callable objects for size and data(). We previously tried to (badly) pick the best overload ourselves, in a way that would only support member functions. We now leave clamg co

[clang] [Clang] Improve support for expression messages in `static_assert` (PR #73234)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes - Support non-member functions and callable objects for size and data(). We previously tried to (badly) pick the best overload ourselves, in a way that would only support member functions. We now leave clamg co

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Tom Eccles via cfe-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/73111 >From 617d6d23b2f861cd6dceb82f54a2685059b6 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Thu, 14 Sep 2023 09:09:29 + Subject: [PATCH 1/6] [flang] Enable alias tags pass by default Enable by default when o

[clang] [Clang] Improve support for expression messages in `static_assert` (PR #73234)

2023-11-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c43c88501e3bc273a7c1074a19e86dc305ad7234 c8f8e6d0a88b9fd1d905ca0a09ffe6e0415ab90e --

[clang] [Driver] Allow -e entry but reject -eentry (PR #72804)

2023-11-23 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/72804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Improve support for expression messages in `static_assert` (PR #73234)

2023-11-23 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/73234 >From c274d62d03e1ab390284b26d6e23a23d099a98f6 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 23 Nov 2023 12:51:46 +0100 Subject: [PATCH] [Clang] Improve support for expression messages in `static_ass

[clang] [llvm] [SystemZ][z/OS] This change adds support for the PPA2 section in zOS (PR #68926)

2023-11-23 Thread Ulrich Weigand via cfe-commits
@@ -1026,6 +1030,72 @@ void SystemZAsmPrinter::emitADASection() { OutStreamer->popSection(); } +static std::string getProductID(Module &M) { + std::string ProductID; + if (auto *MD = M.getModuleFlag("zos_product_id")) +ProductID = cast(MD)->getString().str(); + if (Pr

[clang] [Driver][MachineOutliner] Support -moutline option for aarch64_be (PR #73223)

2023-11-23 Thread dong jianqiang via cfe-commits
https://github.com/dongjianqiang2 updated https://github.com/llvm/llvm-project/pull/73223 >From 5742f71b9077a038cfefe4c74290d7e9d2f42d3f Mon Sep 17 00:00:00 2001 From: dong jianqiang Date: Thu, 23 Nov 2023 16:58:11 +0800 Subject: [PATCH] [Driver][MachineOutliner] Support outlining option with L

[clang] [SystemZ] Move new test into existing CodeGen test. (PR #73230)

2023-11-23 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/73230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 521b468 - [SystemZ] Move new test into existing CodeGen test. (#73230)

2023-11-23 Thread via cfe-commits
Author: Jonas Paulsson Date: 2023-11-23T13:27:05+01:00 New Revision: 521b4682a55eb735b75e08d5f71c8cbe47395e40 URL: https://github.com/llvm/llvm-project/commit/521b4682a55eb735b75e08d5f71c8cbe47395e40 DIFF: https://github.com/llvm/llvm-project/commit/521b4682a55eb735b75e08d5f71c8cbe47395e40.diff

[clang] [SystemZ] Move new test into existing CodeGen test. (PR #73230)

2023-11-23 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 closed https://github.com/llvm/llvm-project/pull/73230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-23 Thread via cfe-commits
https://github.com/lifengxiang1025 created https://github.com/llvm/llvm-project/pull/73236 Now MemProf can't do IR annotation right in the local linkage function and global initial function __cxx_global_var_init. In llvm-profdata which convert raw memory profile to memory profile, it uses func

[clang] [llvm] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (lifengxiang1025) Changes Now MemProf can't do IR annotation right in the local linkage function and global initial function __cxx_global_var_init. In llvm-profdata which convert raw memory profile to memory profile, it uses function

[llvm] [clang] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: None (lifengxiang1025) Changes Now MemProf can't do IR annotation right in the local linkage function and global initial function __cxx_global_var_init. In llvm-profdata which convert raw memory profile to memory profile, it use

[clang] [Clang] Improve support for expression messages in `static_assert` (PR #73234)

2023-11-23 Thread via cfe-commits
@@ -617,6 +617,9 @@ Bug Fixes in This Version - Fix crash during code generation of C++ coroutine initial suspend when the return type of await_resume is not trivially destructible. Fixes (`#63803 `_) +- Fix crash when the

[llvm] [clang] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-23 Thread via cfe-commits
https://github.com/lifengxiang1025 updated https://github.com/llvm/llvm-project/pull/73236 >From fdce13021329985b7c3cb8748ee4f8f7f83a2730 Mon Sep 17 00:00:00 2001 From: lifengxiang Date: Thu, 23 Nov 2023 20:32:25 +0800 Subject: [PATCH] [MemProf] Expand optimization scope to internal linakge fu

[llvm] [clang] [MemProf] Expand optimization scope to internal linakge function (PR #73236)

2023-11-23 Thread via cfe-commits
lifengxiang1025 wrote: @teresajohnson Can you take a look and provide your insights? I'm learning how to write tests and will upload test cases soon. https://github.com/llvm/llvm-project/pull/73236 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [compiler-rt] [llvm] [lld] [libc] [flang] [libcxx] Fix ISel crash when lowering BUILD_VECTOR (PR #73186)

2023-11-23 Thread Simon Pilgrim via cfe-commits
@@ -7254,6 +7255,10 @@ static SDValue lowerBuildVectorAsBroadcast(BuildVectorSDNode *BVOp, EVT CVT = Ld.getValueType(); assert(!CVT.isVector() && "Must not broadcast a vector type"); +// 512 bit vpbroadcastw is only available with AVX512BW +if (ScalarSize == 1

[libcxx] [llvm] [compiler-rt] [libc] [lld] [clang] [flang] Fix ISel crash when lowering BUILD_VECTOR (PR #73186)

2023-11-23 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/73186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix sorting module headers (PR #73146)

2023-11-23 Thread Tulio Magno Quites Machado Filho via cfe-commits
https://github.com/tuliom updated https://github.com/llvm/llvm-project/pull/73146 >From d0a86b80256a45bfdee790a7aec5a48d2d71e6bb Mon Sep 17 00:00:00 2001 From: Tulio Magno Quites Machado Filho Date: Wed, 22 Nov 2023 14:01:24 -0300 Subject: [PATCH 1/3] [clang] Fix sorting module headers Struct

[clang] [clang] Fix sorting module headers (PR #73146)

2023-11-23 Thread Tulio Magno Quites Machado Filho via cfe-commits
https://github.com/tuliom edited https://github.com/llvm/llvm-project/pull/73146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix sorting module headers (PR #73146)

2023-11-23 Thread Tulio Magno Quites Machado Filho via cfe-commits
tuliom wrote: OK. I modified this PR in order to only make the changes that fix #73145 . Sorting will remain broken as it has been since 2021. I will provide another PR after this one gets merged. https://github.com/llvm/llvm-project/pull/73146 ___ cf

[clang] [flang] [flang] Enable alias tags pass by default (PR #73111)

2023-11-23 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/73111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/72627 >From 81973987254f037f1682b7f0cd7a970177051f04 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 17 Nov 2023 17:22:10 +0800 Subject: [PATCH] [clang][analyzer] Support `fgetc` in StreamChecker --- .../StaticAn

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/72627 >From 5c3cb2cfbb91ac462633aa223ebeecc1d7790138 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 17 Nov 2023 17:22:10 +0800 Subject: [PATCH] [clang][analyzer] Support `fgetc` in StreamChecker --- .../StaticAn

[clang] [clang][AArch64] Pass down stack clash protection options to LLVM/Backend (PR #68993)

2023-11-23 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/68993 >From 553f647e3f8460e376b8a09233b23a0bd6b12ead Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Wed, 11 Oct 2023 17:22:51 +0100 Subject: [PATCH 1/2] [clang][AArch64] Pass down stack clash protection o

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-23 Thread Mariya Podchishchaeva via cfe-commits
@@ -727,6 +729,44 @@ void InitListChecker::FillInEmptyInitForField(unsigned Init, FieldDecl *Field, if (hadError || VerifyOnly) { // Do nothing } else if (Init < NumInits) { Fznamznon wrote: It seems `Init < NumInits` is always true for non-`Ver

[clang-tools-extra] [llvm] [clang] [clang] Fix false positive -Wmissing-field-initializer for anonymous unions (PR #70829)

2023-11-23 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/70829 >From ac30780250875802d13450d17e6959f9e2ad3a70 Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Tue, 31 Oct 2023 09:27:51 -0700 Subject: [PATCH 1/5] [clang] Fix false positive -Wmissing-field-initi

[flang] [clang] [flang] Add runtimes using --dependent-lib on MSVC targets (PR #72519)

2023-11-23 Thread David Truby via cfe-commits
DavidTruby wrote: I've had to add it as just `-fc1` because of the way lit does argument passing on Windows (it puts the "flang-new" and "-fc1" in quotes, but only sometimes :)) https://github.com/llvm/llvm-project/pull/72519 __

[flang] [clang] [flang] Add runtimes using --dependent-lib on MSVC targets (PR #72519)

2023-11-23 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/72519 >From eeb1e7c7b7905d541c9359bd1800fdfb70f0219e Mon Sep 17 00:00:00 2001 From: David Truby Date: Thu, 16 Nov 2023 14:32:27 + Subject: [PATCH 1/3] [flang] Add runtimes using --dependent-lib on MSVC targets

[libc] [llvm] [libcxx] [compiler-rt] [flang] [lld] [clang] Fix ISel crash when lowering BUILD_VECTOR (PR #73186)

2023-11-23 Thread Phoebe Wang via cfe-commits
@@ -7254,6 +7255,10 @@ static SDValue lowerBuildVectorAsBroadcast(BuildVectorSDNode *BVOp, EVT CVT = Ld.getValueType(); assert(!CVT.isVector() && "Must not broadcast a vector type"); +// 512 bit vpbroadcastw is only available with AVX512BW +if (ScalarSize == 1

[clang] 0bc7cd4 - [flang] Add runtimes using --dependent-lib on MSVC targets (#72519)

2023-11-23 Thread via cfe-commits
Author: David Truby Date: 2023-11-23T14:19:57Z New Revision: 0bc7cd4d51226344a54da5929d87184730e73e83 URL: https://github.com/llvm/llvm-project/commit/0bc7cd4d51226344a54da5929d87184730e73e83 DIFF: https://github.com/llvm/llvm-project/commit/0bc7cd4d51226344a54da5929d87184730e73e83.diff LOG: [

[clang] [flang] [flang] Add runtimes using --dependent-lib on MSVC targets (PR #72519)

2023-11-23 Thread David Truby via cfe-commits
https://github.com/DavidTruby closed https://github.com/llvm/llvm-project/pull/72519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix `-Wdocumentation` warning (NFC) (PR #73243)

2023-11-23 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/73243 ``` llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: warning: parameter 'Modifier' not found in the function declaration [-Wdocumentation] /// \param Modifier The modifier applied to 'order' claus

[clang-tools-extra] [clang-tidy] Add check hicpp-ignored-remove-result (PR #73119)

2023-11-23 Thread Piotr Zegar via cfe-commits
=?utf-8?q?Björn?= Svensson Message-ID: In-Reply-To: PiotrZSL wrote: by separate check I mean "Create class that derive from oryginal check, move some code in oryginal check (config) to protected methods (mainly storeConfig) and just override config in parent class. SImply if you call --dump

[clang] [Clang] Fix `-Wdocumentation` warning (NFC) (PR #73243)

2023-11-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes ``` llvm-project/clang/include/clang/AST/OpenMPClause.h:7762:14: warning: parameter 'Modifier' not found in the function declaration [-Wdocumentation] /// \param Modifier The modifier applied to 'order' cla

[clang] [llvm] [AArch64] Stack probing for function prologues (PR #66524)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -1757,46 +1826,55 @@ void AArch64FrameLowering::emitPrologue(MachineFunction &MF, } } - StackOffset AllocateBefore = SVEStackSize, AllocateAfter = {}; + StackOffset SVECalleeSavedSize = {}, SVELocalsSize = SVEStackSize; MachineBasicBlock::iterator CalleeSavesBeg

[clang] [llvm] [AArch64] Stack probing for function prologues (PR #66524)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -0,0 +1,722 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple aarch64-none-eabi < %s -verify-machineinstrs | FileCheck %s +; RUN: llc -mtriple aarch64-none-eabi < %s -verify-machineinstrs -global-isel -global-isel-abort=2 |

[clang] [llvm] [AArch64] Stack probing for dynamic allocas in SelectionDAG (PR #66525)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -9461,6 +9462,94 @@ bool AArch64InstrInfo::isReallyTriviallyReMaterializable( return TargetInstrInfo::isReallyTriviallyReMaterializable(MI); } +MachineBasicBlock::iterator +AArch64InstrInfo::probedStackAlloc(MachineBasicBlock::iterator MBBI, momchil-velik

[libunwind] [libunwind][WebAssembly] Don't build libunwind.cpp (PR #73196)

2023-11-23 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/73196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AArch64] Stack probing for dynamic allocas in SelectionDAG (PR #66525)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -861,6 +861,12 @@ def AArch64stilp : SDNode<"AArch64ISD::STILP", SDT_AArch64stilp, [SDNPHasChain, def AArch64stnp : SDNode<"AArch64ISD::STNP", SDT_AArch64stnp, [SDNPHasChain, SDNPMayStore, SDNPMemOperand]>; def AArch64tbl : SDNode<"AArch64ISD::TBL", SDT_AArch64TBL>; + +de

[llvm] [clang] [AArch64] Stack probing for dynamic allocas in SelectionDAG (PR #66525)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -0,0 +1,363 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple aarch64-none-eabi < %s -verify-machineinstrs | FileCheck %s + +; Dynamically-sized allocation, needs a loop which can handle any size at +; runtime. The final iter

[clang] [clang][analyzer] Support `fgetc` in StreamChecker (PR #72627)

2023-11-23 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. https://github.com/llvm/llvm-project/pull/72627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libc] [llvm] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2023-11-23 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm updated https://github.com/llvm/llvm-project/pull/71222 >From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 6 Nov 2023 19:55:06 + Subject: [PATCH 1/8] FDATE extension implementation: get date and time in ctime format

[clang] [clang][AArch64] Pass down stack clash protection options to LLVM/Backend (PR #68993)

2023-11-23 Thread Momchil Velikov via cfe-commits
@@ -1076,6 +1076,16 @@ void CodeGenModule::Release() { "sign-return-address-with-bkey", 1); } + if (Arch == llvm::Triple::aarch64 || Arch == llvm::Triple::aarch64_be) { momchil-velikov wrote: Done, we now emit both https://

  1   2   3   >