@@ -0,0 +1,46 @@
+//===--- CastingThroughVoidCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/PiotrZSL approved this pull request.
LGTM.
About `static_cast(reinterpret_cast(&i));`:
- I'm working now on a check for redundant casts, it will detect this one, so
no need to do it in this check.
You may consider adding support for double and more pointers, but that's not s
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/69453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amadeus Gebauer
Date: 2023-10-20T09:22:49+02:00
New Revision: 5557d983412c2e8cdffaf855463098f7771f6499
URL:
https://github.com/llvm/llvm-project/commit/5557d983412c2e8cdffaf855463098f7771f6499
DIFF:
https://github.com/llvm/llvm-project/commit/5557d983412c2e8cdffaf855463098f7771f6499.dif
PiotrZSL wrote:
> Any particular reason for the `+-`? Maybe it can be resolved?
I'm just not too familiar with this check.
But current change looks fine, and could be merged.
https://github.com/llvm/llvm-project/pull/69207
___
cfe-commits mailing list
@@ -297,6 +297,10 @@ Changes in existing checks
` check to
ignore false-positive for ``if constexpr`` in lambda expression.
+- Improved :doc:`readability-const-params-in-decls
+ ` place the hint check
under
PiotrZSL wrote:
`Improved xyz check to place .
@@ -297,6 +297,10 @@ Changes in existing checks
` check to
ignore false-positive for ``if constexpr`` in lambda expression.
+- Improved :doc:`readability-const-params-in-decls
+ ` place the hint check
under
PiotrZSL wrote:
Or it can be just Improved xyz
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/69103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -285,6 +285,10 @@ Changes in existing checks
` check to fix function pointer and
forward declared ``typedef`` correctly.
+- Improved :doc:`modernize-use-using
PiotrZSL wrote:
merge with previous entry for this check.
https://github.com/llvm/llvm-proje
@@ -325,6 +329,7 @@ Changes in existing checks
identify calls to static member functions with out-of-class inline
definitions.
+
PiotrZSL wrote:
remove added empty line
https://github.com/llvm/llvm-project/pull/69102
_
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
+
+.. code-block:: c++
+
+ extern "C" {
+
PiotrZSL wrote:
remove empty line
https://github.com/llvm/llvm-projec
@@ -28,6 +28,15 @@ After:
using R_t = struct { int a; };
using R_p = R_t*;
+The checker ignores `typedef` within `extern "C" { ... }` blocks.
PiotrZSL wrote:
Maybe this should be put into configuration option ? To give an option to
preserve current behav
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/68389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Endilll wrote:
> While I think that warning is accurate, I somewhat question the value of the
> 'bool' as working on this type
I'm not sure what you mean by "working" here, but I'd like to highlight that we
have hundreds of single-bit bit-fields across Clang that would benefit from
`[[clang::
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/69688
It is misleading when diagnosing 'ExplicitlySpecialMethod' is missing exception
specification 'noexcept' for
```c++
struct ExplicitlySpecialMethod {
ExplicitlySpecialMethod() = default;
};
ExplicitlySpecial
momchil-velikov wrote:
Ping?
https://github.com/llvm/llvm-project/pull/68993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
momchil-velikov wrote:
Ping?
https://github.com/llvm/llvm-project/pull/66524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Congcong Cai (HerrCai0907)
Changes
It is misleading when diagnosing 'ExplicitlySpecialMethod' is missing exception
specification 'noexcept' for
```c++
struct ExplicitlySpecialMethod {
ExplicitlySpecialMethod() = default;
};
ExplicitlySpe
Author: Brad Smith
Date: 2023-10-20T04:01:58-04:00
New Revision: c9b17af22835ace1b4cf35b958a197d8e2de0fd0
URL:
https://github.com/llvm/llvm-project/commit/c9b17af22835ace1b4cf35b958a197d8e2de0fd0
DIFF:
https://github.com/llvm/llvm-project/commit/c9b17af22835ace1b4cf35b958a197d8e2de0fd0.diff
LO
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/69688
>From 2629b346123f9838a4fc3d8b6fb6a98508773965 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 20 Oct 2023 15:45:42 +0800
Subject: [PATCH] [clang]improve diagnosing redefined defaulted constructor
wit
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/67254
>From d16c447291c2c1127a6abc9b83942b47f2d9e145 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Sun, 24 Sep 2023 00:20:53 -0400
Subject: [PATCH] [Driver] Corrections for linker flags passed with relocatable
linking
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/67254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/69465
>From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 18 Oct 2023 08:47:02 +0800
Subject: [PATCH 1/8] [clang-tidy]Add new check bugprone-casting-through-void
F
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/69465
>From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Wed, 18 Oct 2023 08:47:02 +0800
Subject: [PATCH 1/8] [clang-tidy]Add new check bugprone-casting-through-void
F
dyung wrote:
Hi @amgebauer, not sure if you got the notification, but your change seems to
be causing a test failure on two build bots, any idea why?
https://lab.llvm.org/buildbot/#/builders/139/builds/51852
https://lab.llvm.org/buildbot/#/builders/247/builds/10286
https://github.com/llvm/llvm-
Author: Caroline Concatto
Date: 2023-10-20T08:35:13Z
New Revision: b9dae2fa22d3dd4d5c454c2b167428b027d7bc12
URL:
https://github.com/llvm/llvm-project/commit/b9dae2fa22d3dd4d5c454c2b167428b027d7bc12
DIFF:
https://github.com/llvm/llvm-project/commit/b9dae2fa22d3dd4d5c454c2b167428b027d7bc12.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb9dae2fa22d3: [Clang][SVE2.1] Add builtins for svrevd
(authored by CarolineConcatto).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
https://github.com/yubingex007-a11y updated
https://github.com/llvm/llvm-project/pull/69628
>From 786b954e621ac53902ceff4640d1372ef1652699 Mon Sep 17 00:00:00 2001
From: Bing1 Yu
Date: Fri, 20 Oct 2023 02:33:35 +0800
Subject: [PATCH 1/4] [X86] Add regcall4 attribute to make a specific function
@@ -9347,6 +9352,7 @@ ProcessDeclAttribute(Sema &S, Scope *scope, Decl *D,
const ParsedAttr &AL,
case ParsedAttr::AT_ThisCall:
case ParsedAttr::AT_Pascal:
case ParsedAttr::AT_RegCall:
+ //case ParsedAttr::AT_RegCall4:
yubingex007-a11y wrote:
@mikerice1
@@ -37,6 +37,25 @@ These changes are ones which we think may surprise users
when upgrading to
Clang |release| because of the opportunity they pose for disruption to existing
code bases.
+- Fix a bug in reversed argument for templated operators.
+ This breaks code in C++20 wh
https://github.com/Venyla created
https://github.com/llvm/llvm-project/pull/69693
[Screencast from 2023-10-16
15-34-29.webm](https://github.com/sa-concept-refactoring/llvm-project/assets/7629727/bd2c8790-c40f-4834-8523-6d16fca0d498)
https://github.com/llvm/llvm-project/assets/6904387/95fa5ab1-
https://github.com/yubingex007-a11y updated
https://github.com/llvm/llvm-project/pull/69628
>From 786b954e621ac53902ceff4640d1372ef1652699 Mon Sep 17 00:00:00 2001
From: Bing1 Yu
Date: Fri, 20 Oct 2023 02:33:35 +0800
Subject: [PATCH 1/5] [X86] Add regcall4 attribute to make a specific function
https://github.com/yubingex007-a11y edited
https://github.com/llvm/llvm-project/pull/69628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yubingex007-a11y edited
https://github.com/llvm/llvm-project/pull/69628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yubingex007-a11y edited
https://github.com/llvm/llvm-project/pull/69628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yubingex007-a11y edited
https://github.com/llvm/llvm-project/pull/69628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10085,10 +10085,14 @@ getImplicitObjectParamType(ASTContext &Context, const
FunctionDecl *F) {
return M->getFunctionObjectParameterReferenceType();
}
-static bool haveSameParameterTypes(ASTContext &Context, const FunctionDecl *F1,
+static bool allowAmbiguityWithSelf(AST
@@ -37,6 +37,25 @@ These changes are ones which we think may surprise users
when upgrading to
Clang |release| because of the opportunity they pose for disruption to existing
code bases.
+- Fix a bug in reversed argument for templated operators.
+ This breaks code in C++20 wh
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions(
QualType ParamType = ParamTypes[I + Offset];
if (!ParamType->isDependentType()) {
unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed
- ? 0
+
yubingex007-a11y wrote:
there is question here should we really add a new calling conv CC_X86RegCall4
in CFE.
currently i let regcall4 attr reuse CC_X86RegCall instead of creating
CC_X86RegCall4 .
@mikerice1969
https://github.com/llvm/llvm-project/pull/69628
amgebauer wrote:
I have an idea about the reason. I will push a fix in a few moments. Thank you
for the hint
https://github.com/llvm/llvm-project/pull/69453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/Venyla updated
https://github.com/llvm/llvm-project/pull/69693
>From 9e2a80fd1a7ae61ce71ba0caabd2c6a88c662889 Mon Sep 17 00:00:00 2001
From: Vina Zahnd
Date: Fri, 20 Oct 2023 10:01:54 +0200
Subject: [PATCH] [clangd] Add tweak to inline concept requirements
Co-authored-by: Je
@@ -6411,6 +6411,41 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value
*Op0, Value *Op1,
return Constant::getNullValue(ReturnType);
break;
}
+ case Intrinsic::ptrmask: {
+if (isa(Op0) || isa(Op1))
+ return PoisonValue::get(Op0->getType());
+
+
https://github.com/Venyla updated
https://github.com/llvm/llvm-project/pull/69693
>From 2b1f56a758d397649c94717f4a030c04a532bde7 Mon Sep 17 00:00:00 2001
From: Vina Zahnd
Date: Fri, 20 Oct 2023 10:01:54 +0200
Subject: [PATCH] [clangd] Add tweak to inline concept requirements
Co-authored-by: Je
https://github.com/HoBoIs updated
https://github.com/llvm/llvm-project/pull/69480
From f75c2e75042d6d8f5a093967a56f3f59d7e541f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Botond=20Istv=C3=A1n=20Horv=C3=A1th?=
<56926027+hob...@users.noreply.github.com>
Date: Wed, 18 Oct 2023 18:05:01 +0200
Subject
https://github.com/HoBoIs updated
https://github.com/llvm/llvm-project/pull/69480
From f75c2e75042d6d8f5a093967a56f3f59d7e541f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Botond=20Istv=C3=A1n=20Horv=C3=A1th?=
<56926027+hob...@users.noreply.github.com>
Date: Wed, 18 Oct 2023 18:05:01 +0200
Subject
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -fcxx-exceptions -std=c++11 %s
tbaederr wrote:
There's a typo in the name of this file.
https://github.com/llvm/llvm-project/pull/69688
___
cfe-commits mailing
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922
>From 0c71b6bdd557ff4b9ad9a4ec4f0919e3460596b0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 12 Oct 2023 21:35:52 +0200
Subject: [PATCH 1/5] Find opertor!= in the correct namespace
---
clang/lib/Sema/Se
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/amgebauer created
https://github.com/llvm/llvm-project/pull/69700
If PyYAML is not installed, the `-export-fixes` can be used to specify a
directory (not a file).
Follows #69453
>From 947b71ca6498f2783f2b701ad8d03d63779e Mon Sep 17 00:00:00 2001
From: Amadeus Gebauer
D
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Amadeus Gebauer (amgebauer)
Changes
If PyYAML is not installed, the `-export-fixes` can be used to specify a
directory (not a file).
Follows #69453
---
Full diff: https://github.com/llvm/llvm-project/pull/69700.diff
2 Files Affect
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions(
QualType ParamType = ParamTypes[I + Offset];
if (!ParamType->isDependentType()) {
unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed
- ? 0
+
Very late, & by email since phab is down.
Going to land this based on "LG" comment & offline discussion, happy to do
followups if needed.
On Mon, Nov 28, 2022 at 10:08 PM Kadir Cetinkaya via Phabricator <
revi...@reviews.llvm.org> wrote:
> kadircet added a comment.
>
> thanks LG, i'd like to hea
Author: Sam McCall
Date: 2023-10-20T11:47:29+02:00
New Revision: b99f7e6954691efae2d60a1af21f8c1b71a0f786
URL:
https://github.com/llvm/llvm-project/commit/b99f7e6954691efae2d60a1af21f8c1b71a0f786
DIFF:
https://github.com/llvm/llvm-project/commit/b99f7e6954691efae2d60a1af21f8c1b71a0f786.diff
LO
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb99f7e695469: [clangd] Don't run slow clang-tidy checks
by default
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
@@ -85,17 +90,32 @@ static bool isPrologueCFIInstruction(const MachineInstr
&MI) {
MI.getFlag(MachineInstr::FrameSetup);
}
-static bool containsPrologue(const MachineBasicBlock &MBB) {
- return llvm::any_of(MBB.instrs(), isPrologueCFIInstruction);
-}
-
static bool
@@ -1,25 +1,33 @@
// Check the correct function attributes are generated
-// RUN: %clang_cc1 -triple x86_64-linux -O0 -S -emit-llvm -o- %s
-fstack-clash-protection | FileCheck %s
-// RUN: %clang_cc1 -triple s390x-linux-gnu -O0 -S -emit-llvm -o- %s
-fstack-clash-protection | Fil
@@ -85,17 +90,32 @@ static bool isPrologueCFIInstruction(const MachineInstr
&MI) {
MI.getFlag(MachineInstr::FrameSetup);
}
-static bool containsPrologue(const MachineBasicBlock &MBB) {
- return llvm::any_of(MBB.instrs(), isPrologueCFIInstruction);
-}
-
static bool
@@ -1,25 +1,33 @@
// Check the correct function attributes are generated
-// RUN: %clang_cc1 -triple x86_64-linux -O0 -S -emit-llvm -o- %s
-fstack-clash-protection | FileCheck %s
-// RUN: %clang_cc1 -triple s390x-linux-gnu -O0 -S -emit-llvm -o- %s
-fstack-clash-protection | Fil
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?= ,
https://github.com/ckandeler created
https://github.com/llvm/llvm-project/pull/69704
Moving the body of member functions out-of-line makes sense for classes defined
in implementation files too.
>From 0b7df6c0a713c1c40f6c92d958fa6a96796ed80f Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Da
llvmbot wrote:
@llvm/pr-subscribers-clangd
Author: None (ckandeler)
Changes
Moving the body of member functions out-of-line makes sense for classes defined
in implementation files too.
---
Full diff: https://github.com/llvm/llvm-project/pull/69704.diff
2 Files Affected:
- (modified) c
Author: Omar Ahmed
Date: 2023-10-20T03:16:28-07:00
New Revision: 7c15dd60ec4549f53f1a51c5302c61f8a025a4a5
URL:
https://github.com/llvm/llvm-project/commit/7c15dd60ec4549f53f1a51c5302c61f8a025a4a5
DIFF:
https://github.com/llvm/llvm-project/commit/7c15dd60ec4549f53f1a51c5302c61f8a025a4a5.diff
LO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7c15dd60ec45: [clang-format] Add space in placement new
expression (authored by omarahmed, committed by owenpan).
Changed prior to commit:
https://reviews.llvm.org/D127270?vs=445172&id=557807#toc
Repos
koops updated this revision to Diff 557808.
koops added a comment.
1. In class OMPFailClause, the was a duplication in the storage of parameter to
the fail clause because the parameter was stored as FailParameterKind and
MemoryOrderClause (FailMemoryOrderClause). There was a possibility of these
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/69681
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/OCHyams commented:
This SGTM.
I don't think the unnamed variable serves any useful purpose but may not being
imaginative enough. I can't see any discussion on the topic when the code was
added in [D119178](https://reviews.llvm.org/D119178) . CC the author, @shafik
(or @adri
@@ -2,10 +2,8 @@
OCHyams wrote:
Please can you add `--implicit-check-not="call void @llvm.dbg.declare"` to the
`FileCheck` command?
https://github.com/llvm/llvm-project/pull/69681
___
cfe-commits mailing list
cfe-co
@@ -0,0 +1,20 @@
+// RUN: %clang_cc1 -emit-llvm -debug-info-kind=standalone %s -o - | FileCheck
%s
+
+struct Tuple {
+ int Fld_1;
+ int Fld_2;
+};
+__attribute__((optnone)) Tuple get() { return {10, 20}; }
+
+// CHECK-LABEL: define dso_local noundef i32 @main
+// CHECK: %r
https://github.com/Venyla updated
https://github.com/llvm/llvm-project/pull/69693
>From 1a49159a4d8186223c0cf87e9225aafe0fd6a2dd Mon Sep 17 00:00:00 2001
From: Vina Zahnd
Date: Fri, 20 Oct 2023 10:01:54 +0200
Subject: [PATCH] [clangd] Add tweak to inline concept requirements
Co-authored-by: Je
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/69707
So we can differentiate on the while keyword between a do-while-loop and a
normal while-loop.
From be24095877e6ddd25e0884ad8aaf3eca4846f38d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3
https://github.com/amgebauer edited
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Björn Schäpers (HazardyKnusperkeks)
Changes
So we can differentiate on the while keyword between a do-while-loop and a
normal while-loop.
---
Full diff: https://github.com/llvm/llvm-project/pull/69707.diff
3 Files Affected:
- (m
amgebauer wrote:
Is there any way to trigger the failing tests within this PR?
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,104 @@
+//===- TaggedUnionModeling.h -*- C++
-*-==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/HazardyKnusperkeks updated
https://github.com/llvm/llvm-project/pull/68743
From be24095877e6ddd25e0884ad8aaf3eca4846f38d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?=
Date: Fri, 20 Oct 2023 13:00:39 +0200
Subject: [PATCH 1/2] [clang-format] Annotate do
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/69707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HazardyKnusperkeks wrote:
Some pathological test cases added and handling do-while (relying on #69707).
Only a reply from @mydeveloperday open regarding the change of the existing
test with function braces.
https://github.com/llvm/llvm-project/pull/68743
@@ -10085,10 +10085,14 @@ getImplicitObjectParamType(ASTContext &Context, const
FunctionDecl *F) {
return M->getFunctionObjectParameterReferenceType();
}
-static bool haveSameParameterTypes(ASTContext &Context, const FunctionDecl *F1,
+static bool allowAmbiguityWithSelf(AST
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69595
>From 4460b02508d21d98cf05103bece99fc5bd474ab0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 19 Oct 2023 12:33:45 +0200
Subject: [PATCH 1/5] Reapply "Correctly compute conversion seq for args to fn
with
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/69595
>From 4460b02508d21d98cf05103bece99fc5bd474ab0 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Thu, 19 Oct 2023 12:33:45 +0200
Subject: [PATCH 1/6] Reapply "Correctly compute conversion seq for args to fn
with
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/69712
Skip anonymous members when rebuilding DesignatedInitExpr since designated
inits for them are meant to be created during
`InitListChecker::CheckDesignatedInitializer` routine.
Fixes https://github.com/llvm/llv
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Skip anonymous members when rebuilding DesignatedInitExpr since designated
inits for them are meant to be created during
`InitListChecker::CheckDesignatedInitializer` routine.
Fixes https://github
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
> Is there any way to trigger the failing tests within this PR?
No, in worst case we can revert faulty change.
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -7688,7 +7688,7 @@ bool Sema::CheckNonDependentConversions(
QualType ParamType = ParamTypes[I + Offset];
if (!ParamType->isDependentType()) {
unsigned ConvIdx = PO == OverloadCandidateParamOrder::Reversed
- ? 0
+
PiotrZSL wrote:
Lets push this, if it wont help then we can revert oryginal change.
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amadeus Gebauer
Date: 2023-10-20T13:40:38+02:00
New Revision: 49af6502c6dcb4a7f7520178bd14df396f78240c
URL:
https://github.com/llvm/llvm-project/commit/49af6502c6dcb4a7f7520178bd14df396f78240c
DIFF:
https://github.com/llvm/llvm-project/commit/49af6502c6dcb4a7f7520178bd14df396f78240c.dif
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/69700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov approved this pull request.
The change looks good, I believe the comments about potentially redundant
checks and naming of the function could be addressed in a follow-up.
https://github.com/llvm/llvm-project/pull/69595
___
@@ -10085,10 +10085,14 @@ getImplicitObjectParamType(ASTContext &Context, const
FunctionDecl *F) {
return M->getFunctionObjectParameterReferenceType();
}
-static bool haveSameParameterTypes(ASTContext &Context, const FunctionDecl *F1,
+static bool allowAmbiguityWithSelf(AST
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/69713
None
>From 12cb6e61a8e77a7800fda0ae4dd1148e76844da8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 20 Oct 2023 14:16:22 +0200
Subject: [PATCH] [clang][Interp] Implement builintin_expect
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ba8565fbcb975e2d067ce3ae5a7dbaae4953edd3
12cb6e61a8e77a7800fda0ae4dd1148e76844da8 --
https://github.com/Venyla edited https://github.com/llvm/llvm-project/pull/69693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/69693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
5chmidti wrote:
Clangd (actually large parts of llvm) don't use trailing return types, you will
probably have to change those. This is a bit of a chore, so you could wait for
another reviewer to confirm that for you.
https://github.com/llvm/llvm-project/pull/
@@ -0,0 +1,262 @@
+//===--- InlineConceptRequirement.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
1 - 100 of 348 matches
Mail list logo
