[clang] 4357571 - [Clang] Fix crash caused by line splicing in doc comment

Author: Corentin Jabot Date: 2023-04-12T10:07:51+02:00 New Revision: 43575719d0c6d8cf5afedf39f6d89f69231aedc4 URL: https://github.com/llvm/llvm-project/commit/43575719d0c6d8cf5afedf39f6d89f69231aedc4 DIFF: https://github.com/llvm/llvm-project/commit/43575719d0c6d8cf5afedf39f6d89f69231aedc4.diff

[PATCH] D148029: [Clang] Fix crash caused by line splicing in doc comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43575719d0c6: [Clang] Fix crash caused by line splicing in doc comment (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] ce1fb03 - [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

Author: Balázs Kéri Date: 2023-04-12T10:24:55+02:00 New Revision: ce1fb03db8174ca63fedc6e3aebdd6fb2c4fcfdf URL: https://github.com/llvm/llvm-project/commit/ce1fb03db8174ca63fedc6e3aebdd6fb2c4fcfdf DIFF: https://github.com/llvm/llvm-project/commit/ce1fb03db8174ca63fedc6e3aebdd6fb2c4fcfdf.diff L

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce1fb03db817: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1440

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4258380 , @kamaub wrote: > Sorry I should have requested changes before for this comment below, but I do > want these test moved to codegen and expanded, please let me know if anything > is unclear. > > In D143467#42416

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

asb added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:51 // CHECK-NOT: __riscv_zcf {{.*$}} +// CHECK-NOT: __riscv_zcmp // CHECK-NOT: __riscv_h {{.*$}} jrtc27 wrote: > Does this really belong in an MC patch? We typically do inclu

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

asb added a comment. Will `--[no-]relax-gp` make its way into a minor gcc point release or do we need to wait for the next major release? In terms of this breaking GNU users - isn't it the case that without this option, they may get silently broken code when using the shadow call stack? Breaki

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. This extension doesn't appear to be ratified but you've listed it in the table of ratified extensions and treated it as a ratified extension in RISCVISAInfo.cpp. I know that given we don't do checking for CSR names the distinction feels a bit academic, but I don't think thi

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary planned changes to this revision. lenary added a comment. To be clear: I've not yet addressed @jhenderson's comments above, yet, which may require changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://revie

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The purpose of this patch and follow-on patches is to ens

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds an extra AttributeCommonInfo::Form constr

[PATCH] D148104: [clang] Type safety tweak for AttributeCommonInfo::Form

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds static functions for constructing most At

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AttributeCommonInfo::isAlignasAttribute() was used in one

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

rsandifo-arm added a comment. FWIW, the original reason for looking at this was to explore ways of removing `AS_AttributeLikeKeyword` from https://reviews.llvm.org/D139028 . I wanted to find a way of conveying extra information about a spelling without having to change the existing enums. It

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 512743. asb edited the summary of this revision. asb added a comment. Rebase and use the new encoding suggested in https://github.com/riscv/riscv-bfloat16/issues/33 - hoping for the commits that alter the encoding to be pushed to the spec repo and a new PDF (wit

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

asb updated this revision to Diff 512744. asb added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org/D147611 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

asb updated this revision to Diff 512745. asb added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm.org/D147612 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/S

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/6]

barannikov88 created this revision. Herald added a subscriber: pengfei. Herald added a project: All. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. `CCState`

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 created this revision. Herald added a project: All. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove `getABIInfo` overrides returning refere

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/6]

barannikov88 created this revision. Herald added a subscriber: dschuff. Herald added a project: All. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane. barannikov88 published this revision for review. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Mo

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/6]

barannikov88 created this revision. Herald added a project: All. barannikov88 added reviewers: rjmccall, aaron.ballman, erichkeane. barannikov88 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't derive from `DefaultTargetCodeGenInfo`.

[clang] 6d3b779 - Set 'rounding_mode' to 'tonearest' with '#pragma STDC FENV_ACCESS OFF'.

Author: Zahira Ammarguellat Date: 2023-04-12T06:44:45-04:00 New Revision: 6d3b779792fbf9ec5cc119f1812655da01020b7a URL: https://github.com/llvm/llvm-project/commit/6d3b779792fbf9ec5cc119f1812655da01020b7a DIFF: https://github.com/llvm/llvm-project/commit/6d3b779792fbf9ec5cc119f1812655da01020b7a

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d3b779792fb: Set 'rounding_mode' to 'tonearest' with '#pragma STDC FENV_ACCESS OFF'. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

barannikov88 created this revision. Herald added a project: All. barannikov88 updated this revision to Diff 512750. barannikov88 added a comment. barannikov88 updated this revision to Diff 512751. barannikov88 updated this revision to Diff 512753. barannikov88 edited the summary of this revision. b

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 created this revision. Herald added subscribers: luke, nlopes, kosarev, mattd, gchakrabarti, pmatos, asb, asavonic, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, mgrang, edwa

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

mboehme created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. See https://ti

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet created this revision. Herald added a subscriber: mgrang. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Principal here is: - Making sure each template instantiation implies use o

[PATCH] D147969: Add InsertBraces to ChromiumStyle

aaron.ballman added inline comments. Comment at: clang/lib/Format/Format.cpp:1699 ChromiumStyle.DerivePointerAlignment = false; +ChromiumStyle.InsertBraces = true; if (Language == FormatStyle::LK_ObjC) MyDeveloperDay wrote: > owenpan wrote: > > aaro

[clang] 3820e9a - Reapply (4) "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-12T12:35:17+01:00 New Revision: 3820e9a2b29a2e268319ed6635da0d59e18d736d URL: https://github.com/llvm/llvm-project/commit/3820e9a2b29a2e268319ed6635da0d59e18d736d DIFF: https://github.com/llvm/llvm-project/commit/3820e9a2b29a2e268319ed6635da0d59e18d736d.diff LOG:

[PATCH] D143260: [clangd] Add semantic token for labels

ckandeler added a comment. Hello? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143260/new/ https://reviews.llvm.org/D143260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet updated this revision to Diff 512775. kadircet edited the summary of this revision. kadircet added a comment. - Use template instantion pattern helper instead of dealing with partial specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov added inline comments. Comment at: clang/test/SemaObjCXX/arc-objc-lifetime.mm:69-79 +// See https://github.com/llvm/llvm-project/issues/61419 + +template struct pair { + T0 first; + T1 second; +}; + I think the fix looks good, although this test may b

[PATCH] D147263: Fix an assertion failure in unwrapSugar

mizvekov accepted this revision. mizvekov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147263/new/ https://reviews.llvm.org/D147263 ___

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 512784. tbaeder set the repository for this revision to rG LLVM Github Monorepo. Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Fil

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 512785. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options.td clan

[PATCH] D148112: [include-cleaner] Improve handling for templates

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:91 +auto *CTSD = llvm::cast(TD); +if (CTSD->isExplicitInstantiationOrSpecialization()) +

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder updated this revision to Diff 512795. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 Files: clang/include/clang/Basic/DiagnosticOptions.def clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options.td clan

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. Ping for review again plz. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. If all comments and concerns are done, then I'm inclined to accept, but I'd like @owenpan and @HazardyKnusperkeks to give their opinion before we land this. Repository: rG

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added a comment. is it possible to point to a github issue that this related to in the review summary, if not please can you make one so we can track the issue its trying to solve Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Requesting changes so we don't accidentally commit this. There is some confusion elsewhere on how ready this is for commit. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added a comment. In D145088#4259377 , @craig.topper wrote: > In D145088#4258856 , @erichkeane > wrote: > >> So I don't see any handling of the dependent version of this, we probably >> need tests for

[PATCH] D147909: [clang] Implement CWG 2397

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/CXX/dcl.decl/dcl.meaning/dcl.array/p1-cxx0x.cpp:5 int b[5]; - auto a[5] = b; // expected-error{{'a' declared as array of 'auto'

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512801. junaire added a comment. use unsigned long instead of std::size_t when including the runtimes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/i

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman added a comment. Precommit CI has several failures introduced by this patch -- some test cases need to be fixed up (in addition to the new test coverage). Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3424 "attribute %0 is ignored, place it afte

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

kito-cheng created this revision. kito-cheng added reviewers: asb, craig.topper, luismarques. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 512805. skatrak added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGO

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 suggestion to catch a few more cases that I think are incorrect, but this is a move in the right direction. Thanks! Comment at: clang/include/clang/Basic/Attribut

[PATCH] D98012: [RFC][doc] Document that RISC-V's __fp16 has different behavior

kito-cheng abandoned this revision. kito-cheng added a comment. Herald added subscribers: pcwang-thead, VincentWu, arichardson. Herald added a project: All. RISC-V using `_Float16` as official half-precision type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

erichkeane added a comment. I'm not sold on the value of this patch, but I don't see any problems with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___ c

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

erichkeane added a comment. Again, not sold on value, but no problems with the patch itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/ https://reviews.llvm.org/D148103 ___ cfe-commits mai

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske updated this revision to Diff 512808. balazske added a comment. Simplified AST matchers a bit. Added check for list-initialization syntax at constructor call. Added some tests. Updated documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:44-45 +return BinOp->getOpcode() == BO_Assign && + BinOp->getRHS()->IgnoreParenCasts() == E; + + return

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4261301 , @MyDeveloperDay wrote: > is it possible to point to a github issue that this related to in the review > summary, if not please can you make one so we can track the issue its trying > to solve added an issu

[PATCH] D147888: Update declaration message of extern linkage

tbaeder added inline comments. Comment at: clang/test/SemaCXX/extern_static.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -Wabstract-vbase-init +void f(void) That's unnecessary, isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Huh, this is much less disruptive than I thought it was going to be. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148105/new/ ht

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/ https://revi

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

erichkeane added a comment. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___ cfe-commits ma

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added a comment. Since basically nobody has seen multiple snippet lines being printed, we probably need to fix up a bunch of diagnostics afterwards to be more useful, e.g. ./array.cpp:111:5: error: no matching function for call to 'func' 111 | func(1, 2, 3, 4), "hah, reason!")

[clang] 2266f4a - [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

Author: Sergio Afonso Date: 2023-04-12T14:59:37+01:00 New Revision: 2266f4a3b38f4b59d313cdd2a9209952afb29d14 URL: https://github.com/llvm/llvm-project/commit/2266f4a3b38f4b59d313cdd2a9209952afb29d14 DIFF: https://github.com/llvm/llvm-project/commit/2266f4a3b38f4b59d313cdd2a9209952afb29d14.diff

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

This revision was automatically updated to reflect the committed changes. skatrak marked 2 inline comments as done. Closed by commit rG2266f4a3b38f: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang (authored by skatrak). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4261293 , @MyDeveloperDay wrote: > If all comments and concerns are done, then I'm inclined to accept, but I'd > like @owenpan and @HazardyKnusperkeks to give their opinion before we land > this. Sure. Thanks! ==

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jp4a50 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[clang] d982643 - [clang] Implement CWG 2397

Author: Younan Zhang Date: 2023-04-12T22:30:23+08:00 New Revision: d9826433f31cd081d0229d47d7982b5bf3c0055f URL: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f DIFF: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f.diff

[PATCH] D147909: [clang] Implement CWG 2397

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9826433f31c: [clang] Implement CWG 2397 (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258981 , @aaron.ballman wrote: > In D147073#4258664 , @zequanwu > wrote: > >> In D147073#4258529 , >> @aaron.ballman wrote: >> >>>

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:333 + // enabled. + !(Current.is(TT_LambdaLBrace) && Style.BraceWrapping.BeforeLambdaBody) && CurrentState.NoLineBreakInOperand) { AFAICT, this only matters when

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512837. junaire added a comment. dont include if we don't have it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/inc

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1894 and its duplicate CWG2199 are resolved p

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 512848. Krishna-13-cyber added a comment. - Updated with removing redundant flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 Files: clang/include/clan

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

craig.topper added a comment. What is the interaction between this and the -m32 and -m64 options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124 ___ cfe-commit

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet updated this revision to Diff 512851. kadircet marked an inline comment as done. kadircet added a comment. Herald added a subscriber: ChuanqiXu. - Ignore explicit instantiations - Update tests to use decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:109 ADD_FAILURE() << DiagBuf << "\nfrom code:\n" << ReferencingCode; + llvm::sort(TargetDeclKinds); + TargetDeclKinds.erase(ll

[clang-tools-extra] 34f5774 - [include-cleaner] Improve handling for templates

Author: Kadir Cetinkaya Date: 2023-04-12T17:36:05+02:00 New Revision: 34f5774920f54f81b3e3a361a7c7f21a61e39b39 URL: https://github.com/llvm/llvm-project/commit/34f5774920f54f81b3e3a361a7c7f21a61e39b39 DIFF: https://github.com/llvm/llvm-project/commit/34f5774920f54f81b3e3a361a7c7f21a61e39b39.dif

[PATCH] D148112: [include-cleaner] Improve handling for templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34f5774920f5: [include-cleaner] Improve handling for templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4261633 , @zequanwu wrote: > In D147073#4258981 , @aaron.ballman > wrote: > >> Perhaps a way to split the middle would be to assert that the source >> locations are vali

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + @erichkeane does this cover the dependent case or were you looking for something else? Here are on the only mentions of templ

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2262 + /// Return true if the given vector types are lax-compatible RISC-V vector + /// types as defined by -flax-vector-conversions=, false otherwise. + bool areLaxCompatibleRVVTypes(QualType

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. > Well, MSVC cl removes redundant dots so we shouldn't remove > llvm::sys::path::remove_dots. Could we do the `remove_dots` on the Clang side, where we can decide based on the LangOpts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2263 + /// types as defined by -flax-vector-conversions=, which permits implicit + /// conversions between vectors wit different number of elemnts and/or + /// incompatible element types, false

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512868. zequanwu added a comment. Add assertion on source locations in `pushRegion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files: clang/lib/CodeGen/Cover

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512869. junaire added a comment. fix ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/TokenKinds

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4261949 , @hans wrote: >> Well, MSVC cl removes redundant dots so we shouldn't remove >> llvm::sys::path::remove_dots. > > Could we do the `remove_dots` on the Clang side, where we can decide based on > the LangOpts?

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Since we red

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > @erichkeane does this cover the dependent case or were you looking for > > somethi

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] 3704752 - [clang][NFC] Use range-for loop in TextDiagnostic.cpp

Author: Timm Bäder Date: 2023-04-12T18:50:37+02:00 New Revision: 37047523a9fb5ffa74eaf94d9d52db831f99c062 URL: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062 DIFF: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062.diff LO

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:379 + (H.physical() == MainFile || + H.physical()->getName().endswith(PreamblePatch::HeaderName))) { Satisfied = true; Comparing strin

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > erichkeane wrote: > > craig.topper wrote: > > > @erichkeane does this cover the dependent case or were you

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/loop_bind_codegen.cpp:51-56 +void thread_loop2() { + #pragma omp loop bind(thread) + for (int j = 0 ; j < NNN ; j++) { +aaa[j] = j*NNN; + } +} ABataev wrote: > I think it should trigger the assert

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > @erichkeane does this cover th

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added a comment. I've not done a complete review yet, but I got started on it and have a handful of comments. Comment at: clang/include/clang/Basic/TokenKinds.def:945 +// Annotation for end of input in clang-repl. +ANNOTATION(input_end) + Should

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ I think i would prefer re

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > erichkeane wrote: > > craig.topper wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > > >

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

Endill created this revision. Endill added reviewers: clang-language-wg, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This script has hardcoded relative paths to `clang/test/CXX/drs`, `cwg_i

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Great idea, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148146/new/ https://reviews.llvm.org/D148146

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; What abou

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added a comment. Thank you for taking a look at this. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ ---

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ Endill wrote: > cor3ntin

  1   2   >