[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[clang] 7dc0734 - [msan] Insert simplification passes after instrumentation

Author: Vitaly Buka Date: 2022-09-09T00:33:04-07:00 New Revision: 7dc0734567217236a61fa2ed3b3909ac25925ce5 URL: https://github.com/llvm/llvm-project/commit/7dc0734567217236a61fa2ed3b3909ac25925ce5 DIFF: https://github.com/llvm/llvm-project/commit/7dc0734567217236a61fa2ed3b3909ac25925ce5.diff L

[PATCH] D133555: [pseudo] Eliminate a false parse of the template parameter "class T".

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Implements the temp.param#2 rule with

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. struct Style { enum E { Yes, No, }; unsigned OverEmptyLines; } I don't understand the need for `state` as a struct could have multiple options (as enums) each enum should have a state that means "Leave" Repository: rG LLVM Github Mo

[PATCH] D133565: [pseudo] Print a random text code for each ambiguous symbol in --print-statistics

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. I found it useful when diagnosing/investigating ambiguous cases. Repository

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. > But you could set MaxEmptyLinesToKeep to 3 and aligning comments to over 2 > empty lines. Correct! lets assume MaxEmptyLinesToKeep = 3 if this case is valid in that case int a;// Foo int longer foo; // Foo int verylong foo; // Foo then so

[clang] 9424497 - [Clang] Use virtual FS in processing config files

Author: Serge Pavlov Date: 2022-09-09T16:28:51+07:00 New Revision: 9424497e43aff088e014d65fd952ec557e28e6cf URL: https://github.com/llvm/llvm-project/commit/9424497e43aff088e014d65fd952ec557e28e6cf DIFF: https://github.com/llvm/llvm-project/commit/9424497e43aff088e014d65fd952ec557e28e6cf.diff

[PATCH] D132867: [Clang] Use virtual FS in processing config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9424497e43af: [Clang] Use virtual FS in processing config files (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D132867

[clang] 55e1441 - Revert "[Clang] Use virtual FS in processing config files"

Author: Serge Pavlov Date: 2022-09-09T16:43:15+07:00 New Revision: 55e1441f7b5d01a37fc46eb1711f03ee69845316 URL: https://github.com/llvm/llvm-project/commit/55e1441f7b5d01a37fc46eb1711f03ee69845316 DIFF: https://github.com/llvm/llvm-project/commit/55e1441f7b5d01a37fc46eb1711f03ee69845316.diff

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 459004. t.p.northover marked an inline comment as done. t.p.northover added a comment. Switched to `enum class`. > You may want to split the patch, with refactoring as the first, and the > Mach-O specific change as the second one. I've got it split in

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

ilya-biryukov added a subscriber: aaron.ballman. ilya-biryukov added a comment. In D133029#3766058 , @shafik wrote: > This old cfe-dev thread might be relevant: > https://lists.llvm.org/pipermail/cfe-dev/2018-June/058338.html Thanks, the thread is defin

[clang] 7b9fae0 - [Clang] Use virtual FS in processing config files

Author: Serge Pavlov Date: 2022-09-09T18:24:45+07:00 New Revision: 7b9fae05b4d0d3184ffc340e90d06a75e3cba2de URL: https://github.com/llvm/llvm-project/commit/7b9fae05b4d0d3184ffc340e90d06a75e3cba2de DIFF: https://github.com/llvm/llvm-project/commit/7b9fae05b4d0d3184ffc340e90d06a75e3cba2de.diff

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. Thanks very much for your comments @rjmccall @rsmith , I've take a look at D45383 , I believe that user code isn't allowed to declare __builtin_*, but seems `intrin0.inl.h` is a system header on windows, should we keep compatibility(li

[PATCH] D133415: [clangd] Fix non-idempotent cases of canonicalRenameDecl()

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM to unbreak clangd. Agree that a more thorough look at this is needed. Maybe add a bug to track this? Comment at: clang-tools-extra/clangd/unittests/RenameT

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

hans added a comment. For more context, this was initially raised in https://discourse.llvm.org/t/why-is-the-deprecated-copy-warning-suppressed-in-msvc-compatibility-mode/65085/1 I'm not aware of any reason for the special microsoft mode case, but it's very possible that I'm missing something.

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + beanz wrote: > python3kgae wrote: > > aaron.ballman

[PATCH] D132977: [HLSL] Call global constructors inside entry

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132977/new/ https://reviews.llvm.org/D132977

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} shafik wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > > On

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro added a comment. In D133405#3779190 , @MaskRay wrote: > So, sparc64 gcc does seem to define the macro by default. (I am using Debian > testing and can't tell whether it's distro setting or upstream default) > ¯\_(ツ)_/¯ > > % sparc64-linux-gnu-gcc -

[PATCH] D133405: [Linux] Hack around Linux/sparc

ro updated this revision to Diff 459017. ro added a comment. Add comment, tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133405/new/ https://reviews.llvm.org/D133405 Files: clang/lib/Basic/Targets/OSTargets.h clang/test/Preprocessor/init

[PATCH] D133457: Add Clang driver flags equivalent to cl's /MD, /MT, /MDd, /MTd.

hans added inline comments. Comment at: clang/include/clang/Driver/Options.td:2209 +def fms_runtime_lib_EQ : Joined<["-"], "fms-runtime-lib=">, Group, + Flags<[NoXarchOption, CoreOption]>, HelpText<"Select Windows run-time library">; defm delayed_template_parsing : BoolFOption

Re: [clang] b7a7aee - [clang] Qualify auto in range-based for loops (NFC)

On Thu, Sep 8, 2022 at 12:37 PM David Blaikie wrote: > > Mixed feelings here - Kazu's made a lot of cleanup/stylistic changes > across the LLVM project for a while now, most, at least I think, are > quite welcome (things like switching to range-based-for, std > algorithms over llvm ones, llvm algo

[PATCH] D133570: [Clang] changing behavior of constant array emission [AsmPrinter] changing Size from unsigned to uint64_t

OfekShochat created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. OfekShochat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. fixes issue with emitting partially initialized constant arr

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added a project: clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Herald added a project: clang. As highlighted by https://github.

[PATCH] D133570: #57353 on github

OfekShochat added a comment. its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D13357

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

MyDeveloperDay updated this revision to Diff 459024. MyDeveloperDay added a comment. self review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133571/new/ https://reviews.llvm.org/D133571 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

ningvin added a comment. In D133354#3779123 , @dblaikie wrote: > That works, you can also take the hash with the `rG` prefix and use that: > rGd577fbbd1c9d6dab193d530fcd807efc3b3bc9ad >

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

aaron.ballman added subscribers: erichkeane, ldionne. aaron.ballman added a comment. CC @erichkeane for attribute questions, and CC @ldionne for STL questions and design/usability of the proposed attribute In D133029#3779663 , @ilya-biryukov wrote: > I

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:935 +**AllowShortCaseLabelsOnASingleLine** (``ShortCaseLabelStyle``) :versionbadge:`clang-format 3.6` + Determine if Short case labels will be contracted to a single line. + =

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 459028. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contra

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc created this revision. Herald added a project: All. inclyc updated this revision to Diff 459034. inclyc added a comment. inclyc added reviewers: aaron.ballman, clang-language-wg. inclyc published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

ldionne added a comment. Just my .02, but I am conflicted between: 1. Simply not doing anything -- the diagnostic users get when they violate the requirement currently is probably not that bad? I did see this breakage a bit in our internal code base as well, but it was easy to fix and there wer

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459037. inclyc added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diag

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 459039. inclyc added a comment. Use double backquotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D129755#3777038 , @aaronpuchert wrote: > I was under the impression that we've already switched to C++17, but the > Windows pre-subm

[PATCH] D133570: #57353 on github

OfekShochat added a comment. trying to fix the problem. probably going to split this into two patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-co

[PATCH] D133570: #57353 on github

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. In D133570#3779856 , @OfekShochat wrote: > its my first time contributing. this is probably very bad and goes against a > lot of guidelines, but I wouldnt resist to fix th

[PATCH] D133570: #57353 on github

OfekShochat added a comment. hello! thank you so much, Ill do that now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D133570 ___ cfe-commits mailing list cfe

[clang] d3c54a1 - [HLSL] Call global constructors inside entry

Author: Chris Bieneman Date: 2022-09-09T09:01:28-05:00 New Revision: d3c54a172d48a2e3a0c2740c300a1d7dbdf4e292 URL: https://github.com/llvm/llvm-project/commit/d3c54a172d48a2e3a0c2740c300a1d7dbdf4e292 DIFF: https://github.com/llvm/llvm-project/commit/d3c54a172d48a2e3a0c2740c300a1d7dbdf4e292.diff

[PATCH] D132977: [HLSL] Call global constructors inside entry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3c54a172d48: [HLSL] Call global constructors inside entry (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hmm, one problem, seems like nor clang and nor gcc can compile the example in the github issue fully, only to assembly. is there something like c -> llir, llir -> asm checks? in the issue, it did succeed to compile to either llir and asm, just not correctly Reposi

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

aaron.ballman added a comment. In D133570#3780071 , @OfekShochat wrote: > hello! thank you so much, Ill do that now, thanks! just a question, what are > your guidelines when it comes to commit naming/number etc? Thanks, the new title is great! I'm not

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

domada created this revision. domada added a reviewer: kiranchandramohan. Herald added subscribers: bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a comment. hello again, I added two tests, one for llvm and one for clang. how do I run those specifically so I see I didnt do something wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133570/new/ https://reviews.llvm.org/D1

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

aaron.ballman added a comment. In D133029#3779970 , @ldionne wrote: > Just my .02, but I am conflicted between: > > 1. Simply not doing anything -- the diagnostic users get when they violate > the requirement currently is probably not that bad? I did see

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

aaron.ballman added a comment. In D133570#3780171 , @OfekShochat wrote: > hello again, I added two tests, one for llvm and one for clang. how do I run > those specifically so I see I didnt do something wrong? The short answer is: you can run the `check

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > beanz wrote: > > python3kgae wrote: >

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + beanz wrote: > aaron.ballman wrote: > > beanz wrote:

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459064. Codesbyusman edited the summary of this revision. Codesbyusman added a comment. updated the test work for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.or

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[clang] 28bd794 - [clang-format] NFC remove incorrect whitespace causing documentation issue

Author: mydeveloperday Date: 2022-09-09T16:03:48+01:00 New Revision: 28bd7945eabdbde2b1fc071ab2f9b78e6e754a1a URL: https://github.com/llvm/llvm-project/commit/28bd7945eabdbde2b1fc071ab2f9b78e6e754a1a DIFF: https://github.com/llvm/llvm-project/commit/28bd7945eabdbde2b1fc071ab2f9b78e6e754a1a.diff

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariabl

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + aaron.ballman wrote: > beanz wrote: > > aaron.ballman wrote:

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

MyDeveloperDay updated this revision to Diff 459074. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. - rebase with fixed doc NFC update - rework the nofallback condition to prevent repeated checks - fix grammar checks CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy, CK_IntegralToFloating); IntExpr = S.ImpCastExprToType(IntExpr.get(), ComplexT

[PATCH] D133522: [clang] Fix Complex x Float x Int conversions so it handles type sugar

mizvekov abandoned this revision. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1135 +QualType RHSElementType = +RHSComplexType ? RHSComplexType->getElementType() : RHSType; +QualType ResultType = shafik wrote: > Can you

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778883 , @MaskRay wrote: > Sorry, I just reverted it:) You may check whether the fix fixes GCC > libstdc++-v3/src/c++98/complex_io.cc I confirm it does not crash on my system with this patch. Repository: rG LLVM

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin created this revision. yronglin added reviewers: rjmccall, rsmith. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix __builtin_assume_aligned incorrect type descriptor example from @rsmith

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. In D133425#3779121 , @dblaikie wrote: >> One thing I don't understand in the current state of things is why the >> diagnostic fires at all inside system headers. I thought warnings in system >> headers were discarded? > > It doe

[PATCH] D133354: [Clang]: Diagnose deprecated copy operations also in MSVC compatibility mode

dblaikie added a comment. In D133354#3779882 , @ningvin wrote: > In D133354#3779123 , @dblaikie > wrote: > >> That works, you can also take the hash with the `rG` prefix and use that: >> rGd577fbbd1c9d6dab193d53

[clang] 493766e - Frontend: Respect -working-directory when checking if output files can be written

Author: Steven Wu Date: 2022-09-09T08:57:12-07:00 New Revision: 493766e068474a80a790ac41c667061229d2262d URL: https://github.com/llvm/llvm-project/commit/493766e068474a80a790ac41c667061229d2262d DIFF: https://github.com/llvm/llvm-project/commit/493766e068474a80a790ac41c667061229d2262d.diff LOG

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

This revision was automatically updated to reflect the committed changes. Closed by commit rG493766e06847: Frontend: Respect -working-directory when checking if output files can be… (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > mizvekov w

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 459090. python3kgae added a comment. Remove attribute for first cbuffer commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 Files: clang/include/clang/AST/D

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin added a comment. Hi, should I both fix alignment in this patch or in another separate patch? (this seems have different behavior with gcc https://godbolt.org/z/7dvM8zhnh ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/new/ https://

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

tahonermann added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator.

[PATCH] D133202: [Clang] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. I've a new patch D133583 , please can you guys take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Parse/ParseHLSL.cpp:79-80 +ParsedAttributes Attrs(AttrFactory); +MaybeParseCXX11Attributes(Attrs); +MaybeParseMicrosoftAttributes(Attrs); + beanz wrote: > aaron.ballman wrote: > > beanz wrote: >

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

yronglin updated this revision to Diff 459092. yronglin added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/new/ https://reviews.llvm.org/D133583 Files: clang/include/clang/Basic/Builtins.def clang/lib/Basic/Builtins.c

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

zero9178 added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. +

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added a comment. In D133425#3780435 , @ldionne wrote: > In D133425#3779121 , @dblaikie > wrote: > >>> One thing I don't understand in the current state of things is why the >>> diagnostic fires at all i

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman added a comment. Hi, I am not getting why **Sema/cast.c** is failing here. While all test are running fine on my system? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194

[PATCH] D133586: [clang] do not hash undefined qualifiers for FunctionNoProtoType

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When calculating the ODR hash of a `FunctionNoProtoType` do not include qualifiers derived from `FastTypeQuals`. These are only de

[PATCH] D133587: Loop names used in reporting can grow very large

jamieschmeiser created this revision. jamieschmeiser added reviewers: Whitney, dongjunduo, aeubanks, MaskRay. Herald added subscribers: ormris, StephenFan, steven_wu, zzheng, hiraditya. Herald added a project: All. jamieschmeiser requested review of this revision. Herald added projects: clang, LLVM

[PATCH] D133588: [NFC] Remove a FIXME fixed by an earlier patch.

ymandel created this revision. ymandel added a reviewer: sgatev. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Commit 28bd7945eabdbde2b1fc071ab2f9b78e6e754a1a

[PATCH] D133587: Loop names used in reporting can grow very large

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. this is something I've wanted to do for a while but never got around to thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133587/new/ ht

[PATCH] D133586: [clang] do not hash undefined qualifiers for FunctionNoProtoType

rmaz updated this revision to Diff 459108. rmaz added a comment. Move code to VisitFunctionProtoType instead of branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133586/new/ https://reviews.llvm.org/D133586 Files: clang/lib/AST/ODRHash.cpp

[clang] abc16c7 - [NFC] Remove a FIXME fixed by an earlier patch.

Author: Yitzhak Mandelbaum Date: 2022-09-09T17:13:52Z New Revision: abc16c7a5b0a63d14172262153608b3d24de957f URL: https://github.com/llvm/llvm-project/commit/abc16c7a5b0a63d14172262153608b3d24de957f DIFF: https://github.com/llvm/llvm-project/commit/abc16c7a5b0a63d14172262153608b3d24de957f.diff

[PATCH] D133588: [NFC] Remove a FIXME fixed by an earlier patch.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabc16c7a5b0a: [NFC] Remove a FIXME fixed by an earlier patch. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added a project: clang-format. Herald added a project: All. MyDeveloperDay requested review of this revision. Herald added a project: clang. Working in a mixed environment of

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

ymandel requested changes to this revision. ymandel added a comment. This revision now requires changes to proceed. It turns out that this change wasn't necessary. I've deleted the relevant FIXME in https://reviews.llvm.org/rGabc16c7a5b0a63d14172262153608b3d24de957f. AFAICT, the reason that the

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5904-5905 def err_block_extern_cant_init : Error< - "'extern' variable cannot have an initializer">; + "declaration of block scope identifier with %select{external|internal}0 " +

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

samestep accepted this revision. samestep added a comment. @ymandel Huh, interesting! I'll go ahead and abandon this patch, then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/ https://reviews.llvm.org/D130270 __

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

AaronLiu added a comment. This cause a large amount failures in our testing with errors such as: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister] error: ISO C++17 does not allow dynamic exception specifications [-Wdynamic-exception-spec] Repository: rG LL

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

shafik added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} aaron.ballman wrote: > shafik wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > > > > aaron.ballman wrote: > > > > > erichk

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

aaron.ballman added a comment. In D131465#3780717 , @AaronLiu wrote: > This cause a large amount failures in our testing with errors such as: > > error: ISO C++17 does not allow 'register' storage class specifier > [-Wregister] > > error: ISO C++17 d

[PATCH] D133499: [clang]: Add DeclContext::dumpDecl() in order to conveniently dump an AST from a DeclContext.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ASTDumper.cpp:205 + if (const Decl *D = dyn_cast(this)) +D->dump(); +} shafik wrote: > aaron.ballman wrote: > > shafik wrote: > > > aaron.ballman wrote: > > > > erichkeane wrote: > > > > > aaron.

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459121. Codesbyusman added a comment. updating one time again, to again run test as no failed test on my system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194

[PATCH] D133578: [OpenMP] Add generation of SIMD align assumptions to OMPIRBuilder

jdoerfert added a comment. Thanks for this patch! I have two drive by comments that should probably be addressed first. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:629 + llvm::ArrayRef AlignedVars, + llvm::Value *Alignment, Valu

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

ymandel added a comment. In D130270#3780705 , @samestep wrote: > @ymandel Huh, interesting! I'll go ahead and abandon this patch, then? Please. Sorry I didn't catch this earlier! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1225 assert(CAT && "can't emit array init for non-constant-bound array"); -unsigned NumInitElements = ILE->getNumInits(); -unsigned NumElements = CAT->getSize().getZExtValue(); +uint

[PATCH] D133194: rewording note note_constexpr_invalid_cast

aaron.ballman added inline comments. Comment at: clang/test/Sema/cast.c:2 // RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown %s -verify +// RUN: %clang_cc1 -std=c99 -fsyntax-only -DConstantCast -Wvla -verify %s + Instead of adding this RUN line, I

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. In D131465#3780717 , @AaronLiu wrote: > This cause a large amount failures in our testing with errors such as: > > error: ISO C++17 does not allow 'register' storage class specifier > [-Wregister] > > error: ISO C++17 does no

[clang] 5e3ac79 - Loop names used in reporting can grow very large

Author: Jamie Schmeiser Date: 2022-09-09T13:45:14-04:00 New Revision: 5e3ac7969039678fc017a5599b051ea2b78075a4 URL: https://github.com/llvm/llvm-project/commit/5e3ac7969039678fc017a5599b051ea2b78075a4 DIFF: https://github.com/llvm/llvm-project/commit/5e3ac7969039678fc017a5599b051ea2b78075a4.dif

[PATCH] D133587: Loop names used in reporting can grow very large

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e3ac7969039: Loop names used in reporting can grow very large (authored by jamieschmeiser). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32

OfekShochat added a subscriber: eli.friedman. OfekShochat added a comment. yep @eli.friedman. probably gonna scratch this idea, makes more sense to actually tackle the problem itself, which is that getArrayFiller doesnt return anything. trying to actually get to the problem, but its quite hard,

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. In D131465#3776841 , @nikic wrote: > In D131465#3776599 , @nikic wrote: > >> It looks like the switch to `-std=c++17` has some major compile-time impact: >> http://llvm-compile-time-track

[PATCH] D132913: [HLSL] Preserve vec3 for HLSL.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132913/new/ https://reviews.llvm.org/D132913 ___ c

  1   2   >