[clang-tools-extra] e42f5d4 - [clangd] Fix filename ranges while replaying preamble

Author: Kadir Cetinkaya Date: 2021-10-27T09:34:17+02:00 New Revision: e42f5d4b488e78ebf5b756e1e76422c7458ba81c URL: https://github.com/llvm/llvm-project/commit/e42f5d4b488e78ebf5b756e1e76422c7458ba81c DIFF: https://github.com/llvm/llvm-project/commit/e42f5d4b488e78ebf5b756e1e76422c7458ba81c.dif

[PATCH] D112559: [clangd] Fix filename ranges while replaying preamble

This revision was automatically updated to reflect the committed changes. Closed by commit rGe42f5d4b488e: [clangd] Fix filename ranges while replaying preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112559/new/ https:

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula added a comment. In D112284#3088531 , @tra wrote: > In D112284#3086499 , @bondhugula > wrote: > >> @tra While on this, I also wanted to ask as to why clang cuda codegen is >> using an argument on the

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Very nice. As discussed it'd be nice to enhance MainFileMacros at some point but it doesn't seem urgent Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:174 +

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:141 + // either v or zve* suppaort v instructions + bool hasStdExtV() const { return HasStdExtV || HasStdExtZve32x; } + bool hasStdExtZve32x() const { return HasStdExtZve32x; } cra

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382540. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382543. eopXD added a comment. Fix clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-ar

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382544. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382549. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

kbobyrev updated this revision to Diff 382550. kbobyrev added a comment. Use IncludeCleaner to clean the includes and clean up a little. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112447/new/ https://reviews.llvm.org/D112447 Files: clang-tool

[clang-tools-extra] e3c6090 - [clangd] IncludeCleaner: Support macros

Author: Kirill Bobyrev Date: 2021-10-27T10:30:04+02:00 New Revision: e3c6090e597685c23e9d2aac27d45c5a35b2f9bd URL: https://github.com/llvm/llvm-project/commit/e3c6090e597685c23e9d2aac27d45c5a35b2f9bd DIFF: https://github.com/llvm/llvm-project/commit/e3c6090e597685c23e9d2aac27d45c5a35b2f9bd.diff

[PATCH] D112447: [clangd] IncludeCleaner: Support macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3c6090e5976: [clangd] IncludeCleaner: Support macros (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 9fb52cb - [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

Author: Shraiysh Vaishay Date: 2021-10-27T14:05:44+05:30 New Revision: 9fb52cb3f1235639a5a357fb5de18e1aeeb5b5f4 URL: https://github.com/llvm/llvm-project/commit/9fb52cb3f1235639a5a357fb5de18e1aeeb5b5f4 DIFF: https://github.com/llvm/llvm-project/commit/9fb52cb3f1235639a5a357fb5de18e1aeeb5b5f4.di

[PATCH] D112565: [clangd] Add integration test for crash handling

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112565/new/ https://reviews.llvm.org/D112565 __

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:258 for (const auto *Inc : computeUnusedIncludes(AST)) { +// FIXME(kirillbobyrev): Standard library h

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

ardb created this revision. ardb added reviewers: nickdesaulniers, nathanchance, psmith. Herald added subscribers: hiraditya, kristof.beyls. ardb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In ARM mode, passing -mtp=cp

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:735 const StringMap> Implications = { -{"v", {"zvlsseg", "zvl128b"}}, +{"v", {"zvlsseg", "zvl128b", "zve64d"}}, + khchen wrote: > please update implication rule based on > http

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

whisperity added a comment. 100% typo. 😂 Aww 'chute... Bunch of rebases. Yeah I didn't add extensive tests for simply the configuration, only for the configurations working. Did you check the documentation file? It should mention the default values for the checker configuration options. Does it

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

salman-javed-nz added a comment. The documentation looks correct. https://clang.llvm.org/extra/clang-tidy/checks/bugprone-easily-swappable-parameters.html > By default, the following, and their lowercase-initial variants are ignored: > bool, It, Iterator, InputIt, ForwardIt, BidirIt, RandomIt, r

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Perfect! Have you obtained commit rights already, or should I go ahead and commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

frasercrmck added a comment. I think the rest of my comments would be to do with `zvl` so I'll leave it there to avoid repetition. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:65 + unsigned getMinVLen() const { return MinVLen; } + unsigned getMaxEew() const { return

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

salman-javed-nz added a comment. I have just received commit access, and this will be my first patch that I can commit on my own. I'll be in touch if I run into committing issues. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

eopXD added a comment. Sorry I mixed zvl patch when rebasing. I will remove it ASAP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112408/new/ https://reviews.llvm.org/D112408 ___ cfe-commits mailing lis

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382571. eopXD added a comment. Add implication: v imply d and f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Doing otherwise leads to crashi

[clang-tools-extra] 897402e - [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

Author: Salman Javed Date: 2021-10-27T22:38:52+13:00 New Revision: 897402e95988d41d7be88075f80a35ecdbc10d52 URL: https://github.com/llvm/llvm-project/commit/897402e95988d41d7be88075f80a35ecdbc10d52 DIFF: https://github.com/llvm/llvm-project/commit/897402e95988d41d7be88075f80a35ecdbc10d52.diff

[PATCH] D112596: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG897402e95988: [clang-tidy] Correct typo in bugprone-easily-swappable-parameters (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382574. eopXD added a comment. Address comments: - remove duplicate `checkDependency()` - stay consistent in my patch of using auto for `StringRef` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

kbobyrev updated this revision to Diff 382576. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112571/new/ https://reviews.llvm.org/D112571 Files: clang-t

[PATCH] D112571: [clangd] IncludeCleaner: Don't warn on system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4723785c190: [clangd] IncludeCleaner: Don't warn on system headers (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang-tools-extra] c472378 - [clangd] IncludeCleaner: Don't warn on system headers

Author: Kirill Bobyrev Date: 2021-10-27T11:51:08+02:00 New Revision: c4723785c1902d6a53f3808fa1dabb2a97c1cc6e URL: https://github.com/llvm/llvm-project/commit/c4723785c1902d6a53f3808fa1dabb2a97c1cc6e DIFF: https://github.com/llvm/llvm-project/commit/c4723785c1902d6a53f3808fa1dabb2a97c1cc6e.diff

[clang-tools-extra] 9cc08cb - [clangd] Add integration test for crash handling

Author: Sam McCall Date: 2021-10-27T11:52:31+02:00 New Revision: 9cc08cb02fdc4f8a2b717519c3bf33b4ed3070e4 URL: https://github.com/llvm/llvm-project/commit/9cc08cb02fdc4f8a2b717519c3bf33b4ed3070e4 DIFF: https://github.com/llvm/llvm-project/commit/9cc08cb02fdc4f8a2b717519c3bf33b4ed3070e4.diff LO

[PATCH] D112565: [clangd] Add integration test for crash handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cc08cb02fdc: [clangd] Add integration test for crash handling (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D112565?vs=382407&id=382579#toc Repository: rG LLVM Github Mo

[PATCH] D112409: [clang-tidy] Add check 'cert-err33-c'.

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:45-50 +// The following functions are +// deliberately excluded because they can +// be called with NULL argument and in +// this case the check is not applicable: +// mblen, mbrlen

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:44-49 +// Handle adjustment with non-comparison ops. +const llvm::APSInt &Zero = getBasicVals().getValue(0, SIE->getType()); +

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong updated this revision to Diff 382581. martong marked 3 inline comments as done. martong added a comment. - Add new test case - Adapt style changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112296/new/ https://reviews.llvm.org/D112296 F

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382582. eopXD added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

labrinea updated this revision to Diff 382584. labrinea added a comment. Changed AppleA10 to HasV8_0aOps CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AArch64.h clang/l

[PATCH] D112408: [WIP][RISCV] Add the zve extension according to the v1.0-rc2 spec

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:181 } + if (MinVLen) { khchen wrote: > please add a note in commit or comment here for those macros are proposed in > the PR https://github.c

[PATCH] D112406: [Driver][AArch64]Add driver support for neoverse-512tvb target

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with nit addressed. Comment at: llvm/lib/Target/AArch64/AArch64.td:840 +def TuneNeoverse512TVB : SubtargetFeature<"neoverse512tvb", "ARMProcFamily", "Neoverse512T

[clang] f0d527b - [clang-repl] Remove redundant link libraries and drop unused file.

Author: Vassil Vassilev Date: 2021-10-27T10:13:30Z New Revision: f0d527b28d07f2ce321e7055efb6635a62829eac URL: https://github.com/llvm/llvm-project/commit/f0d527b28d07f2ce321e7055efb6635a62829eac DIFF: https://github.com/llvm/llvm-project/commit/f0d527b28d07f2ce321e7055efb6635a62829eac.diff LO

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/CMakeLists.txt:5 + OrcJIT + Support ) thakis wrote: > v.g.vassilev wrote: > > v.g.vassilev wrote: > > > thakis wrote: > > > > Why are t

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

ASDenysPetrov accepted this revision. ASDenysPetrov added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:44-49 +// Handle adjustment with non-comparison ops. +const llvm::APSInt &Zero

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh updated this revision to Diff 382537. shraiysh added a comment. Rebase with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ https://reviews.llvm.org/D111992 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp flang/lib/Semantics/

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fb52cb3f123: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write (authored by shraiysh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111992/new/ ht

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

john.brawn accepted this revision. john.brawn added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110065/new/ https://reviews.llvm.org/D110065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

steakhal accepted this revision. steakhal added inline comments. Comment at: clang/test/Analysis/constraint-assignor.c:7 void clang_analyzer_warnIfReached(); +void clang_analyzer_eval(); Expect an `int` parameter. Repository: rG LLVM Github Monorepo CHANG

[clang] 8689f5e - [AArch64] Add support for the 'R' architecture profile.

Author: Alexandros Lamprineas Date: 2021-10-27T12:32:30+01:00 New Revision: 8689f5e6e77394528155b624d74557790278a407 URL: https://github.com/llvm/llvm-project/commit/8689f5e6e77394528155b624d74557790278a407 DIFF: https://github.com/llvm/llvm-project/commit/8689f5e6e77394528155b624d74557790278a4

[PATCH] D110065: [AArch64] Add support for the 'R' architecture profile.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8689f5e6e773: [AArch64] Add support for the 'R' architecture profile. (authored by labrinea). Changed prior to commit: https://reviews.llvm.org/D110065?vs=382584&id=382605#toc Repository: rG LLVM Git

[PATCH] D112608: [clangd] IncludeCleaner: Do not process locations in built-in files

kbobyrev updated this revision to Diff 382608. kbobyrev added a comment. Also handle the Command-Line defines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112608/new/ https://reviews.llvm.org/D112608 Files: clang-tools-extra/clangd/IncludeClea

[clang-tools-extra] 6edc509 - [clangd] NFC: Remove single-line braces in IncludeCleaner

Author: Kirill Bobyrev Date: 2021-10-27T13:53:30+02:00 New Revision: 6edc50971953775ab32d2bf298b4c991e8961055 URL: https://github.com/llvm/llvm-project/commit/6edc50971953775ab32d2bf298b4c991e8961055 DIFF: https://github.com/llvm/llvm-project/commit/6edc50971953775ab32d2bf298b4c991e8961055.diff

[clang] e76a9f1 - [clang][deps] Fix fragile test

Author: Jan Svoboda Date: 2021-10-27T14:00:13+02:00 New Revision: e76a9f16363c4a37b2b68da816a7bc2de0e7965e URL: https://github.com/llvm/llvm-project/commit/e76a9f16363c4a37b2b68da816a7bc2de0e7965e DIFF: https://github.com/llvm/llvm-project/commit/e76a9f16363c4a37b2b68da816a7bc2de0e7965e.diff L

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be simplified by using totalSizeToAlloc()? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://r

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail updated this revision to Diff 382618. lkail retitled this revision from "[compiler-rt][atomics] Support __atomic_fetch_nand" to "[clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall". lkail edited the summary of this revision. lkail a

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail added a comment. > The GCC builtins paint the ABI into a corner. They accept > non-`_Atomic`-qualified types (the C11 spec guarantees only that these > operations work on `_Atomic` types). The goal of the original C++ > specification was to allow implementations to use atomic operations

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

theraven accepted this revision. theraven added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112400/new/ https://reviews.llvm.org/D112400

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail updated this revision to Diff 382624. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112400/new/ https://reviews.llvm.org/D112400 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Builtins.def clang/lib/AST/Expr.cpp cla

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang/include/clang/AST/StmtObjC.h:279 + catch_stmt_iterator catch_stmts_end() { +return getStmts() + 1 + NumCatchStmts; + } i might have

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis added a comment. > Do you think the ObjCAtTryStmt::Create and CreateEmpty methods could be > simplified by using totalSizeToAlloc()? Oh nice. Done :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

thakis updated this revision to Diff 382627. thakis added a comment. more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112542/new/ https://reviews.llvm.org/D112542 Files: clang/include/clang/AST/StmtObjC.h clang/lib/AST/StmtObjC.cpp Index: clang/lib/AST/StmtObjC.cpp

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

thakis marked an inline comment as done. thakis added a comment. Done, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112543/new/ https://reviews.llvm.org/D112543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 382628. eopXD marked 4 inline comments as done. eopXD added a comment. Change: - Address commments on restrictions in RISCVSubtarget.cpp - Fix clang-format fail - Fix test case fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D112577: [clang][OpenMP] Initial parsing/sema for 'align' clause

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:334 +/// value of 8. +class OMPAlignClause : public OMPClause { + friend class OMPClauseReader; `final` Comment at: clang/include/clang/AST/OpenMPClause.h:362-36

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:134 "maximum!"); + assert(RVVVectorBitsMin >= ZvlLen && + "Minimum V extension vector length should be at least the length " eopXD wrote: > craig.topper wrote: >

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, rjmccall, arthur.j.odwyer. aaron.ballman requested review of this revision. Herald added a project: clang. When parsing the following construct, we parse it as an erroneous deduction guide declaration and corr

[clang] 7c10c9d - [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

Author: Nico Weber Date: 2021-10-27T08:57:05-04:00 New Revision: 7c10c9d8e8004a09b7477806eef53cbebee82333 URL: https://github.com/llvm/llvm-project/commit/7c10c9d8e8004a09b7477806eef53cbebee82333 DIFF: https://github.com/llvm/llvm-project/commit/7c10c9d8e8004a09b7477806eef53cbebee82333.diff LO

[clang] c7aaa2e - [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

Author: Nico Weber Date: 2021-10-27T08:57:05-04:00 New Revision: c7aaa2efefdd1bfc56b877dc08a4ee5633048195 URL: https://github.com/llvm/llvm-project/commit/c7aaa2efefdd1bfc56b877dc08a4ee5633048195 DIFF: https://github.com/llvm/llvm-project/commit/c7aaa2efefdd1bfc56b877dc08a4ee5633048195.diff LO

[PATCH] D112542: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c10c9d8e800: [clang] Convert ObjCAtTryStmt to llvm::TrailingObjects (authored by thakis). Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D112543: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7aaa2efefdd: [clang] Add range accessor for ObjCAtTryStmt catch_stmts and use it (authored by thakis). Herald added a project: clang. Changed prior

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 382632. Sockke added a comment. Update! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp clang-tools-extra/clang-tidy/performance/Mov

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke marked 2 inline comments as done. Sockke added a comment. In D107450#3087103 , @whisperity wrote: > I think this is becoming okay and looks safe enough. I can't really grasp > what `HasCheckedMoveSet` means, and how it synergises with storing >

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

jyknight added inline comments. Comment at: compiler-rt/lib/builtins/atomic.c:339 +#define ATOMIC_RMW_NAND(n, lockfree, type) \ + type __atomic_fetch_nand_##n(type *ptr, type val, int model) { \ Same as ATOMI

[PATCH] D111654: [analyzer] Retrieve a value from list initialization of multi-dimensional array declaration.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1706-1743 + // Check offsets for being out of bounds. // C++20 [expr.add] 7.6.6.4 (excerpt): // If P points to an array element i of an array object x with n // elements, where

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for cases, like: + // const char *str = "123"; // literal length is 4 + // char c = str[41];// offset is 41 + // It sh

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: teemperor. manas requested review of this revision. Herald added a project: clang. Her

[PATCH] D112400: [clang][compiler-rt][atomics] Add `__c11_atomic_fetch_nand` builtin and support `__atomic_fetch_nand` libcall

lkail added inline comments. Comment at: compiler-rt/lib/builtins/atomic.c:339 +#define ATOMIC_RMW_NAND(n, lockfree, type) \ + type __atomic_fetch_nand_##n(type *ptr, type val, int model) { \ jyknight wrote:

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. @steakhal @martong This patch solves the comparison between different types by bypassing the RangeSets first to `VisitBinaryOperator` which coarses/converts, and then only it checks for any True/False ranges via comparison. This is similar to what happens with `BO_Rem`, `

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. Please also demonstrate that the patch can deal with sign mismatching ranges. Aside from that, it looks clean and sweet. Although, I still miss the point of how it would bypass anything. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam updated this revision to Diff 382663. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112094/new/ https://reviews.llvm.org/D112094 Files: clang/docs/LanguageExtensions.rst clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOpti

[PATCH] D112094: Add support for floating-point option `ffp-eval-method` and for `pragma clang fp eval_method`.

zahiraam added a comment. In D112094#3087531 , @aaron.ballman wrote: > One thing I think we need additional test coverage for is constant expression > evaluation. Should the pragma impact the resulting value stored into `f`: > > constexpr long double

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. It seems like the test does not exercise the modified code segment. Please investigate, and make sure that the code you submit is actually exercised by the test you provide. Rep

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille updated this revision to Diff 382671. serge-sans-paille added a comment. - Use a FunctionDecl Attribute to store the shadowed inline redecl status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112059/new/ https://reviews.llvm.org/D112059 Files: clang/include/clang/A

[PATCH] D112600: [ARM] Use hardware TLS register in Thumb2 mode when -mtp=cp15 is passed

nathanchance added a subscriber: peter.smith. nathanchance added a comment. I tested this against `next-20211027`, where it resolved the build error and boots in QEMU master without any visible issues. Disassembly between GCC and clang seems to be good. I'll leave it up to @nickdesaulnier

[PATCH] D112059: Fix inline builtin handling in case of redefinition

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/user-func-gnu-inline-redecl.c:20 + return some_size(s); +} nickdesaulniers wrote: > this test passes before this patch is applied; I wonder if we have existing > coverage in tree for this c

[clang] 888af47 - [Analyzer][solver] Simplification: reorganize equalities with adjustment

Author: Gabor Marton Date: 2021-10-27T16:48:55+02:00 New Revision: 888af47095d5a7121c1d78566df59c292f30ceaf URL: https://github.com/llvm/llvm-project/commit/888af47095d5a7121c1d78566df59c292f30ceaf DIFF: https://github.com/llvm/llvm-project/commit/888af47095d5a7121c1d78566df59c292f30ceaf.diff

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG888af47095d5: [Analyzer][solver] Simplification: reorganize equalities with adjustment (authored by martong). Changed prior to commit: https://rev

[PATCH] D111642: [Analyzer][solver] Simplification: reorganize equalities with adjustment

martong marked an inline comment as done. martong added a comment. Thanks for the assiduous review guys! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111642/new/ https://reviews.llvm.org/D111642 ___ cfe

[PATCH] D107339: [analyzer] Retrieve a character from StringLiteral as an initializer for constant arrays.

steakhal added a comment. It looks good to me. I don't mind that FIXME. That being said, I'm not even sure it's a FIXME. Check my comment inline about this. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1757-1760 + // FIXME: Nevertheless, we can't do the same for

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

Quuxplusone added a comment. @lewissbaker wrote: > #include // which transitively includes > #include Good example! I had not previously been thinking about transitive includes. I believe we "obviously" don't need to cater to code that manually includes both `` and `` in the same source

[clang] 749581d - [IR] `IRBuilderBase::CreateAnd()`: fix short-circuiting for constant on LHS

Author: Roman Lebedev Date: 2021-10-27T18:01:06+03:00 New Revision: 749581d21f2b3f53e4fca4eb8728c942d646893b URL: https://github.com/llvm/llvm-project/commit/749581d21f2b3f53e4fca4eb8728c942d646893b DIFF: https://github.com/llvm/llvm-project/commit/749581d21f2b3f53e4fca4eb8728c942d646893b.diff

[clang] f3190de - [IR] `IRBuilderBase::CreateAnd()`: short-circuit `x & 0` --> `0`

Author: Roman Lebedev Date: 2021-10-27T18:01:06+03:00 New Revision: f3190dedeef9da2109ea57e4cb372f295ff53b88 URL: https://github.com/llvm/llvm-project/commit/f3190dedeef9da2109ea57e4cb372f295ff53b88 DIFF: https://github.com/llvm/llvm-project/commit/f3190dedeef9da2109ea57e4cb372f295ff53b88.diff

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 382679. ASDenysPetrov added a comment. @martong @steakhal Updated according to your comments. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Co

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

martong marked an inline comment as done. martong added a comment. @ASDenysPetrov @steakhal Thanks for the assiduous reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112296/new/ https://reviews.llvm.org/D112296 __

[clang] a8297ed - [Analyzer][solver] Handle adjustments in constraint assignor remainder

Author: Gabor Marton Date: 2021-10-27T17:14:34+02:00 New Revision: a8297ed994301dbf34f259690e9f5fa8fce96ea2 URL: https://github.com/llvm/llvm-project/commit/a8297ed994301dbf34f259690e9f5fa8fce96ea2 DIFF: https://github.com/llvm/llvm-project/commit/a8297ed994301dbf34f259690e9f5fa8fce96ea2.diff

[PATCH] D112296: [Analyzer][solver] Handle adjustments in constraint assignor remainder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8297ed99430: [Analyzer][solver] Handle adjustments in constraint assignor remainder (authored by martong). Changed prior to commit: https://revie

[clang] 9fcca8b - Fix consteval crash when transforming 'this' expressions

Author: Aaron Ballman Date: 2021-10-27T11:25:07-04:00 New Revision: 9fcca8b470fb92466ec4cada9fbeacc90096116d URL: https://github.com/llvm/llvm-project/commit/9fcca8b470fb92466ec4cada9fbeacc90096116d DIFF: https://github.com/llvm/llvm-project/commit/9fcca8b470fb92466ec4cada9fbeacc90096116d.diff

[PATCH] D111814: Fix consteval crash when transforming 'this' expressions

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 9fcca8b470fb92466ec4cada9fbeacc90096116d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D112627: [clang] Inclusive language: change error message to use allowlist

ZarkoCA created this revision. ZarkoCA added reviewers: tuktuk, vitalybuka, MaskRay. ZarkoCA added a project: clang. ZarkoCA requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112627 Files: clang/include/cl

[PATCH] D112628: NOT READY FOR REVIEW Nothing to see here, just exporting to show this to someone.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112628 Files: clan

[PATCH] D112059: Fix inline builtin handling in case of redefinition

aaron.ballman added a comment. In D112059#3090466 , @serge-sans-paille wrote: > - Use a FunctionDecl Attribute to store the shadowed inline redecl status The downside to this approach is that we can now handle less ctor initializers because we need to

  1   2   3   >