[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

steakhal added a comment. Herald added a subscriber: manas. In D75171#1954405 , @Szelethus wrote: > In D75171#1954279 , @sylvestre.ledru > wrote: > >> @baloghadamsoftware @Szelethus it would be great to have the na

[clang] fb321c2 - [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-01T10:15:17+01:00 New Revision: fb321c2ea274c1bd1e1b294f2c090f1c0d9a97fe URL: https://github.com/llvm/llvm-project/commit/fb321c2ea274c1bd1e1b294f2c090f1c0d9a97fe DIFF: https://github.com/llvm/llvm-project/commit/fb321c2ea274c1bd1e1b294f2c090f1c0d9a97fe.dif

[PATCH] D108704: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb321c2ea274: [OpenCL] Define OpenCL 3.0 optional core features in C++ for OpenCL 2021 (authored by Topotuna). Repository: rG LLVM Github Monorepo

[PATCH] D108989: [OpenCL] Supports optional 64-bit floating point types in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108989/new/ https://reviews.llvm.org/D108989 _

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo created this revision. blackgnezdo added a reviewer: brad. Herald added a subscriber: krytarowski. blackgnezdo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OpenBSD with this change would use this name for ASan: /usr/lib/clang

[clang] f0514a4 - Reland "[clang-repl] Re-implement clang-interpreter as a test case."

Author: Vassil Vassilev Date: 2021-09-01T10:21:38Z New Revision: f0514a4d26100239088f08d618f2ba100f59958e URL: https://github.com/llvm/llvm-project/commit/f0514a4d26100239088f08d618f2ba100f59958e DIFF: https://github.com/llvm/llvm-project/commit/f0514a4d26100239088f08d618f2ba100f59958e.diff LO

[clang] 83f3782 - [clang-nvlink-wrapper] Wrapper around nvlink for archive files

Author: Saiyedul Islam Date: 2021-09-01T16:00:29+05:30 New Revision: 83f3782c6129e7a5df3faaf0ae576611d16a8d49 URL: https://github.com/llvm/llvm-project/commit/83f3782c6129e7a5df3faaf0ae576611d16a8d49 DIFF: https://github.com/llvm/llvm-project/commit/83f3782c6129e7a5df3faaf0ae576611d16a8d49.diff

[PATCH] D108912: [release][analyzer] Add 13.0.0 release notes

ASDenysPetrov added a comment. Here is one more related to HTML diagnostics: rG9e02f58780ab8734e5d27a0138bd477d18ae64a1 //Highlight arrows for currently selected event// Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D109051: Use Component in OpenBSD::getCompilerRT to find libraries

blackgnezdo added a comment. OpenBSD commit: https://github.com/openbsd/src/commit/0b99cc4d5d8311a90145e8f4c6ae23275c275c52 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109051/new/ https://reviews.llvm.org/D109051 ___

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. I like that! Though for now, any tests that displays how these notes can emit different messages for different `BugType`s will suffice, so we can bypass other design discussions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] cec7c2b - Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly"

Author: Zahira Ammarguellat Date: 2021-09-01T04:48:50-07:00 New Revision: cec7c2b32ecfd38151822a6e01ec78afaf98bf9a URL: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a DIFF: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a

[PATCH] D109003: Ensure field-annotations on pointers properly match the AS of the field.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2408 llvm::Type *VTy = V->getType(); - llvm::Function *F = CGM.getIntrinsic(llvm::Intrinsic::ptr_ann

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Herald added a subscriber: ormris. The test fails for me on macOS (normal cmake build): % tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests [==] Running 1 test from 1 test suite. [--] Global test environment set-up.

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. Also failing on the bots: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/23343/execution/node/39/log/ (that's for the original land, but from what I can tell nothing has changed in this regard for the reland, and I'm still seeing the same failure

[clang] 9b6c813 - Revert "Reland "[clang-repl] Re-implement clang-interpreter as a test case.""

Author: Nico Weber Date: 2021-09-01T08:35:33-04:00 New Revision: 9b6c8132d3785269512803ff51cb421f8d8bcf0e URL: https://github.com/llvm/llvm-project/commit/9b6c8132d3785269512803ff51cb421f8d8bcf0e DIFF: https://github.com/llvm/llvm-project/commit/9b6c8132d3785269512803ff51cb421f8d8bcf0e.diff LO

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added a comment. In D107049#2976603 , @thakis wrote: > The test fails for me on macOS (normal cmake build): > > % > tools/clang/unittests/Interpreter/ExceptionTests/ClangReplInterpreterExceptionTests > [==] Running 1 test from 1

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

thakis added a comment. > I did not find a good way to 'find back' the clang resource-dir and it seems > to be put in a constant place. The test needs to have a compiled and > interpreted parts -- it throws an exception from the interpreter land and > expects a compiled binary to be able to cat

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield created this revision. JonChesterfield added reviewers: tianshilei1992, grokos, jdoerfert. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The commandline

[clang] 42ae7eb - Ensure field-annotations on pointers properly match the AS of the field.

Author: Erich Keane Date: 2021-09-01T06:12:24-07:00 New Revision: 42ae7eb581ff6abf77524f4c9e4333262c95aa4b URL: https://github.com/llvm/llvm-project/commit/42ae7eb581ff6abf77524f4c9e4333262c95aa4b DIFF: https://github.com/llvm/llvm-project/commit/42ae7eb581ff6abf77524f4c9e4333262c95aa4b.diff L

[PATCH] D109003: Ensure field-annotations on pointers properly match the AS of the field.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42ae7eb581ff: Ensure field-annotations on pointers properly match the AS of the field. (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D109003?

[PATCH] D107589: [CMake] Support setting default fused FP contract via CMake

hans added a comment. I just got back from vacation, so am probably missing some of the discussion elsewhere, but I'm a bit skeptical of this patch. It seems it would be confusing for users if clang generates code with different floating-point behaviour depending on how it was built. Reposito

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Topotuna updated this revision to Diff 369913. Topotuna retitled this revision from "[OpenCL] Supports optional generic address space in C++ for OpenCL 2021" to "[OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021". Topotuna edited the summary of this revision. Topotu

[PATCH] D109060: Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109060 Files: clang/test/CodeGenObjC/2007-05-02-Strong.m clang/test/CodeGenObjC

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, grokos, tianshilei1992. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, Op

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1701 StringRef ArchPrefix = Triple.isAMDGCN() ? "amdgcn" : "nvptx"; + std::string LibOmpTargetName = "libomptarget-" + BitcodeSuffix.str() + ".bc"; This part is co

[PATCH] D109060: Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add lit.local.cfg and add the unsupport there, no adding to every files in the folder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109060/new/ https://rev

[PATCH] D108917: [PowerPC] Define __powerpc and __PPC macros

cebowleratibm added a comment. The XL compiler only defined this weird form of the macros on AIX, but not on the XL Linux on Power compiler. I think it's preferable that we define these macros only on AIX and in the source/commit messages indicate that we're only doing so for AIX XL C/C++ comp

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

Jake-Egan added a comment. In D109060#2976745 , @jsji wrote: > For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add > lit.local.cfg and add the unsupport there, no adding to every files in the > folder? These tests are a subset of th

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

balazske added a comment. The following test is not good in place of the 3rd? It is nearly the same, only the condition `(!ferror(F) && !feof(F))` is used instead of call to `clearerr`. void check_indeterminate_notes_fseek_no_feof_no_ferror() { FILE *F; char Buf[10]; F = fopen("foo

[PATCH] D109060: [AIX] Disable LIT tests on AIX due to lack of Objective-C support

jsji added a comment. In D109060#2976752 , @Jake-Egan wrote: > In D109060#2976745 , @jsji wrote: > >> For `clang/test/CodeGenObjCXX` and `clang/test/CodeGenObjC`, can we add >> lit.local.cfg and add the unsupport

[PATCH] D108917: [PowerPC] Define __powerpc and __PPC macros

Jake-Egan updated this revision to Diff 369932. Jake-Egan added a comment. Define for AIX only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Prepr

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @rsmith ping again, did you get a time to take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 ___ cfe-commits mailing li

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus updated this revision to Diff 369935. Szelethus marked 5 inline comments as done. Szelethus added a comment. Herald added a subscriber: mgorny. - Make sure that the matching CallExitEnd is retrieved. - Add a unit test to neatly demonstrate how the visitor is intended to be used. - Fix th

[PATCH] D107764: [OpenMP][OpenMPIRBuilder] Implement loop unrolling.

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. Thanks for the responses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107764/new/ https://reviews.llvm.org/D107764 ___

[PATCH] D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:361 + while (!SCtx->inTopFrame()) { +auto p = FramesModifying.insert(SCtx); +if (!p.second) martong wrote: > Wh

[clang-tools-extra] d8afa57 - [clang-tidy] Fix documentation typos (NFC)

Author: Kazu Hirata Date: 2021-09-01T08:48:31-07:00 New Revision: d8afa5777b66f6193aac3c6b0dcb5680f8cf0d3d URL: https://github.com/llvm/llvm-project/commit/d8afa5777b66f6193aac3c6b0dcb5680f8cf0d3d DIFF: https://github.com/llvm/llvm-project/commit/d8afa5777b66f6193aac3c6b0dcb5680f8cf0d3d.diff L

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 _

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but please add a test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 __

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

cebowleratibm requested changes to this revision. cebowleratibm added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Preprocessor/init-ppc.c:520 // PPC-AIX:#define __POWERPC__ 1 +// PPC-AIX:#define __PPC 1 // PPC-AIX:#define __PPC__ 1 ---

[PATCH] D108421: Mark openmp internal global dso_local

kamleshbhalui added a comment. In D108421#2958848 , @MaskRay wrote: > If you read the comment in TargetMachine::shouldAssumeDSOLocal: this is the > wrong direction. dso_local is assumed to be marked by the frontend. > > Direct accesses and GOT accesses a

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977084 , @jdoerfert wrote: > LG, but please add a test for this. D109061 sends everything in check-openmp down this code path, but we should indeed have a check for the file

[PATCH] D106809: [clang-offload-bundler] Make Bundle Entry ID backward compatible

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106809/new/ https://reviews.llvm.org/D106809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D108421: Mark openmp internal global dso_local

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D108421#2977107 , @kamleshbhalui wrote: > In D108421#2958848 , @MaskRay wrote: > >> If you re

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369969. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/test/Driver/openmp-offload-gpu.c Index: clang/test/Driver/openmp-offload-gpu.c

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Well, that's not helpful. Managed to add a test through the webui as arcanist was misbehaving but it has worked by deleting the functional change. Will try again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369971. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index: cl

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield updated this revision to Diff 369972. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109057/new/ https://reviews.llvm.org/D109057 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/openmp-offload-gpu.c Index: cl

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. OK, test added, same code as originally, checked that the test fails on trunk. Because it's driver only we don't get a far as the fatal error, but you can see the driver passing the directory through to builtin-bitcode. Will land when the premerge checks catch u

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:1729 bool IsOpenCLC30 = (S.getLangOpts().OpenCLVersion == 300); +bool IsOpenCLC30Comp = S.getLangOpts().getOpenCLCompatibleVersion() == 300; // OpenCL C v3.0 s6.3.3 - OpenCL image types require

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/lib/Basic/TargetInfo.cpp:413 OpenCLFeaturesMap, "__opencl_c_generic_address_space"); - Opts.OpenCLPipes = - hasF

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

nemanjai added a comment. The idea with putting all of these in a separate function was to: 1. Make it easy to limit it to specific targets as I suggested above 2. Have them all in one place to easily identify which ones are added for this compatibility so we can eventually pull this support onc

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. We recently enabled assertions in our Fuchsia builds, and our builds started to fail: FAILED: obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o ../../../recipe_cleanup/clangLhcV7J/bin/clang++ -MD -MF obj/src/lib/storage/vfs/cpp/libcpp.fuchsia_vfs.cc.o.d -D_LIBCPP_

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

gulfem added a comment. @aaron.ballman would it be possible for you to review this patch, so we can fix our broken builds? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

Jake-Egan updated this revision to Diff 369992. Jake-Egan added a comment. Add negative test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Preproce

[PATCH] D108761: [OpenCL] Remove decls for scalar vloada_half and vstorea_half* fns

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108761/new/ https://reviews.llvm.org/D108761 _

[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108470/new/ https://reviews.llvm.org/D108470 ___ cfe-commits mailing list

[PATCH] D109078: [clang][driver][AIX] Add system libc++ header paths to driver

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, stevewan, ZarkoCA. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds the system libc++ header location to the driver. As well we defi

[PATCH] D108360: [clang][NFC] Remove dead code

Anastasia added a comment. In D108360#2962010 , @wingo wrote: > @Anastasia is this good to go for you or does this need closer attention? Yeah I agree that this code seems like a left-over from some refactoring as it seems to have no effect. Repositor

[PATCH] D108360: [clang][NFC] Remove dead code

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108360/new/ https://reviews.llvm.org/D108360

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

efriedma added a comment. I'd prefer not to mess with the AST if we don't need to; more differences between targets make it harder to understand any issues that come up. BPF-flavored C already has enough weird differences without adding unnecessary changes. If all you need is to avoid unneces

[PATCH] D107882: BPF: Enable frontend constant folding for VLA size

yonghong-song added a comment. @efriedma Thanks for suggestion! Let me look at CodeGenFunction::EmitAutoVarAlloca() call instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107882/new/ https://reviews.llvm.org/D107882 _

[clang] 0173e02 - [openmp] Accept directory for libomptarget-bc-path

Author: Jon Chesterfield Date: 2021-09-01T19:46:21+01:00 New Revision: 0173e024fd9e779a94503040a532bcf125277f86 URL: https://github.com/llvm/llvm-project/commit/0173e024fd9e779a94503040a532bcf125277f86 DIFF: https://github.com/llvm/llvm-project/commit/0173e024fd9e779a94503040a532bcf125277f86.di

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0173e024fd9e: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3d157cf - [clang] Add a -canonical-prefixes option

Author: Nico Weber Date: 2021-09-01T14:51:06-04:00 New Revision: 3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 URL: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7 DIFF: https://github.com/llvm/llvm-project/commit/3d157cfcc4ef2b4e09a36d3249c960d0a4099ca7.diff LO

[PATCH] D108818: [clang] Add a -canonical-prefixes option

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d157cfcc4ef: [clang] Add a -canonical-prefixes option (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt Please take a look and revert if it takes a while to fix. Probably just need to optionally accept win slashiness in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370024. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp openmp

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. I suppose it require users to add a command line argument every time they want to build a program? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a228f872fbb: [openmp] No longer use LIBRARY_PATH to find devicertl (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 7a228f8 - [openmp] No longer use LIBRARY_PATH to find devicertl

Author: Jon Chesterfield Date: 2021-09-01T20:24:34+01:00 New Revision: 7a228f872fbbefa6a6eba1d51da192761879fcca URL: https://github.com/llvm/llvm-project/commit/7a228f872fbbefa6a6eba1d51da192761879fcca DIFF: https://github.com/llvm/llvm-project/commit/7a228f872fbbefa6a6eba1d51da192761879fcca.di

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. In D109057#2977632 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/44930/step_7.txt > > Please take a look and revert if it takes a while to fix. Probably just need > to optionally accept win slash

[clang] 88511f6 - [libomptarget] Drop path separator from test to fix windows build

Author: Jon Chesterfield Date: 2021-09-01T20:34:58+01:00 New Revision: 88511f6bc56792b47fb6e003f5357eff3b94717a URL: https://github.com/llvm/llvm-project/commit/88511f6bc56792b47fb6e003f5357eff3b94717a DIFF: https://github.com/llvm/llvm-project/commit/88511f6bc56792b47fb6e003f5357eff3b94717a.di

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Nope, works the same as it used to - looks relative to clang. However I think it's broken some CI machines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 ___

[clang] cef1199 - Revert "[openmp] No longer use LIBRARY_PATH to find devicertl"

Author: Jon Chesterfield Date: 2021-09-01T20:44:12+01:00 New Revision: cef1199686475c0c63ba63ddb56f46bc7866fa3e URL: https://github.com/llvm/llvm-project/commit/cef1199686475c0c63ba63ddb56f46bc7866fa3e DIFF: https://github.com/llvm/llvm-project/commit/cef1199686475c0c63ba63ddb56f46bc7866fa3e.di

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In D109061#2977690 , @JonChesterfield wrote: > Nope, works the same as it used to - looks relative to clang. However I think > it's broken some CI machines Well, it also breaks when OpenMP is built standalone. Reposito

[clang] 6b0636c - Revert "[openmp] Accept directory for libomptarget-bc-path"

Author: Jon Chesterfield Date: 2021-09-01T20:45:41+01:00 New Revision: 6b0636ce535efb8649e7cd01ccd03825fd63f8a2 URL: https://github.com/llvm/llvm-project/commit/6b0636ce535efb8649e7cd01ccd03825fd63f8a2 DIFF: https://github.com/llvm/llvm-project/commit/6b0636ce535efb8649e7cd01ccd03825fd63f8a2.di

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Bad times. Changing that to accept the / was a shotgun fix for the problem but it collides with one of the nearby regex, reverting while I work out what is going on Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. From my perspective, using `LIBRARY_PATH` to find bitcode library conforms with convention because the library is linked in a linkage during compilation time, where `LIBRARY_PATH` is used by the linker. If we don't want to mess up test results, the patch to force

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. Another thing is how we deal with a corner case. Say the OpenMP code is written in the following way: #pragma omp atomic compare x = e < x ? e : x; That's how OpenMP spec defines the atomic operation. `x` is always in "else statement" of a conditional stat

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. Using LIBRARY_PATH to find the bitcode is a reasonable interpretation of LIBRARY_PATH but it's a disaster in terms of using clang on a system that has LIBRARY_PATH pointing at some other version of clang. Rpath will be ignored by the bitcode lib handling. How d

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Anastasia added a comment. In D106343#2974055 , @haonanya wrote: > Hi, svenvh and Anastasia. If you approve the patch, could you please submit > it? > I don't have permission to do it. Sure, I can commit it on your behalf, `atomic_half` can be added sep

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

tianshilei1992 added a comment. In D109061#2977714 , @JonChesterfield wrote: > Using LIBRARY_PATH to find the bitcode is a reasonable interpretation of > LIBRARY_PATH but it's a disaster in terms of using clang on a system that has > LIBRARY_PATH point

[clang] 8976a1e - VFS: Document goals of 'use-external-name' and related logic, NFC

Author: Duncan P. N. Exon Smith Date: 2021-09-01T15:55:33-04:00 New Revision: 8976a1e111393aab7b4965196364ad734a17f2d5 URL: https://github.com/llvm/llvm-project/commit/8976a1e111393aab7b4965196364ad734a17f2d5 DIFF: https://github.com/llvm/llvm-project/commit/8976a1e111393aab7b4965196364ad734a17

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a subscriber: kito.cheng. apivovarov added a comment. @evandro @kito-cheng @kito.cheng @khchen @MaskRay Could you review this patch? Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108

[PATCH] D108886: Add RISC-V sifive-s51 cpu

jrtc27 added a comment. In D108886#2977730 , @apivovarov wrote: > @evandro @kito-cheng @kito.cheng @khchen @MaskRay Could you review this > patch? Thank you You don't need to tag people as well as adding them as reviewers, it's just annoying. Also, it

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 updated this revision to Diff 370036. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://reviews.llvm.org/D102449 Files: clang/include/clang/AST/OpenMPClause.h clang/include/

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield added a comment. That helps disambiguate. You aren't concerned that this change will break the in tree tests, rather that people who currently rely on LIBRARY_PATH to choose a bitcode library to use with a clang located somewhere else in the filesystem will now need to pass --li

[PATCH] D108886: Add RISC-V sifive-s51 cpu

MaskRay added a comment. Looks reasonable. You can add a bullet point to clang/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 ___ cfe-com

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

thakis created this revision. thakis added a reviewer: hans. Herald added a subscriber: pengfei. thakis requested review of this revision. When using __readfsdword(), clang used to warn that one has to include -- no matter if that was already included or not. Now it only warns if it's not yet in

[clang] c7cbf1a - [openmp] Accept directory for libomptarget-bc-path

Author: Jon Chesterfield Date: 2021-09-01T21:22:35+01:00 New Revision: c7cbf1a03ea6f624be54370ea7b571842bc67dda URL: https://github.com/llvm/llvm-project/commit/c7cbf1a03ea6f624be54370ea7b571842bc67dda DIFF: https://github.com/llvm/llvm-project/commit/c7cbf1a03ea6f624be54370ea7b571842bc67dda.di

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7cbf1a03ea6: [openmp] Accept directory for libomptarget-bc-path (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D109057?vs=370006&id=370040#toc Repository: rG LLVM G

[PATCH] D108917: [AIX][PowerPC] Define __powerpc and __PPC macros

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108917/new/ https://reviews.llvm.org/D108917

[PATCH] D109085: clang/win: Add __readfsdword to intrin.h

thakis updated this revision to Diff 370041. thakis added a comment. no-op rebase in the hope that the precommit bot doesn't run in a "git lockfile already held" error again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109085/new/ https://reviews.llvm.org/D109085 Files: clang/lib/H

[PATCH] D109061: [openmp] No longer use LIBRARY_PATH to find devicertl

JonChesterfield updated this revision to Diff 370047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109061/new/ https://reviews.llvm.org/D109061 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp openmp/libomptarget/test/lit.cfg Index: openmp/l

[clang] 06cdf48 - [openmp] Drop test from D109057, disproportionately difficult to run on windows

Author: Jon Chesterfield Date: 2021-09-01T21:51:51+01:00 New Revision: 06cdf48a0d94749a19b0b7075a8baf9d979bb409 URL: https://github.com/llvm/llvm-project/commit/06cdf48a0d94749a19b0b7075a8baf9d979bb409 DIFF: https://github.com/llvm/llvm-project/commit/06cdf48a0d94749a19b0b7075a8baf9d979bb409.di

[PATCH] D109057: [openmp] Accept directory for libomptarget-bc-path

JonChesterfield added a comment. Turns out {{.}} is also fine as far as Linux is concerned and unacceptable to Windows. I can't run anything on Windows locally, and trial and error while watching http://45.33.8.238/win has taken too many iterations already, so I've dropped the test case in 06cd

[PATCH] D108886: Add RISC-V sifive-s51 cpu

apivovarov added a comment. In D108886#2977733 , @jrtc27 wrote: > You don't need to tag people as well as adding them as reviewers, it's just > annoying. Also, it's only been four days; the developer policy is that for > non-urgent patches you shouldn't

  1   2   >