[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

2021-08-01 Thread Anshil Gandhi via Phabricator via cfe-commits
gandhi21299 updated this revision to Diff 363324. gandhi21299 added a comment. Herald added a subscriber: pengfei. - transferred code over to AtomicExpandPass to be able to call `getAnalysis().getORE()` and simplify code as `SITargetLowering::shouldExpandAtomicRMW()` is called there. Repositor

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2021-08-01 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Seems like lnt related things are stable now so maybe it is a good time to update release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 __

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. Forgot to mention that we may need to backport this patch to the llvm13 branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 __

[clang] 25a288b - [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2021-08-01T23:01:00+03:00 New Revision: 25a288b009f7d30b5392ea36c29570cbdcf238c3 URL: https://github.com/llvm/llvm-project/commit/25a288b009f7d30b5392ea36c29570cbdcf238c3 DIFF: https://github.com/llvm/llvm-project/commit/25a288b009f7d30b5392ea36c29570cbdcf238c3.diff

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG25a288b009f7: [clang-repl] Fix building with win32 dylibs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D107231#2918824 , @v.g.vassilev wrote: > Forgot to mention that we may need to backport this patch to the llvm13 > branch. That might be good yes, especially if you intend to enable it by default there too. (I only noticed

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. In D107231#2918834 , @mstorsjo wrote: > In D107231#2918824 , @v.g.vassilev > wrote: > >> Forgot to mention that we may need to backport this patch to the llvm13 >> branch. > > That

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

2021-08-01 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a subscriber: tstellar. mstorsjo added a comment. In D107231#2918835 , @v.g.vassilev wrote: > In D107231#2918834 , @mstorsjo > wrote: > >> In D107231#2918824

[PATCH] D107241: Define __THW_BIG_ENDIAN__ macro

2021-08-01 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107241 Files: clang/lib/Basic/Target

[PATCH] D107242: Define __HOS_AIX__ macro

2021-08-01 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107242 Files: clang/lib/Basic/Target

[PATCH] D107243: Define __THW_PPC__ macro

2021-08-01 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107243 Files: clang/lib/Bas

[PATCH] D107244: Define _ARCH_PPC64 macro for 32-bit

2021-08-01 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107244 Files: clang/lib/Bas

[clang] 0e25867 - [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

2021-08-01 Thread Michael Kruse via cfe-commits
Author: Michael Kruse Date: 2021-08-01T19:08:13-05:00 New Revision: 0e2586779ca6606a3df085f253a31b89b8ad8508 URL: https://github.com/llvm/llvm-project/commit/0e2586779ca6606a3df085f253a31b89b8ad8508 DIFF: https://github.com/llvm/llvm-project/commit/0e2586779ca6606a3df085f253a31b89b8ad8508.diff

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

2021-08-01 Thread Michael Kruse via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2586779ca6: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions. (authored by Meinersbur). Reposi

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

2021-08-01 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. @mstorsjo I've taken all steps required for the resolution suggested @aaron.ballman. llvm.org/PR51300 suberseedes llvm.org/PR51261 (release-13.x branch is under @tstellard's control). D107183 has been pushed to main to fix the outs

[PATCH] D105690: [RISCV] Rename assembler mnemonic of unordered floating-point reductions for v1.0-rc change

2021-08-01 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105690/new/ https://reviews.llvm.org/D105690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

2021-08-01 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

2021-08-01 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:179 const std::vector &IntrinsicTypes, - StringRef RequiredExtension, unsigned NF); + const std::vector RequiredExtensions, unsigned NF); ~RVVIntr

[PATCH] D107248: [RISCV] Define preprocessor definitions for 'P' extension

2021-08-01 Thread Jim Lin via Phabricator via cfe-commits
Jim created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2021-08-01 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:69 +def sub_lo : SubRegIndex<32>; +def sub_hi : SubRegIndex<32, 32>; Jim wrote: > jrtc27 wrote: > > Jim wrote: > > > Jim wrote: > > > > luismarques wrote: > > > > > jrtc27 wrot

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

2021-08-01 Thread Jianjian Guan via Phabricator via cfe-commits
jacquesguan added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:179 const std::vector &IntrinsicTypes, - StringRef RequiredExtension, unsigned NF); + const std::vector RequiredExtensions, unsigned NF); ~RVVIntri

[PATCH] D95590: [RISCV] Define preprocessor definitions for 'P' extension

2021-08-01 Thread Jim Lin via Phabricator via cfe-commits
Jim updated this revision to Diff 363371. Jim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95590/new/ https://reviews.llvm.org/D95590 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h clang/tes

[PATCH] D95589: [RISCV] Support experimental 'P' extension 0.9

2021-08-01 Thread Jim Lin via Phabricator via cfe-commits
Jim updated this revision to Diff 363372. Jim added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95589/new/ https://reviews.llvm.org/D95589 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp clang/test/Driver/riscv-arch.c In

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

2021-08-01 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 363374. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/FormatString.h clang/lib/AST/FormatString.cpp clang/lib/AST/PrintfF

[PATCH] D106755: Extended format string checking to wprintf/wscanf

2021-08-01 Thread Marcus Johnson via Phabricator via cfe-commits
MarcusJohnson91 updated this revision to Diff 363376. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106755/new/ https://reviews.llvm.org/D106755 Files: clang-tools-extra/clang-tidy/boost/UseToStringCheck.cpp clang-tools-extra/clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp cl

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

2021-08-01 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/43180/step_8.txt "The command line is too long" Maybe some arts could be passed via a response file instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86671/new/ htt

[PATCH] D107047: [clangd] Fix the crash in getQualification

2021-08-01 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 363383. kbobyrev added a comment. Add test, improve docs in code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107047/new/ https://reviews.llvm.org/D107047 Files: clang-tools-extra/clangd/AST.cpp clang-t