[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

steakhal updated this revision to Diff 346061. steakhal added a comment. now it should build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102643/new/ https://reviews.llvm.org/D102643 Files: clang/unittests/StaticAnalyzer/FalsePositiveRefutationBRVisitorTest.cpp Index: clang/unitte

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

steakhal added a reviewer: balazske. steakhal added a comment. I don't really like having multiple files with the same name. And the importer TU should be simple to be simply `cat`-ed into a temporal file. At that point, you could put the importee's content into this file. It would result in a si

[clang] 88ee91c - [ASTimporter] Remove decl from lookup only if it has decl context

Author: Balazs Benics Date: 2021-05-18T09:43:20+02:00 New Revision: 88ee91cd87794813f4394f82d2c693c8d766e1d2 URL: https://github.com/llvm/llvm-project/commit/88ee91cd87794813f4394f82d2c693c8d766e1d2 DIFF: https://github.com/llvm/llvm-project/commit/88ee91cd87794813f4394f82d2c693c8d766e1d2.diff

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

This revision was automatically updated to reflect the committed changes. Closed by commit rG88ee91cd8779: [ASTimporter] Remove decl from lookup only if it has decl context (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102640/

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

steakhal added a comment. In D102640#2764759 , @shafik wrote: > This is a good catch, thank you for fixing this! Thanks for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102640/new/ http

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764085 , @vitalybuka wrote: > Would you mind to add compiler-rt/test/asan which triggers this one? Yes, I will. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov updated this revision to Diff 346071. AndreyChurbanov added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/depobj_codegen.cpp clang/test/Ope

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); -

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764357 , @eugenis wrote: > You are adding a new global to every translation unit. > > - Private linkage would not allow them to be merged, this can have > significant binary size and RAM overhead. Do you suggest linkon

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

martong added a comment. Post commit looks good to me as well. @steakhal Nice work! @shafik Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102640/new/ https://reviews.llvm.org/D102640 _

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4654 + + return ImportUsingShadowDecls(D, ToUsingEnum); } Could it work if you imported the shadow declarations **before** creating the `UsingEnumDecl`? I yes, then that would be the pref

[clang] 3f3642a - [CodeGen] Avoid unused variable warning in Release builds. NFCI.

Author: Benjamin Kramer Date: 2021-05-18T11:09:12+02:00 New Revision: 3f3642a7631e28e44c248a46703e381d389958a1 URL: https://github.com/llvm/llvm-project/commit/3f3642a7631e28e44c248a46703e381d389958a1 DIFF: https://github.com/llvm/llvm-project/commit/3f3642a7631e28e44c248a46703e381d389958a1.dif

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

Anastasia added a comment. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102248/new/ https://reviews.llvm.org/D102248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

martong added a comment. Thank you @OikawaKirie for working on this many CTU related patches! I am going to find time for a thorough review and going to pursue @gamesh411 as well to do the same! On the other hand, it would be really useful if you could build a "Stack" from these patches, I mean

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Comment at: clang/lib/Sema/Sema.cpp:304 addImplicitTypedef("event_t", Context.OCLEventTy); + if (getLangOpts().OpenCLCPlusPlus || getLangOpts().

[PATCH] D102669: [analyzer][ctu] Fix wrong 'multiple definitions' errors caused by space characters in lookup names when parsing the ctu index file

OikawaKirie marked an inline comment as done. OikawaKirie added a comment. In D102669#2765233 , @steakhal wrote: > I'm not really familiar with the extdefmap part, but I'm surprised that we > are using spaces as separators. > Shouldn't we consider using

[clang] 642d2f0 - [OpenCL] Fix initialization of __constant constructors without arguments

Author: Ole Strohm Date: 2021-05-18T10:59:53+01:00 New Revision: 642d2f000b26821010793ea1ea6a38a6695fc864 URL: https://github.com/llvm/llvm-project/commit/642d2f000b26821010793ea1ea6a38a6695fc864 DIFF: https://github.com/llvm/llvm-project/commit/642d2f000b26821010793ea1ea6a38a6695fc864.diff LO

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG642d2f000b26: [OpenCL] Fix initialization of __constant constructors without arguments (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

OikawaKirie added a comment. In D102149#2765402 , @martong wrote: > Thank you @OikawaKirie for working on this many CTU related patches! I am > going to find time for a thorough review and going to pursue @gamesh411 as > well to do the same! On the othe

[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cheers! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102643/new/ https://reviews.llvm.org/D102643 ___ cfe-commits mailing list cfe-

[clang] 2ab513c - [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Author: Alexey Bader Date: 2021-05-18T10:27:35+03:00 New Revision: 2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 URL: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 DIFF: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749.diff

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan added a comment. good, it appears the patch bot fail is fixed -- it seems unhappy with non-tree-like dependency graphs, and tries to apply each reachable patch as many times as it is reachable :( The data race failure seems entirely unconnected with this patch -- please correct me if I

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346107. urnathan added a comment. updating to reset dependency graph and coax build bot into working CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clan

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4654 + + return ImportUsingShadowDecls(D, ToUsingEnum); } martong wrote: > Could it work if you imported the shadow declarations **before** creating the > `UsingEnumDecl`? I yes, then th

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

uweigand added a comment. Looks like this is also failing on s390x: error: Added modules have incompatible data layouts: E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-a:8:16-n32:64 (module) vs E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-v128:64-a:8:16-n32:64 (jit) The problem here is that on s390x we use a

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); --

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102670/new/ https://reviews.llvm.org/D102670 ___

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

Szelethus added a comment. While I still see checker silencing as a solution to a problem that shouldn't exist, I'm unsure about the amount of tedious and invasive work required to make the underlying infrastructure elegant just for the sake of it being elegant. Most notably, checker silencing

[PATCH] D102261: Introduce SYCL 2020 mode

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Sorry for the delay. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commit

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader closed this revision. bader added a comment. Herald added subscribers: ebevhan, arphaman. Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28080/new/ https://reviews.llvm.org/D28080 __

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Could I get an LGTM on this? I have removed the spurious comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

v.g.vassilev created this revision. v.g.vassilev added reviewers: hubert.reinterpretcast, uweigand. v.g.vassilev requested review of this revision. In cases where `-fno-integrated-as` is specified we should overwrite the `EmitAssembly` action as well. We also should rely on the target triple fro

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @hubert.reinterpretcast, thanks for the feedback. I have created a patch as discussed -- https://reviews.llvm.org/D102688 @uweigand, thanks for reaching out. I believe the patch above should fix your setup. Could you confirm? Repository: rG LLVM Github Monorepo

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

olestrohm created this revision. olestrohm added reviewers: Anastasia, rjmccall. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. Allow converting between types with different address sp

[clang] 7d64493 - [DebugInfo][test] Check specific func name to ignore codegen differences

Author: Jinsong Ji Date: 2021-05-18T14:03:27Z New Revision: 7d6449322ecba2fa34090ca8ed610328febee108 URL: https://github.com/llvm/llvm-project/commit/7d6449322ecba2fa34090ca8ed610328febee108 DIFF: https://github.com/llvm/llvm-project/commit/7d6449322ecba2fa34090ca8ed610328febee108.diff LOG: [D

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

This revision was automatically updated to reflect the committed changes. jsji marked an inline comment as done. Closed by commit rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 346169. balazske added a comment. Improved the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the output file stays the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 _

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102688/new/ https://reviews.llvm.org/D102688 _

[clang] 6381664 - Introduce SYCL 2020 mode

Author: Aaron Ballman Date: 2021-05-18T10:34:14-04:00 New Revision: 6381664580080f015bc0c2ec647853f697cf744a URL: https://github.com/llvm/llvm-project/commit/6381664580080f015bc0c2ec647853f697cf744a DIFF: https://github.com/llvm/llvm-project/commit/6381664580080f015bc0c2ec647853f697cf744a.diff

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in 6381664580080f015bc0c2ec647853f697cf744a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://rev

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

kpn added a comment. In D99675#2696327 , @pengfei wrote: > In D99675#2695424 , @kpn wrote: > >> What changes are needed for a backend, and what happens if they aren't done? > > As far as I understand it, backend doe

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske added a comment. This change in itself is not enough to support `BindingDecl`. The tests pass but the resulting AST is not correct because `DecompositionDecl` is not imported yet. Still no visible problem happens, the `DecompositionDecl` is just visited and imported as a `VarDecl`. The

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

uweigand added a comment. In D96033#2765954 , @v.g.vassilev wrote: > @hubert.reinterpretcast, thanks for the feedback. I have created a patch as > discussed -- https://reviews.llvm.org/D102688 > > @uweigand, thanks for reaching out. I believe the patch a

[PATCH] D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

paulwalker-arm added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5741-5747 +// (insert_vector _, (extract_vector X, 0), 0) -> X +unsigned IdxN = cast(Idx)->getZExtValue(); +Value *X = nullptr; +if (match(SubVec, m_Intrinsic( +

[clang] 8998a8a - [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

Author: Sergey Dmitriev Date: 2021-05-18T08:44:41-07:00 New Revision: 8998a8aa97f81c758403615ec897ce79c1ccdcad URL: https://github.com/llvm/llvm-project/commit/8998a8aa97f81c758403615ec897ce79c1ccdcad DIFF: https://github.com/llvm/llvm-project/commit/8998a8aa97f81c758403615ec897ce79c1ccdcad.dif

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8998a8aa97f8: [clang-offload-bundler] Add sections and set section flags using one llvm… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102261: Introduce SYCL 2020 mode

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/9739/step_7.txt http://45.33.8.238/mac/31615/step_7.txt Please take a look, and please revert for now if it takes a while to fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://re

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong created this revision. martong added reviewers: steakhal, NoQ, vsavchenko. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. marton

[clang] ccbac06 - Speculatively fix failing tests from 6381664580080f015bc0c2ec647853f697cf744a

Author: Aaron Ballman Date: 2021-05-18T12:44:58-04:00 New Revision: ccbac06a072b86ea3b46479e478a1abee8520ef8 URL: https://github.com/llvm/llvm-project/commit/ccbac06a072b86ea3b46479e478a1abee8520ef8 DIFF: https://github.com/llvm/llvm-project/commit/ccbac06a072b86ea3b46479e478a1abee8520ef8.diff

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2766240 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/9739/step_7.txt > http://45.33.8.238/mac/31615/step_7.txt > > Please take a look, and please revert for now if it takes

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

steven_wu added a comment. I don't think current implementation is the best idea. I think is better to make the gcc compatible LTO value to be a clang Driver only option, give them an option name, and handle them separately in driver to invoke correct fullLTO cc1 command, so that: - The value

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux builders after this change landed. It looks like linking `clang-repl` always fails on our bot, but I've also seen OOM when linking `ClangCodeGenTests` and `FrontendTests`. Do you have any idea why

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

NoQ added a comment. Ok so the state has enough constraints. It's enough to know that `$x + $y == 0` and `$y == 0` in order to deduce that `$x + 0 == 0`. But you're saying that we don't know how to infer it so instead of making us able to infer it let's make us ask the solver easier questions.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2766332 , @phosek wrote: > We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux > builders after this change landed. It looks like linking `clang-repl` always > fails on our bot, but I've also

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. In D101849#2764825 , @ABataev wrote: > No, it is not required. Most probably, needed to simplify test checks, > nothing else. Thanks. I'd like to remove the "REQUIRES: x86-registered-target", the -O1 for CHECK6,10, and regene

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Oof. Accurate! > // Would it be more elegant to create the emitting checkers tag here? Mind > that this is a checker that houses many others. I think the checkers should have a right to attach cu

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#2766372 , @v.g.vassilev wrote: > In D96033#2766332 , @phosek wrote: > >> We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux >> builders after this change la

[clang] 2919222 - [Driver] Delete -mimplicit-it=

Author: Fangrui Song Date: 2021-05-18T10:57:24-07:00 New Revision: 2919222d8017f2425a85765b95e4b7c6f8e70ca4 URL: https://github.com/llvm/llvm-project/commit/2919222d8017f2425a85765b95e4b7c6f8e70ca4 DIFF: https://github.com/llvm/llvm-project/commit/2919222d8017f2425a85765b95e4b7c6f8e70ca4.diff

[PATCH] D102568: [Driver] Delete -mimplicit-it=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2919222d8017: [Driver] Delete -mimplicit-it= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

NoQ added a comment. I've just been patching up clang-tidy's infinite loop checker and the problem sounds s similar. Maybe we should move clang-tidy's alias analysis into `libAnalysis` and re-use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich created this revision. vlovich added reviewers: MyDeveloperDay, curdeius. vlovich added a project: clang-format. vlovich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently the lambda body indents relative to where the lambda

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. I'm not 100% certain if the implementation is absolutely correct. For example, the `#define A` test case is broken (the closing brace is on the wrong line). Additionally, the `pop_back` feels weird but seems to fix all the other cases to make the closing brace aligned p

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks. I'

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. Maybe a bit more test cases with smaller lambdas? Or without the outer parenthesis? Comment at: clang/include/clang/Format/Format.h:2456 + enum LambdaBodyIndentationKind : unsigned char { +/// Align lambda body relative to the lambda si

[PATCH] D99235: [HIP] Change to code object v4

gregrodgers added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { yaxunl wrote: > tra wrote: > > We

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 346235. ggeorgakoudis added a comment. Update correction for implicit simd checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files: clang/utils/refactor_

[clang] 8dd5ef0 - [clang-repl] Better match the underlying architecture.

Author: Vassil Vassilev Date: 2021-05-18T19:14:33Z New Revision: 8dd5ef01ef13e402784bba47f7a24175f5f00325 URL: https://github.com/llvm/llvm-project/commit/8dd5ef01ef13e402784bba47f7a24175f5f00325 DIFF: https://github.com/llvm/llvm-project/commit/8dd5ef01ef13e402784bba47f7a24175f5f00325.diff LO

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dd5ef01ef13: [clang-repl] Better match the underlying architecture. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong added a comment. In D102696#2766337 , @NoQ wrote: > Ok so the state has enough constraints. It's enough to know that `$x + $y == > 0` and `$y == 0` in order to deduce that `$x + 0 == 0`. But you're saying > that we don't know how to infer it s

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks.

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr

[PATCH] D102714: [clang-tidy] Fix a crash on invalid code for memset-usage check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102714 Files: clang-tools-extra/clang-ti

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2766141 , @uweigand wrote: > In D96033#2765954 , @v.g.vassilev > wrote: > >> @hubert.reinterpretcast, thanks for the feedback. I have created a patch as >> discussed -- http

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, sfertile, jasonliu, daltenty. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2766680 , @HazardyKnusperkeks wrote: > Maybe a bit more test cases with smaller lambdas? Or without the outer > parenthesis? I'm not sure I understand this comment. Which test case are you referring to by "or withou

[PATCH] D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check

ggeorgakoudis updated this revision to Diff 346255. ggeorgakoudis added a comment. Update for correct implicit checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102105/new/ https://reviews.llvm.org/D102105 Files: clang/test/OpenMP/cancel_code

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope created this revision. bjope added reviewers: yaxunl, tra, zhuhan0. bjope requested review of this revision. Herald added a project: clang. The checks (both positive and negative checks) in the test case hip-include-path.hip could mistakenly end up matching the string "clang" from the Instal

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102723/new/ https://reviews.llvm.org/D102723 __

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Sam, this patch has apparently triggered some unwanted side effects. I'm still reducing the failures to something that could be used for debugging, but the rough symptoms are: We now end up emitting the code for the host-only static member functions of instantiated class t

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Jake-Egan added reviewers: cebowleratibm, jasonliu, sfertile, daltenty, DiggerLin, hubert.reinterpretcast. Herald added subscribers: jeroen.dobbelaere, nemanjai. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribe

[PATCH] D102306: Add gfx1034

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_GFX1033 = 0x039, + EF_AMDGPU_MACH_AMDGCN_GFX1034 = 0x03e, EF_AMDGPU_MACH_AMDGCN_GFX602= 0x03a, For future reference, MACH values

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964 if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && - !RawTriple.isAMDGPU() && !RawTriple.isOSAIX()) + !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); --

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl added a comment. In D102237#2767052 , @tra wrote: > Sam, this patch has apparently triggered some unwanted side effects. I'm > still reducing the failures to something that could be used for debugging, > but the rough symptoms are: > > We now end

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. In D102237#2767131 , @yaxunl wrote: > > It would be interesting to know what kind of variables are emitted. I'm still reducing the failure. I'll send you a reproducer once I have it. > Would you like the change reverted? We ha

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); -

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb created this revision. cjdb added reviewers: gbiv, manojgupta, aaron.ballman. Herald added a reviewer: george.burgess.iv. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-j

[PATCH] D102730: [clang-format] Support custom If macros

vlovich created this revision. vlovich added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. vlovich added a project: clang-format. vlovich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like with ForEachMacros, support user to pr

[PATCH] D102730: [clang-format] Support custom If macros

vlovich added inline comments. Comment at: clang/include/clang/Format/Format.h:2098 + /// + /// For example: KJ_IF_MAYBE. + std::vector IfMacros; Should I put a hyperlink to https://github.com/capnproto/capnproto/blob/master/kjdoc/tour.md#maybes? Repository

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 346289. aorlov added a comment. Simplified the solution. Replaced RemoveDiagnosticsFromPool with SuppressAccessChecks. @krisb, please, look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://revi

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang created this revision. akhuang added reviewers: rnk, aganea, amccarth. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first wri

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:872 // using stdin. + void *FileHandle = nullptr; +#ifdef _WIN32 I'm saving the windows HANDLE here instead of using `fd` because for some reason calling `_get_osfhandle(fd)`

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Here's one example reproducer: https://godbolt.org/z/77M596W89 It's rather hairy, but should be usable for further debugging. There are no CUDA attributes anywhere in sight, but we do end up emitting a host-only constructor for `o_u` which calls `strlen`. Repository: rG

  1   2   >