[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet added a comment. can you give me an email address to associate the commit with? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

jansvoboda11 added a comment. I'm seeing build failures that might be triggered by this patch: http://lab.llvm.org:8011/#/builders/109/builds/3714 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 __

[clang] 9738436 - [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

Author: Jan Svoboda Date: 2020-12-01T09:24:04+01:00 New Revision: 973843681b9df4ba9303e98f7b4531ba31c2b1bf URL: https://github.com/llvm/llvm-project/commit/973843681b9df4ba9303e98f7b4531ba31c2b1bf DIFF: https://github.com/llvm/llvm-project/commit/973843681b9df4ba9303e98f7b4531ba31c2b1bf.diff L

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG973843681b9d: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC) (authored by jansvoboda11). Repository: rG LLVM Github Mon

[PATCH] D92041: [clangd] Add hover info for `this` expr

njames93 added a comment. One last point, is it worth including cv qualifications in the hover info? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] 88ab384 - [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

Author: Jan Svoboda Date: 2020-12-01T09:50:11+01:00 New Revision: 88ab38449b49bf002ed7794d1b81d362aa9f9df2 URL: https://github.com/llvm/llvm-project/commit/88ab38449b49bf002ed7794d1b81d362aa9f9df2 DIFF: https://github.com/llvm/llvm-project/commit/88ab38449b49bf002ed7794d1b81d362aa9f9df2.diff L

[PATCH] D91861: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88ab38449b49: [clang][cli] Split DefaultAnyOf into a default value and ImpliedByAnyOf (authored by jansvoboda11). Changed prior to commit: https:/

[PATCH] D92370: [clang] Enable code completion of designated initializers in Compound Literal Expressions

kadircet created this revision. kadircet added reviewers: sammccall, hokein, adamcz. Herald added subscribers: cfe-commits, usaxena95. Herald added a project: clang. kadircet requested review of this revision. Herald added a subscriber: ilya-biryukov. PreferedType were not set when parsing compoun

[PATCH] D83697: [clang][cli] Port Frontend option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b84efa00040: [clang][cli] Port Frontend option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] 2b84efa - [clang][cli] Port Frontend option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-01T10:02:08+01:00 New Revision: 2b84efa00040410d97aff403788ee5d96b1046e2 URL: https://github.com/llvm/llvm-project/commit/2b84efa00040410d97aff403788ee5d96b1046e2 DIFF: https://github.com/llvm/llvm-project/commit/2b84efa00040410d97aff403788ee5d96b1046e2.diff L

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems like a good idea to me. From the change description: > This allows us to use its value everywhere, rather than just llvm. Do you mean rather than just clang? Repository: rG LLVM Github

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308573. jansvoboda11 added a comment. Remove unnecessary std namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83694/new/ https://reviews.llvm.org/D83694 Files: clang/include/clang/Driver/Options.

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kadircet added a comment. In D92201#2421520 , @sammccall wrote: > In D92201#2419933 , @kbobyrev wrote: > >> I was trying to cause the index to load in the initialization stage for >> D92198

[PATCH] D83694: [clang][cli] Port DependencyOutput option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e41a688a5b1: [clang][cli] Port DependencyOutput option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 8e41a68 - [clang][cli] Port DependencyOutput option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-01T10:36:12+01:00 New Revision: 8e41a688a5b1000b51c61b9d103545791c54af17 URL: https://github.com/llvm/llvm-project/commit/8e41a688a5b1000b51c61b9d103545791c54af17 DIFF: https://github.com/llvm/llvm-project/commit/8e41a688a5b1000b51c61b9d103545791c54af17.diff L

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ marked 16 inline comments as done. NoQ added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5497 + called from a function with the enforce_tcb attribute. A function may be + a part of multiple TCBs. Invocations of function pointers and C++ methods + are

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ updated this revision to Diff 308581. NoQ marked 5 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91898/new/ https://reviews.llvm.org/D91898 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/

[PATCH] D91874: [GNU ObjC] Fix a regression listing methods twice.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1ed67037de6: [GNU ObjC] Fix a regression listing methods twice. (authored by theraven). Changed prior to commit: https://reviews.llvm.org/D91874?

[clang] 398b729 - [clang][cli] Port HeaderSearch option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-01T10:52:00+01:00 New Revision: 398b729243b12bdfbc7a75b46d39b547545cbd2d URL: https://github.com/llvm/llvm-project/commit/398b729243b12bdfbc7a75b46d39b547545cbd2d DIFF: https://github.com/llvm/llvm-project/commit/398b729243b12bdfbc7a75b46d39b547545cbd2d.diff L

[clang] d1ed670 - [GNU ObjC] Fix a regression listing methods twice.

Author: David Chisnall Date: 2020-12-01T09:50:18Z New Revision: d1ed67037de6f3f44dc446784f74f0e02adec9b5 URL: https://github.com/llvm/llvm-project/commit/d1ed67037de6f3f44dc446784f74f0e02adec9b5 DIFF: https://github.com/llvm/llvm-project/commit/d1ed67037de6f3f44dc446784f74f0e02adec9b5.diff LOG

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG398b729243b1: [clang][cli] Port HeaderSearch option flags to new option parsing system (authored by jansvoboda11). Changed prior to commit: https:

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3336 +if (Fun->getExplicitSpecifier().getExpr()) { + ExplicitExpr = importChecked(Err, Fun->getExplicitSpecifier().getExpr()); + if (Err) rnk wrote: > GCC 5.3 complained about

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308596. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308597. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

hans added a comment. In D85808#2424908 , @jansvoboda11 wrote: > I'm seeing build failures that might be triggered by this patch: > http://lab.llvm.org:8011/#/builders/109/builds/3714 It seems to affect a lot of the main bots (random example: http://la

[clang] e98d3be - [clang] Enable code completion of designated initializers in Compound Literal Expressions

Author: Kadir Cetinkaya Date: 2020-12-01T12:06:48+01:00 New Revision: e98d3be11c2991c7d446d5c7c714d0384f3b7432 URL: https://github.com/llvm/llvm-project/commit/e98d3be11c2991c7d446d5c7c714d0384f3b7432 DIFF: https://github.com/llvm/llvm-project/commit/e98d3be11c2991c7d446d5c7c714d0384f3b7432.dif

[PATCH] D92370: [clang] Enable code completion of designated initializers in Compound Literal Expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe98d3be11c29: [clang] Enable code completion of designated initializers in Compound Literal… (authored by kadircet). Repository: rG LLVM Github Mo

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2710 +**SpacesInLineComments** (``SpacesInLineComment``) + How many spaces are allowed at the start of a line comment. To disable the Is this change generated? with clang/

[clang] 523775f - [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

Author: Sven van Haastregt Date: 2020-12-01T11:33:10Z New Revision: 523775f96742e6f099b3498b6606b7250c0af841 URL: https://github.com/llvm/llvm-project/commit/523775f96742e6f099b3498b6606b7250c0af841 DIFF: https://github.com/llvm/llvm-project/commit/523775f96742e6f099b3498b6606b7250c0af841.diff

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

This revision was automatically updated to reflect the committed changes. Closed by commit rG523775f96742: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2 (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D92091?vs=308075&id=308607#toc Repository: rG LLVM Gi

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

RKSimon added a comment. @ashi1 This is causing build failures - please can you take a look ? http://lab.llvm.org:8011/#/builders/14/builds/2514 :17:66: note: possible intended match here "/b/1/clang-x86_64-debian-new-pass-manager-fast/llvm.obj/bin/llvm-ar" "rcsD" "a.out" "/tmp/a-88f827.o"

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a step towards making compil

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:89 + // Has cache been filled from disk? FIXME: this should be an expiry time. + bool CachePopulated = false; + // Whether a new CDB has been loaded but not broadcast yet. -

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

PiotrFusik added a comment. These specification for these extensions was edited by Ben Ashbaugh @Intel. I've asked him about this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commit

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia added a comment. In D92231#2425305 , @PiotrFusik wrote: > The specification for these extensions was edited by Ben Ashbaugh @Intel. > I've asked him about this change. Sure. Thanks! Happy to hold off committing for a few days to see if Ben has

[PATCH] D92384: [AST][NFC] Silence GCC warning about broken strict aliasing rules

thopre created this revision. thopre added reviewers: jdenny, aaron.ballman, hfinkel, llvm-commits. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. The deserialize() method would trigger the following warning on GCC <7: warning: d

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. I wanted to defer the resolution of the todos after all existing patches (https://reviews.llvm.org/search/query/wPZcRaH7zHgu/#R) are upstreamed to avoid conflicts when rebasing and refactoring. Looking at the patches more closely, only two of them seem to be dealin

[PATCH] D92386: [VE] Add standard include path and library path for C++

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: clang, VE. Herald added subscribers: cfe-commits, ormris. kaz7 requested review of this revision. We have a plan to add libcxx and libcxxabi for VE. In order to do so, we need to compile cxx source code wit

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added a comment. In D92041#2424869 , @kadircet wrote: > can you give me an email address to associate the commit with? xnd...@gmail.com, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. maybe rename th

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein updated this revision to Diff 308636. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new/ https://reviews.llvm.org/D87349 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveA

[PATCH] D87349: [clang] adapt c++17 behavior for dependent decltype-specifiers

hokein added a comment. @rsmith I think it still makes sense to get this patch landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87349/new/ https://reviews.llvm.org/D87349 ___ cfe-commits mailing lis

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308643. ftynse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang tests. The order of arguments is switched in the internal outlined function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D92220: [clangd] Add support for static fields in rename

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630 )cpp", + R"cpp( +template struct Foo { static T Variable; }; hmm, looks like these two tests are already working at head (without the patch). R

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

ASDenysPetrov added a comment. Just a ping. Let me, please, do smth with this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87146/new/ https://reviews.llvm.org/D87146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse added inline comments. Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*, i32*, ...)*, ...) @__kmpc_fork_call(%struct.ident_t* [[DEF_LOC_2]], i32 2, void (i32*, i32*, ...)* bitcast (void (i32*, i32*

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L updated this revision to Diff 308648. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Split testcases; Simplified code; Don't need to respect attribute align within typedef when the alignment value is less than bitcontainer size; CHANGES SINCE LAST ACTION

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

Xiangling_L added inline comments. Comment at: clang/test/Layout/aix-bitfield-alignment.cpp:1 +// RUN: %clang_cc1 -triple powerpc-ibm-aix-xcoff -fdump-record-layouts \ +// RUN: -fsyntax-only -faix-pragma-pack -x c++ %s | \ sfertile wrote: > I suggest we split

[PATCH] D92140: Fix noderef for array member of deref expr

thejh added a comment. @leonardchan I don't have commit access; can you land this change and D92141 for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 __

[PATCH] D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl

teemperor added a comment. @gamesh411 I recreated the setup you listed (thanks for that btw) but for me this works just fine. I assume the crash happens in a class template from one of the external libraries. It probably works for me because I don't have the same library version as you have, bu

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

jdoerfert added a comment. While only partially related, can you leave a FIXME saying that more than 15 arguments need to be packed in a structure? Comment at: clang/test/OpenMP/parallel_codegen.cpp:139 // CHECK: call {{.*}}void (%struct.ident_t*, i32, void (i32*, i32*,

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu updated this revision to Diff 308653. jasonliu added a comment. Address comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91455/new/ https://reviews.llvm.org/D91455 Files: clang/lib/CodeGen/CGCleanup.h clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/personal

[PATCH] D92386: [VE] Add standard include path and library path for C++

simoll added inline comments. Comment at: clang/lib/Driver/ToolChains/VEToolchain.cpp:109 +return; + if (const char *cl_include_dir = getenv("NCC_CPLUS_INCLUDE_PATH")) { +SmallVector Dirs; Do we want a test for this code path? Ie, checking system include

[PATCH] D92342: [HIP] Fix HIP test on windows due to lld suffix

ashi1 added a comment. In D92342#2425271 , @RKSimon wrote: > @ashi1 This is causing build failures - please can you take a look ? > http://lab.llvm.org:8011/#/builders/14/builds/2514 > > :17:66: note: possible intended match here >"/b/1/clang-x86_64

[clang] cd5897d - [HIP] Fix static-lib test CHECK bug

Author: Aaron En Ye Shi Date: 2020-12-01T15:49:39Z New Revision: cd5897d55908827faf3e16c505bd79732a8f6eb6 URL: https://github.com/llvm/llvm-project/commit/cd5897d55908827faf3e16c505bd79732a8f6eb6 DIFF: https://github.com/llvm/llvm-project/commit/cd5897d55908827faf3e16c505bd79732a8f6eb6.diff LO

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list cf

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list cfe

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90889/new/ https://reviews.llvm.org/D90889 ___ cfe-commits mailing list cfe

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90888/new/ https://reviews.llvm.org/D90888 ___ cfe-commits mailing list cfe

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91296/new/ https://reviews.llvm.org/D91296 ___ cfe-commits mailing list cfe

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation &Invocation, -const llvm::Memory

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

rnk added inline comments. Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:92 /* Define to 1 if you have the header file. */ #cmakedefine HAVE_SYSEXITS_H ${HAVE_SYSEXITS_H} This is unrelated, but appears to be in the wrong header, it should be in c

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPads || (F.hasPersonalityFn() && This logic seems very similar to th

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

emaste added a comment. > How do things go wrong on Darwin? I was under the impression that this was > implemented in LLVM as strictly inline code, no runtime support required. That is my impression as well (although it seems that an earlier version might have emitted calls to a stack probe rou

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. The new MachO lld just grew support for response files in D92149 , so let the clang driver use it. https://reviews.llvm.org/D92399 Files: clang/lib/Driver/T

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis added a comment. Extracted the darwinnew bits to D92399 . Will rebase this once that's in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits maili

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

thakis updated this revision to Diff 308675. thakis added a comment. fewer build errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92399/new/ https://reviews.llvm.org/D92399 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/ToolChains/Darwin.cpp =

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse planned changes to this revision. ftynse added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:736 "Expected copy/create callback to set replacement value!"); - if (ReplacementValue == &V) -return; }

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. Ah, I am sorry. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] b99e2b8 - clang/darwin: Use response files with ld64.lld.darwinnew

Author: Nico Weber Date: 2020-12-01T12:07:56-05:00 New Revision: b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96 URL: https://github.com/llvm/llvm-project/commit/b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96 DIFF: https://github.com/llvm/llvm-project/commit/b99e2b8b14f4ba50f9eb80bd5a2c1824099a7f96.diff LO

[PATCH] D92399: clang/darwin: Use response files with ld64.lld.darwinnew

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2b8b14f4: clang/darwin: Use response files with ld64.lld.darwinnew (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri updated this revision to Diff 308683. lebedev.ri marked 6 inline comments as done. lebedev.ri added a comment. Herald added a subscriber: phosek. @aaron.ballman @aqjune thank you for taking a look! Rebased, mostly addressed review notes: - Moved into `performance` module - Don't diagn

[PATCH] D92357: clang/darwin: Don't use response files with ld64, do use them with ld64.lld.darwinnew

thakis updated this revision to Diff 308684. thakis edited the summary of this revision. thakis added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/Too

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

llitchev added a comment. In D92189#2425639 , @jdoerfert wrote: > While only partially related, can you leave a FIXME saying that more than 15 > arguments need to be packed in a structure? Yes, the number of varargs that is guarantee to work is 15, if mo

[clang-tools-extra] ae7ec47 - [NFC][clang-tidy] Port rename_check.py to Python3

Author: Roman Lebedev Date: 2020-12-01T20:10:19+03:00 New Revision: ae7ec47fc655537ce82c0bfee0b587921663eaff URL: https://github.com/llvm/llvm-project/commit/ae7ec47fc655537ce82c0bfee0b587921663eaff DIFF: https://github.com/llvm/llvm-project/commit/ae7ec47fc655537ce82c0bfee0b587921663eaff.diff

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPads || (F.hasPersonalityFn() && daltenty wrote: > This logic seems

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. In D92041#2424928 , @njames93 wrote: > One last point, is it worth including cv qualifications in the hover info? Yes, I think we should

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. @Bigcheese brought up that if you wanted to mimic the current logic in `OptInFFlag` that automatically creates the `-cc1` option with my current proposal, you'd need to remember to pass it to the right `Flags` (e.g.: use `NegativeFlag<[CC1Option]>` when using `Inve

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + rjmccall wrote: > I don't think we can just unconditionally check for the attribute. The rule > for `trivial_abi` is that it overrides dire

[PATCH] D92403: [LSan][RISCV] Enable LSan for RISCV64

luismarques created this revision. luismarques added reviewers: asb, lenary, vitalybuka, eugenis, EccoTheDolphin. Herald added subscribers: Sanitizers, cfe-commits, NickHung, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, fedor.sergeev, m

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + zoecarver wrote: > rjmccall wrote: > > I don't think we can just unconditionally check for the attribute. The > > rule for `trivial_abi` is

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:68 +Per = dyn_cast(F.getPersonalityFn()->stripPointerCasts()); + bool EmitEHBlock = + HasLandingPa

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6416 + if (D->hasAttr()) +return true; + rjmccall wrote: > zoecarver wrote: > > rjmccall wrote: > > > I don't think we can just unconditionally check for the attribute. The > > > r

[PATCH] D92357: clang/darwin: Don't use response files with ld64

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92357/new/ https://reviews.llvm.org/D92357 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D92357: clang/darwin: Don't use response files with ld64

keith added a comment. I'm a bit worried that without a repro case (outside of the missing newline) Apple won't get around to fixing this, and in the meantime I'm wondering if outside of the chromium build system folks will experience this. I wonder if there's an acceptable alternative here suc

[PATCH] D92357: clang/darwin: Don't use response files with ld64

thakis added a comment. In D92357#2426042 , @keith wrote: > I'm a bit worried that without a repro case (outside of the missing newline) > Apple won't get around to fixing this, and in the meantime I'm wondering if > outside of the chromium build system

[PATCH] D92189: [OpenMPIRBuilder] forward arguments as pointers to outlined function

ftynse updated this revision to Diff 308698. ftynse added a comment. Simplify the code by adapting the PrivatizationCallback signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92189/new/ https://reviews.llvm.org/D92189 Files: clang/lib/Cod

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 308699. zoecarver added a comment. - Add comment in SemaDeclCXX. - Add tests for non-trivial bases/members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: c

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

aeubanks added a comment. In D92072#2425025 , @hans wrote: > Seems like a good idea to me. > > From the change description: > >> This allows us to use its value everywhere, rather than just llvm. > > Do you mean rather than just clang? Whoops, yup. ===

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. svenvh requested review of this revision. These cases weren't in any of the SemaOpenCL tests yet. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:108-109 +; ASM: .byte 255 # @LPStart Encoding = omit +; ASM32: .byte 187 # @TType Encoding = +; ASM64:

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. apply() will fail in those cases, so it's better to detect it in prepare()

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre created this revision. thopre added reviewers: ABataev, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. GCC's -Wcomment warning is emit

[PATCH] D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/

rnk added inline comments. Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:95 +/* Define to 1 to enable the experimental new pass manager by default */ +#cmakedefine01 ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER + aeubanks wrote: > rnk wrote: > > This should be

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

ABataev added a comment. I would just remove this extra symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:35 + // unsigned long lsda; /* Pointer to LSDA */ + // unsigned long personality; /* Pointerto the personality routine */ + // } Typo: missing

[PATCH] D92406: [OpenCL] Add some more kernel argument tests

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:40 +void no_addrspace_param(global int x) { } // expected-error{{parameter may not be qua

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't mind

[clang] 3734079 - Argument dependent lookup with class argument is recursing into base

Author: Zahira Ammarguellat Date: 2020-12-01T10:33:12-08:00 New Revision: 37340798ccb00b9c3a53e8a5f1b6430e85870338 URL: https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338 DIFF: https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338

  1   2   >