[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

sammccall added a comment. In D88414#2319161 , @kadircet wrote: > In D88414#2317106 , @sammccall wrote: > >> Now there's lots of usage (which looks good!) i'm finding it a bit hard to >> keep track of what the tree

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, kristof.beyls. Herald added a project: clang. hokein requested review of this revision. Given the following VarTemplateDecl AST, VarTemplateDecl col:26 X |-TemplateTypePa

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 297136. jonpa marked an inline comment as done. jonpa added a comment. Updated message string per review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/Code

[PATCH] D88417: [clangd] Record memory usages after each notification

sammccall added a comment. In D88417#2319307 , @kadircet wrote: > Bad news, I was testing this with remote-index, hence background-index was > turned off. Unfortunately traversing all of the slabs in `FileSymbols` takes > quite a while in this case (~15m

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice catch, LG with readability nits Comment at: clang-tools-extra/clangd/unittests/ParsedASTTests.cpp:107 +TEST(ParsedASTTest, VarTemplateDecl) { + TestTU TU; -

[PATCH] D89098: [clang] Fix returning the underlying VarDecl as top-level decl for VarTemplateDecl.

sammccall added a comment. Is this https://github.com/clangd/clangd/issues/554 ? :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89098/new/ https://reviews.llvm.org/D89098 ___ cfe-commits mailing list

[clang-tools-extra] 2ff4493 - [clangd] Reduce availability of extract function

Author: Kadir Cetinkaya Date: 2020-10-09T10:12:48+02:00 New Revision: 2ff44935a5f56f755a4f47ad00ee0dec48e19832 URL: https://github.com/llvm/llvm-project/commit/2ff44935a5f56f755a4f47ad00ee0dec48e19832 DIFF: https://github.com/llvm/llvm-project/commit/2ff44935a5f56f755a4f47ad00ee0dec48e19832.dif

[PATCH] D85354: [clangd] Reduce availability of extract function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ff44935a5f5: [clangd] Reduce availability of extract function (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

sammccall accepted this revision. sammccall added a comment. Yeah, we can fairly easily make this tighter if it's noisy. My suspicion is people will rather complain about ranking than these results being totally irrelevant. Nice that we now have workspace/symbols users that can send this feedbac

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

kadircet updated this revision to Diff 297142. kadircet marked an inline comment as done. kadircet added a comment. - Move if checks into asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88814/new/ https://reviews.llvm.org/D88814 Files: cl

[clang-tools-extra] 6f1a56d - [clangd] Enable partial namespace matches for workspace symbols

Author: Kadir Cetinkaya Date: 2020-10-09T10:20:41+02:00 New Revision: 6f1a56d37ac6a541f585846ab0734ab0bedc264f URL: https://github.com/llvm/llvm-project/commit/6f1a56d37ac6a541f585846ab0734ab0bedc264f DIFF: https://github.com/llvm/llvm-project/commit/6f1a56d37ac6a541f585846ab0734ab0bedc264f.dif

[PATCH] D88814: [clangd] Enable partial namespace matches for workspace symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1a56d37ac6: [clangd] Enable partial namespace matches for workspace symbols (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 6ee47f5 - [clangd] Fix dead variable, typo. NFC

Author: Sam McCall Date: 2020-10-09T10:26:58+02:00 New Revision: 6ee47f552ba7654a0997c8deb71f65d0d91f4a28 URL: https://github.com/llvm/llvm-project/commit/6ee47f552ba7654a0997c8deb71f65d0d91f4a28 DIFF: https://github.com/llvm/llvm-project/commit/6ee47f552ba7654a0997c8deb71f65d0d91f4a28.diff LO

[PATCH] D88885: [clangd] Disambiguate overloads of std::move for header insertion.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:557 // :-( llvm::SmallString<256> QName; for (const auto &Entry : IncludeFiles) kadircet wrote: > this one is no longer needed. whoops, fixed in 6ee47f552ba76

[PATCH] D88648: Refactor fixed point conversion test.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9c26eb8b915e: Refactor fixed point conversion test. (authored by ebevhan). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9c26eb8 - Refactor fixed point conversion test.

Author: Bevin Hansson Date: 2020-10-09T10:27:42+02:00 New Revision: 9c26eb8b915e5e20afa7d3e07996ea112c18ccc3 URL: https://github.com/llvm/llvm-project/commit/9c26eb8b915e5e20afa7d3e07996ea112c18ccc3 DIFF: https://github.com/llvm/llvm-project/commit/9c26eb8b915e5e20afa7d3e07996ea112c18ccc3.diff

[PATCH] D89102: [X86] Add HRESET instruction.

pengfei created this revision. pengfei added reviewers: craig.topper, RKSimon, LuoYuanke. Herald added subscribers: llvm-commits, cfe-commits, dang, hiraditya, mgorny. Herald added projects: clang, LLVM. pengfei requested review of this revision. For more details about these instructions, please r

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 297159. Tyker marked 7 inline comments as done. Tyker added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 Files: clang/include/clang/Ba

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; ---

[PATCH] D89102: [X86] Add HRESET instruction.

RKSimon added a comment. Please can you add a mention in the 12.0 release notes? Comment at: llvm/lib/Target/X86/X86InstrInfo.td:2920 + def HRESET : Ii8<0xF0, MRM_C0, (outs), (ins i32u8imm:$imm), "hreset\t$imm", []>, + Requires<[HasHRESET]>, TAXS; +

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

MyDeveloperDay added a comment. Not to my knowledge, if we are not going to fix it we should probably revert it for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388 _

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

Anastasia added a comment. I think it should be ok to proceed with this now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88300/new/ https://reviews.llvm.org/D88300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet updated this revision to Diff 297172. kadircet added a comment. - Move MemoryTree recording from Trace into MemoryTree as suggested in D88417 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88413/new/ http

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet added a comment. > What about something like a 5 minute throttle, but have ClangdLSPServer's > constructor set the timestamp to now+1 minute? (Without profiling) SGTM. Note that this means we can't easily test this in LSP layer anymore. (We've got couple of components depending on time

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet updated this revision to Diff 297173. kadircet marked 2 inline comments as done. kadircet added a comment. - Implement periodic profiling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88417/new/ https://reviews.llvm.org/D88417 Files: cl

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:68 + /// Records total memory usage of each node under "memory_usage" metric. + /// Labels are edges on the path joined with ".", starting with \p RootName. can we make

[clang] caf28b0 - [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers

Author: Dávid Bolvanský Date: 2020-10-09T12:56:06+02:00 New Revision: caf28b0a1288eb06720acf11d7ad09186b27b74f URL: https://github.com/llvm/llvm-project/commit/caf28b0a1288eb06720acf11d7ad09186b27b74f DIFF: https://github.com/llvm/llvm-project/commit/caf28b0a1288eb06720acf11d7ad09186b27b74f.dif

[PATCH] D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf28b0a1288: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers (authored by xbolva00). Herald added a proj

[PATCH] D88417: [clangd] Record memory usages after each notification

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1234 +void ClangdLSPServer::profile(bool Detailed) { + if (!trace::enabled()) ClangdLSPServer does own things other than ClangdServer (e.g. the CDB), though we don't yet

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

sammccall added a comment. In D88414#2320859 , @sammccall wrote: > In D88414#2319161 , @kadircet wrote: > >> In D88414#2317106 , @sammccall >> wrote: >> >>> Now there's lots

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

azabaznov added a comment. Anastasia, Sven, thanks for the review! Anastasia, it seems that I don't have write access yet. Would you mind landing this change on behalf of me? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88300/new/ https://reviews.llvm.org/D88300 _

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

JonasToth updated this revision to Diff 297187. JonasToth added a comment. - [Feature] add elvis operator detection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88088/new/ https://reviews.llvm.org/D88088 Files: clang/lib/Analysis/ExprMutationAn

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang/lib/Analysis/ExprMutationAnalyzer.cpp:61 + // below. + auto const ConditionalOperator = conditionalOperator(anyOf( + hasTrueExpression(ignoringParens(canResolveToExpr(InnerMatche

[PATCH] D89046: [AST] Build recovery expression by default for all language.

sammccall added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-error.c:51 void testCTF(int index) { - vec_ctf(vsi, index); //expected-error {{argument to '__builtin_altivec_vcfsx' must be a constant integer}} - vec_ctf(vui, index); //expected-error {{argument to

[PATCH] D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vrnithinkumar marked an inline comment as done. Closed by commit rG0b4fe8086f03: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner… (autho

[clang] 0b4fe80 - [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-10-09T13:42:25+02:00 New Revision: 0b4fe8086f03294907180007e7de98c80a83b0d7 URL: https://github.com/llvm/llvm-project/commit/0b4fe8086f03294907180007e7de98c80a83b0d7 DIFF: https://github.com/llvm/llvm-project/commit/0b4fe8086f03294907180007e

[PATCH] D88088: [clang] improve accuracy of ExprMutAnalyzer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. JonasToth marked an inline comment as done. Closed by commit rGe517e5cfec90: [clang] improve accuracy of ExprMutAnalyzer (authored by JonasToth). Repository: rG LLVM

[clang] e517e5c - [clang] improve accuracy of ExprMutAnalyzer

Author: Jonas Toth Date: 2020-10-09T13:45:32+02:00 New Revision: e517e5cfec90a00a488ad8df901ab9b903ebb966 URL: https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966 DIFF: https://github.com/llvm/llvm-project/commit/e517e5cfec90a00a488ad8df901ab9b903ebb966.diff LO

[PATCH] D89117: Remove old create(MainFile)?IncludeInsertion overloads

alexfh created this revision. alexfh added a reviewer: hokein. Herald added a project: clang. alexfh requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89117 Files: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp clang-tools-extra/clang-

[PATCH] D88204: [clangd] Drop path suffix mapping for std symbols

sammccall added a comment. Taking another look at the header list, there are a couple of classes of symbols beyond c/c++ standard library. We don't have an alternative database for these. Maybe we should keep the mechanism but stop using it for the standard library? What do you think? ==

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

I switched one of our workers to the main Buildbot and everything seems fine #fingers-crossed. I guess that that was a temporary glitch? We haven't updated our local Buildbot installations - still on 0.8.5. Should we update? -Andrzej On 09/10/2020 00:44, Galina Kistanova wrote: Hi Paula, T

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297197. JonasToth added a comment. - update to landed ExprMutAnalyzer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/cp

[clang-tools-extra] 7530b25 - [clangd] Make the tweak filter a parameter to enumerateTweaks. NFC

Author: Sam McCall Date: 2020-10-09T14:11:19+02:00 New Revision: 7530b254e93a18991a86d145eff066fbe88d6164 URL: https://github.com/llvm/llvm-project/commit/7530b254e93a18991a86d145eff066fbe88d6164 DIFF: https://github.com/llvm/llvm-project/commit/7530b254e93a18991a86d145eff066fbe88d6164.diff LO

[PATCH] D88724: [clangd] Make the tweak filter a parameter to enumerateTweaks. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG7530b254e93a: [clangd] Make the tweak filter a parameter to enumerateTweaks. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88724

[PATCH] D89119: [clangd] Update CC Ranking model to use SymbolCategory::Macro

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. A bug in the dataset generation pipeline captured a SymbolCategory::Macro as Sym

[clang] 4eb627e - first upstream review

Author: Ben Dunbobbin Date: 2020-10-09T13:21:03+01:00 New Revision: 4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 URL: https://github.com/llvm/llvm-project/commit/4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 DIFF: https://github.com/llvm/llvm-project/commit/4eb627ed96e3f2f9f24aec8a0654ce5204874bb8.diff

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but I'm not super well-versed with asm statements to begin with. You should wait a bit for other reviewers to weigh in before landing. CHANGES SINCE LAST ACTION htt

[clang] a9f1bb9 - Revert "first upstream review"

Author: Ben Dunbobbin Date: 2020-10-09T13:22:46+01:00 New Revision: a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc URL: https://github.com/llvm/llvm-project/commit/a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc DIFF: https://github.com/llvm/llvm-project/commit/a9f1bb92bfb1efc005b53bf9ea18ad5e902386fc.diff

Re: [clang] 4eb627e - first upstream review

On Fri, Oct 9, 2020 at 3:21 PM Ben Dunbobbin via cfe-commits wrote: > > > Author: Ben Dunbobbin > Date: 2020-10-09T13:21:03+01:00 > New Revision: 4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 > > URL: > https://github.com/llvm/llvm-project/commit/4eb627ed96e3f2f9f24aec8a0654ce5204874bb8 > DIFF: > htt

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; --

[clang] bb148ad - [windows-itanium] make dllimport/export handling closer to MS behavior

Author: Ben Dunbobbin Date: 2020-10-09T13:24:07+01:00 New Revision: bb148ad426f8c7e6a6f968d54796f872685a00b2 URL: https://github.com/llvm/llvm-project/commit/bb148ad426f8c7e6a6f968d54796f872685a00b2 DIFF: https://github.com/llvm/llvm-project/commit/bb148ad426f8c7e6a6f968d54796f872685a00b2.diff

[PATCH] D86828: [windows-itanium] make dllimport/export handling closer to MS behavior

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb148ad426f8: [windows-itanium] make dllimport/export handling closer to MS behavior (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D89091: Regenerate ClangCommandLineReference.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rGb581c5a42f05: Regenerate ClangCommandLineReference.rst (authored by kzhuravl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] b581c5a - Regenerate ClangCommandLineReference.rst

Author: Konstantin Zhuravlyov Date: 2020-10-09T08:29:53-04:00 New Revision: b581c5a42f052d4d02f1152d0e1ff2d54668e6a0 URL: https://github.com/llvm/llvm-project/commit/b581c5a42f052d4d02f1152d0e1ff2d54668e6a0 DIFF: https://github.com/llvm/llvm-project/commit/b581c5a42f052d4d02f1152d0e1ff2d54668e6

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

Abpostelnicu added a comment. In D79388#2321231 , @MyDeveloperDay wrote: > Not to my knowledge, if we are not going to fix it we should probably revert > it for now, we can bring it back later I'm a strong supporter of reverting it for the moment. Rep

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth marked 2 inline comments as done. JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt:37 + clangLex + clangSerialization clangTidy aaron.ballman wrote: > Why do serialization and lex need to be

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297215. JonasToth marked an inline comment as done. JonasToth added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clan

[PATCH] D88979: [InstCombine] combineLoadToOperationType(): don't fold int<->ptr cast into load

lebedev.ri updated this revision to Diff 297217. lebedev.ri added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88979/new/ https://reviews.llvm.org/D889

[PATCH] D89126: [clangd] Support CodeActionParams.only

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mo

[PATCH] D89117: Remove old create(MainFile)?IncludeInsertion overloads

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe4715c47f9c: Remove old create(MainFile)?IncludeInsertion overloads (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89117/new/ https://

[clang-tools-extra] fe4715c - Remove old create(MainFile)?IncludeInsertion overloads

Author: Alexander Kornienko Date: 2020-10-09T15:24:57+02:00 New Revision: fe4715c47f9c02a83b339c12067f1d27a3115fe4 URL: https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4 DIFF: https://github.com/llvm/llvm-project/commit/fe4715c47f9c02a83b339c12067f1d27a3115fe4

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3683 + auto *Attr = + AnnotateAttr::Create(Context, Str, Args.empty() ? nullptr : Args.data(), + Args.size(), CI.getRange(), CI.getSyntax()); aaron.ballman wr

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

fanbo-meng created this revision. fanbo-meng added reviewers: abhina.sreeskantharajan, uweigand, Kai, hubert.reinterpretcast. Herald added subscribers: cfe-commits, krytarowski. Herald added a project: clang. fanbo-meng requested review of this revision. z/OS defaults to 16 bytes for __attribute

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89127/new/ https://reviews.llvm.org/D89127 ___

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297224. JonasToth added a comment. - fix platform dependent warning message for decltype to just match the beginning and not the 'a.k.a' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://revie

[clang] 0741a2c - [Clang][unittests][NFC] Break up test in Callbacks.cpp

Author: Stefan Pintilie Date: 2020-10-09T08:53:50-05:00 New Revision: 0741a2c9caca864fc30af2104712d02accdc12e6 URL: https://github.com/llvm/llvm-project/commit/0741a2c9caca864fc30af2104712d02accdc12e6 DIFF: https://github.com/llvm/llvm-project/commit/0741a2c9caca864fc30af2104712d02accdc12e6.dif

[PATCH] D88886: [Clang][unittests][NFC] Break up test in Callbacks.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0741a2c9caca: [Clang][unittests][NFC] Break up test in Callbacks.cpp (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D87547: [MinGW][clang-shlib] Build by default on MinGW

ASDenysPetrov reopened this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. Hi, @mati865 Currently I got an error while building with GCC10 on Win10. [2325/2656] Linking CXX shared library bin\libclang-cpp.dll FAILED: bin/libclang-cpp.dll lib/libclang

[PATCH] D89130: [WIP][Sparc] Fix long double on 32-bit Solaris/SPARC

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: Sanitizers, s.egerton, dexonsmith, jrtc27, simoncook, fedor.sergeev, hiraditya, mgorny, jyknight. Herald added projects: clang, Sanitizers, LLVM. ro requested review of this revision. The SysVr4 SPARC psABI pr

[PATCH] D89131: [clangd] Validate optional fields more strictly.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Mono

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added inline comments. Comment at: include/clang/Driver/Options.td:1157 +def fno_delete_null_pointer_checks : Flag<["-"], "fno-delete-null-pointer-checks">, + Group, Flags<[CC1Option]>; rjmccall wrote: > Please include HelpText, and it's probably w

[clang] d91234b - [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

Author: Fanbo Meng Date: 2020-10-09T10:14:44-04:00 New Revision: d91234b21c1a1a34d98157089a8769d8f9a32f06 URL: https://github.com/llvm/llvm-project/commit/d91234b21c1a1a34d98157089a8769d8f9a32f06 DIFF: https://github.com/llvm/llvm-project/commit/d91234b21c1a1a34d98157089a8769d8f9a32f06.diff LO

[PATCH] D89127: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd91234b21c1a: [SystemZ][z/OS] Update target specific __attribute__((aligned)) value for test (authored by fanbo-meng). Repository: rG LLVM Github

[clang-tools-extra] 41d2987 - [clangd] Stop logging in fromJSON, report instead.

Author: Sam McCall Date: 2020-10-09T16:15:45+02:00 New Revision: 41d2987c7558734cef74151e743645f47d9df501 URL: https://github.com/llvm/llvm-project/commit/41d2987c7558734cef74151e743645f47d9df501 DIFF: https://github.com/llvm/llvm-project/commit/41d2987c7558734cef74151e743645f47d9df501.diff LO

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

CJ-Johnson added a comment. After chatting with bkramer , I'm working on rebasing this diff so that it can be landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D17993/new/ https://reviews.llvm.org/D17993 _

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 297231. JonasToth added a comment. - missed one place of decltype Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files: clang-tools-extra/clang-tidy/cppcoreguideli

[clang] 71d3b7e - [OpenCL] Add new compilation mode for OpenCL 3.0.

Author: Anastasia Stulova Date: 2020-10-09T15:28:38+01:00 New Revision: 71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f URL: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f DIFF: https://github.com/llvm/llvm-project/commit/71d3b7ec7b62d37dd3c8eb1a921f0b3e1ffdaa7f.d

[PATCH] D88300: [OpenCL] Initial patch for OpenCL C 3.0 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d3b7ec7b62: [OpenCL] Add new compilation mode for OpenCL 3.0. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D89102: [X86] Add HRESET instruction.

pengfei marked an inline comment as done. pengfei added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89102/new/ https://reviews.llvm.org/D89102 ___ cfe-commits mailing

[PATCH] D89102: [X86] Add HRESET instruction.

pengfei updated this revision to Diff 297234. pengfei added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89102/new/ https://reviews.llvm.org/D89102 Files: clang/docs/ClangCommandLineReference.rst clang/incl

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

teemperor added a comment. I think we could at least have a unittest that just calls these functions with an invalid SourceLocation. `unittests/Basic/SourceManagerTest.cpp` already takes care of creating a valid SourceManager object, so the unit test would just be a single call to each method.

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

sfertile added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1633 + +if (BTy) { + BuiltinType::Kind BTyKind = BTy->getKind(); When can BTy be null? Should this instead be an assert? Instead can we implement this without looking at t

Re: [llvm-dev] [cfe-dev] Upcoming upgrade of LLVM buildbot

Hello Andrzej, Please do not update your bots yet. I will explicitly ask later. Feel free to move other reliably green bots of yours to the production buildbot. Thanks Galina On Fri, Oct 9, 2020 at 3:51 AM Andrzej Warzynski wrote: > I switched one of our workers to the main Buildbot and ever

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ > Can we collapse this function further towards this goal? Say, why not pump > every region //unconditionally// through `castRegion()`? Does > `dispatchCast()` use `castRegion()` internally - and if it does, why are > there so many branches in this function?

[PATCH] D89135: [clangd] Stop capturing trace args if the tracer doesn't need them.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The tracer is now expected to allocate+fr

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. @NoQ BTW, what you think we should do with D77062 and D88477 then? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89055/new/ https://reviews.llvm.or

[PATCH] D88737: [AIX] Turn -fdata-sections on by default in Clang

MaskRay added a comment. A less intrusive approach is to not touch the existing InitTargetOptionsFromCodeGenFlags without parameters. You can add an `initTargetOptionsFromCodeGenFlags` with `const Tripe &` as its parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88737/new/ http

[PATCH] D87449: [clang-tidy] Add new check for SEI CERT rule SIG30-C

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/SignalHandlerCheck.cpp:117-118 +FunctionCallCollector Collector{[&CalledFunctions](const CallExpr *CE) { + if (isa(CE->getCalleeDecl())) +CalledFunctions.push_back(CE); +}}; ---

[PATCH] D89136: Lex: Avoid MemoryBuffer* key in ExcludedPreprocessorDirectiveSkipMapping, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This is a prep patch for https://reviews.llvm.org/D66782, changing SourceManager to return `Optional` instead of `MemoryBuffer`. With that c

[PATCH] D88314: Added llvm-string-referencing check

bogser01 updated this revision to Diff 297246. bogser01 added a comment. Added documentation & Nit fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88314/new/ https://reviews.llvm.org/D88314 Files: clang-tools-extra/clang-tidy/llvm/StringRefe

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith updated this revision to Diff 297245. dexonsmith added a comment. Rebased (on top of https://reviews.llvm.org/D89136). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66782/new/ https://reviews.llvm.org/D66782 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.c

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Thanks for extending this functionality to Windows! Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

jdoerfert added a comment. (Drive By: This is cool) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D88645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a24316087d: [clang] Don't look into for C++ headers if they are found alongside… (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc updated this revision to Diff 297260. mibintc added a comment. I rebased the patch I added documentation to UserManual showing that -ffp-model=strict enables FENV_ACCESS I removed ActOnAfterCompoundStatementLeadingPragmas since it was redundant with work being done in ActOnCompoundStmt

[clang] a3a2431 - [clang] Don't look into for C++ headers if they are found alongside the toolchain

Author: Louis Dionne Date: 2020-10-09T12:41:41-04:00 New Revision: a3a24316087d0e1b4db0b8fee19cdee8b7968032 URL: https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032 DIFF: https://github.com/llvm/llvm-project/commit/a3a24316087d0e1b4db0b8fee19cdee8b7968032.diff

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. In D88498 @rsmith wrote, s far from clear to me that this is correct in C++. In principle, for a dynamic initializer, the rounding mode could have been set by an earlier initializer. Perhaps we can make an argument that, due to the permi

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

Anastasia created this revision. Anastasia added reviewers: azabaznov, svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. As suggested on RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-October/066932.html https://reviews.llvm.org/D89143 Files:

[PATCH] D89143: [OpenCL][Docs] Improved description of the supported language functionality.

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:2718 +Clang only supports the full OpenCL profile, and not `the embedded profile +`_. + I am surprised t

[PATCH] D89146: [SyntaxTree] Fix rtti for `Expression`.

eduucaldas created this revision. eduucaldas added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D89146 Files: clang/include/clang/Tooli

  1   2   >