[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will be needed to support call hierarchy Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added a comment. (As per discussion in https://github.com/clangd/clangd/issues/162#issuecomment-648923948 onwards.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83536/new/ https://reviews.llvm.org/D83536

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276928. martong marked an inline comment as done. martong added a comment. - Make Signature to be an Optional member of the Summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein added a comment. > Not trying to be difficult, but I'm not sure what you mean by "dependent" in > #2. Informally, it means the same thing as #1. Formally, C++ defines > type-dependence and value-dependence for expressions, and the ABI defines > instantiation-dependence for expressions -

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. We must check on every execution path that a specific condition on a value is satisfied (or: find one where the condition is not satisfied). This would be the most simple form of this checker. This can be done with the path sensitive check and `checkDeadSymbols`. If th

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

vsavchenko updated this revision to Diff 276944. vsavchenko added a comment. Add matplotlib and graphviz to requirements.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82967/new/ https://reviews.llvm.org/D82967 Files: clang/utils/analyzer/Doc

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff updated this revision to Diff 276945. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h clang/lib/Driver/

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. This commit inc

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

kadircet added a comment. Thanks a lot for doing this Nathan and sorry for not replying with a concrete decision on the issue tracker, we were still discussing it internally, as 7% increase for allowing multi-level call hierarchy support (compared to ~10% initial cost for single-level support)

[clang] 9c7ff0a - [analyzer][tests] Make test interruption safe

Author: Valeriy Savchenko Date: 2020-07-10T11:31:59+03:00 New Revision: 9c7ff0a4aaef0a1efa33e9ff8a12a064087bded9 URL: https://github.com/llvm/llvm-project/commit/9c7ff0a4aaef0a1efa33e9ff8a12a064087bded9 DIFF: https://github.com/llvm/llvm-project/commit/9c7ff0a4aaef0a1efa33e9ff8a12a064087bded9.d

[clang] 00997d1 - [analyzer][tests] Fix zip unpacking

Author: Valeriy Savchenko Date: 2020-07-10T11:32:13+03:00 New Revision: 00997d1cad9ecd40c92aeae40269f6bfb9e58d11 URL: https://github.com/llvm/llvm-project/commit/00997d1cad9ecd40c92aeae40269f6bfb9e58d11 DIFF: https://github.com/llvm/llvm-project/commit/00997d1cad9ecd40c92aeae40269f6bfb9e58d11.d

[clang] 21bacc2 - [analyzer][tests] Measure peak memory consumption for every project

Author: Valeriy Savchenko Date: 2020-07-10T11:31:41+03:00 New Revision: 21bacc215413d10df53a4690e9561e9b96698742 URL: https://github.com/llvm/llvm-project/commit/21bacc215413d10df53a4690e9561e9b96698742 DIFF: https://github.com/llvm/llvm-project/commit/21bacc215413d10df53a4690e9561e9b96698742.d

[PATCH] D82967: [analyzer][tests] Measure peak memory consumption for every project

This revision was automatically updated to reflect the committed changes. Closed by commit rG21bacc215413: [analyzer][tests] Measure peak memory consumption for every project (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D829

[PATCH] D83374: [analyzer][tests] Fix zip unpacking

This revision was automatically updated to reflect the committed changes. Closed by commit rG00997d1cad9e: [analyzer][tests] Fix zip unpacking (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83374/new/ https://reviews.llvm.or

[PATCH] D83373: [analyzer][tests] Make test interruption safe

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c7ff0a4aaef: [analyzer][tests] Make test interruption safe (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83373/new/ https://revie

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

vsavchenko updated this revision to Diff 276950. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83539/new/ https://reviews.llvm.org/D83539 Files: clang/utils/analyzer/SATest.py clang/utils/analyzer/SATestBench

[PATCH] D83539: [analyzer][tests] Introduce analyzer benchmarking framework

vsavchenko added a comment. Here is an example of how benchmarking chart looks like: F12321843: plot2.png It has 20 runs on each of those projects. It was the same revision of the analyzer, so it is still very sensitive to other stuff happening on the test

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3857 + + // TODO: This misses out on the sanitizer check below. + if (Ops.isFixedPointOp()) leonardchan wrote: > I don't suppose you could fi

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 276951. khchen added a comment. addess asb's comment. [RISCV][Clang] Support -mcpu option. Summary: 1. gcc uses `-march` and `-mtune` flag to chose arch and pipeline model, but clang does not have `-mtune` flag, we uses `-mcpu` to chose both info. 2. Add S

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett updated this revision to Diff 276952. DavidSpickett added a comment. - mv with stderr redirected instead of using non standard file -E flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.llvm.org/D83055 File

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

hans accepted this revision. hans added a comment. Still lgtm. For what it's worth, I think you could have just re-committed with the fixes rather than uploading for review again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://re

[PATCH] D82574: Merge TableGen files used for clang options

herhut added a comment. Could you add the normalization back? This is in line with the comment to make sure the old and new files align. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoStr

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +//

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

kadircet added a comment. thanks for doing this! but i believe these look like bugs that should be addressed in other components, rather than worked around in hover. the first example is likely a bug in selection tree, file location corresponds to a macro body that's never expanded, which resid

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

nikic added a comment. Numbers for the new patch: https://llvm-compile-time-tracker.com/compare.php?from=c0308fd154f9a945608bd42630dc81dce5edfb40&to=e6e3534e77961cfa65d36828de5c75f36a25d009&stat=instructions The regression is definitely smaller now, but still fairly large. E.g. > 2% on mafft.

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

ArcsinX added a comment. @kadircet Thanks for your reply. Think that you are right, because the same problem appears in GTD (with the same test cases). And as for GTD the similar workaround also does not break any regression tests except override/final. Repository: rG LLVM Github Monorepo

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein updated this revision to Diff 276959. hokein added a comment. Clarify the documentation for dependence-bits, and extend it to error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83213/new/ https://reviews.llvm.org/D83213 Files: clang/inc

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276960. eduucaldas added a comment. - Add comment explaining complication on LOK_Raw and LOK_Template - Use FileRange::text instead of Lexer::getSpelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/ne

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein updated this revision to Diff 276961. hokein added a comment. more tweaks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83213/new/ https://reviews.llvm.org/D83213 Files: clang/include/clang/AST/DependenceFlags.h clang/include/clang/AST

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

hokein abandoned this revision. hokein added a comment. closing this in favor of D83213 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83215/new/ https://reviews.llvm.org/D83215 _

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

hokein added a comment. thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83301/new/ https://reviews.llvm.org/D83301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f41ca48d1c4: [clang-tidy] More strict on matching the standard memset function in memset… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang-tools-extra] 5f41ca4 - [clang-tidy] More strict on matching the standard memset function in memset-usage check.

Author: Haojian Wu Date: 2020-07-10T11:42:35+02:00 New Revision: 5f41ca48d1c46fc78958d47c0edfb2dbcde47217 URL: https://github.com/llvm/llvm-project/commit/5f41ca48d1c46fc78958d47c0edfb2dbcde47217 DIFF: https://github.com/llvm/llvm-project/commit/5f41ca48d1c46fc78958d47c0edfb2dbcde47217.diff LO

[PATCH] D83508: [clangd][Hover] Don't use Decl if it is not related with tokens under cursor.

sammccall added a comment. Yeah SelectionTree is the right place to solve this but it's a harder problem there. In general we *don't* only want to trigger on the single token returned by getLocation(). The strategy SelectionTree uses is to attribute tokens to an outer node unless they're assoc

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. In D72705#2143405 , @balazske wrote: > We must check on every execution path that a specific condition on a value is > satisfied (or: find one where the condition is not satisfied). This would be > the most simple form of this

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 276977. LukeGeeson marked 3 inline comments as done. LukeGeeson added a comment. - Addresses dmgreens comments - reordered CPUs in the right places - added code/tests in all files that exist in the a77 patch made minor adjustments including: - adding

[PATCH] D83502: Change behavior with zero-sized static array extents

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2515 +} else { + AI->addAttr(llvm::Attribute::NonNull); +} rjmccall wrote: > Isn't the o

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

Szelethus added a reviewer: NoQ. Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Though, the test file change is interesting. You could add a test that behaves differently from the previous implementation: { FILE *f = fope

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I'd prefer if you moved `f_leak_2` to `stream-notes.c`. Otherwise, LGTM. Comment at: clang/test/Analysis/stream.c:147-150 + FILE *p1 = fopen("foo1.c", "r"); + if (!p1

[clang-tools-extra] a25487f - [clang-tidy] Use Options priority in enum options where it was missing

Author: Nathan James Date: 2020-07-10T12:27:08+01:00 New Revision: a25487fd8cb91f99cfc1db1d4159184ac2a816a9 URL: https://github.com/llvm/llvm-project/commit/a25487fd8cb91f99cfc1db1d4159184ac2a816a9 DIFF: https://github.com/llvm/llvm-project/commit/a25487fd8cb91f99cfc1db1d4159184ac2a816a9.diff

[PATCH] D83115: [Analyzer] Report every bug if only uniqueing location differs.

Szelethus added reviewers: NoQ, vsavchenko, xazax.hun, martong. Szelethus added a subscriber: NoQ. Szelethus added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1136-1137 ID.Add(getLocation()); + ID.Add(getUniqueingLoc()); + ID.AddPointer(getUniqueingLoc

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

Szelethus added a comment. I don't have much to say here, this goes a bit outside my expertise. @NoQ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81061/new/ https://reviews.llvm.org/D81061 ___ cfe-co

[PATCH] D78280: [Analyzer][StreamChecker] Track streams that were not found to be opened.

Szelethus added a comment. Its a bit hard to judge this. Have you tested this on open source projects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78280/new/ https://reviews.llvm.org/D78280 ___ cfe-c

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added a comment. In D83174#2137133 , @rsmith wrote: > @aaron.ballman We will need to do something like this in general, but I'm not > sure it's going to be as easy as just inheriting the attribute in the general > case. What do you think?

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 276991. Xiangling_L marked 6 inline comments as done. Xiangling_L added a comment. Set `Handled...` = true for non-AIX power alignment; Addressed other comments; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/DependenceFlags.h:22 +// cause instantiation to fail +// - or an error (usually in a non-template context) +//

[clang] 4c5a93b - [ABI] Handle C++20 [[no_unique_address]] attribute

Author: Ulrich Weigand Date: 2020-07-10T14:01:05+02:00 New Revision: 4c5a93bd58bad70e91ac525b0e020bd5119a321a URL: https://github.com/llvm/llvm-project/commit/4c5a93bd58bad70e91ac525b0e020bd5119a321a DIFF: https://github.com/llvm/llvm-project/commit/4c5a93bd58bad70e91ac525b0e020bd5119a321a.diff

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/455 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83546

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus marked an inline comment as done. Szelethus added a comment. I'm yet to go over line-by-line, but the overall logic looks great. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

uweigand closed this revision. uweigand added a comment. Committed as 4c5a93bd58bad70e91ac525b0e020bd5119a321a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583

[PATCH] D83511: [clangd] Config: If.PathExclude

sammccall marked an inline comment as done. sammccall added a comment. BTW I'm **not** planning to add Suffix/SuffixExclude in the immediate future, at least for clangd 11 people will have to use `PathMatch: '.*\.h'` or so. Sound OK? Comment at: clang-tools-extra/clangd/unitt

[clang-tools-extra] 86f1313 - [clangd] Config: If.PathExclude

Author: Sam McCall Date: 2020-07-10T14:31:02+02:00 New Revision: 86f1313424fb578b0fd6c950d3ce7cb241f326ea URL: https://github.com/llvm/llvm-project/commit/86f1313424fb578b0fd6c950d3ce7cb241f326ea DIFF: https://github.com/llvm/llvm-project/commit/86f1313424fb578b0fd6c950d3ce7cb241f326ea.diff LO

[PATCH] D83511: [clangd] Config: If.PathExclude

This revision was automatically updated to reflect the committed changes. Closed by commit rG86f1313424fb: [clangd] Config: If.PathExclude (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83511?vs=276839&id=277000#toc Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D82574: Merge TableGen files used for clang options

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[clang] d4ce862 - Reland "[FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support."

Author: Kevin P. Neal Date: 2020-07-10T08:49:45-04:00 New Revision: d4ce862f2aa8b7e4b11462bd72014b08ab9468b3 URL: https://github.com/llvm/llvm-project/commit/d4ce862f2aa8b7e4b11462bd72014b08ab9468b3 DIFF: https://github.com/llvm/llvm-project/commit/d4ce862f2aa8b7e4b11462bd72014b08ab9468b3.diff

[PATCH] D83548: [clangd] Fix tests build for GCC5

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Build log: llvm-project/clang-tools-extra/clangd/unittests/PreambleTests.cpp: In member function ‘virtual void clang::clangd::{

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4ce862f2aa8: Reland "[FPEnv][Clang][Driver] Disable constrained floating point on targets… (authored by kpn). Herald added a reviewer: dang. Changed prior to commit: https://reviews.llvm.org/D80952?vs=

[PATCH] D83511: [clangd] Config: If.PathExclude

hokein added a comment. In D83511#2143803 , @sammccall wrote: > BTW I'm **not** planning to add Suffix/SuffixExclude in the immediate future, > at least for clangd 11 people will have to use `PathMatch: '.*\.h'` or so. > Sound OK? yeah, that sounds goo

[clang] 0555db0 - Normalize default value for -triple correctly

Author: Daniel Grumberg Date: 2020-07-10T13:58:48+01:00 New Revision: 0555db0a5df4d669ce4c2125668ec7a8a42fcd9d URL: https://github.com/llvm/llvm-project/commit/0555db0a5df4d669ce4c2125668ec7a8a42fcd9d DIFF: https://github.com/llvm/llvm-project/commit/0555db0a5df4d669ce4c2125668ec7a8a42fcd9d.dif

[PATCH] D83550: [PATCH 1/4][Sema][AArch64] Add parsing support for arm_sve_vector_bits attribute

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, rsandifo-arm, efriedma, ctetreau, cameron.mcinally. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: aaron.ballman. Herald added a project: clang. This pa

[PATCH] D82574: Merge TableGen files used for clang options

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/CXX/temp/temp.decls/temp.variadic/fixed-expansion.cpp:129 + S &s1 = f({}, 0, 0.0); // expected-error {{no matching function}} \ + expected-

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

dang added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/Driver/Options.td:1246 HelpText<"Enables an experimental new pass manager in LLVM.">; +def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, rsandifo-arm, efriedma, cameron.mcinally, ctetreau. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a reviewer: aaron.ballman. Herald added a project: clang. This pa

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:345 +if (!ILE->isSemanticForm()) + E = ILE->getSemanticForm(); + } shouldn't we put this before `QualType T = E->getType();` ? Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, rsandifo-arm, efriedma, cameron.mcinally, ctetreau. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. This patch implements codegen for the 'arm_sve_

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn marked an inline comment as done. kpn added inline comments. Comment at: clang/include/clang/Driver/Options.td:1246 HelpText<"Enables an experimental new pass manager in LLVM.">; +def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

hokein updated this revision to Diff 277016. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83546/new/ https://reviews.llvm.org/D83546 Files: clang-tools-extra/cla

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:345 +if (!ILE->isSemanticForm()) + E = ILE->getSemanticForm(); + } kadircet wrote: > shouldn't we put this before `QualType T = E->getType();` ? ah, I think you're right. put i

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1246 HelpText<"Enables an experimental new pass manager in LLVM.">; +def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">, + Group, Flags<[CC1Option]>, -

[PATCH] D83548: [clangd] Fix tests build for GCC5

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83548/new/ https://reviews.llvm.org/D83548 __

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83546/new/ https://reviews.llvm.org/D83546 __

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277019. LukeGeeson added a comment. - Added FP16 to Cortex-X1 set of features CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:88-92 + if (const auto *ID = dyn_cast(D)) { +if (const auto *IMD = ID->getImplementation()) + return IMD; +return ID->getDefinition(); + }

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:135 + (AArch64::AEK_FP16 | AArch64::AEK_DOTPROD | AArch64::AEK_RCPC | + AArch64::AEK_SSBS | AArch64::AEK_RAS)) AARCH64_CPU_NAME("neoverse-e1", ARMV8_2A,

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 277022. gargvaibhav64 marked 3 inline comments as done. gargvaibhav64 added a comment. Incorporated the changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files: clang/lib/Serialization/ASTReade

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/stream.c:274-284 // Check that "location uniqueing" works. // This results in reporting only one occurence of resource leak for a stream. void check_leak_noreturn_2() {

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277026. dgoldman added a comment. Fixes for getDefinition/getCanonicalDecl for ObjC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/X

[PATCH] D83556: [clangd] Update semanticTokens support to reflect latest LSP draft

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Mostly a few methods and message names have been renamed. Repository: rG LLVM Github Monor

[PATCH] D83546: [clangd] Fix hover crash on InitListExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG015a0faa5e9e: [clangd] Fix hover crash on InitListExpr. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D83546?vs=277016&id=277031#toc Repository: rG LLVM Github Monorepo CHA

[clang-tools-extra] 015a0fa - [clangd] Fix hover crash on InitListExpr.

Author: Haojian Wu Date: 2020-07-10T16:18:16+02:00 New Revision: 015a0faa5e9ef3095d521e1daf03fab9683ba028 URL: https://github.com/llvm/llvm-project/commit/015a0faa5e9ef3095d521e1daf03fab9683ba028 DIFF: https://github.com/llvm/llvm-project/commit/015a0faa5e9ef3095d521e1daf03fab9683ba028.diff LO

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277032. LukeGeeson added a comment. - removed RAS as it's in 8.2a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c llvm/inc

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277033. LukeGeeson marked an inline comment as done. LukeGeeson added a comment. - removed missed RAS CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

LukeGeeson updated this revision to Diff 277036. LukeGeeson added a comment. - Added FP16 to ARM a78 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c llvm/include/l

[PATCH] D83556: [clangd] Update semanticTokens support to reflect latest LSP draft

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83556/new/ https://reviews.llvm.org/D83556

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:328-329 struct Signature { -const ArgTypes ArgTys; -const QualType RetTy; +ArgTypes ArgTys; +QualType RetTy;

[clang] 523a851 - [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support."

Author: Kevin P. Neal Date: 2020-07-10T10:34:15-04:00 New Revision: 523a8513f8ba4d6b111496c541b9ba9f4d5f0261 URL: https://github.com/llvm/llvm-project/commit/523a8513f8ba4d6b111496c541b9ba9f4d5f0261 DIFF: https://github.com/llvm/llvm-project/commit/523a8513f8ba4d6b111496c541b9ba9f4d5f0261.diff

[PATCH] D82574: Merge TableGen files used for clang options

jeroen.dobbelaere added a comment. I think that 'clang/include/clang/Driver/CC1Options.td' should also be removed ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. I think without index changes this will still give the wrong answer for go-to-definition if the @implementation is in a different file. Do you want to include those too or will that work ok in a separate patch? (I'm not 100% sure of the interactions here, possible it'll

[clang-tools-extra] 5fea54b - [clangd] Update semanticTokens support to reflect latest LSP draft

Author: Sam McCall Date: 2020-07-10T16:52:57+02:00 New Revision: 5fea54bc05a71e81e843fd9284d258cd38d7fe23 URL: https://github.com/llvm/llvm-project/commit/5fea54bc05a71e81e843fd9284d258cd38d7fe23 DIFF: https://github.com/llvm/llvm-project/commit/5fea54bc05a71e81e843fd9284d258cd38d7fe23.diff LO

[PATCH] D83556: [clangd] Update semanticTokens support to reflect latest LSP draft

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fea54bc05a7: [clangd] Update semanticTokens support to reflect latest LSP draft (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83556

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen updated this revision to Diff 277042. khchen added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71124/new/ https://reviews.llvm.org/D71124 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.h c

[PATCH] D82157: Fix crash on `user defined literals`

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:749 + else +return new (allocator()) syntax::FloatUserDefinedLiteralExpression; +} ---

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 277043. c-rhodes added a comment. Changes: - Use fixed-length instead of fixed-width in naming. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83553/new/ https://reviews.llvm.org/D83553 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGR

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2142426 , @rjmccall wrote: > Would it be sensible to use a technical design more like what the matrix > folks are doing, where LLVM provides a small interface for emitting > operations with various semantics? FixedPoin

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman updated this revision to Diff 277054. dgoldman marked 2 inline comments as done. dgoldman added a comment. Add support for categories + fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Fil

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

amyk added a comment. Please update this patch to remove the instruction defs and MC tests. Also, you can update the patch to put your backend llc tests in the file I've introduced in: https://reviews.llvm.org/D82467 Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:14

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 277060. eduucaldas marked an inline comment as done. eduucaldas added a comment. Add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/cl

[PATCH] D83536: [clangd] Index refs to main-file symbols as well

nridge added a comment. In D83536#2143436 , @kadircet wrote: > I can see how this is needed for implementing the full protocol though (we've > already cut on the multi-level callees support), so would you be so kind to > hide this behind an option to sym

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman marked an inline comment as done. dgoldman added a comment. In D83501#2144144 , @sammccall wrote: > I think without index changes this will still give the wrong answer for > go-to-definition if the @implementation is in a different file. > Do yo

  1   2   3   >