[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

vingeldal added a comment. In D70265#1920379 , @aaron.ballman wrote: > LGTM! Do you need someone to commit on your behalf? Yes please. Do I need to, or can I, do anything about the failing builds (https://reviews.llvm.org/B49012) first? They seem unrel

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

jdoerfert added a comment. I think this is functionally correct even if we pass the pointer for now as it is properly "privatized" in the callee. I will go over this once more (after some sleep) but I think it is all good. Once @fghanim puts the new code path on phab we need to ensure it works

[libunwind] abc238a - [libunwind] Silence warnings when __mips_hard_float is not defined

Author: Mikael Holmen Date: 2020-03-13T09:19:56+01:00 New Revision: abc238a3c736191cc24a517428ededf043d7d713 URL: https://github.com/llvm/llvm-project/commit/abc238a3c736191cc24a517428ededf043d7d713 DIFF: https://github.com/llvm/llvm-project/commit/abc238a3c736191cc24a517428ededf043d7d713.diff

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250142. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp c

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250147. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clang/unittests/AST

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko created this revision. hlopko added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko updated this revision to Diff 250147. hlopko added a comment. Reformat Only for the readability reasons. Repository: rG LLVM Github Monorepo https:

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250141. hlopko added a comment. Refactor the test to use matchers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/l

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250143. hlopko added a comment. Rearrange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp

[clang-tools-extra] ecd3e67 - [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

Author: Kadir Cetinkaya Date: 2020-03-13T09:40:47+01:00 New Revision: ecd3e678bbb11cf899603037ec2c5949b8d7fa6c URL: https://github.com/llvm/llvm-project/commit/ecd3e678bbb11cf899603037ec2c5949b8d7fa6c DIFF: https://github.com/llvm/llvm-project/commit/ecd3e678bbb11cf899603037ec2c5949b8d7fa6c.dif

[PATCH] D75996: [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

kadircet updated this revision to Diff 250149. kadircet added a comment. - Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75996/new/ https://reviews.llvm.org/D75996 Files: clang-tools-extra/clangd/Preamble.cpp clang-tool

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked 9 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:33-45 + enum KindTy { +Opened, /// Stream is opened. +Closed, /// Closed stream (an invalid stream pointer after it was closed). +

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/unittests/AST/SourceLocationTest.cpp:856 + + auto *D = selectFirst("vd", match(varDecl().bind("vd"), Ctx)); + ASSERT_TRUE(D != nullptr); s/D/VD/? (for VarDecl) Repository:

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250152. hlopko added a comment. Wrap the test with an anonymous namespace, remove fully qualified name to Lang_*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files:

[PATCH] D76121: Modernize DeclTest

hlopko created this revision. hlopko added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes a call to the old ASTUnit::findFileRegionDecls and replaces it with ast matchers. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg added inline comments. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_max_align_t>::value; ldionne wrote: > So, IIUC what you're saying, `

[PATCH] D75996: [clangd] Populate PreambleData::CompileCommand and make use of it inside buildPreamble

This revision was automatically updated to reflect the committed changes. Closed by commit rGecd3e678bbb1: [clangd] Populate PreambleData::CompileCommand and make use of it inside… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] db1f40d - Modernize DeclTest

Author: Marcel Hlopko Date: 2020-03-13T10:37:48+01:00 New Revision: db1f40d1a16f868a86501e30feadbfb285c2e922 URL: https://github.com/llvm/llvm-project/commit/db1f40d1a16f868a86501e30feadbfb285c2e922 DIFF: https://github.com/llvm/llvm-project/commit/db1f40d1a16f868a86501e30feadbfb285c2e922.diff

[clang] ce79c42 - [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

Author: Marcel Hlopko Date: 2020-03-13T10:47:57+01:00 New Revision: ce79c4246919d777346dd3821c087faa1dcc725e URL: https://github.com/llvm/llvm-project/commit/ce79c4246919d777346dd3821c087faa1dcc725e DIFF: https://github.com/llvm/llvm-project/commit/ce79c4246919d777346dd3821c087faa1dcc725e.diff

[PATCH] D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added a project: clang. These are complicated integer multiply+add instructions with extra saturation, taking the hig

[PATCH] D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. These instructions compute multiply+add in integers, with one of the operands bei

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250158. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/DeclTest.cpp Index: clang/unittests/AST/DeclTest.cp

[PATCH] D76121: Modernize DeclTest

hlopko updated this revision to Diff 250159. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76121/new/ https://reviews.llvm.org/D76121 Files: clang/unittests/AST/DeclTest.cpp Index: clang/unittests/AST/DeclTest.cp

[PATCH] D75298: [Clang][SVE] Parse builtin type string for scalable vectors

sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:86 + OS << "#ifndef __cplusplus\n"; + OS << "#include \n"; + OS << "#endif\n\n"; efriedma wrote: > I'd prefer to avoid depending on st

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250161. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp cla

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250160. hlopko added a comment. Rename D->VD, rebase master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Par

[PATCH] D76121: Modernize DeclTest

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb1f40d1a16f: Modernize DeclTest (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76121/new/ https://reviews.llvm

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250163. hlopko added a comment. Remove extra blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clan

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

This revision was automatically updated to reflect the committed changes. Closed by commit rGce79c4246919: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D72073: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Superseded by https://reviews.llvm.org/D76061. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72073/new/ https://reviews.llvm.org/D72073

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8640737d476: Refactor SourceLocationTest to `using namespace` (authored by hlopko, committed by gribozavr). Changed prio

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250162. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clang/unittests/AST/S

[clang] f864073 - Refactor SourceLocationTest to `using namespace`

Author: Marcel Hlopko Date: 2020-03-13T10:55:24+01:00 New Revision: f8640737d4767cb88225e84515a6a2bd992cb84f URL: https://github.com/llvm/llvm-project/commit/f8640737d4767cb88225e84515a6a2bd992cb84f DIFF: https://github.com/llvm/llvm-project/commit/f8640737d4767cb88225e84515a6a2bd992cb84f.diff

[PATCH] D75911: [clang-tidy] Added hasAnyListedName matcher

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/Matchers.h:53-55 +ast_matchers::internal::Matcher +hasAnyListedName(std::vector Names); + alexfh wrote: > We could change all checks to use t

[clang] 2e77f0c - Added 'const' as suggested by ClangTidy llvm-qualified-auto

Author: Dmitri Gribenko Date: 2020-03-13T11:49:23+01:00 New Revision: 2e77f0cf76be7c4b78784d6bb098e0c23d670ab0 URL: https://github.com/llvm/llvm-project/commit/2e77f0cf76be7c4b78784d6bb098e0c23d670ab0 DIFF: https://github.com/llvm/llvm-project/commit/2e77f0cf76be7c4b78784d6bb098e0c23d670ab0.dif

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

samparker added a comment. Hi, I like reading your code! But I'm concerned around the lack of tests here, specifically: - CPSR liveness. - LR liveness. - All things PIC related. - Linkage legality. - A negative test for Thumb-1. - Inline asm generally concerns me too. Commen

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. First step to enable deferred preamble builds. Not intending to land it alone, will have f

[PATCH] D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76123/new/ https://reviews.llvm.org/D76123 ___

[PATCH] D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA.

simon_tatham updated this revision to Diff 250174. simon_tatham added a comment. Fix clang-format warnings. (Is it //really// sensible to require even //test// input files, which are often autogenerated, to be fixed points of clang-format?) Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0ffb12c - [HIP] Mark kernels with uniform-work-group-size=true

Author: Yaxun (Sam) Liu Date: 2020-03-13T06:56:56-04:00 New Revision: 0ffb12ca67fd813a8ae840399626dd5f8fea3178 URL: https://github.com/llvm/llvm-project/commit/0ffb12ca67fd813a8ae840399626dd5f8fea3178 DIFF: https://github.com/llvm/llvm-project/commit/0ffb12ca67fd813a8ae840399626dd5f8fea3178.dif

[PATCH] D76076: [HIP] Mark kernels with uniform-work-group-size=true

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffb12ca67fd: [HIP] Mark kernels with uniform-work-group-size=true (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

baloghadamsoftware marked 6 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DebugIteratorModeling.cpp:91-111 SVal V = C.getSVal(CE->getArg(0)); const auto *Pos = getIteratorPosition(State, V); + SVal Field =

[clang] 28ad9fc - [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

Author: Alexandre Ganea Date: 2020-03-13T08:15:35-04:00 New Revision: 28ad9fc20823678881baa0d723834b88ea9e8e3a URL: https://github.com/llvm/llvm-project/commit/28ad9fc20823678881baa0d723834b88ea9e8e3a DIFF: https://github.com/llvm/llvm-project/commit/28ad9fc20823678881baa0d723834b88ea9e8e3a.dif

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

hokein updated this revision to Diff 250183. hokein added a comment. - rebase to master - update some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65592/new/ https://reviews.llvm.org/D65592 Files: clang/include/clang/Parse/Parser.h c

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. In D76077#1919897 , @rjmccall wrote: > Note that we have an IR type for the PPC double-double format, which isn't > even hardware-supported. This is literally just an IEEE floating-point > format with non-standard parameters,

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

This revision was automatically updated to reflect the committed changes. Closed by commit rG28ad9fc20823: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D65592: [Parser] Avoid spurious 'missing template' error in presence of typos

hokein updated this revision to Diff 250184. hokein added a comment. remove an accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65592/new/ https://reviews.llvm.org/D65592 Files: clang/include/clang/Parse/Parser.h clang/include/cl

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added a comment. In D76077#1919861 , @rjmccall wrote: > I don't understand why you wouldn't add a new IR type for this; doing so > should be totally mechanical. We had a few reasons for doing it this way. By adding a new IR type we would nee

[PATCH] D76128: [AST] Correct the CXXOperatorCallExpr source range.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Previously, the range for "->" CXXOperatorCallExpr is the range of the class object (not including the operator!), e.g.

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-mangle-16bit-float.cpp:4 + +// CHECK64: define {{.*}}void @_Z3foou6__bf16(half %b) +// CHECK32: define {{.*}}void @_Z3foou6__bf16(i32 %b.coerce) crai

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

lenary added a comment. In D57497#1920870 , @shiva0217 wrote: > In D57497#1920097 , @apazos wrote: > > > Thanks Shiva, I res-ynced and rebuilt the patch. It is working fine. > > > > I see there is a msmall-data-thre

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss updated this revision to Diff 250191. danielkiss marked an inline comment as done. danielkiss added a comment. Patch is rebased, test is updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, sfertile. Herald added subscribers: cfe-commits, kbarton, hiraditya, nemanjai. Herald added a project: clang. This patch adds support for handling of variadic functions for AIX. This includes ensuring that use and consume corr

[clang-tools-extra] 512767e - Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

Author: Kim Viggedal Date: 2020-03-13T10:05:13-04:00 New Revision: 512767eb3fe9c34c655a480d034147c54f1d4f85 URL: https://github.com/llvm/llvm-project/commit/512767eb3fe9c34c655a480d034147c54f1d4f85 DIFF: https://github.com/llvm/llvm-project/commit/512767eb3fe9c34c655a480d034147c54f1d4f85.diff

[PATCH] D75542: [Sema] Prevent UB for uninitialized `IsSurrogate`

modocache abandoned this revision. modocache added a comment. Awesome, thanks! > Alternatively, I considered modifying the `clang::OverloadCandidate` > constructor to initialize `IsSurrogate` with a false value. I feel doing so > would be safer, but I stuck with what appears to be the conventio

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

aaron.ballman closed this revision. aaron.ballman added a comment. In D70265#1921013 , @vingeldal wrote: > In D70265#1920379 , @aaron.ballman > wrote: > > > LGTM! Do you need someone to commit on your behalf? > > >

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

aganea added a comment. Looks like there's a memory corruption detected by ASAN, but I'm not sure it's related to my change. Maybe someone with a more expert eye could tell? http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/steps/check-asan%20in%20gcc%20build/logs/stdio Rep

[clang] 172f146 - [OPENMP]Reduce number of captured global vars.

Author: Alexey Bataev Date: 2020-03-13T10:47:54-04:00 New Revision: 172f1460ae05ab5c33c757142c8bdb10acfbdbe1 URL: https://github.com/llvm/llvm-project/commit/172f1460ae05ab5c33c757142c8bdb10acfbdbe1 DIFF: https://github.com/llvm/llvm-project/commit/172f1460ae05ab5c33c757142c8bdb10acfbdbe1.diff

[clang] 03993f3 - [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

Author: Sergej Jaskiewicz Date: 2020-03-13T17:58:02+03:00 New Revision: 03993f3b6f46ae533575ec057bb84c80d8218641 URL: https://github.com/llvm/llvm-project/commit/03993f3b6f46ae533575ec057bb84c80d8218641 DIFF: https://github.com/llvm/llvm-project/commit/03993f3b6f46ae533575ec057bb84c80d8218641.d

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

jranieri-grammatech updated this revision to Diff 250202. jranieri-grammatech added a comment. Adding context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76083/new/ https://reviews.llvm.org/D76083 Files: clang-tools-extra/clang-tidy/bugprone/

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

ldionne requested changes to this revision. ldionne added inline comments. Herald added a subscriber: dexonsmith. Comment at: libcxx/include/new:240 return __align > __STDCPP_DEFAULT_NEW_ALIGNMENT__; +#elif defined(_LIBCPP_CXX03_LANG) + return __align > alignment_of<__libcpp_

[PATCH] D75760: [clang-format] Do not indent C# array initialisers as continuations

jbcoe marked an inline comment as done. jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1443 +if (Style.isCSharp()) + FormatTok->BlockKind = BK_BracedInit; nextToken(); krasimir wrote: > A more general a

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG03993f3b6f46: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb). Repos

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. Thanks for sticking this out! It just takes me a while to get to the mental space regarding this patch you are already in, sometimes through saying incorrect statements or stupid suggestions! :) If others could chip in in this discussion, it would be most appreciated,

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX.

ZarkoCA updated this revision to Diff 250213. ZarkoCA added a comment. Clang formatted the patch and fixed typo in testcase. Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files: clang/lib/Basic/Targets/P

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

hans added a comment. In D76099#1921571 , @aganea wrote: > Looks like there's a memory corruption detected by ASAN, but I'm not sure > it's related to my change. Maybe someone with a more expert eye could tell? > > http://lab.llvm.org:8011/builders/saniti

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250229. echristo added a comment. Fixed the clang test. Tried to get something that I could reduce down and duplicate with just opt but it's been... difficult. Even the small clang testcase in isolation won't duplicate via something like: clang -O0 -fexpe

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:393-394 + + // Make the return value accordingly to the error. + State = State->assume(RetVal, (SS->*IsOfError)()); + assert(State && "Ret

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

echristo updated this revision to Diff 250232. echristo added a comment. Fix comments around full unroller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 Files: clang/test/Misc/loop-opt-setup.c llvm/l

[Diffusion] rG396b7253944e: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

jdoerfert marked an inline comment as done. jdoerfert added inline comments. BRANCHES master /clang/test/OpenMP/PR44893.c:3 > A test with no CHECK lines also passes if you symlink /bin/true to clang :-) > It also doesn't indicate what is being relevant and when it comes to > maintaining / upd

[clang-tools-extra] 3860b2a - [clang-tidy] Update Abseil Duration Conversion check to find more cases.

Author: Hyrum Wright Date: 2020-03-13T12:52:37-04:00 New Revision: 3860b2a0bd09291a276b0590939961dffe67fbb6 URL: https://github.com/llvm/llvm-project/commit/3860b2a0bd09291a276b0590939961dffe67fbb6 DIFF: https://github.com/llvm/llvm-project/commit/3860b2a0bd09291a276b0590939961dffe67fbb6.diff

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. > The performance implications of deleting those lines is the complicated part. Where does compile time performance suffer from this? I guess if we have massive array initializers, or large struct definitions, or

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

Charusso added a comment. In D75529#1920796 , @vabridgers wrote: > I believe all comments have been addressed. Please let me know if there's > anything else required. Thanks I think you have solved everything. Do you have commit access? May you would r

[PATCH] D75514: [Analyzer] Only add container note tags to the operations of the affected container

baloghadamsoftware updated this revision to Diff 250248. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to the comments of D75677 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75514/new/ https

[PATCH] D72100: Allow matching "any file" in `VerifyDiagnosticConsumer`.

arames updated this revision to Diff 250247. arames added a comment. Apply `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72100/new/ https://reviews.llvm.org/D72100 Files: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h

[PATCH] D75558: [clang-tidy] Update abseil-duration-unnecessary-conversion check to find more cases.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3860b2a0bd09: [clang-tidy] Update Abseil Duration Conversion check to find more cases. (authored by hwright). Changed prior to commit: https://reviews.llvm.org/D75558?vs=247988&id=250252#toc Repository

[PATCH] D75529: [analyzer] Limit UCharMax to min of max uchar or max int

vabridgers marked an inline comment as done. vabridgers added a comment. @Charusso -- I do not have commit access, but I will request. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75529/new/ https://reviews.llvm.org/D75529 __

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

rjmccall added a comment. In D76077#1921490 , @LukeGeeson wrote: > In D76077#1919861 , @rjmccall wrote: > > > I don't understand why you wouldn't add a new IR type for this; doing so > > should be totally mechanica

[PATCH] D76100: Debug Info: Store the SDK in the DICompileUnit.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76100/new/ https://reviews.llvm.org/D76100 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers added inline comments. Comment at: clang/lib/AST/Expr.cpp:3164 + const QualType &QT = cast(this)->getDecl()->getType(); + if (QT->isStructureType() && QT.isConstQualified()) +return true; efriedma wrote: > efriedma wrote: > > nic

[PATCH] D76096: [clang] allow const structs to be constant expressions in initializer lists

nickdesaulniers added a comment. In D76096#1920685 , @efriedma wrote: > I think the code that disables constant evaluation for C is just > https://github.com/llvm/llvm-project/blob/dcaf13a4048df3dad55f1a28cde7cefc99ccc057/clang/lib/AST/ExprConstant.cpp#L1

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

Quuxplusone added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:51 + // Remove the '::' at the end. + assert(NNS.size() >= 2); + NNS.erase(NNS.end() - 2, NNS.end()); As long as you're asserting anyway, I think you sh

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 250263. JonChesterfield added a comment. - Amend diagnostic as suggested, clang-format new lines in SemaKinds.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. In D74361#1920329 , @aaron.ballman wrote: > Aside from the diagnostic wording, I think this LG to me. However, I'd > appreciate if @rjmccall would also sign off. Thanks! @rjmccall? Comment at: clang/

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 250264. JonChesterfield marked an inline comment as done. JonChesterfield added a comment. - undo reformat of existing def Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.o

[clang] 842ea70 - Debug Info: Store the SDK in the DICompileUnit.

Author: Adrian Prantl Date: 2020-03-13T11:21:30-07:00 New Revision: 842ea709e4ed881c2bc59155af5df910eccda9c6 URL: https://github.com/llvm/llvm-project/commit/842ea709e4ed881c2bc59155af5df910eccda9c6 DIFF: https://github.com/llvm/llvm-project/commit/842ea709e4ed881c2bc59155af5df910eccda9c6.diff

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

dblaikie added a comment. Could you upload this with full context ( https://llvm.org/docs/Phabricator.html#id4 mentions how to do this)? Does this still have an OpenMP special case? The production code changes don't seem to mention OpenMP anymore, but there's still a lot of test updates for Op

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson updated this revision to Diff 250267. LukeGeeson added a comment. Added a file from a downstream cleanup of the branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 Files: clang/docs/LanguageExtensions.rst clang/include/clang-c

[PATCH] D76086: [Sema][SVE] Reject arithmetic on pointers to sizeless types

rsandifo-arm added a comment. In D76086#1920558 , @efriedma wrote: > People are going to want to iterate over arrays in memory to write simple > intrinsic loops. If we don't allow `p + i` to work, people will be forced to > write `(__SVInt8_t*)((char*)p

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 250272. logan-5 marked 2 inline comments as done. logan-5 added a comment. Re-juggled and made `bool OnlyDependsOnFundamentalArraySizes(QualType QualTy)` recursive. Made `::` assert more useful. Thanks @Quuxplusone for both good ideas. CHANGES SINCE LAST A

[clang] b50d80c - [Sema][SVE] Don't allow fields to have sizeless type

Author: Richard Sandiford Date: 2020-03-13T19:22:23Z New Revision: b50d80c1ee1fc154c906f59a2ebedab2f85bacca URL: https://github.com/llvm/llvm-project/commit/b50d80c1ee1fc154c906f59a2ebedab2f85bacca DIFF: https://github.com/llvm/llvm-project/commit/b50d80c1ee1fc154c906f59a2ebedab2f85bacca.diff

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

jfb added a comment. In D76077#1921973 , @rjmccall wrote: > In D76077#1921490 , @LukeGeeson > wrote: > > > In D76077#1919861 , @rjmccall > > wrote: > > > > > I don't unders

[PATCH] D76090: [Sema][SVE] Don't allow sizeless types to be caught

rsandifo-arm updated this revision to Diff 250273. rsandifo-arm added a comment. Allow pointers to sizeless types to be caught. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76090/new/ https://reviews.llvm.org/D76090 Files: clang/include/clang/B

[PATCH] D75737: [Sema][SVE] Don't allow fields to have sizeless type

This revision was automatically updated to reflect the committed changes. rsandifo-arm marked an inline comment as done. Closed by commit rGb50d80c1ee1f: [Sema][SVE] Don't allow fields to have sizeless type (authored by rsandifo-arm). Changed prior to commit: https://reviews.llvm.org/D75737?vs=

[clang] 8c5c60a - [Sema][SVE] Reject by-copy capture of sizeless types

Author: Richard Sandiford Date: 2020-03-13T19:27:31Z New Revision: 8c5c60a493ca31c7e808ca48a99ed4bd5900b43d URL: https://github.com/llvm/llvm-project/commit/8c5c60a493ca31c7e808ca48a99ed4bd5900b43d DIFF: https://github.com/llvm/llvm-project/commit/8c5c60a493ca31c7e808ca48a99ed4bd5900b43d.diff

[clang] 994c071 - [Sema][SVE] Reject arrays of sizeless types

Author: Richard Sandiford Date: 2020-03-13T19:28:45Z New Revision: 994c071a1b7eee8de132d78286c730da2be2c48f URL: https://github.com/llvm/llvm-project/commit/994c071a1b7eee8de132d78286c730da2be2c48f DIFF: https://github.com/llvm/llvm-project/commit/994c071a1b7eee8de132d78286c730da2be2c48f.diff

[clang] f82b32a - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

Author: Nico Weber Date: 2020-03-13T15:37:44-04:00 New Revision: f82b32a51e22cc56d20f695772797127d3f9d85a URL: https://github.com/llvm/llvm-project/commit/f82b32a51e22cc56d20f695772797127d3f9d85a DIFF: https://github.com/llvm/llvm-project/commit/f82b32a51e22cc56d20f695772797127d3f9d85a.diff LO

[PATCH] D73846: [PCH] make sure to not warn about unused macros from -D

dblaikie added a comment. Looks pretty reasonable to me - but I don't know enough about the macro and source location infrastructure. @rsmith - mind taking a quick look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846

[PATCH] D76090: [Sema][SVE] Don't allow sizeless types to be caught

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76090/new/ https://reviews.llvm.org/D76090 ___

[PATCH] D75738: [Sema][SVE] Reject by-copy capture of sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c5c60a493ca: [Sema][SVE] Reject by-copy capture of sizeless types (authored by rsandifo-arm). Changed prior to commit: https://reviews.llvm.org/D75738?vs=248702&id=250281#toc Repository: rG LLVM Git

[PATCH] D76082: [Sema][SVE] Reject arrays of sizeless types

This revision was automatically updated to reflect the committed changes. Closed by commit rG994c071a1b7e: [Sema][SVE] Reject arrays of sizeless types (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76082/new/ https://revie

  1   2   >