[PATCH] D71365: expand printf when compiling HIP to AMDGPU

sameerds updated this revision to Diff 237864. sameerds added a comment. - Added a test for address spaces - Removed an unnecessary addrspacecast in the strlen expansion - Updated the tests to pass -fcuda-is-device - printf is not a builtin for device code, so removed the code and tests related t

[PATCH] D72647: [clangd] Only re-open files if their flags changed

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1125 // Per-file update to the compilation database. - bool ShouldReparseOpenFiles = false; + std::set ModifiedFiles; + auto Sub = nit: llvm::StringSet<> or DenseSet a

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

sameerds marked 2 inline comments as done. sameerds added inline comments. Comment at: clang/test/CodeGenHIP/printf.cpp:18 +} + +// CHECK: [[BEGIN:%.*]] = call i64 @__ockl_printf_begin(i64 0) arsenm wrote: > sameerds wrote: > > sameerds wrote: > > > arsenm wrot

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

sylvestre.ledru added a comment. In D71174#1774249 , @ztamas wrote: > I run the new check on LibreOffice codebase with the option > CharTypdefsToIgnore = "sal_Int8". > The check produced 32 findings. Interesting. It found 31 issues on the Firefox code

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

balazske added a comment. The checker was implemented in smaller parts that are visible in the commit list. I can split the patch at the commits (and figure out how to use git history manipulations and phabricator in a better way?). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237886. kadircet marked 5 inline comments as done. kadircet added a comment. - Increase control around paddings for plaintext rendering. - Add another ruler before definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237887. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.llvm.org/D72622 Files: clang-tools-extra/clangd/FormattedString.cpp clang-tools

[clang-tools-extra] 45924eb - [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

Author: Malcolm Parsons Date: 2020-01-14T10:05:12Z New Revision: 45924eb4671692b3fa9fd52fe39c81ec0647a848 URL: https://github.com/llvm/llvm-project/commit/45924eb4671692b3fa9fd52fe39c81ec0647a848 DIFF: https://github.com/llvm/llvm-project/commit/45924eb4671692b3fa9fd52fe39c81ec0647a848.diff LO

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet updated this revision to Diff 237888. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments and rebase on top of ruler patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.or

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:553 + // Put a linebreak after header to increase readability. + Output.addRuler(); sammccall wrote: > (When merging with D72623, I'm assuming return type will go below this line?)

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

balazske added a comment. I wanted to implement the rules described here: https://wiki.sei.cmu.edu/confluence/display/c/ERR33-C.+Detect+and+handle+standard+library+errors This lists the functions to check so this knowledge has to be built into the checker and there are examples of this in other c

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:567 + } else if (Type) { +Output.addParagraph().appendText("Type: ").appendCode(*Type); } sammccall wrote: > consider **`∈`**, which would be short and symmetrical with the arr

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61802 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61802 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. malcolm.parsons marked an inline comment as done. Closed by commit rG45924eb46716: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init (authored by malcolm.parsons). Repository: rG LLVM Github Monorepo

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:567 + } else if (Type) { +Output.addParagraph().appendText("Type: ").appendCode(*Type); } kadircet wrote: > sammccall wrote: > > consider **`

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak marked 2 inline comments as done. llunak added a comment. In D69585#1818205 , @rnk wrote: > I'm interested in making clang do this, but I think this needs significantly > more work until this is ready to land. It needs in-tree tests. What tests s

[PATCH] D72690: [ARM,MVE] Use the new Tablegen `defvar` and `if` statements.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, miyuki. Herald added subscribers: llvm-commits, cfe-commits, dmgreen, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This cleans up a lot of ugly `foreach` bodges that I've been using to work around th

[PATCH] D67843: [clang-format] DisableFormat also now disables SortIncludes

krasimir added a comment. I also am worried that this makes it impossible to just sort includes. Alternatively, we could update the documentation of the `DisableFormat` option to mention this quirk: https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Format/Format.h#L1231 It's n

[PATCH] D72500: [clangd] Show hover info for expressions

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:431 + +// Generates hover info for string literals and evaluatable expressions. +// FIXME: Support hover for user-defined literals. I'd really like to avoid *any literals here in the

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

kmclaughlin updated this revision to Diff 237906. kmclaughlin added a comment. - Rebased patch - Updated comments and extended getSVEContainerType to handle nxv8i16 & nxv16i8 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71698/new/ https://reviews.llvm.org/D71698 Files: llvm/include/

[PATCH] D71698: [AArch64][SVE] Add intrinsic for non-faulting loads

kmclaughlin marked 5 inline comments as done. kmclaughlin added a comment. Thanks for your suggestions, @andwar! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71698/new/ https://reviews.llvm.org/D71698 ___ cfe-commits mailing list cfe-commi

[clang] 3d6c492 - [RISCV] Fix ILP32D lowering for double+double/double+int return types

Author: James Clarke Date: 2020-01-14T11:17:19Z New Revision: 3d6c492d7a9830a1a39b85dfa215743581d52715 URL: https://github.com/llvm/llvm-project/commit/3d6c492d7a9830a1a39b85dfa215743581d52715 DIFF: https://github.com/llvm/llvm-project/commit/3d6c492d7a9830a1a39b85dfa215743581d52715.diff LOG:

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d6c492d7a98: [RISCV] Fix ILP32D lowering for double+double/double+int return types (authored by jrtc27). Changed prior to commit: https://reviews.llvm.org/D69590?vs=226981&id=237912#toc Repository:

[PATCH] D72623: [clangd] Rearrange type, returntype and parameters in hover card

lh123 added a comment. I think the character "🡺" should be avoided, as it may not display properly in some environments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72623/new/ https://reviews.llvm.org/D72623 __

[PATCH] D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata

lenary added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:151 + TargetMachine::initTargetOptions(M, Conf.Options); + tejohnson wrote: > lenary wrote: > > tejohnson wrote: > > > lenary wrote: > > > > tejohnson wrote: > > > > > This is going to be pr

[PATCH] D72690: [ARM,MVE] Use the new Tablegen `defvar` and `if` statements.

MarkMurrayARM accepted this revision. MarkMurrayARM added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2464 + defvar pred_int = int_arm_mve_vshll_imm_predicated; + defvar imm= inst_imm.immediateType;

[PATCH] D72691: [clang-tidy] Match InitListExpr in modernize-use-default-member-init

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. modernize-use-default-member-init wasn't warning about redundant initialisers when the initialiser was an InitL

[clang] 71d5454 - [ARM, MVE] Use the new Tablegen `defvar` and `if` statements.

Author: Simon Tatham Date: 2020-01-14T12:08:03Z New Revision: 71d5454b377239213874a0d762860e6a3e60bf54 URL: https://github.com/llvm/llvm-project/commit/71d5454b377239213874a0d762860e6a3e60bf54 DIFF: https://github.com/llvm/llvm-project/commit/71d5454b377239213874a0d762860e6a3e60bf54.diff LOG:

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

bader added a subscriber: Naghasan. bader added a comment. In D72362#1817682 , @lebedev.ri wrote: > In D72362#1817599 , @bader wrote: > > > Does it make sense to implement such diagnostics in clang Sema, considering

[PATCH] D72690: [ARM,MVE] Use the new Tablegen `defvar` and `if` statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG71d5454b3772: [ARM,MVE] Use the new Tablegen `defvar` and `if` statements. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72690/ne

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. Anything further needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71607/new/ https://reviews.llvm.org/D71607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237934. kadircet added a comment. - Per offline discussions, do post processing to get rid of multiple ruler occurences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.llvm.org/D7262

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61819 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

ztamas added a comment. In D71174#1818883 , @sylvestre.ledru wrote: > In D71174#1774249 , @ztamas wrote: > > > I run the new check on LibreOffice codebase with the option > > CharTypdefsToIgnore = "sal_Int8". > >

[PATCH] D72624: [WIP] TargetMachine Hook for Module Metadata

khchen added a comment. In D72624#1818605 , @khchen wrote: > I think putting the resetTargetDefaultOptions after instance of TargetMachine > is too late. > for example: > ppc >

[clang] df18650 - Make helper functions static or move them into anonymous namespaces. NFC.

Author: Benjamin Kramer Date: 2020-01-14T14:06:37+01:00 New Revision: df186507e1d07c3ddba091a076ba7a33dbdc5867 URL: https://github.com/llvm/llvm-project/commit/df186507e1d07c3ddba091a076ba7a33dbdc5867 DIFF: https://github.com/llvm/llvm-project/commit/df186507e1d07c3ddba091a076ba7a33dbdc5867.dif

[PATCH] D71467: [FPEnv] Generate constrained FP comparisons from clang

uweigand added a comment. In D71467#1817939 , @rjmccall wrote: > Is this approach going to work with scope-local strictness? We need a way to > do a comparison that has the non-strict properties but appears in a function > that enables strictness elsewh

[PATCH] D68115: Zero initialize padding in unions

aaron.ballman added a comment. In D68115#1811091 , @lebedev.ri wrote: > In D68115#1811089 , > @hubert.reinterpretcast wrote: > > > In D68115#1810891 , @lebedev.ri > > wrote

[PATCH] D72518: [clang] New __attribute__((__clang_arm_mve_strict_polymorphism)).

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1473 +def ArmMveStrictPolymorphism : TypeAttr { + let Spellings = [Clang<"__clang_arm_mve_strict_polymorphism">]; Should this be a target-specific attribute?

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added a comment. Do you need someone to commit this on your behalf? (If you plan to continue contributing, which I hope you do, it may be a good time for you to obtain commit privileges: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access but I am happy to commit o

[clang] 25dc5c7 - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-14T14:00:37Z New Revision: 25dc5c7cd159522ec2375544f473c757ee13a03b URL: https://github.com/llvm/llvm-project/commit/25dc5c7cd159522ec2375544f473c757ee13a03b DIFF: https://github.com/llvm/llvm-project/commit/25dc5c7cd159522ec2375544f473c757ee13a03b.diff LOG:

[clang] 7ec7a6e - Fix "null pointer passed to nonnull argument" clang static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-14T14:00:36Z New Revision: 7ec7a6e5bfa745c285d5c651af02b93f2cb923e1 URL: https://github.com/llvm/llvm-project/commit/7ec7a6e5bfa745c285d5c651af02b93f2cb923e1 DIFF: https://github.com/llvm/llvm-project/commit/7ec7a6e5bfa745c285d5c651af02b93f2cb923e1.diff LOG:

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

mgorny added a comment. This broke NetBSD buildbot: + : 'RUN: at line 1' + env -u CLANG_SPAWN_CC1 /home/motus/netbsd8/netbsd8/build-stage2/bin/clang -c /data/motus/netbsd8/netbsd8/llvm-project/clang/test/Driver/cc1-spawnprocess.c -o /dev/null env: unknown option -- u Usage: env [-i] [n

[PATCH] D72488: [clang-tidy] Add check for CERT-OOP57-CPP

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/NotTrivialTypesLibcMemoryCallsCheck.cpp:33-44 +static const char BuiltinMemSet[] = "::std::memset;" +"::memset;"; +static const char BuiltinMemCpy[] = "::std::m

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added a comment. Thank you for the patch! Comment at: clang/docs/ReleaseNotes.rst:68 +- -Wdocumentation properly handles Doxygen comments with multiple identifiers in + one \param command. The validation whether the name of the identifier is valid + has been impr

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman added a comment. I think this patch is getting pretty close to finished -- have you tried running it over a large corpus of code to see if it spots reserved identifiers (or unreserved ones)? If not, I would recommend running it over LLVM + clang + clang-tools-extra to see how it o

[clang] 92451f0 - [OpenCL] Add MSAA sharing extension builtin functions

Author: Sven van Haastregt Date: 2020-01-14T14:46:42Z New Revision: 92451f0904ceab1d81d71a9f17ab366bf57eddc7 URL: https://github.com/llvm/llvm-project/commit/92451f0904ceab1d81d71a9f17ab366bf57eddc7 DIFF: https://github.com/llvm/llvm-project/commit/92451f0904ceab1d81d71a9f17ab366bf57eddc7.diff

[PATCH] D72691: [clang-tidy] Match InitListExpr in modernize-use-default-member-init

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72691/new/ https://reviews.llvm.org/D72691

[PATCH] D65616: Ignore -fsemantic-interposition/-fno-semantic-interposition flag for gcc compatibility

serge-sans-paille added a comment. (back on that one) The default in clang is implicitly `-fno-semantic-interposition`. I think we can safely support it, and either warn or error on `-fsemantic-interposition`. @hfinkel does that seem correct to you? Repository: rG LLVM Github Monorepo CHA

[PATCH] D72703: Add a warning, flags and pragmas to limit the number of pre-processor tokens in a translation unit

hans created this revision. hans added reviewers: thakis, rnk, rsmith. See https://docs.google.com/document/d/1xMkTZMKx9llnMPgso0jrx3ankI4cv60xeZ0y4ksf4wc/preview for background discussion. This adds a warning, flags and pragmas to limit the number of pre-processor tokens either at a certain p

[clang-tools-extra] 9738c75 - [clang-tidy] Match InitListExpr in modernize-use-default-member-init

Author: Malcolm Parsons Date: 2020-01-14T15:19:37Z New Revision: 9738c757bd9bc2fdca935f2b4e356f1d5e5f3682 URL: https://github.com/llvm/llvm-project/commit/9738c757bd9bc2fdca935f2b4e356f1d5e5f3682 DIFF: https://github.com/llvm/llvm-project/commit/9738c757bd9bc2fdca935f2b4e356f1d5e5f3682.diff LO

[clang] 3b929fe - [Syntax] Assert invariants on tree structure and fix a bug in mutations

Author: Ilya Biryukov Date: 2020-01-14T16:31:08+01:00 New Revision: 3b929fe7763570fc1d4a4691a53257a4a0b7760e URL: https://github.com/llvm/llvm-project/commit/3b929fe7763570fc1d4a4691a53257a4a0b7760e DIFF: https://github.com/llvm/llvm-project/commit/3b929fe7763570fc1d4a4691a53257a4a0b7760e.diff

[PATCH] D72691: [clang-tidy] Match InitListExpr in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rG9738c757bd9b: [clang-tidy] Match InitListExpr in modernize-use-default-member-init (authored by malcolm.parsons). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

joerg added inline comments. Comment at: clang/test/Driver/cc1-spawnprocess.c:1 +// RUN: env -u CLANG_SPAWN_CC1 %clang -c %s -o /dev/null +// RUN: env CLANG_SPAWN_CC1=0 %clang -c %s -o /dev/null mgorny wrote: > `env -u` is not portable. I think just going for `en

[clang] 07a4101 - [Syntax] Mark synthesized nodes as modifiable

Author: Ilya Biryukov Date: 2020-01-14T16:41:09+01:00 New Revision: 07a41018e9d27f67f7b4295eb7e00e0345c0aacf URL: https://github.com/llvm/llvm-project/commit/07a41018e9d27f67f7b4295eb7e00e0345c0aacf DIFF: https://github.com/llvm/llvm-project/commit/07a41018e9d27f67f7b4295eb7e00e0345c0aacf.diff

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1126 + std::set ModifiedFiles; + auto Sub = + CDB->watch([&ModifiedFiles](const std::vector Changes) { sammccall wrote: > this is a clever technique. (Why not just use

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 added a comment. In D72217#1819437 , @aaron.ballman wrote: > Do you need someone to commit this on your behalf? (If you plan to continue > contributing, which I hope you do, it may be a good time for you to obtain > commit privileges: > https:

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, mgorny. Herald added a project: clang. First simple implementation, infrastructure is ready. Only one kind of check (NULL error return value) is implemented. Documentation not added yet. Idea of th

[clang] 013c07f - [Syntax] Unset IsOriginal flag on nodes removed from the tree

Author: Ilya Biryukov Date: 2020-01-14T17:00:33+01:00 New Revision: 013c07f697886649b068cd97127e528b4fe7c03e URL: https://github.com/llvm/llvm-project/commit/013c07f697886649b068cd97127e528b4fe7c03e DIFF: https://github.com/llvm/llvm-project/commit/013c07f697886649b068cd97127e528b4fe7c03e.diff

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'.

balazske added a comment. Smaller diff with first part: https://reviews.llvm.org/D72705 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71510/new/ https://reviews.llvm.org/D71510 ___ cfe-commits mailing

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

jsji created this revision. jsji added a reviewer: svenvh. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. jsji edited the summary of this revision. -Werror clang build is broken now. tools/clang/lib/Sema/OpenCLBuiltins.inc:11824:5: error: default label in

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

aaron.ballman added a comment. In D72217#1819678 , @njames93 wrote: > In D72217#1819437 , @aaron.ballman > wrote: > > > Do you need someone to commit this on your behalf? (If you plan to continue > > contributing,

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Nice catch, LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72707/new/ https://reviews.llvm.org/D72707 _

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61822 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong added a comment. In D71612#1812476 , @NoQ wrote: > In D71612#1812036 , @martong wrote: > > > In D71612#1790045 , @NoQ wrote: > > > > > I wonder if this checker will f

[clang] e2b8e21 - [clang][OpenCL] Fix covered switch warning

Author: Jinsong Ji Date: 2020-01-14T16:21:42Z New Revision: e2b8e2113a4929027a237b67f7be86db4ec103d3 URL: https://github.com/llvm/llvm-project/commit/e2b8e2113a4929027a237b67f7be86db4ec103d3 DIFF: https://github.com/llvm/llvm-project/commit/e2b8e2113a4929027a237b67f7be86db4ec103d3.diff LOG: [c

[PATCH] D72707: [clang][OpenCL] Fix covered switch warning

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b8e2113a49: [clang][OpenCL] Fix covered switch warning (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72707/new/ https://reviews.llvm.o

[clang] cfd366b - Fix "pointer is null" static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-14T16:31:17Z New Revision: cfd366ba74c566038c6f417da9c9becc321fd737 URL: https://github.com/llvm/llvm-project/commit/cfd366ba74c566038c6f417da9c9becc321fd737 DIFF: https://github.com/llvm/llvm-project/commit/cfd366ba74c566038c6f417da9c9becc321fd737.diff LOG:

[clang] ab9dbc1 - Fix "pointer is null" clang static analyzer warnings. NFCI.

Author: Simon Pilgrim Date: 2020-01-14T16:31:17Z New Revision: ab9dbc1d124cdf288474073f5233e3fd6ee8e9c3 URL: https://github.com/llvm/llvm-project/commit/ab9dbc1d124cdf288474073f5233e3fd6ee8e9c3 DIFF: https://github.com/llvm/llvm-project/commit/ab9dbc1d124cdf288474073f5233e3fd6ee8e9c3.diff LOG:

Re: [PATCH] D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files

Thanks for reviewing this. The new constructor is to avoid initializing the "OS" field (which is not used by the empty BackendConsumer. Setting this field will affect the output). I will add a comment there. -Rong On Mon, Jan 13, 2020 at 4:50 PM Teresa Johnson via Phabricator < revi...@reviews.l

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

MadCoder marked an inline comment as done. MadCoder added inline comments. Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30 @implementation Y ++(Class)class { ahatanak wrote: > Can you add a test case for `[[self class] alloc]` to test the code in > `t

[PATCH] D72518: [clang] New __attribute__((__clang_arm_mve_strict_polymorphism)).

simon_tatham updated this revision to Diff 237999. simon_tatham marked 7 inline comments as done. simon_tatham added a comment. - Renamed the attribute as suggested. - Made it target-specific. - Added a diagnostic when it's applied to anything other than a vector type with a vector kind of `NeonV

[PATCH] D72518: [clang] New __attribute__((arm_mve_strict_polymorphism)).

simon_tatham added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1474 +def ArmMveStrictPolymorphism : TypeAttr { + let Spellings = [Clang<"__clang_arm_mve_strict_polymorphism">]; + let Documentation = [ArmMveStrictPolymorphismDocs]; aaron.ballm

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. Printing policy was not propogated to functiondecls when creating a completion string which resulted in canonical template p

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61795 tests passed, 1 failed and 781 were skipped. failed: Clangd Unit Tests._/ClangdTests/SignatureHelpTest.PartialSpec {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clan

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

ilya-biryukov added a comment. The patch contains only tests, are we missing the actual functional change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 ___ c

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

ahatanak added inline comments. Comment at: clang/test/CodeGenObjC/objc-alloc-init.m:30 @implementation Y ++(Class)class { MadCoder wrote: > ahatanak wrote: > > Can you add a test case for `[[self class] alloc]` to test the code in > > `tryGenerateSpecialized

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

broadwaylamb created this revision. broadwaylamb added reviewers: aorlov, vvereschaka, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. `filesystem` tests are not yet supported when running tests on a

[PATCH] D71682: Relax the rules around objc_alloc and objc_alloc_init optimizations.

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71682/new/ https://reviews.llvm.org/D71682 ___

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet updated this revision to Diff 238009. kadircet marked 3 inline comments as done. kadircet added a comment. - Populate `Name` for expressions - Don't special case `StringLiteral`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ htt

[clang] 57cf6ee - [RISCV] Add Clang frontend support for Bitmanip extension

Author: Scott Egerton Date: 2020-01-14T17:45:45Z New Revision: 57cf6ee9c84434161088c39a6f8dd2aae14eb12d URL: https://github.com/llvm/llvm-project/commit/57cf6ee9c84434161088c39a6f8dd2aae14eb12d DIFF: https://github.com/llvm/llvm-project/commit/57cf6ee9c84434161088c39a6f8dd2aae14eb12d.diff LOG:

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

logan-5 updated this revision to Diff 238014. logan-5 added a comment. Rebased with trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72284/new/ https://reviews.llvm.org/D72284 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingC

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet updated this revision to Diff 238017. kadircet added a comment. - Upload the correct diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/new/ https://reviews.llvm.org/D72715 Files: clang-tools-extra/clangd/unittests/CodeCompleteTes

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cf6ee9c844: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ ht

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

kadircet added a comment. In D72715#1819879 , @ilya-biryukov wrote: > The patch contains only tests, are we missing the actual functional change? oopsy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72715/

[clang] 2948ec5 - Removed PointerUnion3 and PointerUnion4 aliases in favor of the variadic template

Author: Dmitri Gribenko Date: 2020-01-14T18:56:29+01:00 New Revision: 2948ec5ca98f8593584f2117bc92fe8d75f6f098 URL: https://github.com/llvm/llvm-project/commit/2948ec5ca98f8593584f2117bc92fe8d75f6f098 DIFF: https://github.com/llvm/llvm-project/commit/2948ec5ca98f8593584f2117bc92fe8d75f6f098.dif

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + Also assert tha

[PATCH] D72500: [clangd] Show hover info for expressions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61794 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72715: [clang][CodeComplete] Propogate printing policy to FunctionDecl

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61796 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72622: [clangd] Add a ruler after header in hover

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:121 std::string renderBlocks(llvm::ArrayRef> Children, - void (Block::*RenderFunc)(llvm::raw_ostream &) const) { + const RenderType RT) {

[PATCH] D72089: [Syntax] Build declarator nodes

ilya-biryukov updated this revision to Diff 238022. ilya-biryukov added a comment. - Rebase, get rid of accidental changes with TemplateDeclaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72089/new/ https://reviews.llvm.org/D72089 Files: c

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov updated this revision to Diff 238023. ilya-biryukov added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/To

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill added a comment. Should I wait for the comments to be resolved on D71593 before I commit this patch? Ideally if this patch makes it into a release then that bug fix should be there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D72500: [clangd] Show hover info for expressions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG! Comment at: clang-tools-extra/clangd/Hover.cpp:519 + // + // expression : `int` // Note that we are making use of a level-3 heading because VSCode renders

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238028. ychen added a comment. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. - when optnone is not present, add `optsize` for Os and `minsize` for Oz - add Os Oz function attribute test. - add Os Oz pipeline test Repository: rG L

[PATCH] D72404: [WIP][ThinLTO] Support Os and Oz

ychen updated this revision to Diff 238034. ychen added a comment. - fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72404/new/ https://reviews.llvm.org/D72404 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thinlto-debug-

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary added a comment. @s.egerton Please can you revert rG57cf6ee9c84434161088c39a6f8dd2aae14eb12d - this patch has open dependencies, including on the LLVM support for RISC-V B extension. It would be confusing to users if c

  1   2   3   >