r342862 - [ARM][AArch64] Add feature +fp16fml

Author: sjoerdmeijer Date: Mon Sep 24 00:55:20 2018 New Revision: 342862 URL: http://llvm.org/viewvc/llvm-project?rev=342862&view=rev Log: [ARM][AArch64] Add feature +fp16fml Armv8.4-A adds a few FP16 instructions that can optionally be implemented in CPUs of Armv8.2-A and above. This patch adds

[clang-tools-extra] r342866 - [clangd] Force Dex to respect symbol collector flags

Author: omtcyfz Date: Mon Sep 24 01:45:18 2018 New Revision: 342866 URL: http://llvm.org/viewvc/llvm-project?rev=342866&view=rev Log: [clangd] Force Dex to respect symbol collector flags `Dex` should utilize `FuzzyFindRequest.RestrictForCodeCompletion` flags and omit symbols not meant for code co

r342876 - Fix Wundef NDEBUG warning; NFC

Author: svenvh Date: Mon Sep 24 05:12:03 2018 New Revision: 342876 URL: http://llvm.org/viewvc/llvm-project?rev=342876&view=rev Log: Fix Wundef NDEBUG warning; NFC Check for definedness of the NDEBUG macro rather than its value, to be consistent with other uses. Modified: cfe/trunk/lib/Sema/

r342883 - [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`.

Author: kristina Date: Mon Sep 24 07:06:47 2018 New Revision: 342883 URL: http://llvm.org/viewvc/llvm-project?rev=342883&view=rev Log: [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`. [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that u

[PATCH] D50179: [AArch64][ARM] Context sensitive meaning of option "crypto"

SjoerdMeijer updated this revision to Diff 166643. SjoerdMeijer added a comment. Added FIXMEs, like in https://reviews.llvm.org/D50229, that this needs reimplementation too after the TargerParser rewrite. About v8.5, the ISA description is now available here: https://developer.arm.com/products/

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire added a comment. Actually, I had not run the tests. Thanks for the reminder there. I extended the patch to enable the tests even if CSA is not available. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 ___ cfe-commits

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

steveire updated this revision to Diff 166644. steveire marked 2 inline comments as done. steveire added a comment. Handle tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52334 Files: CMakeLists.txt clang-tidy/CMakeLists.txt clang-tidy/ClangTidy.cpp clang-tidy/plug

[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

kristina added a comment. In https://reviews.llvm.org/D52344#1243149, @rjmccall wrote: > I can respect wanting to change the rules on ELF, but it sounds like we do > need to stick with the current section names. Absent an ABI break to stop > looking for the existing section names, CF will misb

[PATCH] D52390: [analyzer] StackSizeChecker

mate1214 added a comment. Hi @Szelethus ! Thanks for all your detailed and helpful input, I will make sure to go over all the comments and answer them, but it will take some time. A bit more background information on this checker and how it came to be might help you and others to understand so

[PATCH] D52390: [analyzer] StackSizeChecker

mate1214 added a comment. Hi @lebedev.ri! Thanks for the question. I was not sure as to where exactly put the files. The important thing for me is that the `StackUsageMeasuringVisitor` should be reachable from the clang-tidy checker. (For the bigger picture please refer to my answer to @Szelet

[PATCH] D52392: [X86] For lzcnt/tzcnt intrinsics use cttz/ctlz intrinsics with zero_undef flag set to false.

craig.topper added a comment. The only other header that uses the existing builtins is arm_acle.h. But ARM returns false in isCLZForZeroUndef. So they should be creating the cttz/ctlz intrinsics with false for the second argument from __builtin_clz/ctz. The sanitizer code in CodeGenFunction::EmitC

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

alexfh added a comment. > ! In https://reviews.llvm.org/D52334#1242955, @JonasToth wrote: > ... to me it makes sense to have clang-tidy without CSA. Yep, it seems reasonable. Comment at: test/CMakeLists.txt:69 -clang-tidy -) -endif() + clang-tidy + ) -

[PATCH] D50214: Add inherited attributes before parsed attributes.

Meinersbur closed this revision. Meinersbur added a comment. Commited as https://reviews.llvm.org/rL342861. Repository: rC Clang https://reviews.llvm.org/D50214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

thakis added a comment. In https://reviews.llvm.org/D52193#1241067, @aganea wrote: > @thakis > clang-cl isn't supposed to do (explicit) registry accesses when you > hold it right (pass in -fms-compatibility-version etc). Have you seen > registry access costs, or is that speculation? > > Please

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

Anastasia added inline comments. Comment at: include/clang/AST/OperationKinds.def:325 // Convert a zero value for OpenCL queue_t initialization. CAST_OPERATION(ZeroToOCLQueue) I am wondering if we could potentially unify all of those ZeroToOCL* into one cast

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh added inline comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:123-130 if args.fix: command.append('-fix') if args.checks != '': command.append('-checks=' + quote + args.checks + quote) if args.quiet: command.append('-quiet') if args.build

[PATCH] D52412: OpenCL: Mark printf format string argument

arsenm created this revision. arsenm added a reviewer: Anastasia. Herald added subscribers: yaxunl, wdng. Fixes not warning on format string errors. https://reviews.llvm.org/D52412 Files: lib/Headers/opencl-c.h test/SemaOpenCL/printf-format-string-warnings.cl Index: test/SemaOpenCL/printf

[PATCH] D52320: AMDGPU: add __builtin_amdgcn_update_dpp

arsenm added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:11313-11315 + case AMDGPU::BI__builtin_amdgcn_update_dpp: { +llvm::SmallVector Args; +for (unsigned I = 0; I != 6; ++I) The only difference between this and mov_dpp is the argument count

[PATCH] D52230: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

JonasToth added a comment. For the other patches and the following doing the same for other modules too? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

takuto.ikuta added a comment. Ping? This patch reduced obj size largely, and I expect this makes distributed build (like goma) faster by reducing data transferred on network. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5244 + false)) +CmdArgs.push_

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

atanasyan created this revision. atanasyan added reviewers: rsmith, rnk, zturner. Herald added subscribers: jrtc27, arichardson, sdardis, srhines. Enable integrated assembler for MIPS64 targets except N32 ABI explicitly selected by the `-mabi=n32` command line option or `mips64(el)-linux-gnuabin3

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric created this revision. ioeric added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. ioeric updated this revision to Diff 17. ioeric added a comment. - update comment The file stats can be reused when preamble is reused

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric updated this revision to Diff 17. ioeric added a comment. - update comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52419 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/CodeComplete.cpp clangd/CodeComplete.h unittest

[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

kristina closed this revision. kristina added a comment. Closed by https://reviews.llvm.org/rL342883 (https://reviews.llvm.org/rC342883). Manually closing it as Phabricator is slightly broken, hopefully it makes the links when it catches up. Repository: rC Clang https://reviews.llvm.org/D52

[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

kristina added a comment. Alright, I guess I'll land it if there's no objections to it, `cfstring` is staying as is, the PE/COFF codepath is not affected in terms of functionality and test is fine I think, hopefully `x86_64-elf` will not yield different results on different machines in terms of

[PATCH] D50229: [ARM][AArch64] Add feature +fp16fml

This revision was automatically updated to reflect the committed changes. Closed by commit rC342862: [ARM][AArch64] Add feature +fp16fml (authored by SjoerdMeijer, committed by ). Repository: rC Clang https://reviews.llvm.org/D50229 Files: lib/Driver/ToolChains/Arch/AArch64.cpp lib/Driver

[PATCH] D52396: [libcxx] Document new symbols __u64toa and __u32toa on Darwin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX342849: [libcxx] Document new symbols __u64toa and __u32toa on Darwin (authored by ldionne, committed by ). Changed pri

r342885 - Revert "We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case."

Author: stulova Date: Mon Sep 24 07:21:56 2018 New Revision: 342885 URL: http://llvm.org/viewvc/llvm-project?rev=342885&view=rev Log: Revert "We allow implicit function declarations as an extension in all C dialects. Remove OpenCL special case." Discussed on cfe-commits (Week-of-Mon-20180820), t

[PATCH] D52357: [clangd] Force Dex to respect symbol collector flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL342866: [clangd] Force Dex to respect symbol collector flags (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52357?vs=16

[PATCH] D51340: Add /Zc:DllexportInlines option to clang-cl

hans added a comment. In https://reviews.llvm.org/D51340#1243331, @takuto.ikuta wrote: > Ping? > > This patch reduced obj size largely, and I expect this makes distributed > build (like goma) faster by reducing data transferred on network. I'll try to look at it this week. Have you confirmed

[PATCH] D52390: [analyzer] StackSizeChecker

lebedev.ri added a comment. In https://reviews.llvm.org/D52390#1243228, @mate1214 wrote: > Hi @lebedev.ri! > > Thanks for the question. I was not sure as to where exactly put the files. > The important thing for me is that the `StackUsageMeasuringVisitor` should be > reachable from the clang-ti

[PATCH] D52193: RFC: [clang] Multithreaded compilation support

thakis added a comment. ...and to reword this a bit: Clang taking a long time to start up in some configurations is a bug we should profile and fix :-) Repository: rC Clang https://reviews.llvm.org/D52193 ___ cfe-commits mailing list cfe-commits

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Make sure JSONRPCDispatcher outlives the worker threads, they access its fields to remove the stored cancellations when Context dies. Repository:

[PATCH] D52419: [clangd] Cache FS stat() calls when building preamble.

ioeric added inline comments. Comment at: clangd/ClangdUnit.cpp:119 +/// Collect and cache all file status from the underlying file system. +class CollectStatCacheVFS : public vfs::FileSystem { Would it make sense to add a `clang::vfs::ProxyFS` that proxies cal

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

JonasToth added inline comments. Comment at: test/clang-tidy/misc-unused-using-decls-cxx17.cpp:1 +// RUN: %check_clang_tidy %s misc-unused-using-decls %t -- -- -fno-delayed-template-parsing -std=gnu++17 + why gnu++17 and not standard? Repository: rCTE Clang

[clang-tools-extra] r342888 - [clangd] Do bounds checks while reading data, otherwise var-length records are too painful. NFC

Author: sammccall Date: Mon Sep 24 07:51:15 2018 New Revision: 342888 URL: http://llvm.org/viewvc/llvm-project?rev=342888&view=rev Log: [clangd] Do bounds checks while reading data, otherwise var-length records are too painful. NFC Modified: clang-tools-extra/trunk/clangd/index/Serialization

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman created this revision. aaron.ballman added reviewers: lebedev.ri, rsmith, dblaikie. This patch diagnoses parameter names that shadow the names of inherited fields under -Wshadow-field. It addresses PR34120. Note, unlike GCC, we take into account the accessibility of the field when

r342889 - [VFS] Use llvm::StringMap instead of std::map. NFC

Author: ioeric Date: Mon Sep 24 07:52:11 2018 New Revision: 342889 URL: http://llvm.org/viewvc/llvm-project?rev=342889&view=rev Log: [VFS] Use llvm::StringMap instead of std::map. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp URL:

r342890 - [CFString][ELF] Fix a missed test causing buildbot failures from 342883.

Author: kristina Date: Mon Sep 24 07:52:48 2018 New Revision: 342890 URL: http://llvm.org/viewvc/llvm-project?rev=342890&view=rev Log: [CFString][ELF] Fix a missed test causing buildbot failures from 342883. Accidetanlly forgot to update it, big sorry. Modified: cfe/trunk/test/CodeGen/CFStr

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, ioeric, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52422 Files: clangd/CodeComplete.cpp unittests/clangd/CodeCompleteTests.cpp I

[PATCH] D52423: Make ConversionChecker load StdCLibraryFunctionsChecker

donat.nagy created this revision. donat.nagy added a reviewer: dergachev.a. Herald added a subscriber: cfe-commits. ConversionChecker produces false positives when it encounters the idiomatic usage of certain well-known functions (e.g. getc() and the character classification functions like isalpha

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:483 + // Destroy ClangdServer to ensure all worker threads finish. + Server.reset(); This woudn't work if `run()` is called multiple times. Maybe create a `Server` in each `run()`? Repos

r342893 - Revert "rL342883: [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`."

Author: kristina Date: Mon Sep 24 08:26:08 2018 New Revision: 342893 URL: http://llvm.org/viewvc/llvm-project?rev=342893&view=rev Log: Revert "rL342883: [Clang][CodeGen][ObjC]: Fix CoreFoundation on ELF with `-fconstant-cfstrings`." Seems to be causing buildbot failures, need to look into it.

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

Szelethus edited reviewers, added: NoQ; removed: dergachev.a. Szelethus added a comment. Cool! Comment at: test/Analysis/conversion.c:141 -// false positives.. +// old false positives.. I think this comment is no longer relevant ^-^ Repository: rC Clang

[PATCH] D51432: [AArch64] Unwinding support for return address signing

This revision was automatically updated to reflect the committed changes. Closed by commit rL342895: [AArch64] Unwinding support for return address signing (authored by LukeCheeseman, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm

[libunwind] r342895 - [AArch64] Unwinding support for return address signing

Author: lukecheeseman Date: Mon Sep 24 08:55:35 2018 New Revision: 342895 URL: http://llvm.org/viewvc/llvm-project?rev=342895&view=rev Log: [AArch64] Unwinding support for return address signing - When return address signing is enabled, the LR may be signed on function entry - When an exception i

[PATCH] D50171: [python] [tests] Update test_code_completion

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D50171#1236792, @mgorny wrote: > @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do > you think my patch would be good enough

r342897 - [python] [tests] Update test_code_completion

Author: mgorny Date: Mon Sep 24 09:10:25 2018 New Revision: 342897 URL: http://llvm.org/viewvc/llvm-project?rev=342897&view=rev Log: [python] [tests] Update test_code_completion Update expected completions to match output generated by clang-7.0. Differential Revision: https://reviews.llvm.org/D5

[PATCH] D50171: [python] [tests] Update test_code_completion

This revision was automatically updated to reflect the committed changes. Closed by commit rL342897: [python] [tests] Update test_code_completion (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50171?vs=164871&id=1

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D50171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] r342901 - Reverting r342895

Author: lukecheeseman Date: Mon Sep 24 09:36:33 2018 New Revision: 342901 URL: http://llvm.org/viewvc/llvm-project?rev=342901&view=rev Log: Reverting r342895 - The used builtins do not compile for pre arm v8.3a targets with gcc Modified: libunwind/trunk/include/libunwind.h libunwind/tru

[PATCH] D52420: [clangd] Fix crash if pending computations were active on exit

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:483 + // Destroy ClangdServer to ensure all worker threads finish. + Server.reset(); ioeric wrote: > This woudn't work if `run()` is called multiple times. Maybe create a > `Server`

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:1699 + if (Opts.EnableSnippets) { +log("Suffix: {0}", SnippetSuffix); LSP.textEdit->newText += SnippetSuffix; Sorry, leftover from debug printing. Will remove Repository: rCTE

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/Sema/gnu89.c:1-2 -// RUN: %clang_cc1 %s -std=gnu89 -pedantic -fsyntax-only -verify +// RUN: %clang_cc1 %s -std=gnu89 -pedantic -fsyntax-only 2>&1 | FileCheck -check-prefix=CHECK-PEDANTIC %s +// RUN: %clang_cc1 %s -std=gnu89

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

Anastasia added a comment. In https://reviews.llvm.org/D43783#1235126, @yaxunl wrote: > In https://reviews.llvm.org/D43783#1235090, @Anastasia wrote: > > > Ping! Do you still plan to do this? :) > > > Sorry I caught up in something else. Since there are some subsequent commits, > it may take som

[clang-tools-extra] r342903 - [clangd] Fix uninit bool in r342888

Author: sammccall Date: Mon Sep 24 09:52:48 2018 New Revision: 342903 URL: http://llvm.org/viewvc/llvm-project?rev=342903&view=rev Log: [clangd] Fix uninit bool in r342888 Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified: clang-tools-extra/trunk/clangd/index/Serializ

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. > This seems very clever, but extremely complicated - you've implemented much > of C++'s conversion logic, it's not clear to me which parts are actually > necessary to completion quality. Clearly the model that supports C++ conversions is something that **will**

[PATCH] D51568: [modules] Add `-fno-absolute-module-directory` flag for relocatable modules

andrewjcg updated this revision to Diff 166709. andrewjcg added a comment. Dropping the module directory entirely and fully resolving paths on serialization broke some things during deserialization, specifically when the deserializer wanted to update paths to use an alternate module directory.

[PATCH] D46443: Add missing cstdalign header

ldionne added a subscriber: mclow.lists. ldionne added a comment. I believe this header has been deprecated. According to http://eel.is/c++draft/diff.cpp17.library, the effect of this header is nothing. @mclow.lists can you chime in? Repository: rCXX libc++ https://reviews.llvm.org/D46443

[PATCH] D52219: [analyzer] (1/n) Support pointee mutation analysis in ExprMutationAnalyzer.

shuaiwang updated this revision to Diff 166710. shuaiwang added a comment. Added test case place holder for cases that should be supported in later patches. Repository: rC Clang https://reviews.llvm.org/D52219 Files: include/clang/Analysis/Analyses/ExprMutationAnalyzer.h lib/Analysis/Ex

[PATCH] D52252: Driver: render arguments for the embedded bitcode correctly

steven_wu added a comment. Thanks for doing this! Can you add some test cases just to be complete? Other than that, LGTM! Repository: rC Clang https://reviews.llvm.org/D52252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added inline comments. Comment at: clangd/ExpectedTypes.h:68 + +/// Represents a type of partially applied conversion. Should be treated as an +/// opaque value and can only be used to check whether the types are converible sammccall wrote: > this r

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1241928, @probinson wrote: > Do we generate the .dwo file directly these days? If not, I can imagine > wanting to avoid the overhead of the objcopy hack; as long as the linker is > smart enough not to bother with the .debug_*.dwo sec

[PATCH] D52296: [Clang] - Add -gsingle-file-split-dwarf option.

echristo added a comment. In https://reviews.llvm.org/D52296#1241928, @probinson wrote: > Do we generate the .dwo file directly these days? If not, I can imagine > wanting to avoid the overhead of the objcopy hack; as long as the linker is > smart enough not to bother with the .debug_*.dwo sec

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

lebedev.ri added a comment. Thanks! Comment at: lib/Sema/SemaDecl.cpp:12380-12382 } + if (LangOpts.CPlusPlus && II) { I think you could move it into the `if()` above? https://reviews.llvm.org/D52421 ___ cfe

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

george.karpenkov added a comment. The concept makes sense. @NoQ any comments? I don't recall seeing that pattern before. Comment at: test/Analysis/conversion.c:144 int isascii(int c); void falsePositive1() { char kb2[5]; Also the function name should be c

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman updated this revision to Diff 166716. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. https://reviews.llvm.org/D52421 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Sema/SemaDec

[PATCH] D52421: [Sema] Diagnose parameter names that shadow inherited field names

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12380-12382 } + if (LangOpts.CPlusPlus && II) { lebedev.ri wrote: > I think you could move it into the `if()` above? You are correct, I'll hoist it. https://reviews.llvm.org/D52421

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

Szelethus added inline comments. Comment at: test/Analysis/conversion.c:158 extern int dostuff (void); int falsePositive2() { int c, n; And this one Repository: rC Clang https://reviews.llvm.org/D52423 ___

[PATCH] D52423: [analyzer] Make ConversionChecker load StdCLibraryFunctionsChecker

NoQ added a comment. Maybe just move `StdCLibraryFunctionsChecker` to `core`? (`.apiModeling`?) We officially don't support disabling `core`, so i guess it kinda solves the issue. Also all of our languages are C-based, these functions are present on all platforms (if any of those aren't, we cou

r342909 - Fix the type of 1<<31 integer constants.

Author: d0k Date: Mon Sep 24 10:51:15 2018 New Revision: 342909 URL: http://llvm.org/viewvc/llvm-project?rev=342909&view=rev Log: Fix the type of 1<<31 integer constants. Shifting into the sign bit is technically undefined behavior. No known compiler exploits it though. Modified: cfe/trunk/i

r342911 - [Power9] [CLANG] Add __float128 exponent GET and SET builtins

Author: stefanp Date: Mon Sep 24 11:14:50 2018 New Revision: 342911 URL: http://llvm.org/viewvc/llvm-project?rev=342911&view=rev Log: [Power9] [CLANG] Add __float128 exponent GET and SET builtins Added __builtin_vsx_scalar_extract_expq __builtin_vsx_scalar_insert_exp_qp Builtins should behave t

[PATCH] D48184: [Power9] [CLANG] Add __float128 exponent GET and SET builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC342911: [Power9] [CLANG] Add __float128 exponent GET and SET builtins (authored by stefanp, committed by ). Herald added subscribers: cfe-commits, jsji, kristina. Changed prior to commit: https://review

[PATCH] D52399: [AArch64] Support adding X[8-15, 18] registers as CSRs.

trong updated this revision to Diff 166722. trong added a comment. - Added test case for using -fcall-saved-x18 and -ffixed-x18 together. Repository: rC Clang https://reviews.llvm.org/D52399 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td lib/Driver/ToolChains

r342912 - [CodeGen] Revert commit https://reviews.llvm.org/rL342717

Author: calixte Date: Mon Sep 24 11:24:18 2018 New Revision: 342912 URL: http://llvm.org/viewvc/llvm-project?rev=342912&view=rev Log: [CodeGen] Revert commit https://reviews.llvm.org/rL342717 Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/lib/CodeGen/CGDebugInfo.h cfe/trunk

[PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

kristina reopened this revision. kristina added a comment. This revision is now accepted and ready to land. Cascade of build failures stemming from `GV->setSection(".rodata");`, reverted the commit, it seems that `CFString.c` is causing all those issues despite passing when ran locally. Reposi

[PATCH] D52273: [clangd] Initial implementation of expected types

sammccall added a comment. Happy to speculate about what might work here, but I strongly believe the path forward here is to build the simplest version of this feature, without conversions, and try to avoid complicated conversion logic if we can get most of the benefit in simpler ways. In http

[PATCH] D52399: [AArch64] Support adding X[8-15, 18] registers as CSRs.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for this patch, Tri! Repository: rC Clang https://reviews.llvm.org/D52399 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D52390: [analyzer] StackSizeChecker

Szelethus added a comment. > Thanks for all your detailed and helpful input, I will make sure to go over > all the comments and answer them, but it will take some time. Cheers! I can't emphasize enough however that I might be wrong on what I've said, or say in this comment. > It was my introdu

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166737. nickdesaulniers added a comment. - remove debug statments Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c ==

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166736. nickdesaulniers added a comment. - add ISO C tests, handle typedef case new tests found Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, sorry for the delay. Repository: rUNW libunwind https://reviews.llvm.org/D51657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166740. nickdesaulniers added a comment. - condense CHECK-prefixes into CHECK for const const Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c =

[PATCH] D52390: [analyzer] StackSizeChecker

Szelethus added a comment. One important thing I forgot, that you cant rely on `ProgramState` due to tidy's constraints. Btw, how do you plan to make this into a tidy checker? To me it seems like it would amplify the already existing false positive issues (if I understand your currect way of th

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added inline comments. Comment at: test/Sema/gnu89-const.c:41-46 +CHECK-CNU99-NOT: 27:1: warning: duplicate 'const' declaration specifier +CHECK-CNU99-PEDANTIC-NOT: 27:1: warning: duplicate 'const' declaration specifier +CHECK-CNU11-NOT: 27:1: warning: duplicate

[PATCH] D52434: [OpenMP] Make default schedules for NVPTX target regions in SPMD mode achieve coalescing

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. For the OpenMP NVPTX toolchain choose default schedules which ensure coalescing on the GPU when in SPMD mode. This significantly increases the performance of

[PATCH] D51657: [CMake] Link to compiler-rt if LIBUNWIND_USE_COMPILER_RT is ON.

mstorsjo added inline comments. Comment at: src/CMakeLists.txt:60 + append_if(libraries LIBUNWIND_HAS_GCC_S_LIB gcc_s) + list(APPEND libraries gcc) +endif() I'm a little suspicious of this line, of forcibly linking against libgcc here, even if we might not hav

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166742. nickdesaulniers added a comment. - fix typo s/CNU/GNU/g and update NOTEs Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c ==

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers updated this revision to Diff 166743. nickdesaulniers added a comment. - adjust wording in comment Repository: rC Clang https://reviews.llvm.org/D52248 Files: lib/Sema/SemaType.cpp test/Sema/gnu89-const.c Index: test/Sema/gnu89-const.c ==

[PATCH] D52136: [clang-tidy] Add modernize-concat-nested-namespaces check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the local `const` qualification stuff and some minor wordsmithing of the documentation, this LGTM. Comment at: clang-tidy/modernize/ConcatNestedName

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan updated this revision to Diff 166746. leonardchan added a comment. Herald added a subscriber: cfe-commits. - Removed passes since ssaturate can be expanded in the DAG Repository: rC Clang https://reviews.llvm.org/D52286 Files: include/llvm/CodeGen/ISDOpcodes.h include/llvm/IR

[PATCH] D52248: [SEMA] ignore duplicate declaration specifiers from typeof exprs

nickdesaulniers added a comment. This now matches GCC AFAICT. My only question is: Should GCC instead warn for the typedef case for -std=c89 (non pedantic), according to C90 6.5.3? Repository: rC Clang https://reviews.llvm.org/D52248 ___ cfe-c

[PATCH] D52281: [clang-tidy] Add modernize check to use std::invoke in generic code

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ReplaceGenericFunctorCallCheck.cpp:70 + if (MFunctor && MFunctor->isTypeDependent()) { +const auto *Paren = static_cast(MFunctor->getCallee()); +const auto *BinOp = JonasToth wrote: >

[PATCH] D52398: Thread safety analysis: Unwrap __builtin_expect in getTrylockCallExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should give @delesley a chance to weigh in before you commit. Repository: rC Clang https://reviews.llvm.org/D52398 ___

[PATCH] D52264: Deduplicate replacements from diagnostics.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D52437: [CUDA] Add preliminary support for CUDA 10.0

fwyzard created this revision. fwyzard added reviewers: tra, Hahnfeld. Herald added a subscriber: cfe-commits. Add the definitions for CUDA 10.0 and CUDA architecture 7.5 (Turing), and define CUDA 10.0 as the highest supported version. Starting with CUDA 10.0, the include files include/crt/*

r342920 - [analyzer] Prevent crashes in FindLastStoreBRVisitor

Author: george.karpenkov Date: Mon Sep 24 14:20:30 2018 New Revision: 342920 URL: http://llvm.org/viewvc/llvm-project?rev=342920&view=rev Log: [analyzer] Prevent crashes in FindLastStoreBRVisitor This patch is a band-aid. A proper solution would be too change trackNullOrUndefValue to only try to

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan updated this revision to Diff 166756. leonardchan added a reviewer: rjmccall. leonardchan changed the repository for this revision from rC Clang to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D52286 Files: include/llvm/CodeGen/ISDOpcodes.h include/llvm/IR/Intrinsics.t

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan added a comment. Of the intrinsics we plan to implement, it seems that the ordering of legalization affects specifically the fixed point mul/div intrinsics since if they get expanded into other nodes, we will need to check again for legal types since performing scaled mul/div requir

[PATCH] D52438: [CUDA] Add basic support for CUDA-10.0

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, hiraditya, sanjoy, jholewinski. https://reviews.llvm.org/D52438 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/Driver/ToolChains/Cuda.cpp

  1   2   >