xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2382
+// Reset the solver
+RefutationMgr.reset();
+ }
george.karpenkov wrote:
> george.karpenkov wrote:
> > (apologies in advance for nitpicking not on your code
Alexpux added a comment.
Herald added subscribers: llvm-commits, christof.
I'm not be able to build libcxx with 64-bit mingw-w64 due to this commit.
Have error like:
[ 10%] Building CXX object
projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/algorithm.cpp.obj
In file included from
C:/r
Uran198 created this revision.
Uran198 added reviewers: djasper, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D47515
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/Format/Format.cpp
+++ lib/Form
dstenb added a comment.
Any more comments or concerns, or can I land this?
https://reviews.llvm.org/D45686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong added a comment.
Balazs, I'll commit it for you in an hour.
Repository:
rC Clang
https://reviews.llvm.org/D47313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333513: Support __iso_volatile_load8 etc on aarch64-win32.
(authored by statham, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47476?vs=148900&id=149055#toc
Repository:
rC Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333513: Support __iso_volatile_load8 etc on aarch64-win32.
(authored by statham, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rC Clang
https://reviews.llvm.org/D47476
Files:
Author: sammccall
Date: Wed May 30 01:03:43 2018
New Revision: 333514
URL: http://llvm.org/viewvc/llvm-project?rev=333514&view=rev
Log:
Fix -Wunused in NDEBUG introduced by HIP r333484
Modified:
cfe/trunk/lib/Driver/ToolChains/HIP.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/HIP.cpp
URL:
h
Author: hans
Date: Wed May 30 01:05:24 2018
New Revision: 333515
URL: http://llvm.org/viewvc/llvm-project?rev=333515&view=rev
Log:
Add missing curly from r333509
Modified:
cfe/trunk/lib/Headers/avx512vlvnniintrin.h
Modified: cfe/trunk/lib/Headers/avx512vlvnniintrin.h
URL:
http://llvm.org/vi
On Wed, May 30, 2018 at 7:26 AM, Craig Topper via cfe-commits
wrote:
> Author: ctopper
> Date: Tue May 29 22:26:04 2018
> New Revision: 333509
>
> URL: http://llvm.org/viewvc/llvm-project?rev=333509&view=rev
> Log:
> [X86] Remove masking from the AVX512VNNI builtins. Use a select in IR instead.
>
Uran198 created this revision.
Uran198 added reviewers: klimek, krasimir, djasper.
Repository:
rC Clang
https://reviews.llvm.org/D47519
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
ioeric updated this revision to Diff 149061.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47466
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unitte
Author: ioeric
Date: Wed May 30 02:03:39 2018
New Revision: 333519
URL: http://llvm.org/viewvc/llvm-project?rev=333519&view=rev
Log:
[clangd] Avoid inserting new #include when declaration is present in the main
file.
Summary:
Also fix USR generation for classes in unit tests. The previous USR
on
avt77 added a comment.
Hi All,
What should I do to simplify the review?
I could remove all LLVM_DEBUG related stuff; I could remove all addtional
counters and leave only necessary one or two of them. As result the patch will
become shorter.
Should I do all these truncations to simplify the revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333519: [clangd] Avoid inserting new #include when
declaration is present in the main… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
klimek accepted this revision.
klimek added a comment.
LG
Repository:
rC Clang
https://reviews.llvm.org/D47095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martong
Date: Wed May 30 02:19:26 2018
New Revision: 333522
URL: http://llvm.org/viewvc/llvm-project?rev=333522&view=rev
Log:
[ASTImporter] Corrected lookup at import of templated record decl
Summary:
When a CXXRecordDecl under ClassTemplateDecl is imported, check
the templated record dec
Uran198 created this revision.
Uran198 added reviewers: djasper, klimek.
Before the change clang-format would break and make no reformatting.
Repository:
rC Clang
https://reviews.llvm.org/D47520
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Forma
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333522: [ASTImporter] Corrected lookup at import of
templated record decl (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47313?vs=148361&id=149065#toc
Reposito
Uran198 created this revision.
Uran198 added reviewers: klimek, djasper.
Repository:
rC Clang
https://reviews.llvm.org/D47521
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
ilya-biryukov updated this revision to Diff 149073.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Added a unit test
- Address review comments
- Add ASTRetentionPolicy param to ClangdServer
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47063
F
ilya-biryukov added inline comments.
Comment at: clangd/ClangdUnit.h:143
+std::shared_ptr
+buildPreamble(PathRef FileName, CompilerInvocation &CI,
+ std::shared_ptr OldPreamble,
sammccall wrote:
> nit: i think filename here is only used for logging,
jolesiak created this revision.
Herald added subscribers: cfe-commits, klimek.
This reverts commit db9e5e9a616d7fdd4d1ba4c3b2cd89d8a0238533.
Repository:
rC Clang
https://reviews.llvm.org/D47527
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestObjC.cpp
Index: unitte
ilya-biryukov updated this revision to Diff 149075.
ilya-biryukov added a comment.
- Fixed formatting
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47063
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/TUScheduler
sfantao added a comment.
> In a discussion off-list I proposed adding constructor functions to all
> object files and handle them like shared libraries are already handled today
> (ie register separately and let the runtime figure out how to relocate
> symbols in different translation units). I
balazske updated this revision to Diff 149079.
balazske added a comment.
[ASTImporter] Fixed test code in ASTImporter tests.
Test code is fixed instead of turn off the warnings.
For this to work change of match expressions was needed.
Repository:
rC Clang
https://reviews.llvm.org/D47459
Fil
Author: ibiryukov
Date: Wed May 30 03:43:00 2018
New Revision: 333528
URL: http://llvm.org/viewvc/llvm-project?rev=333528&view=rev
Log:
[clangd] Enable parsing of non-doxygen comments in global-symbol-builder
Reviewers: ioeric, sammccall
Reviewed By: ioeric
Subscribers: klimek, MaskRay, jkorous
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333528: [clangd] Enable parsing of non-doxygen comments in
global-symbol-builder (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
Author: statham
Date: Wed May 30 00:54:05 2018
New Revision: 333513
URL: http://llvm.org/viewvc/llvm-project?rev=333513&view=rev
Log:
Support __iso_volatile_load8 etc on aarch64-win32.
These intrinsics are used by MSVC's header files on AArch64 Windows as
well as AArch32, so we should support the
Author: mramalho
Date: Wed May 30 04:17:55 2018
New Revision: 333529
URL: http://llvm.org/viewvc/llvm-project?rev=333529&view=rev
Log:
Fix a (possible) division by zero check in the CmpRuns script
I missed updating the check in r75
Modified:
cfe/trunk/utils/analyzer/CmpRuns.py
Modified:
kunitoki added a comment.
Any news on the status of this ? Would be really nice to have it in.
https://reviews.llvm.org/D37035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: henrywong
Date: Wed May 30 04:46:45 2018
New Revision: 333531
URL: http://llvm.org/viewvc/llvm-project?rev=333531&view=rev
Log:
[analyzer] Remove the redundant check about same state transition in
`ArrayBoundCheckerV2.cpp`.
Summary: Since the `addTransitionImpl()` has a check about same
aaron.ballman added a comment.
In https://reviews.llvm.org/D47157#1115445, @bruno wrote:
> > Consistency would be nice, but at the same time, I don't see a good metric
> > for when we'd know it's time to switch it to being on by default. I'm
> > worried that it'll remain off by default forever
aaron.ballman accepted this revision.
aaron.ballman added a comment.
In https://reviews.llvm.org/D45686#1115836, @dstenb wrote:
> Any more comments or concerns, or can I land this?
None from me; you're good to land it. Any further comments can be handled
post-commit.
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333531: [analyzer] Remove the redundant check about same
state transition in… (authored by henrywong, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.o
ioeric updated this revision to Diff 149091.
ioeric added a comment.
- Fix module build.
Repository:
rC Clang
https://reviews.llvm.org/D47068
Files:
include/clang/Format/Format.h
include/clang/Tooling/Core/HeaderIncludes.h
include/clang/Tooling/Core/IncludeStyle.h
include/clang/Tooli
Author: ioeric
Date: Wed May 30 04:51:48 2018
New Revision: 333532
URL: http://llvm.org/viewvc/llvm-project?rev=333532&view=rev
Log:
Reland "Move #include manipulation code to new lib/Tooling/Inclusions."
This reverts commit r332751 (i.e. reland r332720) after fixing module
build.
Differential R
Author: ioeric
Date: Wed May 30 04:52:01 2018
New Revision: 333533
URL: http://llvm.org/viewvc/llvm-project?rev=333533&view=rev
Log:
Reland "[clangd] Adapt file migration in r332720"
This reverts commit r332752 (i.e. reland r332721).
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333532: Reland "Move #include manipulation code to new
lib/Tooling/Inclusions." (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47068?vs=149091&id=149092#toc
Rep
martong updated this revision to Diff 149093.
martong added a comment.
- Moved the family of `testImport` functions under a test fixture class, so we
can use parameterized test.
- Refactored `testImport` and `testImportSequence`, because for loops over the
different compiler options is no longer
martong updated this revision to Diff 149094.
martong added a comment.
- Forgot to instantiate some of the parameterized tests
Repository:
rC Clang
https://reviews.llvm.org/D47367
Files:
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
===
Author: ioeric
Date: Wed May 30 05:09:58 2018
New Revision: 333534
URL: http://llvm.org/viewvc/llvm-project?rev=333534&view=rev
Log:
Revert "Reland "Move #include manipulation code to new lib/Tooling/Inclusions.""
This reverts commit r333532. Revert for now to fix an internal bot issue.
Added:
Author: ioeric
Date: Wed May 30 05:10:07 2018
New Revision: 333535
URL: http://llvm.org/viewvc/llvm-project?rev=333535&view=rev
Log:
Revert "Reland "[clangd] Adapt file migration in r332720""
This reverts commit r333533.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
clang-tools
martong added a reviewer: balazske.
martong added a comment.
Balazs, could you please review this patch as well? (This code is not in our
fork yet.)
Repository:
rC Clang
https://reviews.llvm.org/D47367
___
cfe-commits mailing list
cfe-commits@li
martong updated this revision to Diff 149095.
martong added a comment.
- Remove unused function
Repository:
rC Clang
https://reviews.llvm.org/D47367
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/Language.cpp
unittests/AST/Language.h
Index: unittests/AST/Language.h
===
martong updated this revision to Diff 149096.
martong added a comment.
- Remove unused RunOptions typedef and isCXX function
Repository:
rC Clang
https://reviews.llvm.org/D47367
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/Language.cpp
unittests/AST/Language.h
Index: unittes
cpplearner added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:9690
+ CanQualType CanonicalDesiredBase = DesiredBase->getCanonicalTypeUnqualified()
+.getUnqualifiedType();
for (auto &Base : Derived->bases()) {
rsmith wrote:
> How are we getting a
aaron.ballman added inline comments.
Comment at: include/clang/AST/Decl.h:2212-2213
+ bool isCpuDispatchMultiVersion() const;
+ bool isCpuSpecificMultiVersion() const;
+
Pedantic nit: CPU instead of Cpu?
Comment at: include/clang/Basic/Attr
Author: ibiryukov
Date: Wed May 30 05:41:19 2018
New Revision: 333537
URL: http://llvm.org/viewvc/llvm-project?rev=333537&view=rev
Log:
[clangd] clang-format the source code. NFC
Modified:
clang-tools-extra/trunk/clangd/AST.h
clang-tools-extra/trunk/clangd/Quality.h
clang-tools-extra/
ilya-biryukov updated this revision to Diff 149099.
ilya-biryukov added a comment.
- Fix the comments
Repository:
rC Clang
https://reviews.llvm.org/D44480
Files:
lib/Sema/SemaDecl.cpp
test/CodeCompletion/crash-skipped-bodies-template-inst.cpp
test/CodeCompletion/skip-auto-funcs.cpp
In
This revision was automatically updated to reflect the committed changes.
Closed by commit rL333538: [Sema] Don't skip function bodies with
'auto' without trailing return type (authored by ibiryukov, committed
by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
Author: ibiryukov
Date: Wed May 30 05:50:48 2018
New Revision: 333538
URL: http://llvm.org/viewvc/llvm-project?rev=333538&view=rev
Log:
[Sema] Don't skip function bodies with 'auto' without trailing return type
Summary:
Skipping them was clearly not intentional. It's impossible to
guarantee corre
Author: jolesiak
Date: Wed May 30 05:57:58 2018
New Revision: 333539
URL: http://llvm.org/viewvc/llvm-project?rev=333539&view=rev
Log:
Revert "[clang-format] Fix putting ObjC message arguments in one line for
multiline receiver"
Summary:
This reverts commit db9e5e9a616d7fdd4d1ba4c3b2cd89d8a02385
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333539: Revert "[clang-format] Fix putting ObjC message
arguments in one line for… (authored by jolesiak, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47527?vs=149074&id=149101#toc
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
It's a very subtle change and it isn't clear if that's the right thing to do
without understanding the problem that we're trying to solve.
Could you please elaborate on
martong created this revision.
martong added reviewers: a.sidorin, r.stahl, xazax.hun, balazske.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
With this patch when any `FunctionDecl` of a redeclaration chain is imported
then we bring in the whole declaration chain. This involves functi
yvvan added a comment.
Memory mapping locks the file on Windows. That means that in the addressed case
it locks main file which we are editing. After that happens many tools struggle
to do something with this file, for example git.
It's the quickest solution, probably not the best. Better one wo
martong updated this revision to Diff 149107.
martong added a comment.
- Add a missing "else"
Repository:
rC Clang
https://reviews.llvm.org/D47532
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
lib/AST/DeclBase.cpp
test/ASTMerge/class/test.cpp
unittests/AST/ASTImpor
balazske accepted this revision.
balazske added a comment.
This revision is now accepted and ready to land.
Found no big problems. But not all extra options are applicable to all
languages (template related things to C) so there may be redundant tests.
Repository:
rC Clang
https://reviews.ll
balazske requested review of this revision.
balazske added inline comments.
Comment at: lib/AST/ASTImporter.cpp:2131
D2CXX->setDescribedClassTemplate(ToDescribed);
+if (!DCXX->isInjectedClassName()) {
+ // In a record describing a template the type shoul
balazske added inline comments.
Comment at: test/ASTMerge/injected-class-name-decl-1/Inputs/inject1.cpp:16
+} // namespace google
+namespace a {
+template class g;
a.sidorin wrote:
> This looks like raw creduce output. Is there a way to simplify this or make
>
martong created this revision.
martong added reviewers: a.sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Add a new test about importing a partial specialization (of a class). Also,
this patch adds new tests about the templated-described swing, some of these
sammccall added a comment.
Unfortunately this seems to miscompile, the stage1 built clang is crashing on
the multistage buildbots:
http://lab.llvm.org:8011/builders/clang-s390x-linux-multistage/builds/2926
shows this crash present already at 333500
I've locally verified the crash and that that
Author: sammccall
Date: Wed May 30 07:14:58 2018
New Revision: 333547
URL: http://llvm.org/viewvc/llvm-project?rev=333547&view=rev
Log:
Revert "Update NRVO logic to support early return"
This reverts commit r333500, which causes stage2 compiler crashes.
Removed:
cfe/trunk/test/CodeGenCXX/nrv
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/TUScheduler.h:66
+ std::chrono::steady_clock::duration UpdateDebounce,
+ ASTRetentionPolicy RetentionPolicy = {});
~
Author: ibiryukov
Date: Wed May 30 07:21:31 2018
New Revision: 333548
URL: http://llvm.org/viewvc/llvm-project?rev=333548&view=rev
Log:
[clangd] Add forgotten include guard to TestFS.h. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/TestFS.h
Modified: clang-tools-extra/trunk/unittest
ebevhan added a comment.
Sorry for the late notice; I missed something.
Comment at: include/clang/Basic/TokenKinds.def:393
+// ISO/IEC JTC1 SC22 WG14 N1169 Extension
+KEYWORD(_Accum , KEYALL)
+
I believe that having KEYALL will enable the k
martong added inline comments.
Comment at: test/ASTMerge/injected-class-name-decl-1/Inputs/inject1.cpp:16
+} // namespace google
+namespace a {
+template class g;
balazske wrote:
> a.sidorin wrote:
> > This looks like raw creduce output. Is there a way to simpli
russellmcc added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:760
(!Style.AllowAllParametersOfDeclarationOnNextLine &&
State.Line->MustBeDeclaration) ||
+(!Style.AllowAllArgumentsOnNextLine &&
djasper wrote:
> This s
tzik added a comment.
In https://reviews.llvm.org/D47067#1116246, @sammccall wrote:
> Unfortunately this seems to miscompile, the stage1 built clang is crashing on
> the multistage buildbots:
>
> http://lab.llvm.org:8011/builders/clang-s390x-linux-multistage/builds/2926
> shows this crash prese
Charusso updated this revision to Diff 149116.
Charusso added a comment.
@xbolva00 idea implemented, doubled the checker's power. Now if the given
argument is a DeclRefExpr this should handle it as it would be inlined as a
simple CallExpr.
Results:
I have found 37 `memcpy()` and 2 `memchr()` er
omtcyfz created this revision.
omtcyfz added reviewers: ioeric, klimek, arphaman.
omtcyfz added projects: clang, clang-tools-extra.
clang-rename was moved to the Clang repository in r306840, but documentation
was left behind, which might be confusing. The Doxygen configuration file in
clang-tool
This revision was automatically updated to reflect the committed changes.
Closed by commit rC333553: [clang-format/ObjC] Correctly parse Objective-C
methods with 'class' in name (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47095?vs=148231&id=14912
Author: benhamilton
Date: Wed May 30 08:21:38 2018
New Revision: 333553
URL: http://llvm.org/viewvc/llvm-project?rev=333553&view=rev
Log:
[clang-format/ObjC] Correctly parse Objective-C methods with 'class' in name
Summary:
Please take a close look at this CL. I haven't touched much of
`Unwrapped
xbolva00 added a comment.
Thanks! Happy to see it is more powerful now :)
https://reviews.llvm.org/D45050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
I've stumbled about this bug too and was looking into it and then I saw the
mail about this change being submitted :)
I've ended up with a slightly different change (https://dpaste.de/PSpM/raw ,
instead of FD->getReturnType()->getContainedDeducedType() I have
FD->getReturn
Charusso updated this revision to Diff 149129.
Charusso added a comment.
Clang format.
https://reviews.llvm.org/D45050
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
clang-tidy/bugprone/NotNullTer
xbolva00 added a comment.
memcpy(crypt_buf, passwd, passwd_len); <--- warning
memcpy(crypt_buf + passwd_len, salt, salt_len);
This is a false warning since it appends strings using memcpy. But no idea what
to do and if it is possible to avoid these false warnings.
https://reviews.llvm.org/D450
kosarev added a comment.
Ping.
https://reviews.llvm.org/D47121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Charusso added a comment.
In https://reviews.llvm.org/D45050#1116361, @xbolva00 wrote:
> memcpy(crypt_buf, passwd, passwd_len); <--- warning
> memcpy(crypt_buf + passwd_len, salt, salt_len);
>
> This is a false warning since it appends strings using memcpy. But no idea
> what to do and if it is
xbolva00 added a comment.
In https://reviews.llvm.org/D45050#1116396, @Charusso wrote:
> In https://reviews.llvm.org/D45050#1116361, @xbolva00 wrote:
>
> > memcpy(crypt_buf, passwd, passwd_len); <--- warning
> > memcpy(crypt_buf + passwd_len, salt, salt_len);
> >
> > This is a false warning sinc
SjoerdMeijer added a comment.
Had only a first brief look; see some first drive by comments inline.
Comment at: lib/CodeGen/CGBuiltin.cpp:7865
}
// FIXME: Sharing loads & stores with 32-bit is complicated by the absence
// of an Align parameter here.
--
ilya-biryukov added a comment.
In https://reviews.llvm.org/D44480#1116359, @nik wrote:
> I've stumbled about this bug too and was looking into it and then I saw the
> mail about this change being submitted :)
>
> I've ended up with a slightly different change (https://dpaste.de/PSpM/raw ,
> ins
omtcyfz updated this revision to Diff 149138.
omtcyfz retitled this revision from "[clang-rename] Move clang-rename
documentation to Clang repository" to "[clang-tools-extra] Cleanup
documentation routine".
omtcyfz edited the summary of this revision.
omtcyfz added a comment.
Herald added a subsc
lebedev.ri added a comment.
I would like to see more negative tests.
What does it do if the len/size is a constant?
Variable that wasn't just assigned with `strlen()` return?
https://reviews.llvm.org/D45050
___
cfe-commits mailing list
cfe-commits@l
erichkeane updated this revision to Diff 149145.
erichkeane marked 11 inline comments as done.
erichkeane added a comment.
Fix based on @craig.topper and @aaron.ballman s comments.
https://reviews.llvm.org/D47474
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Ba
erichkeane added a comment.
Responding to comments :)
Comment at: include/clang/Basic/Attr.td:850
+def CpuSpecific : InheritableAttr {
+ let Spellings = [GCC<"cpu_specific">];
+ let Args = [VariadicIdentifierArgument<"Cpus">];
aaron.ballman wrote:
> Does GCC
EricWF marked 5 inline comments as done.
EricWF added a comment.
In https://reviews.llvm.org/D37035#1116102, @kunitoki wrote:
> Any news on the status of this ? Would be really nice to have it in.
I think this patch is ready to go; but there is more work to be done, as a
separate patch, to sup
Author: ctopper
Date: Wed May 30 10:23:45 2018
New Revision: 333563
URL: http://llvm.org/viewvc/llvm-project?rev=333563&view=rev
Log:
[X86] Remove 'return' from a bunch of intrinsics that return void and use a
builtin that returns void.
Found by running the intrinsic headers through -pedantic -a
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2382
+// Reset the solver
+RefutationMgr.reset();
+ }
xazax.hun wrote:
> george.karpenkov wrote:
> > george.karpenkov wrote:
> > > (apologies in advance f
jfb added inline comments.
Comment at: include/clang/Basic/TokenKinds.def:393
+// ISO/IEC JTC1 SC22 WG14 N1169 Extension
+KEYWORD(_Accum , KEYALL)
+
ebevhan wrote:
> I believe that having KEYALL will enable the keyword even if -fno-fixed-poin
george.karpenkov added a comment.
Herald added subscribers: a.sidorin, zzheng, rnkovacs, szepet.
Herald added a reviewer: george.karpenkov.
@ddcc Hi, are you still interested in landing the fixes associated with this
patch? I can take a look as I'm currently reviewing
https://reviews.llvm.org/D4
leonardchan updated this revision to Diff 149162.
Repository:
rC Clang
https://reviews.llvm.org/D46084
Files:
include/clang-c/Index.h
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/LangOptions.def
i
leonardchan added inline comments.
Comment at: include/clang/Basic/TokenKinds.def:393
+// ISO/IEC JTC1 SC22 WG14 N1169 Extension
+KEYWORD(_Accum , KEYALL)
+
jfb wrote:
> ebevhan wrote:
> > I believe that having KEYALL will enable the keyword
Author: ctopper
Date: Wed May 30 11:02:11 2018
New Revision: 333568
URL: http://llvm.org/viewvc/llvm-project?rev=333568&view=rev
Log:
[X86] Reduce the number of setzero intrinsics to just the set defined by the
Intel Intrinsics Guide.
We had quite a few for different element sizes of integers so
leonardchan updated this revision to Diff 149169.
leonardchan added a comment.
Forgot to include tests for the `_Fract` and `_Sat` keywords in c++ usage
Repository:
rC Clang
https://reviews.llvm.org/D46911
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include
Author: ctopper
Date: Wed May 30 11:27:07 2018
New Revision: 333572
URL: http://llvm.org/viewvc/llvm-project?rev=333572&view=rev
Log:
[X86] Simplify the implementation of _mm_sqrt_ss, _mm_rcp_ss, and _mm_rsqrt_ss.
We don't need the insertion back into the original vector at the end. The
builtin
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: test/Driver/cl-options.c:595
+// RUN: -no-canonical-prefixes \
+// RUN: -fno-coverage-mapping \
// RUN: --version \
takuto.ikuta wrot
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
As far as workarounds go, this looks great! Please add a test case, I think you
had one in the initial patch.
Should I go ahead and commit this?
https://reviews.llvm.org/D46664
Author: jdenny
Date: Wed May 30 11:33:53 2018
New Revision: 333574
URL: http://llvm.org/viewvc/llvm-project?rev=333574&view=rev
Log:
[AST] Fix loss of enum forward decl from decl context
For example, given:
enum __attribute__((deprecated)) T *p;
-ast-print produced:
enum T *p;
The attribu
1 - 100 of 168 matches
Mail list logo
