Author: vvassilev
Date: Sun May 20 02:38:52 2018
New Revision: 332817
URL: http://llvm.org/viewvc/llvm-project?rev=332817&view=rev
Log:
Print the qualified name when dumping deserialized decls.
This is useful to understand and debug the lazy template specializations
used in the pch and modules.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332817: Print the qualified name when dumping deserialized
decls. (authored by vvassilev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4178
Author: marshall
Date: Sun May 20 07:05:31 2018
New Revision: 332818
URL: http://llvm.org/viewvc/llvm-project?rev=332818&view=rev
Log:
Deduction guides for list
Added:
libcxx/trunk/test/std/containers/sequences/list/list.cons/deduct.fail.cpp
libcxx/trunk/test/std/containers/sequences/list
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, bruno, teemperor.
This patch improves traceability of duplicated header files which end up in
multiple pcms.
Repository:
rC Clang
https://reviews.llvm.org/D47118
Files:
lib/Frontend/FrontendActions.cpp
test/Module
theraven marked 3 inline comments as done.
theraven added inline comments.
Comment at: lib/CodeGen/CGObjCGNU.cpp:439
+ ArrayRef IvarOffsets,
+ ArrayRef IvarAlign,
+ ArrayRef IvarOwnership);
--
majnemer added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1173
+cast(CatchStartBlock->getFirstNonPHI());
+CurrentFuncletPad = CPI;
+ }
aheejin wrote:
> majnemer wrote:
> > Hmm, why is this done? Won't RestoreCurrentFuncletPad undo this?
raj.khem added a comment.
Can this be backported to release_60 branch too please ?
Repository:
rL LLVM
https://reviews.llvm.org/D44607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: compnerd
Date: Sun May 20 12:26:44 2018
New Revision: 332821
URL: http://llvm.org/viewvc/llvm-project?rev=332821&view=rev
Log:
Sema: diagnose invalid catch parameter in ObjC
Ensure that the type being used has an associated interface when
declaring the parameter for `@catch`.
Resolves PR
zinovy.nis created this revision.
zinovy.nis added reviewers: alexfh, aaron.ballman.
zinovy.nis added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, xazax.hun.
using A = std::string;
bool foo(A &s) {
A S;
if (GetValue(s) && S != (A)s)
return false;
retur
thakis added a comment.
This changes the default triple on Windows from x86_64-pc-win32 to
x86_64-pc-windows-msvc. This breaks at least
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
thakis added a comment.
(sorry, hit cmd-return accidentally, I will come in again…)
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
thakis added a comment.
This changes the default triple on Windows from x86_64-pc-win32 to
x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple()
(http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234)
def make_itanium_abi_triple(self, triple):
m = re.match(r'(
thakis added a comment.
…hm looks like https://reviews.llvm.org/rL332750 touched files in both clang
and llvm, which is probably why the diff looks super confusing on phab. I'll
revert it in two pieces, I don't know how to commit changes to llvm and clang
in one revision.
Repository:
rC Cla
Author: nico
Date: Sun May 20 16:02:20 2018
New Revision: 332822
URL: http://llvm.org/viewvc/llvm-project?rev=332822&view=rev
Log:
Revert 332750, clang part (see comment on D46910).
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cp
thakis added a comment.
Reverted in r332822 / r332823.
Repository:
rC Clang
https://reviews.llvm.org/D46910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ctopper
Date: Sun May 20 16:34:10 2018
New Revision: 332825
URL: http://llvm.org/viewvc/llvm-project?rev=332825&view=rev
Log:
[X86] Remove mask arguments from permvar builtins/intrinsics. Use a select in
IR instead.
Someday maybe we'll use selects for all the builtins.
Modified:
cfe
phosek added a comment.
In https://reviews.llvm.org/D46910#1105992, @thakis wrote:
> This changes the default triple on Windows from x86_64-pc-win32 to
> x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple()
> (http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234)
>
echristo added a comment.
In https://reviews.llvm.org/D47070#1105533, @Hahnfeld wrote:
> Looks like this was added as a "temporary solution" in
> https://reviews.llvm.org/D8984. Meanwhile the attribute whitelist was merged
> half a year later (https://reviews.llvm.org/D7802), so maybe we can ju
echristo added a comment.
So, I'd really prefer not to set options via the backend option path. From here
I think we should aim to take all of the options we added and having the asm
printer in the backend know how to set them depending on the target. We could
also add things to the IR metadata
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
-eric
https://reviews.llvm.org/D47029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
echristo added subscribers: pcc, paulsemel.
echristo added a comment.
FWIW Peter has some patches to move object emission away from objcopy that I'm
on the hook to review here shortly so the objcopy part of this should become
unnecessary and can just have us able to emit dwarf5 compatible split
aheejin added inline comments.
Comment at: lib/CodeGen/CGException.cpp:1241-1245
+while (llvm::TerminatorInst *TI = RethrowBlock->getTerminator()) {
+ llvm::BranchInst *BI = cast(TI);
+ assert(BI->isConditional());
+ RethrowBlock = BI->getSuccessor(1);
+}
-
sepavloff added a comment.
In https://reviews.llvm.org/D44607#1105962, @raj.khem wrote:
> Can this be backported to release_60 branch too please ?
The patch is compact, clear and addresses stability issue. I think it is worth
of backporting to release_60.
Repository:
rL LLVM
https://revie
Author: ctopper
Date: Sun May 20 20:36:57 2018
New Revision: 332829
URL: http://llvm.org/viewvc/llvm-project?rev=332829&view=rev
Log:
[X86] Remove some unused builtins.
These were upgraded to native shufflevectors months ago.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cfe/tr
echristo added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D47050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo added a comment.
Well, that's ridiculous. We should really fix this a better way in the future.
That said, would you add a testcase for this please so we don't regress if we
fix it? :)
-eric
Repository:
rC Clang
https://reviews.llvm.org/D46230
__
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, my comments seem to all be addressed.
Repository:
rC Clang
https://reviews.llvm.org/D46052
___
cfe-commits mailing list
cfe-commit
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, GBuella.
Because the intrinsics in the headers are implemented as macros, we can't just
use a select builtin and pternlog builtin. This would require one of the macro
arguments to be used twice. Depending on what
Author: ctopper
Date: Sun May 20 23:07:49 2018
New Revision: 332830
URL: http://llvm.org/viewvc/llvm-project?rev=332830&view=rev
Log:
[X86] Remove some preprocessor feature checks from intrinsic headers
Summary:
These look to be a couple things that weren't removed when we switched to
target att
This revision was automatically updated to reflect the committed changes.
Closed by commit rC332830: [X86] Remove some preprocessor feature checks from
intrinsic headers (authored by ctopper, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47029
Files:
lib/Headers/prfchwintri
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:760
(!Style.AllowAllParametersOfDeclarationOnNextLine &&
State.Line->MustBeDeclaration) ||
+(!Style.AllowAllArgumentsOnNextLine &&
This still looks suspiciou
31 matches
Mail list logo
