r292897 - [test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`.

Author: gparker Date: Tue Jan 24 02:47:25 2017 New Revision: 292897 URL: http://llvm.org/viewvc/llvm-project?rev=292897&view=rev Log: [test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`. Requires the new `lit` boolean expressions in LLVM r292896. Modified: cfe/trunk/test/Driv

r292898 - Revert "[test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`."

Author: gparker Date: Tue Jan 24 02:57:17 2017 New Revision: 292898 URL: http://llvm.org/viewvc/llvm-project?rev=292898&view=rev Log: Revert "[test] Replace `REQUIRES-ANY: a, b, c` with `REQUIRES: a || b || c`." The underlying `lit` change needs to be better-coordinated with libc++. Modified:

[libcxx] r292901 - Remove all usages of REQUIRES-ANY in the test suite.

Author: ericwf Date: Tue Jan 24 03:11:08 2017 New Revision: 292901 URL: http://llvm.org/viewvc/llvm-project?rev=292901&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

[libcxx] r292905 - Fix bad XFAIL which recent LIT changes diagnosed

Author: ericwf Date: Tue Jan 24 04:19:32 2017 New Revision: 292905 URL: http://llvm.org/viewvc/llvm-project?rev=292905&view=rev Log: Fix bad XFAIL which recent LIT changes diagnosed Modified: libcxx/trunk/test/std/utilities/meta/meta.unary.prop.query/void_t.pass.cpp Modified: libcxx/trunk/t

[libcxxabi] r292906 - Remove all usages of REQUIRES-ANY in the test suite.

Author: ericwf Date: Tue Jan 24 04:28:23 2017 New Revision: 292906 URL: http://llvm.org/viewvc/llvm-project?rev=292906&view=rev Log: Remove all usages of REQUIRES-ANY in the test suite. Pending LIT changes are about to remove the REQUIRES-ANY keyword in place of supporting boolean && and || withi

[libcxx] r292908 - Revert yet another accidental change caused by r292684

Author: ericwf Date: Tue Jan 24 04:38:46 2017 New Revision: 292908 URL: http://llvm.org/viewvc/llvm-project?rev=292908&view=rev Log: Revert yet another accidental change caused by r292684 Modified: libcxx/trunk/test/libcxx/test/config.py Modified: libcxx/trunk/test/libcxx/test/config.py URL:

[PATCH] D21675: New ODR checker for modules

teemperor added a comment. I feel like we have a really similar use case in the Analysis/CloneDetection{.h/.cpp} with the hashing of statements. I tried substituting the call to the statement hashing with a call to the CloneDetection API and it seems that most tests pass and the remaining fails

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir marked 3 inline comments as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.h:55-56 +/// been reformatted, and +/// - replaceWhitespaceBefore, for executing the reflow using a whitespace +/// manager. +/// klimek wrote: >

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir updated this revision to Diff 85557. krasimir marked 3 inline comments as done. krasimir added a comment. - Address review comments. https://reviews.llvm.org/D28764 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/CMakeLists.txt lib/Format/Comments.cp

r292914 - Replace use of chdir with llvm::sys::fs::set_current_path

Author: labath Date: Tue Jan 24 05:14:29 2017 New Revision: 292914 URL: http://llvm.org/viewvc/llvm-project?rev=292914&view=rev Log: Replace use of chdir with llvm::sys::fs::set_current_path NFCI Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSy

[clang-tools-extra] r292917 - [clang-tidy] Add more tests for modernize-use-using.

Author: alexfh Date: Tue Jan 24 05:40:23 2017 New Revision: 292917 URL: http://llvm.org/viewvc/llvm-project?rev=292917&view=rev Log: [clang-tidy] Add more tests for modernize-use-using. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using.cpp Modified: clang-tools-extra/trun

[clang-tools-extra] r292918 - [clang-tidy] Avoid incorrect fixes in modernize-use-using

Author: alexfh Date: Tue Jan 24 05:41:02 2017 New Revision: 292918 URL: http://llvm.org/viewvc/llvm-project?rev=292918&view=rev Log: [clang-tidy] Avoid incorrect fixes in modernize-use-using Avoid fixes for typedefs with multiple types and for typedefs with struct definitions. Partially addresses

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +Current.TokenText.substr(2).ltrim().st

[PATCH] D29063: [libcxx] Never use within libc++

rmaprath added a comment. @EricWF: My downstream builds have `-DLLVM_ENABLE_ASSERTIONS=ON` by default and they are showing some failures after this commit. Log attached: F3019711: log.txt It should be pretty easy to reproduce these (I'm on Ubuntu 16.04) if yo

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +Current.TokenText.substr(2).ltrim().

[PATCH] D29063: [libcxx] Never use within libc++

rmaprath added a comment. Sorry, I meant `-DLIBCXX_ENABLE_ASSERTIONS=ON`. https://reviews.llvm.org/D29063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r292923 - Revert "[libcxx] Never use within libc++"

Author: ericwf Date: Tue Jan 24 06:26:01 2017 New Revision: 292923 URL: http://llvm.org/viewvc/llvm-project?rev=292923&view=rev Log: Revert "[libcxx] Never use within libc++" This reverts commit r292883. Unfortunately uses _LIBCPP_ASSERT in a way which is not compatible with the C++11 dylib bui

[PATCH] D29063: [libcxx] Never use within libc++

EricWF added a comment. It seems like weird usages of `_LIBCPP_ASSERT` in `` are causing this problem. Specifically the usages in `` attempt to use `_LIBCPP_ASSERT` in C++11 constexpr functions and this currently does not work. For now I've reverted this change in r292923. https://reviews.llv

[PATCH] D29077: [lsan] Enable LSan for x86 Linux.

m.ostapenko created this revision. m.ostapenko added a project: Sanitizers. This is a missed part of https://reviews.llvm.org/D28609. Enable LSan for x86 Linux in clang driver. Repository: rL LLVM https://reviews.llvm.org/D29077 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolCha

[clang-tools-extra] r292926 - [clang-tidy] Fix NOLINT test

Author: alexfh Date: Tue Jan 24 06:42:26 2017 New Revision: 292926 URL: http://llvm.org/viewvc/llvm-project?rev=292926&view=rev Log: [clang-tidy] Fix NOLINT test Summary: Test cases I've added in review D26218 were too brittle and weren't working properly. This patch fixes this. Reviewers: alex

[PATCH] D26466: [clang-tidy] Fix NOLINT test

This revision was automatically updated to reflect the committed changes. Closed by commit rL292926: [clang-tidy] Fix NOLINT test (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D26466?vs=77378&id=85571#toc Repository: rL LLVM https://reviews.llvm.org/D26466 Files:

[PATCH] D29027: [Stack Protection] Add remark for reasons why Stack Protection has been applied

jhenderson updated this revision to Diff 85570. jhenderson edited the summary of this revision. jhenderson added a comment. Thanks for the comments. I have updated the diff accordingly, by removing the unknown case, adding a check to distinguish between the function attribute and command-line sw

Re: [PATCH] D29063: [libcxx] Never use within libc++

Thanks for the lightening fast response :) / Asiri On Tue, Jan 24, 2017 at 12:38 PM, Eric Fiselier via Phabricator via cfe-commits wrote: > EricWF added a comment. > > It seems like weird usages of `_LIBCPP_ASSERT` in `` are > causing this problem. > Specifically the usages in `` attempt to use

r292927 - [Sema] Fix assumption about typo corrections containing no decl.

Author: d0k Date: Tue Jan 24 06:49:59 2017 New Revision: 292927 URL: http://llvm.org/viewvc/llvm-project?rev=292927&view=rev Log: [Sema] Fix assumption about typo corrections containing no decl. This can happen when the typo correction is coming from an external sema source. Test case will follow

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

svenvh updated this revision to Diff 85575. svenvh edited the summary of this revision. svenvh added a comment. Removed the custom sema check and added the extension to the image type in OpenCLImageTypes.def. https://reviews.llvm.org/D28860 Files: include/clang/Basic/OpenCLImageTypes.def l

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

svenvh added a comment. In https://reviews.llvm.org/D28860#653662, @yaxunl wrote: > The tests should be added to SemaOpenCL/extension-version.cl SemaOpenCL/extension-version.cl already has a test for the cl_khr_3d_image_writes extension. Comment at: lib/Sema/SemaType.cpp:66

r292932 - [CodeCompletion] Ensure that ObjC root class completes instance

Author: arphaman Date: Tue Jan 24 08:15:08 2017 New Revision: 292932 URL: http://llvm.org/viewvc/llvm-project?rev=292932&view=rev Log: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well Code completion results for class methods already in

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

seanbruno accepted this revision. seanbruno added a comment. This revision is now accepted and ready to land. FreeBSD is happy with this. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D29031: [mips] Add support for static model on N64

seanbruno accepted this revision. seanbruno added a comment. This revision is now accepted and ready to land. From a "does this work" perspective, FreeBSD compiles are better now with this in place. Repository: rL LLVM https://reviews.llvm.org/D29031 __

[PATCH] D28510: Reinstate CWG1607 restrictions on lambdas appearing inside certain constant-expressions

faisalv added a comment. In https://reviews.llvm.org/D28510#653794, @rsmith wrote: > I don't think it's possible to check this in the way you're doing so here. In > general, there's no way to know whether a constant expression will be part of > a `typedef` declaration or function declaration un

[PATCH] D27257: [CodeCompletion] Ensure that ObjC root class completes instance methods from protocols and categories as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL292932: [CodeCompletion] Ensure that ObjC root class completes instance (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D27257?vs=85400&id=85578#toc Repository: rL LLVM htt

[PATCH] D28860: [OpenCL] Diagnose write_only image3d when extension is disabled

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D28860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D28981: Use GNU-style attributes for several __throw_XXX() functions

dim abandoned this revision. dim added a comment. Ok, back to Mozilla we go. https://reviews.llvm.org/D28981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

arpith-jacob created this revision. Herald added a subscriber: jholewinski. This patch adds support for the Spmd construct 'target parallel' on the NVPTX device. This involves ignoring the num_threads clause on the device since the number of threads in this combined construct is already set on th

[PATCH] D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'.

arpith-jacob created this revision. The num_threads-clause on the combined directive applies to the 'parallel' region of this construct. We modify the NumThreadsClause class to capture the clause expression within the 'target' region. The offload runtime call for 'target parallel' is changed to

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:867 +Expected clang::FindThinLTOModule(MemoryBufferRef MBRef) { + Expected> BMsOrErr = getBitcodeModuleList(MBRef); Would it be better to have this in llvm (e.g. in BitcodeReader li

[PATCH] D28768: [clang-tidy] Add check 'modernize-return-braced-init-list'

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: test/clang-tidy/modernize-return-braced-init-list.cpp:150 +template +T f16() { + return T(); "With multiple instantiations" is an

[PATCH] D29084: [OpenMP] Codegen support for 'target teams' on the host.

arpith-jacob created this revision. This patch adds support for codegen of 'target teams' on the host. This combined directive has two captured statements, one for the 'teams' region, and the other for the 'parallel'. This target teams region is offloaded using the __tgt_target_teams() call. The

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. As mentioned in https://reviews.llvm.org/D29032 I agree with @joerg - `__mips_abicalls` should always be defined if this is what GCC does. https://reviews.llvm.org/D29032 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

emaste added a comment. In https://reviews.llvm.org/D29032#654854, @emaste wrote: > As mentioned in https://reviews.llvm.org/D29032 Err, that should be https://reviews.llvm.org/D29024 https://reviews.llvm.org/D29032 ___ cfe-commits mailing list c

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang-tools-extra] r292938 - [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

Author: xazax Date: Tue Jan 24 09:18:11 2017 New Revision: 292938 URL: http://llvm.org/viewvc/llvm-project?rev=292938&view=rev Log: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer. Fixes PR30964. The old behavior can be achieved using a setting. Patch by: Andras Leitereg

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292938: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D28667?vs=85014&id=85586#toc Repository: rL LL

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:20-33 +static StringRef +makeDynamicExceptionString(const SourceManager &SM, + c

[PATCH] D29085: [OpenMP] Support for num_teams-clause on the 'target teams' directive.

arpith-jacob created this revision. The num_teams-clause on the combined directive applies to the 'teams' region of this construct. We modify the NumTeamsClause class to capture the clause expression within the 'target' region. https://reviews.llvm.org/D29085 Files: include/clang/AST/OpenMPC

[PATCH] D28946: [analyzer] Fix memory space for block-captured static locals.

NoQ updated this revision to Diff 85588. NoQ added a comment. Reopening due to a revert. This time i reduce the scope of the fix to the checker, and add FIXMEs to the problems that showed up while testing it. https://reviews.llvm.org/D28946 Files: lib/StaticAnalyzer/Checkers/MacOSXAPIChecke

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added a comment. This is starting to be pretty awesome. The one thing that would help me review the gist of the implementation a bit more is if that had a bit more comments. Perhaps go over the math in the code and put some comments in why we're doing what at various steps. ==

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/BreakableToken.h:42-48 +/// There is a pair of operations that are used to compress a long whitespace +/// range with a single space if that will bring the line lenght under the +///

[libcxx] r292943 - A couple more tests for constexpr stuff in string_view. No changes other than test code.

Author: marshall Date: Tue Jan 24 10:28:02 2017 New Revision: 292943 URL: http://llvm.org/viewvc/llvm-project?rev=292943&view=rev Log: A couple more tests for constexpr stuff in string_view. No changes other than test code. Modified: libcxx/trunk/test/std/strings/string.view/string.view.ite

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.h:42-48 +/// There is a pair of operations that are used to compress a long whitespace +/// range with a single space if that will bring the line lenght under the +/// column limit: +/// - getLineLengthAfterCompr

[PATCH] D29087: [OpenMP] Support for thread_limit-clause on the 'target teams' directive.

arpith-jacob created this revision. The thread_limit-clause on the combined directive applies to the 'teams' region of this construct. We modify the ThreadLimitClause class to capture the clause expression within the 'target' region. https://reviews.llvm.org/D29087 Files: include/clang/AST/O

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 85593. hintonda marked 4 inline comments as done. hintonda added a comment. - Addressed comments and added additional test cases. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

Thanks for letting me know! I've merged your revert to the branch in r292947. Please let me know if there is any more follow-up. On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote: > FYI, I reverted r292800 from trunk in r292874. It was causing our internal > validation bots to have false pos

[PATCH] D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4996 + CodeGenFunction::RunCleanupsScope NumThreadsScope(CGF); + auto NumThreads = CGF.EmitScalarExpr(Nu

[PATCH] D29039: Proposal for clang-format -r option

stryku added a comment. @djasper You're probably right. Thanks anyway for your time (: Repository: rL LLVM https://reviews.llvm.org/D29039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D29039: Proposal for clang-format -r option

djasper added a comment. No problem :) Repository: rL LLVM https://reviews.llvm.org/D29039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Depending on how you look at the previous commit, you can think that as a new API or just rename the old API. I actually dont think there is too much issue names. Plz go ahead. https:/

[PATCH] D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29084: [OpenMP] Codegen support for 'target teams' on the host.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29085: [OpenMP] Support for num_teams-clause on the 'target teams' directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29087: [OpenMP] Support for thread_limit-clause on the 'target teams' directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D28845: Prototype of modules codegen

dblaikie updated this revision to Diff 85599. dblaikie added a comment. - Move linkage handling into GetGVALinkageForFunction https://reviews.llvm.org/D28845 Files: include/clang/AST/ASTContext.h include/clang/AST/ExternalASTSource.h include/clang/Basic/LangOptions.def include/clang/Bas

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. My apologies again for the delay. There are a few things I'm concerned about: 1. Suppression list being a command-line option is going to be inconvenient to completely useless in many setups. The `-line-filter` option is special in this regard, since it was added for a r

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

alexfh accepted this revision. alexfh added a comment. LGTM, if Aaron has no concerns. Thank you for the new check! https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[libcxx] r292958 - Mark LWG2736 as complete. No code changes, but we have more tests now

Author: marshall Date: Tue Jan 24 12:03:32 2017 New Revision: 292958 URL: http://llvm.org/viewvc/llvm-project?rev=292958&view=rev Log: Mark LWG2736 as complete. No code changes, but we have more tests now Added: libcxx/trunk/test/std/utilities/optional/optional.nullopt/nullopt_t.fail.cpp Modi

[PATCH] D25024: [clang-tidy] Add check for detecting declarations with multiple names

alexfh added a comment. https://reviews.llvm.org/D27621 seems to have a more up-to-date version of this patch. https://reviews.llvm.org/D25024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D27872: [APFloat] Switch from (PPCDoubleDoubleImpl, IEEEdouble) layout to (IEEEdouble, IEEEdouble)

jlebar added a comment. Eric asked me to do a review of this. I notice now it was submitted while I was doing the review. Oh well. Here are the comments I had. Comment at: llvm/include/llvm/ADT/APFloat.h:1054 + opStatus next(bool nextDown) { +if (usesLayout(getSemant

r292960 - Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

Author: mehdi_amini Date: Tue Jan 24 12:12:25 2017 New Revision: 292960 URL: http://llvm.org/viewvc/llvm-project?rev=292960&view=rev Log: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly(). Summary: These accessors maps directly to the command line option. Reviewe

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

This revision was automatically updated to reflect the committed changes. Closed by commit rL292960: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly… (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D29065?vs=85511&id=85605#toc Reposi

r292961 - Forward -bitcode_process_mode to ld64 in marker-only mode

Author: mehdi_amini Date: Tue Jan 24 12:15:21 2017 New Revision: 292961 URL: http://llvm.org/viewvc/llvm-project?rev=292961&view=rev Log: Forward -bitcode_process_mode to ld64 in marker-only mode Reviewers: steven_wu Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D2906

[PATCH] D29066: Forward -bitcode_process_mode to ld64 in marker-only mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL292961: Forward -bitcode_process_mode to ld64 in marker-only mode (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D29066?vs=85530&id=85606#toc Repository: rL LLVM https:

[libcxx] r292962 - Implement LWG2733: [fund.ts.v2] gcd / lcm and bool. We already did tbis for C++17, so replicate the changes in experimental.

Author: marshall Date: Tue Jan 24 12:15:48 2017 New Revision: 292962 URL: http://llvm.org/viewvc/llvm-project?rev=292962&view=rev Log: Implement LWG2733: [fund.ts.v2] gcd / lcm and bool. We already did tbis for C++17, so replicate the changes in experimental. Added: libcxx/trunk/test/std/e

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

alexfh added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:130 +if (isa(*(FirstVarIt + 1))) + return "typedef " + TypeString; + Should we suggest `using x = ...;` in C++11 code? Comment at: clang-ti

[libcxxabi] r292963 - cxa_demangle: avoid butchering the last parameter type

Author: compnerd Date: Tue Jan 24 12:42:56 2017 New Revision: 292963 URL: http://llvm.org/viewvc/llvm-project?rev=292963&view=rev Log: cxa_demangle: avoid butchering the last parameter type Fix an off-by-one case which would destroy the final parameter in a CV-qualified function type with a refer

[PATCH] D29077: [lsan] Enable LSan for x86 Linux.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D29077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r292964 - Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly

Author: mehdi_amini Date: Tue Jan 24 12:49:49 2017 New Revision: 292964 URL: http://llvm.org/viewvc/llvm-project?rev=292964&view=rev Log: Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly Modified: cfe/trunk/test/Driver/embed-bitcode.c Modified: cfe/trunk/t

[PATCH] D29077: [lsan] Enable LSan for x86 Linux.

eugenis added a comment. A test would be nice. Repository: rL LLVM https://reviews.llvm.org/D29077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r292967 - Update status for LWG2733

Author: marshall Date: Tue Jan 24 13:37:09 2017 New Revision: 292967 URL: http://llvm.org/viewvc/llvm-project?rev=292967&view=rev Log: Update status for LWG2733 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm-project

[libcxx] r292969 - Add a test to make sure that implicit conversion from error_code to bool will fail

Author: marshall Date: Tue Jan 24 13:44:55 2017 New Revision: 292969 URL: http://llvm.org/viewvc/llvm-project?rev=292969&view=rev Log: Add a test to make sure that implicit conversion from error_code to bool will fail Added: libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.err

r292970 - IRGen: Factor out function clang::FindThinLTOModule. NFCI.

Author: pcc Date: Tue Jan 24 13:54:37 2017 New Revision: 292970 URL: http://llvm.org/viewvc/llvm-project?rev=292970&view=rev Log: IRGen: Factor out function clang::FindThinLTOModule. NFCI. Modified: cfe/trunk/include/clang/CodeGen/BackendUtil.h cfe/trunk/lib/CodeGen/BackendUtil.cpp Modif

r292972 - IRGen: Factor out function CodeGenAction::loadModule. NFCI.

Author: pcc Date: Tue Jan 24 13:55:38 2017 New Revision: 292972 URL: http://llvm.org/viewvc/llvm-project?rev=292972&view=rev Log: IRGen: Factor out function CodeGenAction::loadModule. NFCI. Modified: cfe/trunk/include/clang/CodeGen/CodeGenAction.h cfe/trunk/lib/CodeGen/CodeGenAction.cpp

[libcxxabi] r292973 - cxa_demangle: fix rvalue ref check

Author: compnerd Date: Tue Jan 24 13:57:05 2017 New Revision: 292973 URL: http://llvm.org/viewvc/llvm-project?rev=292973&view=rev Log: cxa_demangle: fix rvalue ref check When checking if the type is a r-value ref, we would not do a complete check. This would result in us treating a trailing para

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

pcc updated this revision to Diff 85618. pcc added a comment. Address review comments https://reviews.llvm.org/D29067 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/test/CMakeLists.txt clang/test/CodeGen/thinlto-multi-module.ll Index: clang/test/CodeGen/thinlto-multi-module.ll ===

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

pcc added inline comments. Comment at: clang/include/clang/CodeGen/BackendUtil.h:51 + llvm::Expected + FindThinLTOModule(llvm::MemoryBufferRef MBRef); } mehdi_amini wrote: > Indentation seems strange? Yes, it's what clang-format does though.

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. > - That said, I think there are still significant optimization opportunities. > It looks like when performing a query you create a new solver for each set of > constraints. My understanding (and perhaps @nlopes can correct me here) is > that these days Z3 is quite good at

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc updated this revision to Diff 85621. ddcc added a comment. Add CMake CLANG_BUILD_Z3 option, add Z3Model and Z3Solver classes, reuse solver in checkNull() and getSymVal() https://reviews.llvm.org/D28952 Files: CMakeLists.txt cmake/modules/FindZ3.cmake include/clang/Config/config.h.cm

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

dcoughlin added a comment. In https://reviews.llvm.org/D28952#655278, @ddcc wrote: > > - That said, I think there are still significant optimization > > opportunities. It looks like when performing a query you create a new > > solver for each set of constraints. My understanding (and perhaps @n

r292978 - Strengthen test from r292632 to also check we get the mangling correct for this case.

Author: rsmith Date: Tue Jan 24 15:03:48 2017 New Revision: 292978 URL: http://llvm.org/viewvc/llvm-project?rev=292978&view=rev Log: Strengthen test from r292632 to also check we get the mangling correct for this case. Modified: cfe/trunk/test/CodeGenCXX/mangle.cpp Modified: cfe/trunk/test/

Re: r292632 - Fix actually-reachable llvm_unreachable.

On 23 January 2017 at 08:57, David Blaikie wrote: > Should this test that some specific mangling comes out the other end > (tests that amount to "test that this does anything other than crashing" > always make me a bit suspicious that there's /some/ specific behavior that > is intended/should be

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:217 + /// statements. + llvm::SmallVector LabelSeenStack; + rjmccall wrote: > Shouldn't this be maintained by some existing scoping structure like > LexicalScope? I think I need a struct

[PATCH] D28946: [analyzer] Fix memory space for block-captured static locals.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM with some minor comments. Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:98 +const VarDecl *VD = VR->getDecl(); +// FIXME: These should have

[PATCH] D28832: Improve redefinition errors pointing to the same header.

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8708 +def note_redefinition_modules_same_file : Note< + "'%0' included multiple times, additional (likely non-modular) include site in module '%1'">; +def note_redefinition_modules_same_fi

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

ahatanak added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:217 + /// statements. + llvm::SmallVector LabelSeenStack; + ahatanak wrote: > rjmccall wrote: > > Shouldn't this be maintained by some existing scoping structure like > > LexicalScope? >

[PATCH] D27680: [CodeGen] Move lifetime.start of a variable when goto jumps back past its declaration

rjmccall added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:217 + /// statements. + llvm::SmallVector LabelSeenStack; + ahatanak wrote: > ahatanak wrote: > > rjmccall wrote: > > > Shouldn't this be maintained by some existing scoping structure lik

[PATCH] D29031: [mips] Add support for static model on N64

sdardis added a comment. @slthakur can you take a look at this too? Thanks, Simon Repository: rL LLVM https://reviews.llvm.org/D29031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D29032: [mips] Define macros related to -mabicalls in the preprocessor

sdardis added a comment. @joerg , @emaste : My concern is that the stock gcc distributions for FreeBSD, NetBSD from your sources doesn't define __mips_abicalls, so I'm worried about potential incompatibilities. Comment at: test/Preprocessor/init.c:4533 +// MIPS-ABICALLS-NETBS

[PATCH] D29067: IRGen: When loading the main module in the distributed ThinLTO backend, look for the module containing the summary.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[libcxx] r292986 - Remove auto_ptr in C++17. Get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR

Author: marshall Date: Tue Jan 24 16:22:33 2017 New Revision: 292986 URL: http://llvm.org/viewvc/llvm-project?rev=292986&view=rev Log: Remove auto_ptr in C++17. Get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR Added: libcxx/trunk/test/libcxx/depr/depr.auto.ptr/ libcxx/trunk/

[PATCH] D22587: [ASTContext] Fix part of DR224 for nontype template arguments

mgehre added a comment. Ping https://reviews.llvm.org/D22587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Add warning for c++ member variable shadowing

Dear members Here is a patch (attached) to create warnings where a member variable shadows the one in one of its inheriting classes. For cases where we really don't want to shadow member variables, e.g. class a { int foo; } class b : a { int foo; // Generate a warning } This patch (1) add

  1   2   >