[PATCH] D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

malcolm.parsons created this revision. malcolm.parsons added reviewers: klimek, sbenza, bkramer. malcolm.parsons added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Needed for https://reviews.llvm.org/D27166 https://reviews.llvm.org/D27447 Files: docs/LibASTMatchers

[libcxx] r288787 - Add missing stdbool.h module. The test suite now passes on OS X with modules

Author: ericwf Date: Tue Dec 6 03:41:50 2016 New Revision: 288787 URL: http://llvm.org/viewvc/llvm-project?rev=288787&view=rev Log: Add missing stdbool.h module. The test suite now passes on OS X with modules Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/mod

[PATCH] D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

klimek added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:5034 +/// \c substTemplateTypeParmType(hasReplacementType(type())) matches int +AST_MATCHER_P(SubstTemplateTypeParmType, hasReplacementType, + ast_matchers::internal::Matcher, InnerMatc

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a comment. Pondering this a bit - one question is whether we should make clang-format not return 0 if we pass -fallback-style=none (it already has this option) and we can't figure out a style. What do you think? https://reviews.llvm.org/D27440 __

[libcxx] r288789 - Revert r288787: Add missing stdbool.h module.

Author: ericwf Date: Tue Dec 6 03:48:32 2016 New Revision: 288789 URL: http://llvm.org/viewvc/llvm-project?rev=288789&view=rev Log: Revert r288787: Add missing stdbool.h module. Reverting because I didn't properly test this patch. Although it's probably correct to add a stdbool_h module I though

[PATCH] D27140: Allow clang to write compilation database records

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. We can always add more intricate ways later on. Repository: rL LLVM https://reviews.llvm.org/D27140 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r288791 - [clang-move] ignore unsupported symbol kinds when checking if all symbols are moved.

Author: ioeric Date: Tue Dec 6 04:12:23 2016 New Revision: 288791 URL: http://llvm.org/viewvc/llvm-project?rev=288791&view=rev Log: [clang-move] ignore unsupported symbol kinds when checking if all symbols are moved. Modified: clang-tools-extra/trunk/clang-move/ClangMove.cpp clang-tools

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

labrinea abandoned this revision. labrinea added a comment. Hi Renato, apologies for the long silence. Unfortunately this work is more complicated than I initially thought. We'll have to rethink about it thoroughly. I am going to abandon the patch for now. Thank you for reviewing this. https:

r288793 - Also recognize -std=iso9899:201x

Author: d0k Date: Tue Dec 6 04:23:07 2016 New Revision: 288793 URL: http://llvm.org/viewvc/llvm-project?rev=288793&view=rev Log: Also recognize -std=iso9899:201x It should already be handled but a typo in the LANGSTANDARD() definition was introduced in r147220. Patch by Alexander Richardson, te

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

echuraev updated this revision to Diff 80401. echuraev marked an inline comment as done. https://reviews.llvm.org/D27403 Files: test/CodeGenOpenCL/address-spaces-mangling.cl Index: test/CodeGenOpenCL/address-spaces-mangling.cl ==

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

amaiorano added a comment. In https://reviews.llvm.org/D27440#614337, @klimek wrote: > Pondering this a bit - one question is whether we should make clang-format > not return 0 if we pass -fallback-style=none (it already has this option) and > we can't figure out a style. What do you think? W

[PATCH] D27334: [OpenCL] Ambiguous function call.

bader added a comment. In https://reviews.llvm.org/D27334#613504, @Anastasia wrote: > In https://reviews.llvm.org/D27334#612858, @bader wrote: > > > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > > > This change seems to modify normal C behavior again. Is there any strong > >

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

mgorny added a comment. How should I proceed, then? Was something along the lines of the earlier diff a better idea? https://reviews.llvm.org/D25686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

On 5 Dec 2016 9:42 am, "Anastasia Stulova via Phabricator via cfe-commits" mailto:cfe-commits@lists.llvm.org>> wrote: Anastasia added a comment. In https://reviews.llvm.org/D27334#612858, @bader wrote: > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > This change seems to modi

[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: bader, cfe-commits, yaxunl. Although the feature was introduced only in OpenCL C v2.0 spec., it's useful for OpenCL 1.x too and doesn't require HW support. https://reviews.llvm.org/D27453 Files:

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

Actually OpenCL specification has the following text in “Built-in Functions” chapter (OpenCL C 2.0 rev. 33): “ User defined OpenCL C functions, behave per C standard rules for functions (C99, TC2, Section 6.9.1). On entry to the function, the size of each variably modified parameter is evaluate

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

rengolin added a comment. I think this patch should move to canonicalise the triple as per all the others, in the right place (vendor/environment). If you find `hardfloat` or on where the vendor should be, and there are no other possible vendors, just append `hf` to the environment and mark the

[PATCH] D27455: UBSan docs: Explicitly mention that `-fsanitize=unsigned-integer-overflow` does not catch UB.

thakis created this revision. thakis added reviewers: rsmith, samsonov. thakis added a subscriber: cfe-commits. https://reviews.llvm.org/D27455 Files: docs/UndefinedBehaviorSanitizer.rst Index: docs/UndefinedBehaviorSanitizer.rst ===

[PATCH] D25686: [Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi triples

mgorny added a comment. In https://reviews.llvm.org/D25686#614420, @rengolin wrote: > I think this patch should move to canonicalise the triple as per all the > others, in the right place (vendor/environment). > > If you find `hardfloat` or on where the vendor should be, and there are no > othe

r288813 - Fix two clang-tidy misc-move-forwarding-reference warnings

Author: malcolm.parsons Date: Tue Dec 6 08:49:18 2016 New Revision: 288813 URL: http://llvm.org/viewvc/llvm-project?rev=288813&view=rev Log: Fix two clang-tidy misc-move-forwarding-reference warnings Patch by Michael Sharpe. Modified: cfe/trunk/lib/AST/Type.cpp cfe/trunk/lib/CodeGen/CGB

Re: Fix some misc-move-forwarding-reference warnings

On 2 December 2016 at 17:13, Michael Sharpe via cfe-commits wrote: > The attached patch fixes a couple of incorrect uses of std::move as revealed > by clang-tidy. LGTM. Committed as r288813. -- Malcolm Parsons ___ cfe-commits mailing list cfe-commits

[PATCH] D27123: Add AVR target and toolchain to Clang

jroelofs added a comment. In https://reviews.llvm.org/D27123#614313, @saaadhu wrote: > Add testcases to test/Preprocessor/init.c Awesome, thanks! > Correct types for WChar and WInt > > The ABI is documented in the avr-gcc wiki (https://gcc.gnu.org/wiki/avr-gcc) > I took the output of a trunk

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a reviewer: djasper. klimek added a comment. Adding djasper, who had brought forward the idea. https://reviews.llvm.org/D27440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r288818 - Fix doc string typo: s/@__yes/@__objc_yes/

Author: jroelofs Date: Tue Dec 6 09:45:41 2016 New Revision: 288818 URL: http://llvm.org/viewvc/llvm-project?rev=288818&view=rev Log: Fix doc string typo: s/@__yes/@__objc_yes/ Modified: cfe/trunk/include/clang/AST/ExprObjC.h Modified: cfe/trunk/include/clang/AST/ExprObjC.h URL: http://llv

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl marked 15 inline comments as done. yaxunl added a comment. Sorry for the delay. I will update this patch. Comment at: lib/Parse/ParsePragma.cpp:461 + }; + typedef std::pair OpenCLExtData; } Anastasia wrote: > yaxunl wrote: > > Anastasia wrote: > > > C

[PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl updated this revision to Diff 80422. yaxunl marked 6 inline comments as done. yaxunl added a comment. Bring the patch up to date. Revised by Anastasia's comments. https://reviews.llvm.org/D21698 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/DiagnosticSemaKind

[PATCH] D27140: Allow clang to write compilation database records

This revision was automatically updated to reflect the committed changes. Closed by commit rL288821: Allow clang to write compilation database records. (authored by joerg). Changed prior to commit: https://reviews.llvm.org/D27140?vs=79997&id=80429#toc Repository: rL LLVM https://reviews.llv

r288821 - Allow clang to write compilation database records.

Author: joerg Date: Tue Dec 6 10:33:22 2016 New Revision: 288821 URL: http://llvm.org/viewvc/llvm-project?rev=288821&view=rev Log: Allow clang to write compilation database records. When integrating compilation database output into existing build systems, two approaches dominate so far. Ad-hoc i

[PATCH] D27408: [analyzer] RetainCountChecker: remove unused enum value; NFC.

NoQ updated this revision to Diff 80431. NoQ added a comment. Remove OwnedAllocatedSymbol instead. https://reviews.llvm.org/D27408 Files: include/clang/StaticAnalyzer/Checkers/ObjCRetainCount.h lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp Index: lib/StaticAnalyzer/Checkers/RetainCoun

r288822 - If clang was configured for a DEFAULT_SYSROOT and no --sysroot argument

Author: joerg Date: Tue Dec 6 10:40:57 2016 New Revision: 288822 URL: http://llvm.org/viewvc/llvm-project?rev=288822&view=rev Log: If clang was configured for a DEFAULT_SYSROOT and no --sysroot argument is seen, record one with the implicit default. Modified: cfe/trunk/lib/Driver/Tools.cpp

[PATCH] D27409: [analyzer] RetainCountChecker: Improve support for libdispatch APIs.

NoQ retitled this revision from "[analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol." to "[analyzer] RetainCountChecker: Improve support for libdispatch APIs.". NoQ updated the summary for this revision. NoQ updated this revision to Diff 80432. No

r288823 - Make test case slightly more robust by explicitly passing --sysroot.

Author: joerg Date: Tue Dec 6 10:47:00 2016 New Revision: 288823 URL: http://llvm.org/viewvc/llvm-project?rev=288823&view=rev Log: Make test case slightly more robust by explicitly passing --sysroot. Otherwise it would change when DEFAULT_SYSROOT is provided. Modified: cfe/trunk/test/Driver/

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks, apologies for the scope creep. https://reviews.llvm.org/D27226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

r288826 - [MS ABI] Implement more of the Itanium mangling rules

Author: majnemer Date: Tue Dec 6 11:01:02 2016 New Revision: 288826 URL: http://llvm.org/viewvc/llvm-project?rev=288826&view=rev Log: [MS ABI] Implement more of the Itanium mangling rules We didn't implement handle corner cases like: - lambdas used to initialize a field - lambdas in default ar

[PATCH] D27226: [MS ABI] Implement more of the Itanium mangling rules

This revision was automatically updated to reflect the committed changes. Closed by commit rL288826: [MS ABI] Implement more of the Itanium mangling rules (authored by majnemer). Changed prior to commit: https://reviews.llvm.org/D27226?vs=80096&id=80437#toc Repository: rL LLVM https://revie

[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

Anastasia added inline comments. Comment at: lib/Sema/SemaStmtAttr.cpp:232 - if (S.getLangOpts().OpenCLVersion < 200) { -S.Diag(A.getLoc(), diag::err_attribute_requires_opencl_version) The comment above refers to v2.0, could we update it reflecting the fac

r288827 - Allow additional output since e.g. OSX appends flags like

Author: joerg Date: Tue Dec 6 11:02:41 2016 New Revision: 288827 URL: http://llvm.org/viewvc/llvm-project?rev=288827&view=rev Log: Allow additional output since e.g. OSX appends flags like "-mlinker-version=264.3.102" automatically. Wiring down a target on the other hand is problematic as this ac

r288828 - Fix FileCheck pattern.

Author: joerg Date: Tue Dec 6 11:06:33 2016 New Revision: 288828 URL: http://llvm.org/viewvc/llvm-project?rev=288828&view=rev Log: Fix FileCheck pattern. Modified: cfe/trunk/test/Driver/compilation_database.c Modified: cfe/trunk/test/Driver/compilation_database.c URL: http://llvm.org/viewv

[PATCH] D27409: [analyzer] RetainCountChecker: Improve support for libdispatch APIs.

dcoughlin added a comment. In https://reviews.llvm.org/D27409#614601, @NoQ wrote: > Not sure we need to stay merged with `retain-release-arc.m`, as we're not > really reusing many declarations across these files. I find it more helpful to organize tests around functionality ('retain count che

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D16533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

rnk added a comment. This highlights an interesting MS/Itanium C++ ABI difference. GCC and Clang emit cleanup landing pads in destructors to ensure that all subobjects are destroyed even if one throws an exception. In Mingw, both GCC and Clang print ~A and ~B for this program, but MSVC does not

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

rjmccall added inline comments. Comment at: include/clang/Basic/TargetInfo.h:306 + /// \param AddrSpace address space of pointee in source language. + virtual uint64_t getNullPtrValue(unsigned AddrSpace) const { +return 0; We normally spell out "Pointer", I

[PATCH] D27408: [analyzer] RetainCountChecker: remove unused enum value; NFC.

zaks.anna added a comment. LGTM. https://reviews.llvm.org/D27408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r288838 - [OpenMP] Fix typo in the test case. NFC.

Author: kli Date: Tue Dec 6 12:50:20 2016 New Revision: 288838 URL: http://llvm.org/viewvc/llvm-project?rev=288838&view=rev Log: [OpenMP] Fix typo in the test case. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_if_messages.cpp Modified: cfe/trunk/test/OpenMP/teams

[PATCH] D27473: Bring back note about not supporting global register variables

mkuper created this revision. mkuper added a reviewer: rengolin. mkuper added a subscriber: cfe-commits. This partially reverts r260506 which removed this note. Renato, the part about "not being implemented soon because it requires backend support" was taken verbatim from the original text, pre-

[PATCH] D27334: [OpenCL] Ambiguous function call.

Anastasia added a comment. In https://reviews.llvm.org/D27334#614389, @bader wrote: > In https://reviews.llvm.org/D27334#613504, @Anastasia wrote: > > > In https://reviews.llvm.org/D27334#612858, @bader wrote: > > > > > In https://reviews.llvm.org/D27334#611703, @Anastasia wrote: > > > > > > > Th

RE: [PATCH] D27334: [OpenCL] Ambiguous function call.

I think we can’t avoid deviating from C/C++ implementation completely. But we should certainly try to avoid it in unnecessary situations as much as we can. In this case it seems like the spec enforces the rules for resolving the ambiguity that seems logical to me. Is this possibly a better way

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D27403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

Hi Vitaly, I noticed that you posted this patch up for review at https://reviews.llvm.org/D27422, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why you did this? I think that you should've waited for approval

Re: r288089 - Avoid lambdas in default member initializers to work around clang bug

This can be reverted now that PR31197 is fixed. I kind of like the new code better, so up to you, Benjamin. On Mon, Nov 28, 2016 at 3:58 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Nov 28 17:58:04 2016 > New Revision: 288089 > > URL: http://llv

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

Hi Alex, On Tue, Dec 6, 2016 at 11:14 AM Alex L wrote: Hi Vitaly, I noticed that you posted this patch up for review at https://reviews.llvm.org/D27422, but then committed it instantly without waiting for approval (and you did the same for r288685 as well). Is there any particular reason why

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

hans added a comment. In https://reviews.llvm.org/D27438#614223, @amaiorano wrote: > In https://reviews.llvm.org/D27438#614219, @hans wrote: > > > When building the snapshots and releases, I usually put the SVN revision > > number in there to avoid this same problem: > > http://llvm-cs.pcc.me.u

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 removed rL LLVM as the repository for this revision. jyu2 updated this revision to Diff 80459. jyu2 added a comment. Update patch to address Reid's suggestion https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: li

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 added a comment. Hi Reid, I know some problems(ms compatibility) when throw inside destructor. I have not yet look like those problems. I am new for clang. I need sometime to catch up. -:) Thank you so much for your code review. I had add new patch to address your suggestion. Pleas

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 set the repository for this revision to rL LLVM. jyu2 updated this revision to Diff 80462. jyu2 added a comment. A typo. Repository: rL LLVM https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: lib/CodeGen/Micro

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

ahatanak created this revision. ahatanak added reviewers: rsmith, doug.gregor. ahatanak added a subscriber: cfe-commits. This patch silences an incorrect warning that is issued when a function pointer is cast to another function pointer type. The warning gets issued because alignments of the sou

Re: r288089 - Avoid lambdas in default member initializers to work around clang bug

Leaving it as it is now is fine with me. On Tue, Dec 6, 2016 at 8:38 PM, Reid Kleckner wrote: > This can be reverted now that PR31197 is fixed. I kind of like the new code > better, so up to you, Benjamin. > > On Mon, Nov 28, 2016 at 3:58 PM, Reid Kleckner via cfe-commits > wrote: >> >> Author:

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

ahatanak updated this revision to Diff 80464. ahatanak added a comment. Call getTypeInfoImpl from getDeclAlign to get the alignment of functions. https://reviews.llvm.org/D27478 Files: lib/AST/ASTContext.cpp test/Sema/warn-cast-align.c Index: test/Sema/warn-cast-align.c ==

[PATCH] D27447: [ASTMatcher] Add hasReplacementType matcher for SubstTemplateTypeParmType

malcolm.parsons updated this revision to Diff 80465. malcolm.parsons added a comment. Use AST_TYPE_TRAVERSE_MATCHER. https://reviews.llvm.org/D27447 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatcher

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

rnk added a comment. Looks pretty good, just one more thing. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1530-1532 +const CXXRecordDecl *ClassDecl = + cast(CGF.CurCodeDecl)->getParent(); +if (ClassDecl != nullptr && ClassDecl->getNumVBases()) ---

r288850 - Disable -Wweak-vtables when there are no key functions

Author: rnk Date: Tue Dec 6 15:44:41 2016 New Revision: 288850 URL: http://llvm.org/viewvc/llvm-project?rev=288850&view=rev Log: Disable -Wweak-vtables when there are no key functions Our -Wweak-vtables diagnostic is powered by our key function calculation, which checks if key functions are enab

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl marked 7 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() &&

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated this revision to Diff 80485. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Changed Ptr in function names to Pointer. Added TargetCodeGenInfo::performAddrSpaceCast. Fixed folding addrspacecast of null pointer with side effect and added

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 added a comment. I changed! Thank you do much. Upload new patch. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1530-1532 +const CXXRecordDecl *ClassDecl = + cast(CGF.CurCodeDecl)->getParent(); +if (ClassDecl != nullptr && ClassDecl->getNumVBases())

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 updated this revision to Diff 80487. jyu2 added a comment. Remove unnecessary check. Repository: rL LLVM https://reviews.llvm.org/D27358 Files: CodeGen/MicrosoftCXXABI.cpp Index: CodeGen/MicrosoftCXXABI.cpp === --- Code

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated this revision to Diff 80488. yaxunl added a comment. Fix some missed function name and remove accidentally added #if 0. https://reviews.llvm.org/D26196 Files: include/clang/AST/APValue.h include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/APValue.cpp

[PATCH] D27422: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

rsmith added a comment. Phabricator doesn't let me retroactively approve, but LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D27422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane created this revision. erichkeane added reviewers: cfe-commits, chandlerc, majnemer. erichkeane set the repository for this revision to rL LLVM. Based on the comment in the test, and my reading of the standard, a deprecated warning should be issued in the following case: template [[dep

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane removed rL LLVM as the repository for this revision. erichkeane updated this revision to Diff 80489. erichkeane added a comment. Corrected single line statement formatting re-squiggly braces. https://reviews.llvm.org/D27486 Files: lib/Sema/SemaTemplate.cpp test/CXX/dcl.dcl/dcl.at

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

jyu2 updated this revision to Diff 80491. jyu2 added a comment. last one missing test part diff. Sorry for that Repository: rL LLVM https://reviews.llvm.org/D27358 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp Index: lib/CodeGen/MicrosoftCXXABI.cp

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

MatzeB added a comment. This breaks the test-suite lit scripts: Exception during script execution: Traceback (most recent call last): File "/Users/mbraun/dev/public_llvm/utils/lit/lit/run.py", line 183, in execute_test result = test.config.test_format.execute(test, self.lit_config) File

Re: [PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

Investigating right now. Sorry for the breakage. On Dec 6, 2016 3:55 PM, "Matthias Braun via Phabricator" < revi...@reviews.llvm.org> wrote: MatzeB added a comment. This breaks the test-suite lit scripts: Exception during script execution: Traceback (most recent call last): File "/Users/mbra

[PATCH] D27486: Correct class-template deprecation behavior

rsmith added a comment. Thanks! If you look at `Sema::InstantiateClass`, we instantiate all of the attributes there. The problem seems to be that that happens only when instantiating the class definition, which happens after the point at which we would diagnose use of a deprecated declaration.

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

rjmccall added inline comments. Comment at: include/clang/AST/APValue.h:379 void setLValue(LValueBase B, const CharUnits &O, NoLValuePath, - unsigned CallIndex); + unsigned CallIndex, bool IsNuppPtr); void setLValue(LValueBase B, const CharUn

r288862 - [OpenMP] Fix typo in the run command in the test case. NFC.

Author: kli Date: Tue Dec 6 17:18:06 2016 New Revision: 288862 URL: http://llvm.org/viewvc/llvm-project?rev=288862&view=rev Log: [OpenMP] Fix typo in the run command in the test case. NFC. Modified: cfe/trunk/test/OpenMP/teams_distribute_parallel_for_simd_ast_print.cpp Modified: cfe/trunk/t

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

dyung created this revision. dyung added a reviewer: kkwli0. dyung added a subscriber: cfe-commits. This test as originally written fails when run with a compiler that defaults to a different C++ standard. This patch fixes up the test and adds testing it explicitly using c++98 and c++11. The cha

Re: [PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

Fixed in r288863. On Tue, Dec 6, 2016 at 4:00 PM, Eric Fiselier wrote: > Investigating right now. Sorry for the breakage. > > On Dec 6, 2016 3:55 PM, "Matthias Braun via Phabricator" < > revi...@reviews.llvm.org> wrote: > > MatzeB added a comment. > > This breaks the test-suite lit scripts: > >

[PATCH] D27488: Fixing test to work when the compiler defaults to a different c++ standard version.

kkwli0 added a comment. I am okay with the changes. Thanks. Alexey will have the final say. https://reviews.llvm.org/D27488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane added a comment. In https://reviews.llvm.org/D27486#615174, @rsmith wrote: > Thanks! > > If you look at `Sema::InstantiateClass`, we instantiate all of the attributes > there. The problem seems to be that that happens only when instantiating the > class definition, which happens afte

r288866 - [c++17] P0135R1: Guaranteed copy elision.

Author: rsmith Date: Tue Dec 6 17:52:28 2016 New Revision: 288866 URL: http://llvm.org/viewvc/llvm-project?rev=288866&view=rev Log: [c++17] P0135R1: Guaranteed copy elision. When an object of class type is initialized from a prvalue of the same type (ignoring cv qualifications), use the prvalue

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

erichkeane added a comment. I'll land it, thanks! Repository: rL LLVM https://reviews.llvm.org/D27358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27345: [OpenMP] Sema and parsing for 'teams distribute parallel for' pragma

kkwli0 marked an inline comment as done. kkwli0 added inline comments. Comment at: lib/Basic/OpenMPKinds.cpp:757 Kind == OMPD_distribute_parallel_for_simd || Kind == OMPD_distribute_simd; // TODO add next directives. ABataev wrote: > Should

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, please commit. If you don't have commit access, ask a coworker who does to land it, otherwise I'll try to get around to it at some point. Thanks for the fix! Repository: rL LLVM htt

r288868 - Address review feedback by adding comments about ${:uid}

Author: rnk Date: Tue Dec 6 18:17:18 2016 New Revision: 288868 URL: http://llvm.org/viewvc/llvm-project?rev=288868&view=rev Log: Address review feedback by adding comments about ${:uid} Modified: cfe/trunk/lib/Sema/SemaStmtAsm.cpp Modified: cfe/trunk/lib/Sema/SemaStmtAsm.cpp URL: http://ll

Re: r288093 - Use ${:uid} to generate unique MS asm labels, not {:uid}

Comments in r288868. It implements GCC's %= inline asm feature, and we're just using it from MS-style inline asm to avoid duplicate labels clashing. 2016-12-01 0:37 GMT-08:00 Sean Silva : > what is this ${:uid} thing? Could the comment > in Sema::GetOrCreateMSAsmLabel explain it? > > -- Sean Silv

[PATCH] D27358: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288869: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor… (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D27358?vs=80491&id=80505#toc Repositor

r288869 - [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code.

Author: erichkeane Date: Tue Dec 6 18:21:45 2016 New Revision: 288869 URL: http://llvm.org/viewvc/llvm-project?rev=288869&view=rev Log: [MS-ABI]V-base dtor called more than needed when throw happens in v-base ctor in window. Need add "complete object flag" check in eh cleanup code. The problem

r288870 - Fix test.

Author: rsmith Date: Tue Dec 6 18:24:40 2016 New Revision: 288870 URL: http://llvm.org/viewvc/llvm-project?rev=288870&view=rev Log: Fix test. Modified: cfe/trunk/test/SemaCXX/cxx1z-copy-omission.cpp Modified: cfe/trunk/test/SemaCXX/cxx1z-copy-omission.cpp URL: http://llvm.org/viewvc/llvm-p

r288872 - Driver: Remove support for -fobjc-gc*

Author: dexonsmith Date: Tue Dec 6 18:31:10 2016 New Revision: 288872 URL: http://llvm.org/viewvc/llvm-project?rev=288872&view=rev Log: Driver: Remove support for -fobjc-gc* As a first step toward removing Objective-C garbage collection from Clang, remove support from the driver. I'm hoping thi

[PATCH] D25796: [CUDA] Create __host__ and device variants of standard allocator declarations.

tra closed this revision. tra added a comment. Landed in r284879. https://reviews.llvm.org/D25796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25669: [Driver] Simplify ToolChain::GetCXXStdlibType (NFC)

zlei added a comment. LGTM https://reviews.llvm.org/D25669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

tra updated this revision to Diff 80522. tra added a comment. Removed HD overloading checks for using declarations. 'using' exposes number of issues with the way we handle overloading of HD functions vs H/D. The issues will be addressed in a separate patch. https://reviews.llvm.org/D25809 File

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano updated this revision to Diff 80527. amaiorano added a comment. Added hour and minute. https://reviews.llvm.org/D27438 Files: tools/clang-format-vs/CMakeLists.txt Index: tools/clang-format-vs/CMakeLists.txt === --- to

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

amaiorano added a comment. > Yes, I think this is still a worthwhile change. Let's add the hour and minute > and get it landed. Alright, added hour and minute. How do we land this change? Is this something I can now do myself? Or would you need to commit this for me again? I have a couple of m

[PATCH] D27409: [analyzer] RetainCountChecker: Improve support for libdispatch APIs.

dcoughlin added a comment. The analyzer currently doesn't do any checking for dispatch retain/release APIs in C. It similarly doesn't do any checking in Objective-C when OS_OBJECT_USE_OBJC is 0 (and thus the dispatch types are defined to their C-struct versions). This happens when the user expl

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson marked 2 inline comments as done. Zeson added a comment. Hi, All. The revision has been updated, please review it again. Thanks a lot. https://reviews.llvm.org/D27251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D27299: [Sema] C++11 opaque enums should avoid the "case value not in enumerated type" switch warning

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. That makes sense. Thanks for the explanation. Repository: rL LLVM https://reviews.llvm.org/D27299 ___ cfe-commits mailing list cfe-commits

[PATCH] D27501: clang-format-vsix: add command to format document

amaiorano created this revision. amaiorano added reviewers: hans, zturner, klimek. amaiorano added a subscriber: cfe-commits. Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the extension to the Readme. https://reviews.llvm.org/D27501 Files: tools/clang-format-vs/.giti

[PATCH] D27501: clang-format-vsix: add command to format document

amaiorano updated this revision to Diff 80533. amaiorano added a comment. My first patch accidentally included the changes from https://reviews.llvm.org/D27440 https://reviews.llvm.org/D27501 Files: tools/clang-format-vs/.gitignore tools/clang-format-vs/ClangFormat/ClangFormat.vsct tools

[PATCH] D25809: [CUDA] Improved target attribute-based overloading.

jlebar added a comment. If you would like me to have another look at this, is it possible to make an interdiff of your changes between this and the last version I reviewed? phab's interdiff is useless because it straddles a rebase. https://reviews.llvm.org/D25809 __

  1   2   >