honggyu.kim added a comment.
I just wrote how I tested this in the bugzilla report page below:
https://llvm.org/bugs/show_bug.cgi?id=28660
https://reviews.llvm.org/D22666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
omtcyfz added a comment.
Well, in this case `SourceMgr` should be removed...
Please accept patches so fast; at least let the others take a look at it.
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
omtcyfz added a comment.
*please don't accept patches so fast
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
if (auto *RD = Loc.getType()->getAsCXXRecordDecl())
return setResult(RD, TypeBeginLoc, TypeEndLoc);
This isn't needed, too...
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zlei created this revision.
zlei added reviewers: cfe-commits, rafael.
Herald added subscribers: samparker, srhines, danalbert, tberghammer, rengolin,
aemerson.
Bug #1: triples like `armv7-pc-linux-musl` uses wrong linker name
`ld-musl-armv7.so.1`; the right name should be `ld-musl-arm.so.1`, di
alexshap added a comment.
inside setResult Decl->getQualifiedNameAsString() is used
so RD should not be nullptr there.
we get there in the newly added test.
https://reviews.llvm.org/D22881
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
omtcyfz added a comment.
In https://reviews.llvm.org/D22881#498911, @alexshap wrote:
> inside setResult Decl->getQualifiedNameAsString() is used
> so RD should not be nullptr there.
> we get there in the newly added test.
It is used, but then we should add this check to setResult, don't we?
alexshap added a comment.
i took a look at handleNestedNameSpecifierLoc:
const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
if (Decl) {
setResult(Decl, NameLoc.getLocalBeginLoc(), NameLoc.getLocalEndLoc());
}
and added this check to VisitTypeLoc.
the other Visit* methods ar
omtcyfz added a comment.
In https://reviews.llvm.org/D22881#498919, @alexshap wrote:
> i took a look at handleNestedNameSpecifierLoc:
>
> const auto *Decl = NameLoc.getNestedNameSpecifier()->getAsNamespace();
> if (Decl) {
>setResult(Decl, NameLoc.getLocalBeginLoc(), NameLoc.getLocalEndLo
NoQ added inline comments.
Comment at: test/Analysis/misc-ps-region-store.m:332
@@ -330,3 +331,3 @@
if (p < q) {
// If we reach here, 'p' cannot be null. If 'p' is null, then 'n' must
// be '0', meaning that this branch is not feasible.
ayartsev wrot
alexshap created this revision.
alexshap added reviewers: omtcyfz, klimek, compnerd.
alexshap added a subscriber: cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Address the comments on the diff D22881.
Remove SourceMgr.
Author: omtcyfz
Date: Thu Jul 28 04:05:06 2016
New Revision: 276967
URL: http://llvm.org/viewvc/llvm-project?rev=276967&view=rev
Log:
[clang-rename] USRFinder.cpp cleanup
Modified:
clang-tools-extra/trunk/clang-rename/USRFinder.cpp
Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cpp
omtcyfz added a comment.
Fixed in https://reviews.llvm.org/rL276967
https://reviews.llvm.org/D22906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap added a comment.
Thanks!
https://reviews.llvm.org/D22906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere added a comment.
Thanks for the reviews everyone!
I'm currently still stuck on an issue I discovered when processing LLVM. I
asked for help on the mailing list [0] but maybe someone here can help.
Basically the issue is that sometimes pointers are passed to memcpy for which
the ty
rogfer01 added a comment.
Hi, friendly ping.
@rsmith any further comment on this?
Thank you very much.
https://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: omtcyfz
Date: Thu Jul 28 05:31:16 2016
New Revision: 276971
URL: http://llvm.org/viewvc/llvm-project?rev=276971&view=rev
Log:
[clang-rename] remove redundant *_cast<> traversal
Modified:
clang-tools-extra/trunk/clang-rename/USRLocFinder.cpp
Modified: clang-tools-extra/trunk/clang-ren
ayartsev added inline comments.
Comment at: test/Analysis/misc-ps-region-store.m:332
@@ -330,3 +331,3 @@
if (p < q) {
// If we reach here, 'p' cannot be null. If 'p' is null, then 'n' must
// be '0', meaning that this branch is not feasible.
zaks.ann
I’m trying to get reviews for this patch that modifies Expr::HasSideEffects in
order to have better support for CXXOperatorCallExpr and i don’t know from who
i can ask review.
Thanks
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
ayartsev added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
zaks.anna wrote:
> ayartsev wrote:
> > zaks.
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:509
@@ +508,3 @@
+ //}
+ // }
+ //}
dcoughlin wrote:
> I disagree about compactness being valuable here. I think it is more
> important to intrinsically docu
andreybokhanko created this revision.
andreybokhanko added a reviewer: hans.
andreybokhanko added a subscriber: cfe-commits.
This add mention of proper support for "__unaligned" type qualifier in 3.9
clang release notes.
https://reviews.llvm.org/D22913
Files:
docs/ReleaseNotes.rst
Index: doc
aaron.ballman added a comment.
Thank you for the patch!
One thing this patch is missing is a test case that exercises this code path.
For instance, there are diagnostics triggered for expressions with side effects
when used as part of an unevaluated expression like sizeof, noexcept, etc. You
s
teemperor updated this revision to Diff 65909.
teemperor added a comment.
- Actually removed the duplicate test now.
https://reviews.llvm.org/D22514
Files:
lib/Analysis/CloneDetection.cpp
test/Analysis/copypaste/false-positives.cpp
test/Analysis/copypaste/functions.cpp
test/Analysis/cop
dsanders updated this revision to Diff 65918.
dsanders added a comment.
Refresh and ping
https://reviews.llvm.org/D21070
Files:
lib/Basic/Targets.cpp
lib/Driver/ToolChains.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
tools/driver/cc1as_main.cpp
Index: tools/driver/cc1
Author: john.brawn
Date: Thu Jul 28 07:48:17 2016
New Revision: 276973
URL: http://llvm.org/viewvc/llvm-project?rev=276973&view=rev
Log:
Reapply r276856 "Adjust Registry interface to not require plugins to export a
registry"
This version has two fixes compared to the original:
* In Registry.h t
Author: john.brawn
Date: Thu Jul 28 07:48:17 2016
New Revision: 276973
URL: http://llvm.org/viewvc/llvm-project?rev=276973&view=rev
Log:
Reapply r276856 "Adjust Registry interface to not require plugins to export a
registry"
This version has two fixes compared to the original:
* In Registry.h t
kparzysz updated this revision to Diff 65919.
kparzysz marked 2 inline comments as done.
kparzysz added a comment.
Removed the cleanup part.
Repository:
rL LLVM
https://reviews.llvm.org/D22766
Files:
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
test/Driv
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.h:36-37
@@ -32,1 +35,4 @@
+private:
+ std::vector ContainersWithPushBack;
+ std::vector SmartPointers;
};
What about `llvm::make_range()`?
https://reviews.llvm.org/D22208
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
I think this j
Abpostelnicu added a comment.
In https://reviews.llvm.org/D22910#499082, @aaron.ballman wrote:
> Thank you for the patch!
>
> One thing this patch is missing is a test case that exercises this code path.
> For instance, there are diagnostics triggered for expressions with side
> effects when us
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 65928.
yaxunl added a comment.
Use 'opencl.sampler_t' as opque type name for sampler in LLVM IR.
https://reviews.llvm.org/D21567
Files:
include/clang/AST/OperationKinds.def
include/clang/Basic/DiagnosticGroup
aaron.ballman added a comment.
I don't suppose there's a way to test these changes, is there?
Comment at: include/llvm/Support/MathExtras.h:682
@@ +681,3 @@
+
+// alignTo for contexts where a constant expression is required.
+// FIXME: remove when LLVM_CONSTEXPR becomes really c
Author: sfantao
Date: Thu Jul 28 09:23:26 2016
New Revision: 276977
URL: http://llvm.org/viewvc/llvm-project?rev=276977&view=rev
Log:
[OpenMP] Codegen for use_device_ptr clause.
Summary: This patch adds support for the use_device_ptr clause. It includes
changes in SEMA that could not be tested w
Author: sfantao
Date: Thu Jul 28 09:25:09 2016
New Revision: 276978
URL: http://llvm.org/viewvc/llvm-project?rev=276978&view=rev
Log:
[OpenMP] Code generation for the is_device_ptr clause
Summary: This patch adds support for the is_device_ptr clause. It expands SEMA
to use the mappable expressio
Author: sfantao
Date: Thu Jul 28 09:29:18 2016
New Revision: 276979
URL: http://llvm.org/viewvc/llvm-project?rev=276979&view=rev
Log:
[OpenMP][CUDA] Do not forward OpenMP flags for CUDA device actions.
Summary:
This patch prevents OpenMP flags from being forwarded to CUDA device commands.
That w
aaron.ballman added a subscriber: klimek.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:44-54
@@ +43,13 @@
+if (OriginalText == "::std::move") {
+ Diag << FixItHint::CreateReplacement(CallRange, "::std::" + ForwardName);
+ // If the original text was s
aaron.ballman added inline comments.
Comment at: include/llvm/Support/MathExtras.h:672
@@ -669,2 +671,3 @@
inline uint64_t alignTo(uint64_t Value, uint64_t Align, uint64_t Skew = 0) {
+ assert(Align != 0u);
Skew %= Align;
Usually preferred to put in && "ratio
Author: sfantao
Date: Thu Jul 28 09:47:35 2016
New Revision: 276981
URL: http://llvm.org/viewvc/llvm-project?rev=276981&view=rev
Log:
[OpenMP] Do not use default argument in lambda from mappable expressions
handlers.
Windows bots were complaining about that.
Modified:
cfe/trunk/lib/CodeGen
Author: sfantao
Date: Thu Jul 28 09:56:19 2016
New Revision: 276983
URL: http://llvm.org/viewvc/llvm-project?rev=276983&view=rev
Log:
[OpenMP] Fix link command pattern in offloading interoperability test.
It was causing a few bots to fail.
Modified:
cfe/trunk/test/Driver/offloading-interope
I see, thanks.
I've taken a second look at the patch and it seems straight-forward to
me, so I've merged it in r276985.
Cheers,
Hans
On Wed, Jul 27, 2016 at 5:16 PM, David Majnemer
wrote:
> I hear that he is on vacation.
>
>
> On Wednesday, July 27, 2016, Hans Wennborg via cfe-commits
> wrote:
rengolin added a comment.
Hi Lei,
Thanks for the fix. A few comments. Also, please, add some tests.
cheers,
--renato
Comment at: lib/Driver/ToolChains.cpp:4266
@@ -4266,1 +4265,3 @@
+ if (Triple.isAndroid()) {
return Triple.isArch64Bit() ? "/system/bin/linker64" :
"/sys
Author: sfantao
Date: Thu Jul 28 10:31:29 2016
New Revision: 276988
URL: http://llvm.org/viewvc/llvm-project?rev=276988&view=rev
Log:
[OpenMP] Change name of variable in mappble expression.
This attempts to fix a failure in Windows bots pottentially related with a
reserved keyword.
Modified:
I’ve put this review up on the Phabricator site so that it is easier to look
at, see here: https://reviews.llvm.org/D22919
Thanks!
-Erich
From: David Majnemer [mailto:david.majne...@gmail.com]
Sent: Monday, July 25, 2016 1:18 PM
To: Keane, Erich
Cc: cfe-commits@lists.llvm.org
Subject: Re: [Revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276994: Mention of proper support for "__unaligned" type
qualifier in 3.9 clang… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D22913?vs=65914&id=65943#toc
Repository:
rL LLVM
kimgr added a comment.
This is probably not the right place for this discussion, but I thought I'd
offer one more note.
Comment at: include/string_view:216
@@ +215,3 @@
+ basic_string_view(const _CharT* __s)
+ : __data(__s), __size(_Traits::length(__s)) {}
+
rnk created this revision.
rnk added reviewers: amccarth, aprantl, dblaikie, dexonsmith.
rnk added a subscriber: cfe-commits.
rnk added a dependency: D22884: [codeview] Emit vftable records.
MSVC emits codeview records describing all the methods contained in a
vftable. This is observable in windbg
Author: sfantao
Date: Thu Jul 28 11:12:30 2016
New Revision: 276995
URL: http://llvm.org/viewvc/llvm-project?rev=276995&view=rev
Log:
[CUDA] Rename cuda_phases.cu test to cuda-phases.cu to be consistent with the
other tests.
Added:
cfe/trunk/test/Driver/cuda-phases.cu
Added: cfe/trunk/test/
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM as-is, clang's behavior would be congruent with GCC's.
Comment at: lib/Parse/ParseDeclCXX.cpp:3024-3026
@@ -3013,2 +3023,5 @@
Diag(FinalLoc, diag::ext_ms_seale
Author: sfantao
Date: Thu Jul 28 11:18:31 2016
New Revision: 276996
URL: http://llvm.org/viewvc/llvm-project?rev=276996&view=rev
Log:
[CUDA] Remove duplicated test that should have been removed in r276995.
Removed:
cfe/trunk/test/Driver/cuda_phases.cu
Removed: cfe/trunk/test/Driver/cuda_phas
erichkeane removed rL LLVM as the repository for this revision.
erichkeane updated this revision to Diff 65951.
https://reviews.llvm.org/D22919
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Parse/Parser.h
include/clang/Sema/DeclSpec.h
lib/Parse/ParseDeclCXX.cpp
lib/Sem
erichkeane marked an inline comment as done.
erichkeane added a comment.
Fixed the braces mentioned.
https://reviews.llvm.org/D22919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sorry for the delay, I had forgotten about this. I will check it in today.
On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
> comicfans44 added a comment.
>
> In https://reviews.llvm.org/D21946#473071, @zturner wrote:
>
> > In https://reviews.llvm.org/D21946#473070, @comicfans44 wrote:
> >
>
klimek added a subscriber: klimek.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:83
@@ -80,3 +82,3 @@
if (const auto *Used = Result.Nodes.getNodeAs("used")) {
-if (const auto *Specialization =
-dyn_cast(Used))
+if (const auto *FD = dyn_cast(Used)) {
NoQ added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:91
@@ +90,3 @@
+ ASTContext &Context;
+ std::vector &CollectedData;
+
Maybe it's a good idea to introduce a typedef for `unsigned` here, because it'd
be nice to be able to change it (eg., so
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks! Could you please address these small comments before committing!
Comment at: lib/Sema/SemaInit.cpp:6959
@@ +6958,3 @@
+// this has already been don
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D22913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Should we merge this to 3.9?
Cheers,
Hans
On Thu, Jul 28, 2016 at 7:29 AM, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Thu Jul 28 09:29:18 2016
> New Revision: 276979
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276979&view=rev
> Log:
> [OpenMP][CUDA] Do not forward OpenMP
Hi Hans,
I think it should. All the stuff that enables this fix seems to be in 3.9 already.
Thanks!
Samuel
- Original message -From: Hans Wennborg Sent by: hwennb...@google.comTo: Samuel F Antao/Watson/IBM@IBMUS, "Bataev, Alexey" Cc: cfe-commits Subject: Re: r276979 - [OpenMP][CUDA]
I've merged it in r277004.
Cheers,
Hans
On Thu, Jul 28, 2016 at 10:15 AM, Samuel F Antao wrote:
> Hi Hans,
>
> I think it should. All the stuff that enables this fix seems to be in 3.9
> already.
>
> Thanks!
> Samuel
>
>
>
> - Original message -
> From: Hans Wennborg
> Sent by: hwennb..
Author: zturner
Date: Thu Jul 28 12:13:32 2016
New Revision: 277005
URL: http://llvm.org/viewvc/llvm-project?rev=277005&view=rev
Log:
[Driver] Fix Windows SDK Detection
This fixes a couple of bugs in Windows SDK Detection.
1. `readFullStringValue` returns a bool, but was being compared
with E
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277005: [Driver] Fix Windows SDK Detection (authored by
zturner).
Changed prior to commit:
https://reviews.llvm.org/D21946?vs=62570&id=65958#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21946
Committed in r277005
On Thu, Jul 28, 2016 at 9:38 AM Zachary Turner wrote:
> Sorry for the delay, I had forgotten about this. I will check it in today.
>
> On Wed, Jul 27, 2016 at 5:57 PM comicfans44 wrote:
>
>> comicfans44 added a comment.
>>
>> In https://reviews.llvm.org/D21946#473071, @ztu
Author: john.brawn
Date: Thu Jul 28 12:17:22 2016
New Revision: 277008
URL: http://llvm.org/viewvc/llvm-project?rev=277008&view=rev
Log:
Revert r276973 "Adjust Registry interface to not require plugins to export a
registry"
Buildbot failures when building with clang -Werror. Reverting while I tr
Author: john.brawn
Date: Thu Jul 28 12:17:22 2016
New Revision: 277008
URL: http://llvm.org/viewvc/llvm-project?rev=277008&view=rev
Log:
Revert r276973 "Adjust Registry interface to not require plugins to export a
registry"
Buildbot failures when building with clang -Werror. Reverting while I tr
yaxunl marked 2 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:6961
@@ +6960,3 @@
+// the initializer.
+if (!Init->isConstantInitializer(S.Context, false))
+ break;
Anastasia wrote:
> I think you don't need this check any more
Author: dcoughlin
Date: Thu Jul 28 12:18:33 2016
New Revision: 277009
URL: http://llvm.org/viewvc/llvm-project?rev=277009&view=rev
Log:
[analyzer] Fix misleading indentation in ObjCDeallocChecker. NFC.
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp
Modified: cfe/trunk/l
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D22767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6961
@@ +6960,3 @@
+// the initializer.
+if (!Init->isConstantInitializer(S.Context, false))
+ break;
yaxunl wrote:
> Anastasia wrote:
> > I think you don't need this check
kulpreet created this revision.
kulpreet added reviewers: zaks.anna, dcoughlin.
kulpreet added a subscriber: cfe-commits.
- Added in new iOS and macOS APIs that require a localized string
- Removed two APIs that incorrectly were marked as requiring a localized
string
https://reviews.llv
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
The size of image type is reported incorrectly as size of a pointer to address
space 0, which causes error when casting image type to pointers by
__builtin_astype.
The fix is to
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
Comments about the comment, but otherwise, LGTM.
Comment at: lib/CodeGen/CodeGenFunction.cpp:789
@@ -796,1 +788,3 @@
+ // Since emitting mcount call here impacts optimiza
szepet updated this revision to Diff 65966.
szepet marked 12 inline comments as done.
szepet added a comment.
updates based on comments, counter and search functions replaced by std
functions
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/EnumMisuseCh
szepet marked 2 inline comments as done.
szepet added a comment.
https://reviews.llvm.org/D22507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yaxunl
Date: Thu Jul 28 14:26:30 2016
New Revision: 277024
URL: http://llvm.org/viewvc/llvm-project?rev=277024&view=rev
Log:
[OpenCL] Generate opaque type for sampler_t and function call for the
initializer
Currently Clang use int32 to represent sampler_t, which have been a source of
is
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL277024: [OpenCL] Generate opaque type for sampler_t and
function call for the… (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D21567?vs=
ahatanak created this revision.
ahatanak added reviewers: doug.gregor, akyrtzi.
ahatanak added a subscriber: cfe-commits.
This patch fixes a stack overflow bug in ASTContext::getObjCEncodingForTypeImpl
where it keeps expanding a class recursively. I added a check to avoid
expanding a class if Ex
dtarditi created this revision.
dtarditi added a reviewer: erik.pilkington.
dtarditi added a subscriber: cfe-commits.
r272587 (http://reviews.llvm.org/D20490) fixed an issue where typo correction
could cause a crash when compiling C programs.The problem was that a typo
expression could be in
kbdsmoke created this revision.
kbdsmoke added a subscriber: cfe-commits.
kbdsmoke set the repository for this revision to rL LLVM.
clang does not support this by default. By default, if you want to utilize
__declspec to assign a SectionAttr to a function, you should use __declspec
allocate.
How
rnk added a subscriber: rnk.
rnk added a comment.
Needs tests, though. The MSDN sample code is probably a good starting point.
Comment at: lib/Sema/SemaDeclAttr.cpp:2659
@@ -2658,1 +2658,3 @@
+ // code_seg only ever applies to functions.
+ if (Attr.getName()->getName() == "c
majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision now requires changes to proceed.
Thanks for contributing this! I actually worked on an implementation of this
feature but never sent it
sbenza added inline comments.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:93
@@ +92,3 @@
+ hasArgument(0, ignoringParenImpCasts(declRefExpr(
+ to(ForwardingReferenceParmMatcher)
+ .bind("call-move"),
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277029: [analyzer] Update the web manual for checker
developers. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22874?vs=65762&id=65979#toc
Repository:
rL LLVM
https://r
Hi Mike,
I've already pushed r276981 and r276988 to fix those failures shortly after I pushed the patch. After that I didn't receive any bot message complaining about that code.
Do you still see the issues?
Thanks,
Samuel
- Original message -From: Mike Aizatsky To: Samuel F Antao/W
dcoughlin added a comment.
This doesn't compile for me. It looks like there are two separate declarations
of 'buttonWithTitleNSButton'.
https://reviews.llvm.org/D22926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
kbdsmoke added a comment.
Indeed I was incorrect, and I agree with your analysis of the problem @majnemer
I'll try to correct this issue in my own time and get some tests going
Repository:
rL LLVM
https://reviews.llvm.org/D22931
___
cfe-commits
Author: dergachev
Date: Thu Jul 28 15:13:14 2016
New Revision: 277029
URL: http://llvm.org/viewvc/llvm-project?rev=277029&view=rev
Log:
[analyzer] Update the web manual for checker developers.
Fix the explanation of how to run tests after migration
from autotools to cmake.
Significantly expand t
rjmccall added a comment.
LGTM, too.
https://reviews.llvm.org/D22666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kulpreet updated this revision to Diff 66006.
kulpreet added a comment.
Sorry, uploaded the wrong patch. This one should compile with the unique
variable names.
https://reviews.llvm.org/D22926
Files:
lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp
Index: lib/StaticAnalyzer/Checkers/Loca
yaxunl created this revision.
yaxunl added reviewers: Anastasia, nhaustov.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Let the driver pass the option to frontend. Do not set precision metadata for
division instructions when this option is set. Set function attribute
"correctly-rounded-di
jbcoe updated this revision to Diff 66011.
jbcoe added a comment.
Minor changes from review.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsC
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
aaron.ballman wrote:
>
manmanren added a comment.
Yes, this still looks good to me. Please commit.
Manman
https://reviews.llvm.org/D22697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 66017.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 66016.
sfantao added a comment.
- Remove redundant phases from cuda-phases.cu and use DAG check.
- Rebase.
https://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
test/Driver/cuda-phases.cu
Index: test/Driver/c
sfantao updated this revision to Diff 66018.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool
sfantao updated this revision to Diff 66019.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/
sfantao updated this revision to Diff 66020.
sfantao added a comment.
- Add option to dump and test the linker script contents.
- Rebase.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index
sfantao updated this revision to Diff 66023.
sfantao added a comment.
- Fix bug in conditional.
- Rebase.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-
1 - 100 of 144 matches
Mail list logo
