Re: r272247 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

On Thu, Jun 9, 2016 at 7:26 AM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Thu Jun 9 00:26:56 2016 > New Revision: 272247 > > URL: http://llvm.org/viewvc/llvm-project?rev=272247&view=rev > Log: > [Sema] Don't crash when a field w/ a mem-initializer clashes with a record > n

[PATCH] D21175: [include-fixer] do not index friend function declaration.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. we want to exclude friend declaration, but the `DeclContext` of a friend function declaration is not the class in which it is declared, so we need to explicitly check if the parent is a `friendD

r272253 - clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86.

Author: chapuni Date: Thu Jun 9 05:06:13 2016 New Revision: 272253 URL: http://llvm.org/viewvc/llvm-project?rev=272253&view=rev Log: clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86. Modified: cfe/trunk/test/CodeGenCXX/debug-info-method.cpp Modified:

Re: r271918 - Add a release note about the --build-id change.

On Mon, Jun 6, 2016 at 11:23 AM, Rafael Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafael > Date: Mon Jun 6 13:23:11 2016 > New Revision: 271918 > > URL: http://llvm.org/viewvc/llvm-project?rev=271918&view=rev > Log: > Add a release note about the --build-id change.

[PATCH] D21176: Mark invalid RecordDecls as completed.

erikjv created this revision. erikjv added a reviewer: rsmith. erikjv added a subscriber: cfe-commits. Sema::ActOnTag creates TagDecls for records. However, if those record declarations are invalid, and the parser is in C++ mode, it would silently drop the TagDecl (and leave it as "beingDefined").

Re: [PATCH] D18080: CIndex: add support for static_assert

ogoffart added a comment. Ping 2. http://reviews.llvm.org/D18080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18081: Make sizeof and alignof a CXCursor_UnaryExpr

ogoffart added a comment. Ping 2. http://reviews.llvm.org/D18081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19763: Functions declared in a scope should not hide previous declaration in earlier scopes

ogoffart added a comment. Ping. This would be required for http://reviews.llvm.org/D19764 http://reviews.llvm.org/D19763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jholewinski added a comment. Looks reasonable to me. http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

rs created this revision. rs added reviewers: t.p.northover, rengolin. rs added a subscriber: cfe-commits. Patch adds support for the intrinsics mrrc/mrrc2 and updates the existing mcrr/mcrr2 intrinsic definition to accept a single uint64 type as the input value instead of 2 uint32's as I think

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

rs added a comment. LLVM part of the patch is here http://reviews.llvm.org/D21178 http://reviews.llvm.org/D21179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20821: Fix a few issues while skipping function bodies

ogoffart added a comment. The idea is that when we see a ") {" or "} {" in the ctor-initializers, (optionally with "..."), it is necessarily the start of the body. Unless there might be lambda expressions within a template aregument, as in: A::A() : Base<[](){return 42; }()>(){} But t

[PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

zvi created this revision. zvi added reviewers: aaboud, mkuper, echristo, cfe-commits. zvi set the repository for this revision to rL LLVM. zvi added a project: clang-c. Herald added a subscriber: mehdi_amini. This patch adds support for the _MM_ALIGN16 attribute on non-windows targets. This alig

Re: [PATCH] D18081: Make sizeof and alignof a CXCursor_UnaryExpr

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D18081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D18080: CIndex: add support for static_assert

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine http://reviews.llvm.org/D18080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D21175: [include-fixer] do not index friend function declaration.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Makes sense. http://reviews.llvm.org/D21175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r272260 - Replace an ambiguous "it"

Author: rafael Date: Thu Jun 9 08:35:55 2016 New Revision: 272260 URL: http://llvm.org/viewvc/llvm-project?rev=272260&view=rev Log: Replace an ambiguous "it" Thanks to Sean for the suggestion. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://

[PATCH] D21181: [include-fixer] give users an option to show N more headers in case there are too many candidates.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. give users an option to show N more headers in case there are too many candidates. http://reviews.llvm.org/D21181 Files: include-fixer/tool/clang-include-fixer.py Index: include-fixer/tool

Re: [PATCH] D21175: [include-fixer] do not index friend function declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272261: [include-fixer] do not index friend function declaration. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21175?vs=60147&id=60168#toc Repository: rL LLVM http://revie

[clang-tools-extra] r272261 - [include-fixer] do not index friend function declaration.

Author: ioeric Date: Thu Jun 9 09:18:40 2016 New Revision: 272261 URL: http://llvm.org/viewvc/llvm-project?rev=272261&view=rev Log: [include-fixer] do not index friend function declaration. Summary: we want to exclude friend declaration, but the `DeclContext` of a friend function declaration is

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. In http://reviews.llvm.org/D20933#452854, @dcoughlin wrote: > A 6% speed improvement could be a big win! Do we have a sense of what the > expected increased memory cost (as a % of average use over the lifetime of > the process) is? My guess is it would be relatively low.

Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

On Thursday, June 9, 2016, Zvi Rackover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > zvi created this revision. > zvi added reviewers: aaboud, mkuper, echristo, cfe-commits. > zvi set the repository for this revision to rL LLVM. > zvi added a project: clang-c. > Herald added a subscriber

Re: r272247 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

It would mean that the instantiation of the class template gained a field which should be impossible. On Thursday, June 9, 2016, Kim Gräsman wrote: > On Thu, Jun 9, 2016 at 7:26 AM, David Majnemer via cfe-commits > > wrote: > > Author: majnemer > > Date: Thu Jun 9 00:26:56 2016 > > New Revision

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor updated this revision to Diff 60176. teemperor added a comment. Reduced executable size bloat. Made postorder and preorder mutually exclusive and postorder also uses the normal Visit* methods for callbacks. http://reviews.llvm.org/D20382 Files: include/clang/AST/RecursiveASTVisitor

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor added a comment. Agreed. The new patch is now reusing the Visit methods so that the executable size stays the same. The downside is that you can no longer create a Visitor that is both post- and preorder traversing, but I don't think there is any major use case for that. http://revie

Re: r272247 - [Sema] Don't crash when a field w/ a mem-initializer clashes with a record name

On Thu, Jun 9, 2016 at 4:51 PM, David Majnemer wrote: > It would mean that the instantiation of the class template gained a field > which should be impossible. OK, so assert(Lookup.size() > 0) always holds? Makes sense, thanks. - Kim ___ cfe-commits ma

[libcxx] r272263 - Two more issues w/patches

Author: marshall Date: Thu Jun 9 09:50:38 2016 New Revision: 272263 URL: http://llvm.org/viewvc/llvm-project?rev=272263&view=rev Log: Two more issues w/patches Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm

Re: r272253 - clang/test/CodeGenCXX/debug-info-method.cpp: Tweak for thiscall, for targeting Win32 x86.

Reid - is this intended fallout? (seems plausible, but just checking) Is MinGW a good analogy for any of this work? (does it produce DWARF? Does it use the Windows ABI? Does it emit Calling Convention attributes?) On Thu, Jun 9, 2016 at 3:06 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists

Re: [A fix related to closing C++ header file descriptors on windows]

Hi Manuel, I had forgotten this point and I see your mail only now... Thanks for your interest. I did not evaluate this issue with a newer release of clang (issue seen in 3.6.2) However, it seems that other people still have this kind of issue for several months. https://bugreports.qt.io/browse/

[PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

vsk created this revision. vsk added reviewers: aaron.ballman, alexfh. vsk added a subscriber: cfe-commits. Introduce a check which suggests when it might be helpful to use "emplace" methods. The initial version only works with std::vector and push_back (e.g `V.push_back(T(1, 2))` -> `V.emplace_

[PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. It has no RTTI, so the test would always fail in a non-interesting way. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index: test/clang-rename/DynamicCastExp

Re: [PATCH] D21120: clang-rename: implement renaming of classes inside dynamic_cast

vmiklos added a comment. Possible solution posted as http://reviews.llvm.org/D21186. Repository: rL LLVM http://reviews.llvm.org/D21120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r272273 - CIndex: add support for static_assert

Author: ogoffart Date: Thu Jun 9 11:15:55 2016 New Revision: 272273 URL: http://llvm.org/viewvc/llvm-project?rev=272273&view=rev Log: CIndex: add support for static_assert Differential Revision: http://reviews.llvm.org/D18080 Modified: cfe/trunk/include/clang-c/Index.h cfe/trunk/lib/Sem

r272274 - Make sizeof and alignof a CXCursor_UnaryExpr

Author: ogoffart Date: Thu Jun 9 11:16:06 2016 New Revision: 272274 URL: http://llvm.org/viewvc/llvm-project?rev=272274&view=rev Log: Make sizeof and alignof a CXCursor_UnaryExpr So we can match sizeof expressions more accurately than with UnexposedExpr Differential Revision: http://reviews.llv

Re: [PATCH] D18081: Make sizeof and alignof a CXCursor_UnaryExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL272274: Make sizeof and alignof a CXCursor_UnaryExpr (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D18081?vs=50408&id=60187#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D18080: CIndex: add support for static_assert

This revision was automatically updated to reflect the committed changes. Closed by commit rL272273: CIndex: add support for static_assert (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D18080?vs=50407&id=60186#toc Repository: rL LLVM http://reviews.llvm.org/D18080

r272275 - [CMake] Fix an issue building out-of-tree introduced in r272200

Author: cbieneman Date: Thu Jun 9 11:21:10 2016 New Revision: 272275 URL: http://llvm.org/viewvc/llvm-project?rev=272275&view=rev Log: [CMake] Fix an issue building out-of-tree introduced in r272200 The out-of-tree build needs to read LLVM_TOOLS_INSTALL_DIR out of TOOLS_BINARY_DIR because LLVM_

Re: [PATCH] D21163: Strip Android version when looking up toolchain paths.

t.p.northover added a subscriber: t.p.northover. t.p.northover added a comment. This could do with a test in test/Driver. http://reviews.llvm.org/D21163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen marked an inline comment as done. timshen added a comment. Ping? :) http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added a comment. (Art, I would appreciate a second set of eyes on this one, as the last time I did this -- with ldg -- I messed up pretty badly.) http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Miklos, This revision broke tests on one of builders: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please have a look at this? Thanks Galina On Wed, Jun 8, 2016 at 11:38 AM, Miklos Vajna via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Au

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added a comment. Thank you for the reviews, Justin! http://reviews.llvm.org/D21162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21187: Allow use of lambda expressions in array bounds

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. clang currently errors out when a lambda expression is used to compute the size of an array even though clang supports variable-length arrays as a C99 extension. For example, $ cat vla1.cpp ``` int foo3(); struct S1 {

Re: [clang-tools-extra] r272188 - clang-rename: implement renaming of classes inside dynamic_cast

Hi Galina, On Thu, Jun 09, 2016 at 10:15:27AM -0700, Galina Kistanova wrote: > This revision broke tests on one of builders: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/14332 Please accept if it's the correct fix. It fix

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

vsk added a reviewer: flx. vsk updated this revision to Diff 60194. vsk added a comment. - Fix handling of push_back(X(/* comment */)). - Don't try to emit a warning when the callee comes from a macro expansion. - Get rid of a weird/wrong comment about checking for "default constructors". As a si

r272280 - Revert "[CMake] Fix an issue building out-of-tree introduced in r272200"

Author: cbieneman Date: Thu Jun 9 12:24:16 2016 New Revision: 272280 URL: http://llvm.org/viewvc/llvm-project?rev=272280&view=rev Log: Revert "[CMake] Fix an issue building out-of-tree introduced in r272200" This reverts r272275. This actually wasn't the right way to fix the problem. The correc

Java Interface for clang

Hello everybody, I want to use clang and its facilities to parse c and c++ . but I need to use it in java. In my searches , saw jClang or Clang bindings for java, checking the date of pages returned to me was before 2015. so I know what is the status of jclang or is there any solution to use clang

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

tra added inline comments. Comment at: lib/Headers/__clang_cuda_intrinsics.h:77-80 @@ +76,6 @@ +_Static_assert(sizeof(__tmp) == sizeof(__in)); \ +memcpy(&__tmp, &__in, sizeof(__in)); \ +__tmp = ::__FnN

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

vsk updated this revision to Diff 60206. vsk added a comment. - Fix the diagnostic message. Suggested by Erik Pilkington. http://reviews.llvm.org/D21185 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/EmplaceCheck.cpp clang-tidy/performance/EmplaceCheck.h clang-tidy/

Re: [PATCH] D20444: [OpenCL] Include opencl-c.h by default as a clang module

Anastasia added inline comments. Comment at: test/Headers/opencl-c-header.cl:70 @@ +69,3 @@ +// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o - -finclude-default-header -fmodules -fimplicit-module-maps -fmodules-cache-path=%t %s | FileCheck %s +// RUN: %clang_cc1 -t

Re: [PATCH] D20979: [OpenCL] Use function attribute/metadata to represent kernel attributes

Anastasia added a comment. In http://reviews.llvm.org/D20979#452616, @yaxunl wrote: > In http://reviews.llvm.org/D20979#452463, @Anastasia wrote: > > > Looking good generally, I am just not sure about mixing two different > > representations. > > > If we choose only one form of representation, w

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

hans added a comment. Is this waiting for anything more now that http://reviews.llvm.org/D20346 has landed? http://reviews.llvm.org/D20347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[libcxx] r272288 - Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change.

Author: marshall Date: Thu Jun 9 13:34:38 2016 New Revision: 272288 URL: http://llvm.org/viewvc/llvm-project?rev=272288&view=rev Log: Make the comparison objects that we pass in for various tests look more like actual comparison objects. No functional change. Modified: libcxx/trunk/test/st

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 added a comment. Can someone have a look at this now that there's a test? http://reviews.llvm.org/D20132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added a comment. This is a fairly important bug for anyone hosting clang as a library (e.g. IDEs). Can someone have a look at this patch when they have a free moment? http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commit

Re: [PATCH] D20328: [libcxx] Externally threaded libc++ variant

rmaprath added a comment. @mclow.lists, @EricWF: Gentle (and shameless) ping! http://reviews.llvm.org/D20328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

Thanks the suggestion, David. I did not realize __attribute__ is supported by Windows targets. Zvi From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Thursday, June 09, 2016 17:48 To: reviews+d21173+public+9a6e31402e430...@reviews.llvm.org; Rackover, Zvi Cc: Aboud, Amjad ; mku...@goo

Re: [PATCH] D21173: [X86] _MM_ALIGN16 attribute support for non-windows targets

zvi updated this revision to Diff 60217. zvi added a comment. Following David Majnemer's suggestion on cfe-commits: I would just use the __attribute__ spelling, no need for two definitions Repository: rL LLVM http://reviews.llvm.org/D21173 Files: lib/Headers/xmmintrin.h test/Headers/xmm

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

Fwd: Java Interface for clang

Hello everybody, I want to use clang and its facilities to parse c and c++ . but I need to use it in java. In my searches , saw jClang or Clang bindings for java, checking the date of pages returned to me was before 2015. so I know what is the status of jclang or is there any solution to use clang

Re: [PATCH] D20347: Add support to clang-cl driver for /GS switch

thakis added a comment. probably at least the "the XOR with RSP/EBP/ESP" bit still (and maybe EH function upgrades instead of bailing) Comment at: lib/Driver/Tools.cpp:9990 @@ +9989,3 @@ + /*default=*/false)) +CmdArgs.push_back("/GS-"); +

Re: [PATCH] D19854: Define Contiki OS toolchain

eugenis added a comment. This needs a driver test. http://reviews.llvm.org/D19854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. See also http://reviews.llvm.org/D20964. I think modernize is better place for such check. http://reviews.llvm.org/D21185 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Eugene.Zelenko added a comment. There are alternative implementation in http://reviews.llvm.org/D21185. Will be good idea to how one which take the best from both :-) http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. > If the underlying allocator that does a poor job at reusing freed memory, > then trivial > functions will use about 1 MB more than before, then free the memory > immediately. You could probably flag some of those functions, especially the ones that do not conta

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar updated this revision to Diff 60223. jlebar marked 2 inline comments as done. jlebar added a comment. Update after tra's review. http://reviews.llvm.org/D21162 Files: include/clang/Basic/BuiltinsNVPTX.def lib/Headers/__clang_cuda_intrinsics.h lib/Headers/__clang_cuda_runtime_wrappe

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

jlebar added inline comments. Comment at: lib/Headers/__clang_cuda_intrinsics.h:77-80 @@ +76,6 @@ +_Static_assert(sizeof(__tmp) == sizeof(__in)); \ +memcpy(&__tmp, &__in, sizeof(__in)); \ +__tmp = ::__

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

erik.pilkington added a comment. Pong!! http://reviews.llvm.org/D20490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272296 - [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr.

Author: timshen Date: Thu Jun 9 14:54:46 2016 New Revision: 272296 URL: http://llvm.org/viewvc/llvm-project?rev=272296&view=rev Log: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr. These ExprWithCleanups are added for holding a RunCleanupsScope not for destructor calls

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely updated this revision to Diff 60226. jvesely added a comment. Test all known extensions against expected nvptx outcome (add negative tests) Repository: rL LLVM http://reviews.llvm.org/D20389 Files: lib/Basic/Targets.cpp test/Misc/nvptx.languageOptsOpenCL.cl Index: test/Misc/nvpt

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL272296: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr. (authored by timshen). Changed prior to commit: http://reviews.llvm.org/D20498?vs=58694&id=60227#toc Repository: rL

Re: [PATCH] D20389: NVPTX: Add supported CL features

jvesely marked 2 inline comments as done. jvesely added a comment. Repository: rL LLVM http://reviews.llvm.org/D20389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272299 - [CUDA] Implement __shfl* intrinsics in clang headers.

Author: jlebar Date: Thu Jun 9 15:04:57 2016 New Revision: 272299 URL: http://llvm.org/viewvc/llvm-project?rev=272299&view=rev Log: [CUDA] Implement __shfl* intrinsics in clang headers. Summary: Clang changes to make use of the LLVM intrinsics added in D21160. Reviewers: tra Subscribers: jhole

Re: [PATCH] D21162: [CUDA] Implement __shfl* intrinsics in clang headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL272299: [CUDA] Implement __shfl* intrinsics in clang headers. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D21162?vs=60223&id=60230#toc Repository: rL LLVM http://reviews.l

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

vsk added a subscriber: vsk. vsk added a comment. @Eugene.Zelenko thanks for pointing this out, I had totally missed this patch! Once we get this reviewed I'm willing to abandon my version. Some comments inline -- Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:26 @@ +25,

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig updated this revision to Diff 60177. bcraig added a comment. Capping the pre-reserve space http://reviews.llvm.org/D20933 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h lib/StaticAnalyzer/Core/CoreEngine.cpp Index: lib/StaticAnalyzer/Core/CoreEngine.cpp =

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

bcraig added a comment. I got better valgrind numbers (symbols are important). Before: 106,131,538 After: 106,657,666 Diff: 526,128 larger. Note that this is sampled peaks for heap usage. They may not be accurate. Regardless, the peak usage increased by less than .5%. http://reviews.llvm.org

Re: [PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

rsmith added inline comments. Comment at: lib/Parse/ParseExpr.cpp:450-452 @@ -449,1 +449,5 @@ + +// In this case, ActOnBinOp performed the CorrectDelayedTyposInExpr check. +if (!getLangOpts().CPlusPlus) + continue; } else { The inc

Re: [PATCH] D21187: Allow use of lambda expressions in array bounds

rsmith added a subscriber: rsmith. Comment at: lib/Sema/SemaExpr.cpp:12825 @@ -12824,1 +12824,3 @@ + // BlockContext. + } else if (!Rec.IsArrayBound) { // C++1y [expr.const]p2: This isn't correct; you still need to produce the diagnostic even if

Re: [PATCH] D20821: Fix a few issues while skipping function bodies

rsmith added a comment. Please call `Parser::ConsumeAndStoreFunctionPrologue` rather than trying to reinvent it. You're still getting a number of cases wrong that it handles properly. You also need to handle the case where the code completion token appears within the constructor *mem-initializ

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler added a comment. > Before this goes in again, I want to double check that this doesn't affect > compile time on darwin + frameworks. @bruno, you're not likely to find a difference for darwin + frameworks since the frameworks headers like `Cocoa/Cocoa.h` don't exist on-disk with th

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

rsmith added inline comments. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; Yes. The `IsValid` flag is just supposed to mean that this file has actually been added to the `UniqueRealFi

Re: [PATCH] D21054: CodeGen: Update Clang to use the new type metadata.

eugenis accepted this revision. eugenis added a reviewer: eugenis. eugenis added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

r272310 - Revert "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr."

Author: timshen Date: Thu Jun 9 16:13:39 2016 New Revision: 272310 URL: http://llvm.org/viewvc/llvm-project?rev=272310&view=rev Log: Revert "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr." This reverts r272296, since there are clang-tidy failures that appear to be ca

[PATCH] D21198: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of suffi

[PATCH] D21199: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of suffi

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D20933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D20933: Preallocate ExplodedNode hash table

zaks.anna added a comment. Ah, right, please, add a comment explaining what we are doing and why. http://reviews.llvm.org/D20933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272312 - [CMake] Cleaning up CMake feature gating on 2.8.12

Author: cbieneman Date: Thu Jun 9 16:29:55 2016 New Revision: 272312 URL: http://llvm.org/viewvc/llvm-project?rev=272312&view=rev Log: [CMake] Cleaning up CMake feature gating on 2.8.12 CMake 2.8.12 introduced interface libraries and some related policies. This removes the conditional block bec

[PATCH] D21204: clang-format: [JS] post-fix non-null assertion operator.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Do not insert whitespace preceding the "!" postfix operator. This is an incomplete fix, but should cover common usage. http://reviews.llvm.org/D21204 File

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21198: RenderScript support in the Frontend

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please make sure that any relevant parts of our documentation are also updated. Given how small and self-contained this is, that we have a reasonable expectation of good support and maintainer

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 added inline comments. Comment at: lib/Basic/FileManager.cpp:389 @@ -383,2 +388,3 @@ UFE->File.reset(); + UFE->IsVirtual = true; return UFE; rsmith wrote: > Yes. The `IsValid` flag is just supposed to mean that this file has actually > been adde

Re: Does anyone need these zorg modules?

Hello, Last call for the next builder modules: ChrootSetup.py DragonEggBuilder.py KLEEBuilder.py ScriptedBuilder.py gccSuiteBuilder.py I am going to remove them. If anyone have plans for any of them please speak up! Thanks Galina ___ cfe-commits mail

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60247. pirama updated the summary for this revision. pirama added a comment. Re-ordered enum http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Driver/Types.def include/clang/Frontend/F

Re: [PATCH] D21199: Add a RenderScript language type

This revision was automatically updated to reflect the committed changes. Closed by commit rL272317: Add a RenderScript language type (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21199?vs=60238&id=60249#toc Repository: rL LLVM http://reviews.llvm.org/D21199 Files

r272317 - Add a RenderScript language type

Author: pirama Date: Thu Jun 9 16:57:40 2016 New Revision: 272317 URL: http://llvm.org/viewvc/llvm-project?rev=272317&view=rev Log: Add a RenderScript language type Summary: Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to th

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama added a comment. Oops, this update merged changes from http://reviews.llvm.org/D21199 as well. Let me clean up and upload a new patch. http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

cameron314 updated this revision to Diff 60250. cameron314 added a comment. Here's the final fix (it's the line in FileManager.cpp, plus a test). http://reviews.llvm.org/D20338 Files: include/clang/Frontend/ASTUnit.h lib/Basic/FileManager.cpp lib/Frontend/ASTUnit.cpp unittests/Frontend/

  1   2   >