Hi,

> >> No, tested with qemu.git. Plus the code the patch touches in
> >> nvme_controller_enable comes after where the alloc failure happens.
> > 
> > I haven't upstreamed the relevant QEMU patch yet as I'm waiting for the 
> > SeaBIOS part to be reviewed first.
> > 
> > The alloc failure can be avoided be setting BUILD_MIN_BIOSTABLE to 32K.
> > 
> 
> Okay I just tried that, on top of master. It's still not enough for
> qemu's 256 namespace default, same reported error. If I override it with
> `identify->nn = 128;` in nvme_controller_enable then things start working.

Oh well.  nvme goes allocate 256 nvme_namespace structs, even if 255 of
them are not active.  We can certainly do better than that, patch will
follow shortly ...

take care,
  Gerd

_______________________________________________
SeaBIOS mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to