Dear Run Guo,
Am 28.03.21 um 13:23 schrieb RunaGuo-oc:
I am so sorry to reply late.
Thank you for following up. Can you please configure your email client
to use UTF-8 character set instead of gb2312? The subject line looks
quite mangled. Also, please just send plain text messages, and no HTML
part [1].
Here is the newly rebase patch, pls help check, thanks.
Can you please use git send-email to send the patches [2]?
$ git commit --amend -s
$ git format-patch --reroll-count=3 -1
$ git send-email 0001*
1: For ATA device, the first ATA_CMD_IDENTIFY_PACKET_DEVICE command will be
failed with PORT_IRQ_TF set to 1 from ahci spec;
AHCI
2: For seabios, this fail will be considered as timeout for it only polling
PORT_IRQ_D2H_REG/PIO_FIS;
SeaBIOS
3: From ahci spec, I have not yet found any evidences which can be use to combine the
AHCI
above fail with these above error;
Please add how you tested this.
May be, we can also add PORT_IRQ_TF_ERR bit check while polling command
completion?
Thank you again for your contribution.
Signed-off-by: zhaoxin\runaguooc <[email protected]>
Please configure the author name with:
$ git config --global user.name Runa Guo-oc
---
src/hw/ahci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/hw/ahci.c b/src/hw/ahci.c
index d45b430..998b5fe 100644
--- a/src/hw/ahci.c
+++ b/src/hw/ahci.c
@@ -143,7 +143,8 @@ static int ahci_command(struct ahci_port_s *port_gf, int
iswrite, int isatapi,
error = GET_LOWFLAT(fis->psfis[3]);
break;
}
- if (intbits & 0x01) {
+
+ if (intbits & (0x01| PORT_IRQ_TF_ERR)) {
status = GET_LOWFLAT(fis->rfis[2]);
error = GET_LOWFLAT(fis->rfis[3]);
break;
--
2.17.1
Kind regards,
Paul
[1]: https://useplaintext.email/
[2]: https://git-scm.com/docs/git-send-email#_examples
_______________________________________________
SeaBIOS mailing list -- [email protected]
To unsubscribe send an email to [email protected]
