On Thu, Jul 09, 2020 at 06:49:37PM +0300, Michael Tokarev wrote: > 09.07.2020 18:41, Kevin O'Connor wrote: > .. > > Some background links: > > > > https://www.mail-archive.com/[email protected]/msg12275.html > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26047 > > Doh. This is a known issue, even the commit in question has been > known to break seabios even before it were committed.. > > > Nick - the original poster of PR 26047 was aware the binutils change > > would break software. Were you aware of that when you committed the > > change? > > What's wrong with changing seabios as done by Fāng-ruì Sòng?
My initial feedback was at: https://www.mail-archive.com/[email protected]/msg12157.html and later at (now as a "patch 3"): https://www.mail-archive.com/[email protected]/msg12189.html The proposed approach is to use a combination of printf and dd to binary modify the intermediate object file so as to clear the (now banned) linker flag. I did feel, and continue to feel, this is an ugly hack that is fragile. -Kevin _______________________________________________ SeaBIOS mailing list -- [email protected] To unsubscribe send an email to [email protected]
