On Thu, May 14, 2020 at 10:03:29PM -0400, Kevin O'Connor wrote: > On Wed, Apr 29, 2020 at 03:46:41PM +0200, Gerd Hoffmann wrote: > > Create a list of devices found in the DSDT table. Add helper functions > > to find devices, walk the list and figure device informations like mmio > > ranges and irqs. > > > > Signed-off-by: Gerd Hoffmann <[email protected]> > > --- > > Makefile | 2 +- > > src/util.h | 11 + > > src/fw/biostables.c | 9 + > > src/fw/dsdt_parser.c | 668 +++++++++++++++++++++++++++++++++++++++++++ > > src/fw/paravirt.c | 5 +- > > src/Kconfig | 7 + > > 6 files changed, 699 insertions(+), 3 deletions(-) > > create mode 100644 src/fw/dsdt_parser.c > > > > diff --git a/Makefile b/Makefile > > index 985ef591a13b..f02eda314784 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -42,7 +42,7 @@ SRC32FLAT=$(SRCBOTH) post.c e820map.c malloc.c romfile.c > > x86.c optionroms.c \ > > hw/pcidevice.c hw/ahci.c hw/pvscsi.c hw/usb-xhci.c hw/usb-hub.c > > hw/sdcard.c \ > > fw/coreboot.c fw/lzmadecode.c fw/multiboot.c fw/csm.c fw/biostables.c \ > > fw/paravirt.c fw/shadow.c fw/pciinit.c fw/smm.c fw/smp.c fw/mtrr.c > > fw/xen.c \ > > - fw/acpi.c fw/mptable.c fw/pirtable.c fw/smbios.c fw/romfile_loader.c \ > > + fw/acpi.c fw/mptable.c fw/pirtable.c fw/smbios.c fw/romfile_loader.c > > fw/dsdt_parser.c \ > > hw/virtio-ring.c hw/virtio-pci.c hw/virtio-mmio.c hw/virtio-blk.c > > hw/virtio-scsi.c \ > > hw/tpm_drivers.c hw/nvme.c > > As a very minor comment, this file and a few other files add lines > that are over 80 characters. I think it would be good to try and keep > the code to a max of 80 characters (I know I've not always done a good > job at this myself).
Patch sent. > > +#include "byteorder.h" // le32_to_cpu > > +#include "config.h" // CONFIG_* > > +// Support for manipulating bios tables (pir, mptable, acpi, smbios). > > +// > > +// Copyright (C) 2008,2009 Kevin O'Connor <[email protected]> > > +// > > +// This file may be distributed under the terms of the GNU LGPLv3 license. > > This looks like a cut-and-paste error (or perhaps git merge error)? Yes, git rebase error probably. Fixed & commited. thanks, Gerd _______________________________________________ SeaBIOS mailing list -- [email protected] To unsubscribe send an email to [email protected]
