Hello Hansi, I'm not sure what to do with the library. SDCC currently has almost no library code for 8051 derivatives and I'm not sure if we want to start to. Most library functionality can be found on the SDCC OKR, on www.8052.com or on the website of the manufacturer. But I'm just one vote so let's see what others have to say about it.
The headers could be included and I'm glad you already used compiler.h. But I do not like anything I see in uctypes.h. NULL, bool and the int's are all already defined in stdlib.h, stdbool.h and stdint.h. Please use those. And when compiling with --std-c89 you cannot use // comments nor 'xdata'. Please use /* */ and __xdata instead. Personally, I am totally against function implementations in header files unless 'inline'd. But inline again is C99 only. Finally, are you sure the TUSB is completely 8052 compatible? Otherwise I'd prefer not to include 8052.h and copy the relevant portions only. Nevertheless, thank you for all the work you already put in it and making it available to the public. Happy New Year! Maarten > Hi! > > I've done some programming with the Texas Instruments TUSB2136 uC. It is > an 8051 including 8kB code RAM with a USB full-speed peripheral and a > two-port USB hub. The firmware can be downloaded via USB into a pristine > chip so no extra programmer or JTAG hardware is required. The TUSB3210 > is very similar except that it has a no built-in USB hub (but still is > an USB peripheral). > > For the firmware I've developed header files, a little library for the > timer, UART, I2C and USB functionality and several demo programs. For > the PC software there is a demo program plus a versatile command line > utility for working with pristine TUSB chips which implements all vendor > requests of the ROM boot code (downloading the firmware, read and write > the I2C EEPROM, ...). > > Please find attached the source code which I'm going to release under > the terms of the LGPL (and one file under GPL). I ask you to review the > work. I'll appreciate your feedback. > > Are you interested in incorporating the files to the SDCC sources? > > Bye > Hansi > > ------------------------------------------------------------------------------ _______________________________________________ Sdcc-user mailing list Sdcc-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sdcc-user
