This patch set cleans up a set of compiler warnings, and issues. Specifially, there was an unsigned comparison against < 0 which would have never evaluated true.
The out of tree build has been fixed by using the -iquote CPP parameter so that it will correctly only include the local "config.h", and not override any system headers (such as pty.h...) These commits are mostly related to signedness issues, and whilst I have tried to read and verify the surrounding code to ensure I am performing the correct fix (as opposed to the obvious fix), they should still be reviewed before applying. This patch set compiles cleanly with -Wno-unused-result -Wno-unused-parameter but does not tackle those issues yet. That set of warnings is for another day (or another person) I am a big fan of using -Werror to prevent warnings creeping back in, but I'll leave that as a decision for the maintainer :D This patch set will be mirrored/hosted at github at the following tag: https://github.com/kbingham/screen/tree/2015_10_04_bug_fixes_v1 Please review and feel free to make adjustments if required, or let me known and I'll re-spin the patch set. -- Regards Kieran
