On Sun, Feb 25, 2024 at 12:13:35AM -0700, Bob Proulx wrote:
> 
> I am trying to understand the large change wave that has been
> committed in the last few days.

Last quite a few months, in a sense. the date of 9fd58ef254ab is
2023-08-16.

> I made a commit on Feb 8 a894e1 and for example between then and now I
> see many commits resulting in this large diff.
> 
>     $ git diff a894e1..HEAD | diffstat | tail -n1
>      386 files changed, 56532 insertions(+), 16683 deletions(-)

Most of insertions are in two new data files,
backend/external/cities15000{.txt,}, though.

> That is a very large number of changes in a very short period of time!
> This has only been in the last few days.

I believe the most important change from Savannah admins' viewpoint
wasn't in fact in the code. it was in how the frontend code is
installed. previously, what was used were basically a Git clone
(which wasn't actually supported); then I migrated to a regular
installation.

I did it on Jan, 31, when migrating to frontend2, and I mentioned
I was going to do that even earlier, when the fundraiser was
running.

> Just on the surface I see the following confusing things.
> 
> * All of the .gitignore files have been deleted.  This causes a large
>   amount of noise files to appear in the git status.  What's the plan
>   for this?

When I use a separate build tree, git status only shows these files
[reordered]:

  configure Makefile.in frontend/Makefile.in lib/Makefile.in
  po/Makefile.in autotools/m4/Makefile.in
  aclocal.m4 autom4te.cache/ autotools/install-sh autotools/missing
  po/stamp-po po/savane.pot
  po/ca.po~ po/de.po~ po/es.po~ po/fr.po~ po/he.po~ po/it.po~
  po/ja.po~ po/pt_BR.po~ po/ru.po~ po/sv.po~

I don't think the amount is really large and noisy.

> * The local development router has been removed.  This was being used
>   to run a local sandbox.
> 
> * The script that was used to launch the local development router has
>   been removed.

To be precise, they weren't removed, they were replaced with scripts
that take into account configure-time settings; moreover, an option
to specify the path to the PHP executable was added (to say nothing
of the standard --help and --version), a450ed9468.

> On the frontend servers the files being served had been in version
> control at /opt/savannah/savane.  Those files are still there but the
> version control has not been updated in a very long time.  Yet I think
> as recently as last month when the fundraising banner was removed that
> it had been updated.

The files in /opt/savannah/savane are leftover from the times when
frontend2 served as frontend.

> I see that apparently on Jan 31 this has been changed to serve files
> from /opt/savane/share/savane/frontend/php as what appears to be an
> installed files area.  But I can't find any indication of where those
> files are being installed from or from what version.

mgt1:ChangeLog does include some records; general setup is now
outlined in <https://savannah.gnu.org/maintenance/SavaneSetup/>.

> When I look through the version control commit message history I see a
> lot of very confusing things that indicate to me that the timeline was
> committed and then reset and then re-committed differently.

I often modify and reorder commits before they enter the master branch,
typically because

* a commit may need fixing, or it may be incomplete; committing
  every fix at HEAD would make the history more complicated than
  necessary; or

* some commits seem ready for master, i.e. it doesn't look like
  they'll need fixing; then I move them closer to master (or just
  push them into master).

Git preserves the original dates, as far as I can tell.

Attachment: signature.asc
Description: PGP signature

Reply via email to