On 01/08/2013 18:46, Stef wrote:
> On 01/08/2013 17:56, Tom Gundersen wrote:
>> On Thu, Aug 1, 2013 at 2:33 PM, Stef <stef.dev at free.fr> wrote:
>>> On 31/07/2013 15:39, Tom Gundersen wrote:
>>>> On Wed, Jul 31, 2013 at 3:27 PM, Stef <stef.dev at free.fr> wrote:
>>>>> On 31/07/2013 14:49, Tom Gundersen wrote:
>>>>>> Hi Stef,
>>>>>>
>>>>>> On Wed, Jul 31, 2013 at 2:39 PM, Stef <stef.dev at free.fr> wrote:
>>>>>>> before applying this patch I'm considering adding a
>>>>>>> testsuite for
>>>>>>> sane-desc first. Since it is too big to be in-lined, I have
>>>>>>> posted the
>>>>>>> corresponding patch athttp://dl.free.fr/vzjrF6ete . It adds a tools
>>>>>>> subdirectory to the testsuite directory. In this directory, a test
>>>>>>> .desc
>>>>>>> file is parsed with sane-desc for all known modes and the resulting
>>>>>>> files
>>>>>>> are compared to the expected files.
>>>>>>>
>>>>>>> I am waiting for your comments and suggestions.
>>>>>> Sounds like a good idea. However, I was unable to download the
>>>>>> file. I
>>>>>> get "code incorrect"... Any chance you could upload it elsewhere?
>>>>>>
>>>>>> -t
>>>>>
>>>>> Hello,
>>>>>
>>>>> the http://dl.free.fr/vzjrF6ete URL is working for me in
>>>>> seamonkey
>>>>> and
>>>>> firefox. Maybe some typo ? I can send the patch directly to you if it
>>>>> helps.
>>>> Thanks, now it worked. Should the patch have included an
>>>> testsuite/tools/Makefile.in ? As it is, ./configure fails.
>>>>
>>>> Cheers,
>>>>
>>>> Tom
>>> Hello,
>>>
>>> here is the missing file.
>> Thanks. As far as I can tell this works well (I tried breaking
>> sane-desc and it was reported as expected). It also works with my hwdb
>> patch applied.
>>
>> Will you commit this and the hwdb patch so I can just submit a
>> separate patch adding the two new hwdb modes to the testsuite?
>>
>> Cheers,
>>
>> Tom
> Hello,
>
> yes, send a patch, I'll commit all this this week-end.
>
> Regards,
> Stef
>
Hello,
I have committed all these patches.
Regards,
Stef
