Hi Henry, Many thanks for reporting MX890 as working.
Before I will commit your patch, please test the ADF. The MX890 should support normal and duplex ADF. Cheers, Rolf Am 29.11.2012 03:34, schrieb Gernot Hassenpflug: > On Thu, Nov 29, 2012 at 2:43 AM, Henry Ptasinski <henry at logout.com> wrote: >> On 11/28/2012 09:38 AM, Henry Ptasinski wrote: >>> >>> Flatbed scans with resolutions up to 600 dpi all seem to be working >>> fine. At 1200 and 2400 dpi, the images are mangled. Columns appear to >>> be interleaved at both resolutions. I assume the problem is due to a >>> missing check in pixma_mp150.c:post_process_image_data(). Any >>> suggestions for how to start fixing this issue? > > > Hello Henry, > Yes, that is the correct solution. We know by now that many newer > devices require this exception, but we will only add the exception > when someone reports it, as that is the only sure way to tell. > Thank you for bringing this to our attention. Nice to know that both > 1200 and 2400 work without extra image data manipulation necessary > too. > > Regards, > Gernot Hassenpflug > >> With a little poking around, I found that this change fixes the 1200 and >> 2400 dpi scanning problem: >> >> --- a/backend/pixma_mp150.c >> +++ b/backend/pixma_mp150.c >> @@ -1081,6 +1081,7 @@ post_process_image_data (pixma_t * s, pixma_imagebuf_t >> * i >> /* special image format for *most* devices at high dpi. >> * MP220, MX360, MX370, MG5300 are exceptions */ >> if (s->cfg->pid != MP220_PID && s->cfg->pid != MX360_PID >> + && s->cfg->pid != MX890_PID >> && s->cfg->pid != MX370_PID && s->cfg->pid != MG5300_PID && n >>> 0 >> reorder_pixels (mp->linebuf, sptr, c, n, m, s->param->wx, >> line_si >> >> >> For people more familiar with the pixma code, does this seem like the right >> approach? >> >> >> Thanks, >> --- >> Henry Ptasinski >> henry at logout.com >> >> >> -- >> sane-devel mailing list: sane-devel at lists.alioth.debian.org >> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel >> Unsubscribe: Send mail with subject "unsubscribe your_password" >> to sane-devel-request at lists.alioth.debian.org > >
