I disagree with this commit. Perhaps we need to change what is
printed, but I don't think we should hide them.

allan

On Mon, Nov 1, 2010 at 2:34 AM, St?phane Voltz <stef.dev at free.fr> wrote:
> The following commit has been merged in the master branch:
> commit 27c7eae2b59385fec7228f6bec65fbcc649637a3
> Author: St?phane Voltz <stef.dev at free.fr>
> Date: ? Sat Oct 30 16:23:17 2010 +0200
>
> ? ?don't print readonly controls as valid command line options
>
> diff --git a/frontend/scanimage.c b/frontend/scanimage.c
> index 8657a72..7a24ea1 100644
> --- a/frontend/scanimage.c
> +++ b/frontend/scanimage.c
> @@ -2141,7 +2141,8 @@ Parameters are separated by a blank from 
> single-character options (e.g.\n\
> ? ? ? ? ? ? ?if (!opt)
> ? ? ? ? ? ? ? ?opt = sane_get_option_descriptor (device, i);
>
> - ? ? ? ? ? ? print_option (device, i, opt);
> + ? ? ? ? ? ? if (SANE_OPTION_IS_SETTABLE 
> (opt->cap)||opt->type==SANE_TYPE_GROUP)
> + ? ? ? ? ? ? ? print_option (device, i, opt);
> ? ? ? ? ? ?}
> ? ? ? ? ?if (num_dev_options)
> ? ? ? ? ? ?fputc ('\n', stdout);
>
> --
> SANE backends - scanner drivers
>
> _______________________________________________
> sane-commit mailing list
> sane-commit at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/sane-commit



-- 
"The truth is an offense, but not a sin"

Reply via email to