Hi,
On Mon, Mar 04, 2002 at 09:32:12PM -0600, Frank Zago wrote:
> Could someone review it before I add it to cvs?
backend/Makefile.in:
* DISTFILES doesn't mention matsushita.conf
backend/matsushita.h:
* when compiling with --enable-warnings:
gcc -c -g -O2 -W -Wall -Wcast-align -Wcast-qual
-Wmissing-declarations -Wmissing-prototypes -Wpointer-arith
-Wreturn-type -Wstrict-prototypes -pedantic -ansi -DHAVE_CONFIG_H
-I. -I. -I../include -I../include -D_GNU_SOURCE
-DPATH_SANE_CONFIG_DIR=/usr/local/etc/sane.d
-DPATH_SANE_DATA_DIR=/usr/local/share -DV_MAJOR=1 -DV_MINOR=0
-DBACKEND_NAME=matsushita -DLIBDIR=/usr/local/lib/sane matsushita.c
-fPIC -DPIC -o .libs/matsushita.lo
In file included from matsushita.c:83:
matsushita.h:144: syntax error before int'
matsushita.h:145: warning: no previous prototype for getbitfield'
matsushita.c: In function matsushita_init_options':
matsushita.c:1180: warning: cast discards qualifiers from pointer target type
matsushita.c:1183: warning: cast discards qualifiers from pointer target type
make[1]: *** [matsushita.lo] Fehler 1
(doesn't seem to like the inline)
Generally: use GNU indent :-) At least it looks like you use tabsize=2
or like very big indents
Otherwise it seems to run and I couldn't finmd any obvious problem.
But I didn't read every single line.
I haven't checked yet on other platforms but Linux/i386 but I don't
expect too much trouble.
This is probably the shortest list of annotations for a new backend
until now. Very good!
Bye,
Henning
