Hi Andrew, i tried your both patches (on a 'clean' 4.0.6), and the difference is that samba is not crashing anymore, but winbind seems to be blocked after a wbinfo --uid-info 3000000.
e.g : r...@gwnois03.test.ch ~# wbinfo --uid-info 3000011 TEST\Guest:*:3000011:3000012::/home/TEST/Guest:/bin/false r...@gwnois03.test.ch ~# wbinfo --uid-info 3000000 <<no response, infinite timeout> Philippe > -----Original Message----- > From: Andrew Bartlett [mailto:abart...@samba.org] > Sent: Thursday, June 27, 2013 3:43 AM > To: Simonet Philippe, ITS-OUS-OP-IFM-NW-IPE; me...@samba.org; > k...@samba.org > Cc: sa...@samba.org; samba-techni...@samba.org > Subject: [PATCH] Do not close winbind socket during use > > On Wed, 2013-06-26 at 20:39 +1000, Andrew Bartlett wrote: > > On Mon, 2013-06-24 at 15:26 +0000, philippe.simo...@swisscom.com > wrote: > > > Hi Andrew, and by putting more num-callers : > > > > > > valgrind --num-callers=50 samba -i -M single > > > > Thanks for getting me that. I've managed to reproduce it here, but not > > under valgrind, and only when I hack the code to force a timeout. At > > least this should help me figure out why we process the winbind socket > > close, which is the crux of this issue. > > I think I've found the cause of the issue you are hitting. There is > still another issue with the nested event loop in the krb5 libs, but > these two patches should help significantly. > > As you have had more luck than I in reproducing this in a unaltered > setting, please let me know if this helps. > > Patches are for git master, but may apply to 4.0 as well. > > Kai, Metze: > > In reading the code, I cannot see why the DNS server would not suffer > the same issue, if the DNS clients closed it's socket. Should we find a > more generic way to do this in service_stream, or should just duplicate > this? I don't think other servers hit the same issue as they are > currently 'blocking' in terms of the socket handler. > > Thanks, > > Andrew Bartlett > > -- > Andrew Bartlett http://samba.org/~abartlet/ > Authentication Developer, Samba Team http://samba.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
