On Sat, Nov 3, 2012 at 4:09 PM, Jason Grout <[email protected]>wrote:
> On 11/3/12 5:06 PM, Brandon Curtis wrote: > >> >> The proper thing to do is to make a fork on github, push your changes > there, and submit a pull request [1]. I'll probably start compiling rc3 > and test your changes against rc3 sometime early next week. > I just compiled rc3 and followed exactly my Sage Cell installation log from rc2, and everything installed and appears to work perfectly. > It looks like your 003 and 002 patches can be combined. That line that > you change in 003 is actually already modified in 002. > Patches 002 and 003 do modify the same line, but in different ways: Patch 002 changes the line so that the sagecell spkg can successfully install 02-sage-show.patch, but the change that 02-sage-show.patch makes is incorrect. Patch 003 is then applied to correct that line. Ideally I would just change 02-sage-show.patch instead of applying patches over patches, but I haven't yet read the docs [1] to learn how to 'crack open' the spkg to modify the individual patches held inside. If I attempt to install the spkg and wait until it fails, then make the changes manually and *hg -qrefresh*, the spkg complains that I 'have an outdated version' of the patch I refreshed. Is it considered better practice to modify existing patches, or to write entirely new patches to fix problems with existing patches? > Also, it would be great if you could submit a pull request to up the > default memory allocation to 2GB. Apparently our initial defaults were way > too low. I'll read the documentation this weekend and hopefully learn enough about git to submit that. Where and in what format can I contribute documentation? A sketch of my >> installation procedure is available here: >> Sage Cell Server 2 on Sage Math 5.4 rc2 - http://pastebin.com/7sBMHGdG >> > > Can you change the existing installation documentation in the readme.rst > file and submit a third pull request? > I assume you mean this repository: https://github.com/sagemath/sagecell. Am I correct to assume that the pre-built (2012-09.25) spkg is up-to-date, since the last major changes to this repository occurred on that date? > Thanks! > > Jason > > [1] > https://help.github.com/**articles/fork-a-repo<https://help.github.com/articles/fork-a-repo>, > https://help.github.com/**articles/using-pull-requests<https://help.github.com/articles/using-pull-requests>, > plus there are lots of other tutorials found by searching for github, fork, > pull request, etc. > > Thanks for helping me get up to speed. I have no formal training in software (I'm a chemical engineer), and I have always felt sort of weird advocating open-source software with very little knowledge of the tools and processes that actually produce it. Glad to finally contribute something concrete. [1] http://www.sagemath.org/doc/developer/producing_spkgs.html -- You received this message because you are subscribed to the Google Groups "sage-support" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-support?hl=en.
