On Wed, Feb 29, 2012 at 11:29 AM, Kelvin Li <ltwis...@gmail.com> wrote: > On Feb 29, 12:24 pm, Niles <nil...@gmail.com> wrote: >> So this means that you should write "Apply trac_10229-2.patch" in a >> new comment on the ticket. Unfortunately writing this in the ticket >> description is useless for the patchbot (although still helpful for >> human readers). > > Ah, so a comment is not the description. Another question: what if > there are multiple comments with "apply ..."? Does the patchbot simply > look at the most recent comment with such a string, so that older > comments can be completely overridden?
Yep. The problem with the ticket description is that it doesn't have an associated (easily visible) chronology, so if one posts "trac_10229.patch" and puts in the description "Apply trac_10229.patch" then someone comes along and posts "trac_10229-referee.patch" fixing a typo and adding a doctest, it's unclear if the description was specifically excluding the referee patch or just not updated. An enhancement could be that if the description has an "apply" section (?) then we should strictly obey it, forcing everyone to do the busywork of keeping it up to date. Even better would be checkboxes and a way to re-order the list of actual attached patches. (Even better than that would be specifying a commit/branch in a revision control system, where the selection and order of "patches" to apply doesn't have to be specified externally.) - Robert -- To post to this group, send email to sage-support@googlegroups.com To unsubscribe from this group, send email to sage-support+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-support URL: http://www.sagemath.org
