Hi, Maybe it is a good thing to keep the same order as ginac internally and your more usual ordering for printing. However if you'd better not duplicate code, I can look at the "- x^2+x^2" part of bug #9046. Now I may understand a big enough part of pynac code to do that. But if you'd better use the above patch, that won't be necessary.
Cheers, On 29 sep, 17:33, Burcin Erocal <bur...@erocal.org> wrote: > Hi, > > On Wed, 29 Sep 2010 07:00:39 -0700 (PDT) > > Jean-Pierre Flori <jpfl...@gmail.com> wrote: > > Ok, I have finally looked at the comparison functions and exchanging : > > cmpval = seq[0].coeff.compare(other.exponent); > > by > > cmpval = -seq[0].coeff.compare(other.exponent); > > in mul::compare_pow (mul.cpp:1265) seems to prevent the above bug from > > happening. > > It seems to fit better with the change made by William Stein in > > power::compare_same_type (power.cpp:951). > > However it doesn't mean the problem is completely solved... > > I'll try to take a deeper look at the comparison functions at some > > point. > > Thank you for following up on this and taking the time to go through > the comparisons. > > I was planning to build on the patch I posted before [1] to fix this > problem once and for all (perhaps rather optimistically). > > [1]http://sage.math.washington.edu/home/burcin/pynac/pynac_order.patch > > Note that your suggestions fixes your bug (#9880), but doesn't effect > #9046. > > Cheers, > Burcin -- To post to this group, send email to sage-support@googlegroups.com To unsubscribe from this group, send email to sage-support+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-support URL: http://www.sagemath.org
