On May 15, Matthias Koeppe wrote:
On Friday, May 15, 2020 at 2:19:11 PM UTC-7, Reimundo Heluani wrote:I wanted to test a couple of very simple patches #29690 and #29691. The latter depends on the former. #29690 passes without problems but #29691 fails tests as if the patch from #29690 were not applied. If #29691 depends on #29690, its branch should be on top of the branch of that. On Trac, add #29690 in the Dependencies field so that reviewers know about this.
Thanks, I had already added this as a dependency and I thought that patchbot would pick this up and pull that branch first. But now that I forced push and test again it fails with the same problem so I guess patchbot is not pulling the dependency branch before. So is my understanding correct that the right workflow is to rebase #29691 on top of #29690 and push again? R.
-- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [1]sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit [2]https://groups.google.com/d/msgid/ sage-devel/6c8d9fa4-f72c-4f37-b58a-e1780dd59ab1%40googlegroups.com. References: [1] mailto:sage-devel+unsubscr...@googlegroups.com [2] https://groups.google.com/d/msgid/sage-devel/6c8d9fa4-f72c-4f37-b58a-e1780dd59ab1%40googlegroups.com?utm_medium=email&utm_source=footer
-- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/20200515223455.GA791654%40vertex.
signature.asc
Description: PGP signature
